mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-15 18:39:52 +00:00
23c5b0d02c
* Restricting "camelcase":
No changes, we were passing all of these already
* Explicitly unrestricting "forin" and "plusplus"
These are off by default in node-jshint, but some distro of jshint
and editors that use their own wrapper around jshint instead of
node-jshint (Eclipse?) may have different defaults. Therefor
setting them to false explicitly. This also serves as a reminder
for the future so we'll always know we don't pass that, in case
we would want to change that.
* Fix order ("quotemark" before "regexp")
* Restricting "unused"
We're not passing all of this, which is why I've set it to false
for now. But I did put it in .jshintrc as placeholder.
I've fixed most of them, there's some left where there is no clean
solution.
* While at it fix a few issues:
- Unused variables ($target, $window)
- Bad practices (using jQuery context for find instead of creation)
- Redundant /*global */ comments
- Parameters that are not used and don't have documentation either
- Lines longer than 100 chars @ 4 spaces/tab
* Note:
- ve.ce.Surface.prototype.onChange takes two arguments but never
uses the former. And even the second one can be null/undefined.
Aside from that, the .change() function emits
another event for the transaction already. Looks like this
should be refactored a bit, two more separated events probably
or one that is actually used better.
- Also cleaned up a lot of comments, some of which were missing,
others were incorrect
- Reworked the contentChange event so we are no longer using the
word new as an object key; expanded a complex object into multiple
arguments being passed through the event to make it easier to work
with and document
Change-Id: I8490815a508c6c379d5f9a743bb4aefd14576aa6
|
||
|---|---|---|
| .. | ||
| ve.ce.AlienBlockNode.js | ||
| ve.ce.AlienInlineNode.js | ||
| ve.ce.DefinitionListItemNode.js | ||
| ve.ce.DefinitionListNode.js | ||
| ve.ce.DocumentNode.js | ||
| ve.ce.HeadingNode.js | ||
| ve.ce.ImageNode.js | ||
| ve.ce.ListItemNode.js | ||
| ve.ce.ListNode.js | ||
| ve.ce.ParagraphNode.js | ||
| ve.ce.PreformattedNode.js | ||
| ve.ce.TableCellNode.js | ||
| ve.ce.TableNode.js | ||
| ve.ce.TableRowNode.js | ||
| ve.ce.TableSectionNode.js | ||
| ve.ce.TextNode.js | ||