mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-16 19:09:29 +00:00
9e74e2f352
This check makes sure the user doesn't loose work when clicking the back button. I would like to argue that neither of these values is valuable enough to block the user with a confirmation dialog: * Literally nothing is lost when the input is empty. * The auto-value is only temporarily lost, but will automatically be restored when the user decides to add the template back. The input field is pre-filled with this value. * The default value doesn't need to be manually entered. It will show up anyway when the parameter is missing. There is a rare edge-case, but it is not really relevant in this situation. Some templates allow to override a default value with the empty string. This will be considered irrelevant by this code. However, this was already happening before and doesn't change with this patch. The only edge-case where this patch makes a difference is if a parameter is marked as required or suggested, is documented to have a default value, _and_ the template allows to override it with an empty string. But this combination is rather crazy, if not bogus, and not worth considering here, I believe. Bug: T274551 Change-Id: Ib176a82844335c3d4dd5b720d335ec28245e1637 |
||
|---|---|---|
| .. | ||
| ve.dm.MWImageModel.js | ||
| ve.dm.MWParameterModel.js | ||
| ve.dm.MWTemplateModel.js | ||
| ve.dm.MWTemplatePlaceholderModel.js | ||
| ve.dm.MWTemplateSpecModel.js | ||
| ve.dm.MWTransclusionContentModel.js | ||
| ve.dm.MWTransclusionModel.js | ||
| ve.dm.MWTransclusionPartModel.js | ||