mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-25 23:05:35 +00:00
0516b1d7f0
Check for all node classes in getOffsetFromTextNode(), not just branches and aliens (an entity is neither) Render entities with contenteditable=false. Without this, selection was still broken, because: Foo|€Bar was really <p>Foo<span>|€</span>Bar</p> which maps correctly. Foo€|Bar was really <p>Foo<span>€|</span>Bar</p> which maps to the same, which is incorrect. With cE=false, the cursor can't be inside the span, so we get: Foo|€Bar is really <p>Foo|<span>€</span>Bar</p> which maps correctly. Foo€|Bar is really <p>Foo<span>€</span>|Bar</p> which maps correctly. Change-Id: Iaf603346590a9ad553c152565eb203136be7a399
68 lines
1.4 KiB
JavaScript
68 lines
1.4 KiB
JavaScript
/**
|
|
* VisualEditor content editable MWEntityNode class.
|
|
*
|
|
* @copyright 2011-2012 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
/**
|
|
* ContentEditable node for an entity.
|
|
*
|
|
* @class
|
|
* @constructor
|
|
* @extends {ve.ce.LeafNode}
|
|
* @param {ve.dm.MWEntityNode} model Model to observe.
|
|
*/
|
|
ve.ce.MWEntityNode = function VeCeMWEntityNode( model ) {
|
|
// Parent constructor
|
|
ve.ce.LeafNode.call( this, 'MWentity', model, $( '<span>' ) );
|
|
|
|
// DOM Changes
|
|
this.$.addClass( 've-ce-MWEntityNode' );
|
|
// Need cE=false to prevent selection issues
|
|
this.$.attr( 'contenteditable', false );
|
|
|
|
// Properties
|
|
this.currentSource = null;
|
|
|
|
// Events
|
|
this.model.addListenerMethod( this, 'update', 'onUpdate' );
|
|
|
|
// Initialization
|
|
this.onUpdate();
|
|
};
|
|
|
|
/* Inheritance */
|
|
|
|
ve.inheritClass( ve.ce.MWEntityNode, ve.ce.LeafNode );
|
|
|
|
/* Static Members */
|
|
|
|
/**
|
|
* Node rules.
|
|
*
|
|
* @see ve.ce.NodeFactory
|
|
* @static
|
|
* @member
|
|
*/
|
|
ve.ce.MWEntityNode.rules = {
|
|
'canBeSplit': false
|
|
};
|
|
|
|
/* Methods */
|
|
|
|
/**
|
|
* Responds to model update events.
|
|
*
|
|
* If the source changed since last update the image's src attribute will be updated accordingly.
|
|
*
|
|
* @method
|
|
*/
|
|
ve.ce.MWEntityNode.prototype.onUpdate = function () {
|
|
this.$.text( this.model.getAttribute( 'character' ) );
|
|
};
|
|
|
|
/* Registration */
|
|
|
|
ve.ce.nodeFactory.register( 'MWentity', ve.ce.MWEntityNode );
|