wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Visual.../modules/ve-mw/ui/widgets
History
Thiemo Kreuz 19edc6043a Tab to first template parameter in list, not to the selection 
This is a partial revert of Iaf089f4. It restores the old behavior:
* In case there is already a highlight in the parameter list, just
  keep that. Usually there is no highlight at this point, but better
  have this check in place to be sure.
* Otherwise always start at the top.

Jumping to the selection is confusing, esp. for keyboard-only users.
The argument goes like this:
* Let's say I'm in the middle of editing values on the right side of
  the dialog.
* I want to navigate to the sidebar. How do I do this with the
  keyboard? I use the tab key.
* Pressing tab also implies I move the selection to the next
  parameter. And the next. Until I reach the end of the parameter
  list. Then the selection stays there.
* When I finally reach the sidebar and tab into the parameter list,
  the last parameter is selected. But this was merely a side-effect
  of me navigating the dialog.

Such a "selection becomes highlighting" behavior was not specified
in T311204.

This patch is requested and approved by PM.

Bug: T312647
Bug: T311204
Change-Id: Ie5b5dfd4fca132050815e6182845ca23adb5f805
2022-07-21 10:44:48 +02:00
..
ve.ui.MWAceEditorWidget.js Fix resize of MWAceEditorWidget when setting up 2022-03-18 22:30:54 +00:00
ve.ui.MWCategoryInputWidget.js eslint: Enable no-jquery/no-append-html 2021-12-16 02:04:11 +01:00
ve.ui.MWCategoryItemWidget.js Update and fix all @param config and @cfg documentation 2021-09-12 12:35:27 +00:00
ve.ui.MWCategoryPopupWidget.js Move var declarations inline 2022-03-01 17:50:24 +00:00
ve.ui.MWCategoryWidget.js Move var declarations inline 2022-03-01 17:50:24 +00:00
ve.ui.MWEditSummaryWidget.js Use boolean RegExp.test() instead of .match() where possible 2022-03-24 11:04:43 +01:00
ve.ui.MWEducationPopupWidget.js Move var declarations inline 2022-03-01 17:50:24 +00:00
ve.ui.MWExternalLinkAnnotationWidget.js Prefere ve.extendObject over $.extend 2021-11-15 21:30:19 +00:00
ve.ui.MWGalleryGroupWidget.js Prefere ve.extendObject over $.extend 2021-11-15 21:30:19 +00:00
ve.ui.MWGalleryItemWidget.js GalleryImageNode: Handle broken images 2022-05-23 15:29:42 +01:00
ve.ui.MWInternalLinkAnnotationWidget.js Move var declarations inline 2022-03-01 17:50:24 +00:00
ve.ui.MWLazyMultilineTextInputWidget.js Update and fix all @param config and @cfg documentation 2021-09-12 12:35:27 +00:00
ve.ui.MWMediaInfoFieldWidget.js Use boolean RegExp.test() instead of .match() where possible 2022-03-24 11:04:43 +01:00
ve.ui.MWParameterCheckboxInputWidget.js Document some classes touched in the sidebar rewrite 2022-07-12 12:49:31 +02:00
ve.ui.MWPreTextInputWidget.js doc: Bump copyright year for 2020 2020-01-08 09:13:24 -08:00
ve.ui.MWTargetWidget.js Add 'vector-body' hack to TargetWidgets 2022-07-18 14:12:10 +01:00
ve.ui.MWTemplateTitleInputWidget.js Document some classes touched in the sidebar rewrite 2022-07-12 12:49:31 +02:00
ve.ui.MWTocWidget.js Move var declarations inline 2022-03-01 17:50:24 +00:00
ve.ui.MWTransclusionOutlineButtonWidget.js Document some classes touched in the sidebar rewrite 2022-07-12 12:49:31 +02:00
ve.ui.MWTransclusionOutlineControlsWidget.js Document some classes touched in the sidebar rewrite 2022-07-12 12:49:31 +02:00
ve.ui.MWTransclusionOutlineParameterSelectWidget.js Tab to first template parameter in list, not to the selection 2022-07-21 10:44:48 +02:00
ve.ui.MWTransclusionOutlineParameterWidget.js Rename confusing "itemSet" to "active parameter" 2022-07-20 11:42:42 +02:00
ve.ui.MWTransclusionOutlinePartWidget.js Use generic "outline item selected" event for top-level parts 2022-07-19 11:05:32 +00:00
ve.ui.MWTransclusionOutlinePlaceholderWidget.js Document some classes touched in the sidebar rewrite 2022-07-12 12:49:31 +02:00
ve.ui.MWTransclusionOutlineTemplateWidget.js Merge "Use generic "outline item selected" event for top-level parts" 2022-07-20 10:07:22 +00:00
ve.ui.MWTransclusionOutlineToggleUnusedWidget.js Minor fixes to template dialog related code documentation 2022-07-12 20:10:02 +02:00
ve.ui.MWTransclusionOutlineWidget.js Merge "Use generic "outline item selected" event for top-level parts" 2022-07-20 10:07:22 +00:00
ve.ui.MWTransclusionOutlineWikitextWidget.js Document some classes touched in the sidebar rewrite 2022-07-12 12:49:31 +02:00