mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-12-11 05:56:11 +00:00
eb515188ec
`new mw.Title` throws on invalid input. Converting uses to mw.Title.newFromText instead and converting try/catch to if/else. mw.Title in general (regardless of which constructor) has been improved in core. It will no longer crash on pages where the page title was a false hit for invalid (e.g. we couldn't load VE on [[.com]] because the js parser thought it was invalid). However, though the initialisation works since core has been fixed, there are still plently of cases where we take real user input that can genuinely be invalid. In cases where the code did not catch exceptions and there was no obvious way to handle it, I left it as is (let's revisit them in a separate commit). It would be an exception either way, and I'd rather see "mw.Title: Parser error" than "TypeError: null does not have method getNamespaceId". Change-Id: I5b1b23d56d39cdb7ecb0809e3d721992e0c30f54 |
||
---|---|---|
.. | ||
ve.dm.MWExternalLinkAnnotation.js | ||
ve.dm.MWInternalLinkAnnotation.js | ||
ve.dm.MWNowikiAnnotation.js |