wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-17 03:18:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Visual.../modules/ve-mw/ui/widgets
History
Thiemo Kreuz eb1f1e28a3 Make new template editor sidebar items actual ButtonElements 
Actually reusing this OOUI mixin gives us a lot of well
developed functionality we need anyway. Most notably proper
event management, e.g. click events.

The number of CSS properties we need to override is managable,
I would argue. Let's see:
* Our buttons are not inline-elements, but should use the full
  width.
* No focus-border left and right for the same reason.
* We want much more inner padding.
* We want a stronger hover effect.
* We need to fine-tune the position of the icon. This is
  because of the inner padding.
* Need to get rid of a negative margin that's only relevant
  for inline-buttons.

I currently feel like the benefits are worth living with
slightly more brittle code. Note that we can undo this change
any time because all this is well encapsulated in this new
class.

Bug: T274544
Change-Id: I33f275a958964d49e803e56bf74a6fa961093da1
2021-07-14 13:31:40 +02:00
..
ve.ui.MWAceEditorWidget.js Remove @param/@return docs that literally repeat the code 2021-06-14 15:44:51 +02:00
ve.ui.MWCategoryInputWidget.js build: Update eslint-config-wikimedia to 0.17.0 2020-08-18 13:16:49 +01:00
ve.ui.MWCategoryItemWidget.js doc: Bump copyright year for 2020 2020-01-08 09:13:24 -08:00
ve.ui.MWCategoryPopupWidget.js doc: Bump copyright year for 2020 2020-01-08 09:13:24 -08:00
ve.ui.MWCategoryWidget.js Remove/fix a few small pieces of unused code 2021-05-21 11:43:45 +00:00
ve.ui.MWDismissibleMessageWidget.js Add missing newline in JSDoc 2021-06-18 14:13:31 +02:00
ve.ui.MWEditSummaryWidget.js Document and use mw.Api parameter defaults 2021-07-12 09:13:59 +02:00
ve.ui.MWEducationPopupWidget.js Rewrite EducationPopup so it isn't a mixin 2020-09-24 21:33:50 +01:00
ve.ui.MWExternalLinkAnnotationWidget.js Fix:Internal and External Link annotation widget 2020-02-24 16:40:19 -08:00
ve.ui.MWGalleryGroupWidget.js doc: Bump copyright year for 2020 2020-01-08 09:13:24 -08:00
ve.ui.MWGalleryItemWidget.js Preserve inline media tag name in galleries across edits 2020-12-16 17:28:51 -05:00
ve.ui.MWInternalLinkAnnotationWidget.js Move MWutils to preinit and rename to parsoid utils 2020-03-24 23:13:16 +01:00
ve.ui.MWLazyMultilineTextInputWidget.js doc: Bump copyright year for 2020 2020-01-08 09:13:24 -08:00
ve.ui.MWMediaInfoFieldWidget.js eslint: Enable the mediawiki/class-doc rule and make pass 2020-04-17 22:59:11 +01:00
ve.ui.MWMoreParametersResultWidget.js doc: Bump copyright year for 2020 2020-01-08 09:13:24 -08:00
ve.ui.MWNoParametersResultWidget.js doc: Bump copyright year for 2020 2020-01-08 09:13:24 -08:00
ve.ui.MWParameterCheckboxInputWidget.js doc: Bump copyright year for 2020 2020-01-08 09:13:24 -08:00
ve.ui.MWParameterResultWidget.js Change style for adding an "Unknown field" in the parameter search 2021-07-08 09:20:25 +02:00
ve.ui.MWParameterSearchWidget.js Merge "Change style for adding an "Unknown field" in the parameter search" 2021-07-08 08:20:59 +00:00
ve.ui.MWPreTextInputWidget.js doc: Bump copyright year for 2020 2020-01-08 09:13:24 -08:00
ve.ui.MWTargetWidget.js Merge "Ensure correct classes are added to surfaces" 2021-05-25 19:33:17 +00:00
ve.ui.MWTemplateOutlineParameterCheckboxLayout.js Reuse generic button widget for elements in the new sidebar 2021-07-13 17:23:27 +00:00
ve.ui.MWTemplateTitleInputWidget.js Document and use mw.Api parameter defaults 2021-07-12 09:13:59 +02:00
ve.ui.MWTocWidget.js build: Update eslint-config-wikimedia to 0.17.0 2020-08-18 13:16:49 +01:00
ve.ui.MWTransclusionOutlineButtonWidget.js Make new template editor sidebar items actual ButtonElements 2021-07-14 13:31:40 +02:00
ve.ui.MWTransclusionOutlineContainerWidget.js Update new sidebar when moving template parts up/down 2021-07-13 10:18:20 +02:00
ve.ui.MWTransclusionOutlinePartWidget.js Make new template editor sidebar items actual ButtonElements 2021-07-14 13:31:40 +02:00
ve.ui.MWTransclusionOutlinePlaceholderWidget.js Reuse generic button widget for elements in the new sidebar 2021-07-13 17:23:27 +00:00
ve.ui.MWTransclusionOutlineTemplateWidget.js Reuse generic button widget for elements in the new sidebar 2021-07-13 17:23:27 +00:00
ve.ui.MWTransclusionOutlineWikitextWidget.js Reuse generic button widget for elements in the new sidebar 2021-07-13 17:23:27 +00:00