mediawiki-extensions-Visual.../modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
Andrew Kostka 0c14b6d0bb Don't jump back-and-forth between fullscreen and floating when resizing
Previously, when the tranclusion dialog was being resized, there was
a specific width at which both the sidebar was collapsed and the dialog
was downsized from "larger/large" to "medium". This resulted in the
dialog switching from fullscreen to floating, since the dialog's width
breakpoint for "medium" doesn't match our width breakpoint for mobile.
If the user continued to downsize past this breakpoint, then the dialog
would eventually switch back to fullscreen resulting in this weird
behavior.

A simple way to prevent this is to avoid changing the dialog's size
at all. Since we don't support collapsing the new sidebar (unless
already in fullscreen), we can just leave the dialog at the
"larger/large" size.

Bug: T274554
Change-Id: I5460cdfb1a7ed73fe7957745ba37055c5f66dce1
2021-09-09 12:16:52 +02:00

636 lines
20 KiB
JavaScript

/*!
* VisualEditor user interface MWTransclusionDialog class.
*
* @copyright 2011-2020 VisualEditor Team and others; see AUTHORS.txt
* @license The MIT License (MIT); see LICENSE.txt
*/
/**
* Dialog for inserting and editing MediaWiki transclusions, i.e. a sequence of one or more template
* invocations that strictly belong to each other (e.g. because they are unbalanced), possibly
* mixed with raw wikitext snippets.
*
* Note the base class {@see ve.ui.MWTemplateDialog} alone does not allow to manage more than a
* single template invocation. Most of the code for this feature set is exclusive to this subclass.
*
* @class
* @extends ve.ui.MWTemplateDialog
*
* @constructor
* @param {Object} [config] Configuration options
*/
ve.ui.MWTransclusionDialog = function VeUiMWTransclusionDialog( config ) {
var veConfig = mw.config.get( 'wgVisualEditorConfig' );
// Parent constructor
ve.ui.MWTransclusionDialog.super.call( this, config );
// Properties
this.isSidebarExpanded = null;
this.closeButton = null;
this.backButton = null;
this.resetConfirmation = new OO.ui.FieldsetLayout( {
classes: [ 'oo-ui-processDialog-errors' ]
} );
this.resetConfirmationTitle = new OO.ui.LabelWidget( {
label: OO.ui.deferMsg( 'visualeditor-dialog-transclusion-reset-confirmation-title' )
} );
this.resetConfirmationMessage = new OO.ui.MessageWidget( {
label: OO.ui.deferMsg( 'visualeditor-dialog-transclusion-reset-confirmation-message' ),
type: 'error'
} );
this.resetConfirmationCancelButton = new OO.ui.ButtonWidget( {
label: OO.ui.deferMsg( 'visualeditor-dialog-transclusion-reset-confirmation-cancel' )
} );
this.resetConfirmationResetButton = new OO.ui.ButtonWidget( {
label: OO.ui.deferMsg( 'visualeditor-dialog-transclusion-reset-confirmation-reset' ),
flags: [ 'primary', 'destructive' ]
} );
// Events
this.resetConfirmationCancelButton.connect( this, {
click: 'resetConfirmationHide'
} );
this.resetConfirmationResetButton.connect( this, {
click: 'resetConfirmationReset'
} );
// Initialization
this.resetConfirmation.addItems( [
new OO.ui.HorizontalLayout( {
items: [ this.resetConfirmationTitle ],
classes: [ 'oo-ui-processDialog-errors-title' ]
} ),
this.resetConfirmationMessage,
new OO.ui.HorizontalLayout( {
items: [ this.resetConfirmationCancelButton, this.resetConfirmationResetButton ],
classes: [ 'oo-ui-processDialog-errors-actions' ]
} )
] );
this.resetConfirmation.toggle( false );
this.$content.append( this.resetConfirmation.$element );
// Temporary feature flags
this.useInlineDescriptions = veConfig.transclusionDialogInlineDescriptions;
this.useBackButton = veConfig.transclusionDialogBackButton;
this.useSearchImprovements = veConfig.templateSearchImprovements;
this.useNewSidebar = veConfig.transclusionDialogNewSidebar;
if ( this.useInlineDescriptions ) {
this.$element.addClass( 've-ui-mwTransclusionDialog-bigger' );
}
if ( this.useSearchImprovements ) {
this.$element.addClass( 've-ui-mwTransclusionDialog-enhancedSearch' );
}
if ( this.useNewSidebar ) {
this.$element.addClass( 've-ui-mwTransclusionDialog-newSidebar' );
}
};
/* Inheritance */
OO.inheritClass( ve.ui.MWTransclusionDialog, ve.ui.MWTemplateDialog );
/* Static Properties */
ve.ui.MWTransclusionDialog.static.name = 'transclusion';
ve.ui.MWTransclusionDialog.static.actions = ve.ui.MWTemplateDialog.static.actions.concat( [
{
action: 'mode',
modes: [ 'edit', 'insert' ],
// HACK: Will be set later, but we want measurements to be accurate in the mean time, this
// will not be needed when T93290 is resolved
label: $( document.createTextNode( '\u00a0' ) )
},
{
action: 'back',
label: OO.ui.deferMsg( 'visualeditor-dialog-action-goback' ),
modes: [ 'edit', 'insert' ],
flags: [ 'safe', 'back' ]
}
] );
/** @inheritdoc */
ve.ui.MWTransclusionDialog.static.bookletLayoutConfig = ve.extendObject(
{},
ve.ui.MWTemplateDialog.static.bookletLayoutConfig,
{ outlined: true, editable: true }
);
ve.ui.MWTransclusionDialog.static.smallScreenMaxWidth = 540;
/* Methods */
/**
* Handle outline controls move events.
*
* @private
* @param {number} places Number of places to move the selected item
*/
ve.ui.MWTransclusionDialog.prototype.onOutlineControlsMove = function ( places ) {
var parts = this.transclusionModel.getParts(),
itemId = this.findSelectedPartId();
if ( itemId ) {
var part = this.transclusionModel.getPartFromId( itemId );
// Move part to new location, and if dialog is loaded switch to new part page
var promise = this.transclusionModel.addPart( part, parts.indexOf( part ) + places );
if ( this.loaded && !this.preventReselection ) {
promise.done( this.focusPart.bind( this, part.getId() ) );
}
}
};
/**
* Handle outline controls remove events.
*
* @private
*/
ve.ui.MWTransclusionDialog.prototype.onOutlineControlsRemove = function () {
var id = this.findSelectedPartId();
if ( id ) {
var part = this.transclusionModel.getPartFromId( id );
// Check if the part is the actual template, or one of its parameters
if ( part instanceof ve.dm.MWTemplateModel && id !== part.getId() ) {
var param = part.getParameterFromId( id );
if ( param instanceof ve.dm.MWParameterModel ) {
part.removeParameter( param );
}
} else if ( part instanceof ve.dm.MWTransclusionPartModel ) {
this.transclusionModel.removePart( part );
}
}
};
/**
* Handle booklet layout focus.
*
* @private
*/
ve.ui.MWTransclusionDialog.prototype.onBookletLayoutFocus = function () {
var currentPage = this.bookletLayout.getCurrentPage(),
isParameterPage = currentPage instanceof ve.ui.MWParameterPage;
this.bookletLayout.getOutlineControls().removeButton.setDisabled( isParameterPage );
};
/**
* Handle add template button click events.
*
* @private
*/
ve.ui.MWTransclusionDialog.prototype.onAddTemplateButtonClick = function () {
this.addPart( new ve.dm.MWTemplatePlaceholderModel( this.transclusionModel ) );
};
/**
* Handle add content button click events.
*
* @private
*/
ve.ui.MWTransclusionDialog.prototype.onAddContentButtonClick = function () {
this.addPart( new ve.dm.MWTransclusionContentModel( this.transclusionModel ) );
};
/**
* Handle add parameter button click events.
*
* @private
*/
ve.ui.MWTransclusionDialog.prototype.onAddParameterButtonClick = function () {
var partId = this.findSelectedPartId();
if ( !partId ) {
return;
}
var part = this.transclusionModel.getPartFromId( partId );
if ( !( part instanceof ve.dm.MWTemplateModel ) ) {
return;
}
// TODO: Use a distinct class for placeholder model rather than
// these magical "empty" constants.
part.addParameter( new ve.dm.MWParameterModel( part ) );
};
/**
* Handle booklet layout page set events.
*
* @private
* @param {OO.ui.PageLayout} page Active page
*/
ve.ui.MWTransclusionDialog.prototype.onBookletLayoutSet = function ( page ) {
var isPlaceholder = page instanceof ve.ui.MWTemplatePlaceholderPage,
acceptsNewParameters = page instanceof ve.ui.MWTemplatePage ||
page instanceof ve.ui.MWParameterPage,
isRequired = page instanceof ve.ui.MWParameterPage && page.parameter.isRequired(),
canNotRemove = isRequired ||
( isPlaceholder && this.transclusionModel.getParts().length === 1 );
this.addParameterButton.setDisabled( !acceptsNewParameters || this.isReadOnly() );
this.bookletLayout.getOutlineControls().removeButton.toggle( !canNotRemove );
};
/**
* @inheritdoc
*/
ve.ui.MWTransclusionDialog.prototype.onReplacePart = function ( removed, added ) {
ve.ui.MWTransclusionDialog.super.prototype.onReplacePart.call( this, removed, added );
var parts = this.transclusionModel.getParts();
if ( parts.length === 0 ) {
this.addParameterButton.setDisabled( true );
this.addPart( new ve.dm.MWTemplatePlaceholderModel( this.transclusionModel ) );
}
this.multipartMessage.toggle( parts.length > 1 && this.useNewSidebar );
var canCollapse = this.isSingleTemplateTransclusion();
this.actions.setAbilities( { mode: canCollapse } );
this.updateActionSet();
};
/**
* @private
* @return {boolean} True if the dialog contains a single template or template placeholder. False
* otherwise. Also false if there is no data model connected yet.
*/
ve.ui.MWTransclusionDialog.prototype.isSingleTemplateTransclusion = function () {
var parts = this.transclusionModel && this.transclusionModel.getParts();
return parts && parts.length === 1 && (
parts[ 0 ] instanceof ve.dm.MWTemplateModel ||
parts[ 0 ] instanceof ve.dm.MWTemplatePlaceholderModel
);
};
/**
* @return {string|undefined}
*/
ve.ui.MWTransclusionDialog.prototype.findSelectedPartId = function () {
if ( this.pocSidebar ) {
return this.pocSidebar.findSelectedPartId();
}
var item = this.bookletLayout.getOutline().findSelectedItem();
return item && item.getData();
};
/**
* @inheritdoc
*/
ve.ui.MWTransclusionDialog.prototype.getPageFromPart = function ( part ) {
var page = ve.ui.MWTransclusionDialog.super.prototype.getPageFromPart.call( this, part );
if ( !page && part instanceof ve.dm.MWTransclusionContentModel ) {
return new ve.ui.MWTransclusionContentPage( part, part.getId(), { $overlay: this.$overlay, isReadOnly: this.isReadOnly() } );
}
return page;
};
/**
* Automatically expand or collapse the sidebar according to default logic.
*
* @private
*/
ve.ui.MWTransclusionDialog.prototype.autoExpandSidebar = function () {
var showSidebar;
if ( this.useInlineDescriptions ) {
var isSmallScreen = $( window ).width() <= this.constructor.static.smallScreenMaxWidth;
showSidebar = !isSmallScreen;
this.$otherActions.toggleClass( 'oo-ui-element-hidden', !isSmallScreen );
this.$content.toggleClass( 've-ui-mwTransclusionDialog-small-screen', isSmallScreen );
} else {
showSidebar = !this.isSingleTemplateTransclusion();
}
this.toggleSidebar( showSidebar );
};
/**
* Set if the sidebar is visible (which means the dialog is expanded), or collapsed.
*
* @param {boolean} showSidebar
* @private
*/
ve.ui.MWTransclusionDialog.prototype.toggleSidebar = function ( showSidebar ) {
if ( this.isSidebarExpanded === showSidebar ) {
return;
}
this.isSidebarExpanded = showSidebar;
this.$content
.toggleClass( 've-ui-mwTransclusionDialog-collapsed', !showSidebar )
.toggleClass( 've-ui-mwTransclusionDialog-expanded', showSidebar );
var dialogSizeSidebarExpanded = this.useInlineDescriptions ? 'larger' : 'large';
var dialogSizeSidebarCollapsed = this.useNewSidebar ? dialogSizeSidebarExpanded : 'medium';
this.ignoreNextWindowResizeEvent = true;
this.setSize( showSidebar ? dialogSizeSidebarExpanded : dialogSizeSidebarCollapsed );
this.bookletLayout.toggleOutline( showSidebar );
this.updateTitle();
this.updateModeActionState();
// HACK blur any active input so that its dropdown will be hidden and won't end
// up being mispositioned
this.$content.find( 'input:focus' ).trigger( 'blur' );
};
/**
* @inheritdoc
*/
ve.ui.MWTransclusionDialog.prototype.updateTitle = function () {
if ( !this.isSingleTemplateTransclusion() ) {
this.title.setLabel( ve.msg( 'visualeditor-dialog-transclusion-title-edit-transclusion' ) );
} else {
// Parent method
ve.ui.MWTransclusionDialog.super.prototype.updateTitle.call( this );
}
};
/**
* Update the state of the 'mode' action
*
* @private
*/
ve.ui.MWTransclusionDialog.prototype.updateModeActionState = function () {
var parts = this.transclusionModel && this.transclusionModel.getParts(),
isExpanded = this.isSidebarExpanded,
label = ve.msg( isExpanded ?
'visualeditor-dialog-transclusion-collapse-options' :
'visualeditor-dialog-transclusion-expand-options' );
this.actions.forEach( { actions: [ 'mode' ] }, function ( action ) {
action.setLabel( label );
action.$button.attr( 'aria-expanded', isExpanded ? 1 : 0 );
} );
// Decide whether the button should be enabled or not. It needs to be:
// * disabled when we're in the initial add-new-template phase, because it's
// meaningless
// * disabled if we're in a multi-part transclusion, because the sidebar's
// forced open (this does not apply when using the new sidebar)
// * enabled if we're in a single-part transclusion, because the sidebar's
// closed but can be opened to add more parts
if ( parts ) {
var canCollapse = !( parts[ 0 ] instanceof ve.dm.MWTemplatePlaceholderModel ) &&
( this.useInlineDescriptions || this.isSingleTemplateTransclusion() );
this.actions.setAbilities( { mode: canCollapse } );
}
};
/**
* Add a part to the transclusion.
*
* @param {ve.dm.MWTransclusionPartModel} part Part to add
*/
ve.ui.MWTransclusionDialog.prototype.addPart = function ( part ) {
var parts = this.transclusionModel.getParts(),
itemId = this.findSelectedPartId();
if ( part ) {
// Insert after selected part, or at the end if nothing is selected
var index = itemId ?
parts.indexOf( this.transclusionModel.getPartFromId( itemId ) ) + 1 :
parts.length;
// Add the part, and if dialog is loaded switch to part page
var promise = this.transclusionModel.addPart( part, index );
if ( this.loaded && !this.preventReselection ) {
promise.done( this.focusPart.bind( this, part.getId() ) );
}
}
};
/**
* @inheritdoc
*/
ve.ui.MWTransclusionDialog.prototype.getActionProcess = function ( action ) {
if ( action === 'back' ) {
if ( !this.containsValuableData() ) {
return this.getActionProcess( 'reset' );
}
return new OO.ui.Process( function () {
this.resetConfirmation.toggle( true );
}, this );
}
if ( action === 'reset' ) {
return new OO.ui.Process( function () {
this.resetDialog();
}, this );
}
if ( action === 'mode' ) {
return new OO.ui.Process( function () {
this.toggleSidebar( !this.isSidebarExpanded );
}, this );
}
return ve.ui.MWTransclusionDialog.super.prototype.getActionProcess.call( this, action );
};
/**
* Update the widgets in the dialog's action bar.
*
* @private
*/
ve.ui.MWTransclusionDialog.prototype.updateActionSet = function () {
var backButton = this.actions.get( { flags: [ 'back' ] } ).pop(),
saveButton = this.actions.get( { actions: [ 'done' ] } ).pop();
if ( saveButton && this.getMode() === 'edit' ) {
saveButton.setLabel( ve.msg( 'visualeditor-dialog-transclusion-action-save' ) );
}
if ( backButton ) {
// Todo: this won't be needed if https://gerrit.wikimedia.org/r/c/oojs/ui/+/686439 is resolved
this.backButton = backButton;
}
// T283511
if ( !this.backButton ) {
return;
}
if ( this.useBackButton ) {
var closeButton = this.actions.get( { flags: [ 'close' ] } ).pop(),
parts = this.transclusionModel && this.transclusionModel.getParts(),
isInitialPage = parts && parts.length === 1 && parts[ 0 ] instanceof ve.dm.MWTemplatePlaceholderModel,
isInsertMode = this.getMode() === 'insert';
if ( closeButton ) {
// Todo: this won't be needed if https://gerrit.wikimedia.org/r/c/oojs/ui/+/686439 is resolved
this.closeButton = closeButton;
}
this.closeButton.toggle( !isInsertMode || isInitialPage );
this.backButton.toggle( isInsertMode && !isInitialPage );
} else {
this.backButton.toggle( false );
}
};
/**
* Dismisses the reset confirmation.
*
* @private
*/
ve.ui.MWTransclusionDialog.prototype.resetConfirmationHide = function () {
this.resetConfirmation.toggle( false );
};
/**
* Dismisses the reset confirmation and runs the reset action.
*
* @private
*/
ve.ui.MWTransclusionDialog.prototype.resetConfirmationReset = function () {
this.resetConfirmationHide();
this.executeAction( 'reset' );
};
/**
* Revert the dialog back to its initial state.
*
* @private
*/
ve.ui.MWTransclusionDialog.prototype.resetDialog = function () {
var target = this;
this.transclusionModel.reset();
if ( this.pocSidebar ) {
this.pocSidebar.clear();
}
this.bookletLayout.clearPages();
this.transclusionModel
.addPart( new ve.dm.MWTemplatePlaceholderModel( this.transclusionModel ), 0 )
.done( function () {
target.autoExpandSidebar();
target.updateModeActionState();
} );
};
/**
* @return {boolean} True if any transclusion part contains meaningful, non-default user input
*/
ve.ui.MWTransclusionDialog.prototype.containsValuableData = function () {
return this.transclusionModel.getParts().some( function ( part ) {
return part.containsValuableData();
} );
};
/**
* @inheritdoc
*/
ve.ui.MWTransclusionDialog.prototype.initialize = function () {
// Parent method
ve.ui.MWTransclusionDialog.super.prototype.initialize.call( this );
// Properties
this.addTemplateButton = new OO.ui.ButtonWidget( {
framed: false,
icon: 'puzzle',
title: ve.msg( 'visualeditor-dialog-transclusion-add-template' )
} );
this.addContentButton = new OO.ui.ButtonWidget( {
framed: false,
icon: 'wikiText',
title: ve.msg( this.useNewSidebar ?
'visualeditor-dialog-transclusion-add-wikitext' :
'visualeditor-dialog-transclusion-add-content' )
} );
this.addParameterButton = new OO.ui.ButtonWidget( {
framed: false,
icon: 'parameter',
title: ve.msg( 'visualeditor-dialog-transclusion-add-param' )
} );
this.bookletLayout.getOutlineControls().addItems( [ this.addTemplateButton, this.addContentButton ] );
if ( !this.useNewSidebar ) {
this.bookletLayout.getOutlineControls().addItems( [ this.addParameterButton ] );
}
this.multipartMessage = new OO.ui.MessageWidget( {
label: ve.msg( 'visualeditor-dialog-transclusion-multipart-message' ),
classes: [ 've-ui-mwTransclusionDialog-multipart-message' ]
} );
// Events
if ( this.useInlineDescriptions ) {
this.getManager().connect( this, { resize: ve.debounce( this.onWindowResize.bind( this ) ) } );
}
this.bookletLayout.connect( this, { set: 'onBookletLayoutSet' } );
this.bookletLayout.$menu.find( '[ role="listbox" ]' ).first()
.attr( 'aria-label', ve.msg( 'visualeditor-dialog-transclusion-templates-menu-aria-label' ) );
this.addTemplateButton.connect( this, { click: 'onAddTemplateButtonClick' } );
this.addContentButton.connect( this, { click: 'onAddContentButtonClick' } );
this.addParameterButton.connect( this, { click: 'onAddParameterButtonClick' } );
this.bookletLayout.getOutlineControls().connect( this, {
move: 'onOutlineControlsMove',
remove: 'onOutlineControlsRemove'
} );
if ( this.useNewSidebar ) {
this.bookletLayout.$element.on( 'focusin', this.onBookletLayoutFocus.bind( this ) );
this.bookletLayout.stackLayout.$element.prepend( this.multipartMessage.$element );
}
};
/**
* @inheritdoc
*/
ve.ui.MWTransclusionDialog.prototype.getSetupProcess = function ( data ) {
return ve.ui.MWTransclusionDialog.super.prototype.getSetupProcess.call( this, data )
.next( function () {
var isReadOnly = this.isReadOnly();
this.addTemplateButton.setDisabled( isReadOnly );
this.addContentButton.setDisabled( isReadOnly );
this.addParameterButton.setDisabled( isReadOnly );
this.bookletLayout.getOutlineControls().setAbilities( {
move: !isReadOnly,
remove: !isReadOnly
} );
if ( this.useNewSidebar ) {
this.bookletLayout.getOutlineControls().toggle( !this.isSingleTemplateTransclusion() );
this.$element.toggleClass(
've-ui-mwTransclusionDialog-single-transclusion',
this.isSingleTemplateTransclusion()
);
}
this.updateModeActionState();
this.autoExpandSidebar();
}, this );
};
/**
* @private
*/
ve.ui.MWTransclusionDialog.prototype.onWindowResize = function () {
if ( !this.ignoreNextWindowResizeEvent ) {
this.autoExpandSidebar();
}
this.ignoreNextWindowResizeEvent = false;
};
/**
* @inheritdoc
*
* Temporary override to increase dialog size when a feature flag is enabled.
*/
ve.ui.MWTransclusionDialog.prototype.getSizeProperties = function () {
var sizeProps = ve.ui.MWTransclusionDialog.super.prototype.getSizeProperties.call( this );
if ( this.useInlineDescriptions ) {
sizeProps = ve.extendObject( { height: '90%' }, sizeProps );
}
return sizeProps;
};
/* Registration */
ve.ui.windowFactory.register( ve.ui.MWTransclusionDialog );