mediawiki-extensions-Visual.../includes/VisualEditorDesktopArticleTargetInitModule.php
Timo Tijhof 139b5b879a DesktopArticleTargetInitModule: Avoid expensive $msg->exists check
This check currently requires LCStore, MessageCache, and (sometimes)
Database to involved to check whether the message and/or local override
exist.

Using `useDatabase(false)` should take away most of this cost
by no longer performing the multiple Memcached/Database roundtrips,
and leaving only a cheap in-process check on LCStore.

Bug: T221294
Change-Id: I6bf47cd84cdf9bfdd63bee0a613425bb79595e4f
2019-04-17 23:12:53 +01:00

48 lines
1.5 KiB
PHP

<?php
/**
* ResourceLoader module for the 'ext.visualEditor.desktopArticleTarget.init'
* module. Necessary to incorporate the VisualEditorTabMessages
* configuration setting.
*
* @file
* @ingroup Extensions
* @copyright 2011-2019 VisualEditor Team and others; see AUTHORS.txt
* @license MIT
*/
class VisualEditorDesktopArticleTargetInitModule extends ResourceLoaderFileModule {
/**
* @inheritDoc
*/
public function getMessages() {
$messages = parent::getMessages();
$veConfig = ConfigFactory::getDefaultInstance()->makeConfig( 'visualeditor' );
$messages = array_merge(
$messages,
array_filter( $veConfig->get( 'VisualEditorTabMessages' ) )
);
// Some skins don't use the default 'edit' and 'create' message keys.
// Check the localisation cache for which skins have a custom message for this.
// We only need this for the current skin, but ResourceLoader's message cache
// does not fragment by skin.
foreach ( SkinFactory::getDefaultInstance()->getSkinNames() as $skname => $unused ) {
foreach ( [ 'edit', 'create' ] as $msgKey ) {
// Messages: vector-view-edit, vector-view-create
// Disable database lookups for site-level message overrides as they
// are expensive and not needed here (T221294). We only care whether the
// message key is known to localisation cache at all.
$msg = wfMessage( "$skname-view-$msgKey" )->useDatabase( false )->inContentLanguage();
if ( $msg->exists() ) {
$messages[] = "$skname-view-$msgKey";
}
}
}
return $messages;
}
}