wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Visual.../modules/parser
History
Gabriel Wicke 08b5ed1a43 Use _inNewlineContext method instead of bare onNewline 
This makes sure that we escape start-of-line syntax when needed, since
onNewline is often not yet set.

Discussion / background:
[19:18] <subbu> this will fix it, but, i think this is asking for another
minor refactoring of these flags ... because this is a subtle fix which means
it might be possible to make it clearer.  onNewline is one true in on
direction, i.e. if true, we are in a new line state, but if we are in a
newline context, onNewline is not true, which is why this new method is
needed.
[19:19] <subbu> i dont know if it is possible, but it seems like it shoudl be
possible.  but, something for later.
[19:20] <subbu> badly phraed.  "onNewline" ==> in new line context, but if in
new line context, onNewline may be false.
[19:20] <gwicke> we should perhaps update it as early as possible instead
[19:21] <subbu> i cannot today, but possible monday.  i am heading out in
about 15-30 mins.
[19:22] <gwicke> will need to check all conditions depending on it in
_serializeToken
[19:22] <subbu> oh, i misunderstood you :)
[19:22] <gwicke> and if there are cases where the onNewline / onStartOfLine
state could be reverted later
[19:23] <subbu> you were referring to the flag, i thought you meant we should
fix this sooner than later.
[19:23] <gwicke> yes, I wasn't terribly clear
[19:23] <gwicke> you wrote something about following productions swallowing
newlines, but I think we don't actually do that any more
[19:24] <gwicke> I'm quite optimistic that updating those flags much earlier
would work
[19:25] <subbu> yes, it could fix it.
[19:26] <subbu> you might be right reg. swallowing.  it was happening earlier.
but, not right now, after single-line mode and other fixes.

Change-Id: Ic1d8141c04eb54a59977d0ba87bcf06bafd421e0
2012-06-23 19:27:56 +02:00
..
html5 Update patched html5 library to version 0.3.8 2012-06-06 10:17:03 +02:00
core-upgrade.js Add core-upgrade 2012-06-06 15:58:17 +02:00
ext.Cite.js Very basic interwiki support 2012-06-05 11:19:58 +02:00
ext.cite.taghook.ref.js Moving parser stuff back into the modules folder (oops) 2011-11-02 21:45:57 +00:00
ext.core.AttributeExpander.js Big token transform framework overhaul part 2 2012-05-15 17:05:47 +02:00
ext.core.BehaviorSwitchHandler.js Big token transform framework overhaul part 2 2012-05-15 17:05:47 +02:00
ext.core.LinkHandler.js Clean up sHref handling a bit 2012-06-20 00:34:57 +02:00
ext.core.ListHandler.js Support dt/dd transitions in the middle of the stack 2012-06-21 18:40:40 +02:00
ext.core.NoIncludeOnly.js Big token transform framework overhaul part 2 2012-05-15 17:05:47 +02:00
ext.core.ParserFunctions.js Fix padleft / padright (mis)use as substr 2012-06-04 11:30:45 +02:00
ext.core.PostExpandParagraphHandler.js Improve the handling of newlines for round-tripping 2012-06-06 10:17:03 +02:00
ext.core.QuoteTransformer.js Fixed bugs handing/transforming quotes 2012-06-07 01:37:45 -05:00
ext.core.Sanitizer.js Big token transform framework overhaul part 2 2012-05-15 17:05:47 +02:00
ext.core.TemplateHandler.js Very basic round-trip test mode for the API 2012-06-02 16:20:54 +02:00
ext.Util.js Nominate more HTML5 sectioning and heading elements for block-level treatment 2012-04-11 12:53:49 +02:00
ext.util.TokenCollector.js Big token transform framework overhaul part 2 2012-05-15 17:05:47 +02:00
mediawiki.ApiRequest.js Add ApiRequest 2012-06-02 16:52:51 +02:00
mediawiki.DOMConverter.js Replace console.log with console.warn in all debug statements 2012-02-14 20:56:14 +00:00
mediawiki.DOMPostProcessor.js First pass implementing a general tag minimization routine 2012-05-31 12:10:28 -05:00
mediawiki.HTML5TreeBuilder.node.js Emit SpaceCharacters token for HTML5 'space' chars 2012-06-17 16:16:07 +02:00
mediawiki.LinearModelConverter.js Add HTML DOM -> linear model converter 2012-03-29 12:47:14 -07:00
mediawiki.parser.defines.js Wikitext escaping and quite complete source range tracking 2012-06-19 23:36:44 +02:00
mediawiki.parser.environment.js Improve interwiki config a bit 2012-06-07 12:30:16 +02:00
mediawiki.parser.js Big token transform framework overhaul part 2 2012-05-15 17:05:47 +02:00
mediawiki.Title.js Very basic interwiki support 2012-06-05 11:19:58 +02:00
mediawiki.tokenizer.peg.js Tokenizer backtracking cache bug fix and memory savings 2012-06-01 12:53:49 +02:00
mediawiki.TokenTransformManager.js Minor code refactoring 2012-06-13 09:46:34 -05:00
mediawiki.WikitextSerializer.js Use _inNewlineContext method instead of bare onNewline 2012-06-23 19:27:56 +02:00
package.json Basic parser / serializer web service 2012-05-23 12:35:00 +02:00
parse.js Very basic interwiki support 2012-06-05 11:19:58 +02:00
pegTokenizer.pegjs.txt Fix definition list parsing and round-trip single vs. multi-line dt/dd 2012-06-21 17:34:25 +02:00
README.txt As much as I have loved writing Makefiles... I've replaced its functionality with package.json, mostly so we can avoid non-node dependencies. This is one of the recommended practices. We should consider moving tests/parser into modules/parser/tests, other node projects keep all module code in one directory. 2012-04-04 11:02:58 -07:00

README.txt 

A combined Mediawiki and html parser in JavaScript running on node.js. Please
see (https://www.mediawiki.org/wiki/Future/Parser_development) for an overview
of the current implementation, and instructions on running the tests.

You might need to set the NODE_PATH environment variable,
  export NODE_PATH="node_modules"

Download the dependencies:
  npm install

Run tests:
  npm test