Commit graph

9795 commits

Author SHA1 Message Date
jenkins-bot 17b160b125 Merge "Remove obsolete comment; this functionality is now in place" 2015-04-15 00:52:31 +00:00
jenkins-bot 2fb464e552 Merge "Focus on the first input in template dialog" 2015-04-14 22:43:37 +00:00
Roan Kattouw 86b82b537d Make activation timings sent to EventLogging not lie
The activation timing was always a bit of a lie even pre-TargetLoader,
because the timer only started when the first RL request for VE
modules had loaded. But at least the process it covered was consistent,
which is no longer true with TargetLoader. Now that we start the
request for the HTML together with the RL request, the activation
time might include some, all or none of the HTML request depending
on how fast the RL request was.

This change makes the activation timings more useful by measuring
from the moment the user clicks "edit" to the moment the editor
is done loading, which is what actually matters.

* Moved start of activation timing to VPT init
** For mobile this falls back to when mw.Target#load is called;
   we'll have to fix that in MobileFrontend later
* Moved end of activation timing out of TargetEvents#onSurfaceReady
  into individual onSurfaceReady handlers
** This is necessary because VPT's onSurfaceReady does quite a lot,
   and we want to include the time that takes in our measurements

Change-Id: Ie44f0b839b39a2b3b22dcd86e20f0d1170cb6069
2015-04-14 21:57:11 +00:00
jenkins-bot ec01cdfb94 Merge "Comment potential override of wikitextRef sequence" 2015-04-14 21:46:42 +00:00
Translation updater bot 660fdfa635 Localisation updates from https://translatewiki.net.
Change-Id: I26100d5e756fa033ebee6e9094cad81631ac1e3e
2015-04-14 22:36:57 +02:00
jenkins-bot 2db2e4c4c7 Merge "Remove HTML escaping from createTextNode" 2015-04-14 18:57:20 +00:00
Ed Sanders 4b15914047 Remove HTML escaping from createTextNode
Change-Id: Icb5ad749ed48808f6cf377bdd368bff3cf035913
2015-04-14 19:30:21 +01:00
jenkins-bot 54afadf9d1 Merge "Replace abstract functions that just throw with null" 2015-04-14 16:57:10 +00:00
James D. Forrester 45f04c4cda Update VE core submodule to master (bc37479)
New changes:
eab6467 Add ve.dm.Document#getLength
310a040 ve.ui.Tool: Correct documentation
7a64825 Localisation updates from https://translatewiki.net.
d025658 ve.utils: Add ve.binarySearch() and port ve.dm.MetaList#findItem to it
8400efd demo: Fix another bug showing both LTR and RTL stylesheets
d3168f3 Factor out method which fills paste target with dummy contents for copy
363c804 Remove platform auto-instantiation
67ac409 Improve demo read mode
c2588bd Replace abstract functions that just throw with null
9073b6b Add docs for ve.ui.ContextItem#embeddable

Change-Id: I41b0ec10e0c085290944e8c3293bcad5e956e909
2015-04-14 09:17:59 -07:00
Timo Tijhof 66c9d538c5 MWPopupTool: Don't assume editnotice html has a single wrapping element
In case of FlaggedRevs, for example, the software is given a loose
string of html with a Bold element, Text nodes, and Anchor element.

Bug: T95989
Change-Id: I3d345677507ffc08feec0f7785e148ac98f19cb7
2015-04-14 12:39:42 +01:00
Roan Kattouw 95bffa22a0 Stop using this.$
Has been a backwards-compatibility alias since OOjs UI 0.7.0.

Change-Id: I17d7c03e9d1b9fa991d88444d22abfd403269ee0
2015-04-14 02:54:01 +01:00
Matthew Flaschen fee6681049 Remove obsolete comment; this functionality is now in place
Change-Id: I2752c69e871965ac408aaa70eb268e129b587013
2015-04-13 19:11:34 -04:00
Translation updater bot 6335f08963 Localisation updates from https://translatewiki.net.
Change-Id: I4a65b2b95c71551f37c6be20c2b2ff9d252b6455
2015-04-13 22:36:28 +02:00
jenkins-bot 8c29e52202 Merge "mw.ViewPageTarget: Use new simplified ve.ui.Surface#getDom" 2015-04-13 19:06:13 +00:00
jenkins-bot f32477f6e6 Merge "Remove useless ve.init.Platform overrides" 2015-04-13 19:06:07 +00:00
Ed Sanders 502272a1bc mw.ViewPageTarget: Use new simplified ve.ui.Surface#getDom
Depends on I6355cf484b8 in core.

Change-Id: I3dcce40af346b1c5ab75c0da81aee8ae02937f44
2015-04-13 18:38:56 +00:00
Ed Sanders 91923e815b Remove useless ve.init.Platform overrides
The parent methods (ve.init.Platform) are now identical.

Change-Id: Idbf18d64b723ce2465e7c0c994c88b4b63c87445
2015-04-13 18:30:57 +00:00
James D. Forrester 009a44b03a Update VE core submodule to master (8c5917f)
New changes:
ecbbbd6 Close inspectors when dialog opens
d8868a9 ce.ContentBranchNode: Clean up documentation
c47d7b8 Follow-up Ifa18938: Fix cursoring in nested table cells
483b614 Localisation updates from https://translatewiki.net.
24787de Stop using this.$
b29f8ea ve.ce.Surface: Don't assume ve.compareDocumentOrder() returns exactly 1
3c5442e [BREAKING CHANGE] Generalize ve.compareOffsetPaths() to ve.compareTuples()
8e6ccc4 ce.Surface: Remove unused clone of copied data in #onCopy
950b8d6 Localisation updates from https://translatewiki.net.
8a20669 Follow-up 950b8d6: Add new langs 'ang' & 'gn' to build
48a69ea Show full diff when grunt git-status fails
8e0e1a3 demo: Separate run scripts from load modules
bcac0fd Provide simplified API for getting DOM from a surface
9061708 ve.init.sa.Target: Add jsduck @demo for simplest editor
fb98167 build: Provide concatenated distribution files for libraries which don't
053ec12 Create minimal demo
68da78e build: Fix eg-iframe.html
12ef310 Move @example demo to ve.init.sa.Platform
8c5917f Update OOjs UI to v0.9.8

Change-Id: I31eb5cd4b0c7e5cb0693c58b6a139beca921d98b
2015-04-12 22:47:56 +00:00
Translation updater bot 56125724e4 Localisation updates from https://translatewiki.net.
Change-Id: I7fd073dff4328b6f6e1951734fe3c85451ba2ea7
2015-04-12 21:58:20 +02:00
Translation updater bot aec2a80a44 Localisation updates from https://translatewiki.net.
Change-Id: Ifcd84e4b3bd96294e362a12cc2d29807e6e4f325
2015-04-11 21:34:32 +02:00
Ed Sanders 2bbcb13e9d Comment potential override of wikitextRef sequence
Change-Id: Iac6df7ecd5482fd65ec91927f3a02e4efdcd617e
2015-04-11 12:03:58 +01:00
Translation updater bot d415113e39 Localisation updates from https://translatewiki.net.
Change-Id: Ifa79dd1622f06aac4181007d75eaa76cc5c84026
2015-04-10 21:51:51 +02:00
Moriel Schottlender 35059ee54c Focus on the first input in template dialog
When the dialog opens make sure the first input is focused.

** Depends on OOUI change I9f1e908e0d **

Bug: T95450
Change-Id: I789bcf98ada7c3e2b9544426546775f65bab0edd
2015-04-10 16:45:22 +00:00
Ori Livneh 30772ee3f5 Update RESTBase pre-connect URL to hit /_preconnect
/_preconnect is a special end-point that is handled by Varnish with an HTTP
204, sparing the RESTBase backend. See I95a716592.

Change-Id: I0c0430014768d7a1c6673d078569d0cf4062d338
2015-04-09 17:43:53 -07:00
Moriel Schottlender c10483999e Focus the search box in the re-use citation dialog
Bug: T91479
Change-Id: I3ad7c99d2fded2d2f21bd210dd57ad9807d88e13
2015-04-09 16:28:17 -07:00
James D. Forrester 916eba05a5 Replace abstract functions that just throw with null
Per Timo, this avoids us having pointless code that is never
executed, and the replacement notification to the user (that
ve.blah.UnicornAnnotation.foo is null and not a method) is
sufficiently clear that the issue lies in the lack of existence
of the ve.blah.UnicornAnnotation#foo method.

Only ones in this repo appear to be in ve.init.mw.ApiResponseCache.

Bug: T54482
Change-Id: If44b8d63b8e7b2a5c289fe7278ad54e722b185fa
2015-04-09 23:20:07 +00:00
Moriel Schottlender 7c0b307d8a Allow for citation tools to work under the reference dialog
Set up the surface widget as inside the reference dialog, and let
the citation action notify the template dialog the name of the
dialog it is in. If the tool was executed from within the reference
dialog, skip over creating a reference and instead insert the
citation as a template.

* Depends on ve-core fix I709eeb0de475 *

Bug: T94621
Change-Id: I4871f8c0afe190117cc90e88227b37f292a71e20
2015-04-09 12:18:54 -07:00
Roan Kattouw 0d78c3225f Update VE core submodule to master (3edec8a)
New changes:
10b1ae6 Skip ignoreChildren nodes in getAnnotatedRangeFromSelection
05c4dab Add tests for TableAction#create
48f71d1 Encode as few characters in comments as possible
56ce872 Add an inDialog config option in ve.ui.Surface
dd3eabf Add tests for TableAction#insert
874ed86 Add tests for TableAction#mergeCells
9114d9e Follow-up I23d37e3d: Remove unused converter method
12eda5d Test TableAction#merge when full rows/cols selected
06bcc9e Add test for TableAction#delete
2ac1ae1 Add tests for TableAction#changeStyle and TableAction#caption
915dd75 ve.utils: Fix bug in batchSplice polyfill
97e9cce Test SurfaceFragment#expandLinearSelection( 'annotation' ...
f6a63fe Localisation updates from https://translatewiki.net.

Change-Id: I47aadba81b0ea14bf241e7c6658c9c900b8cabed
2015-04-09 12:17:38 -07:00
Ori Livneh c741db5378 Pre-fetch RESTBase DNS and negotiate TLS
Keep VisualEditor load times snappy by eagerly establishing a connection with
RESTBase via a beacon request, which is deferred until after window.onload /
setTimeout to ensure it does not slow down the loading of the page.

Task: T94784
Change-Id: I19fd2ef6beffe1c4c4f05c2716da079b49e88b95
2015-04-09 11:54:27 -07:00
jenkins-bot 0f76888310 Merge "Split AlienExtensionNode into inline and block" 2015-04-09 17:37:57 +00:00
Translation updater bot 471fbe5219 Merge "Localisation updates from https://translatewiki.net." 2015-04-09 17:37:22 +00:00
Translation updater bot 23cdc8c1d6 Localisation updates from https://translatewiki.net.
Change-Id: I4d57690e6310b81acac375da1834ffc84b7628a1
2015-04-09 19:35:40 +02:00
jenkins-bot 65fe5399a3 Merge "Set targetName for apiLoad and restbaseLoad metrics to the correct values again" 2015-04-09 17:25:49 +00:00
Ed Sanders fdcd42f73a Split AlienExtensionNode into inline and block
MWExtensionNode:
* Inherit from LeafNode at the top level. Inline and block only
  differ in CE where inline has isContent set.

MWAlienExtensionNode:
* Inhert from MW(Inline|Block)ExtensionNode respectively. Both
  mixin MWAlienExtensionNode.

Bonus:
* Bring in paragraph unwrapping on inline nodes from MWMathNode

Bug: T93712
Change-Id: Ib04234f740cf1f27c861d8b3cfeea5e323b94678
2015-04-09 16:32:02 +01:00
Alex Monk 19dc7d31fe Set targetName for apiLoad and restbaseLoad metrics to the correct values again
If70ff601 didn't really fix anything. The only reason you'd want this data is
to distinguish between mobile and desktop data, but it just set the value to
the desktop version always...

Bug: T95432
Change-Id: I76722e3ad8b7dbe644374b24093bec696f27f48c
2015-04-09 13:57:25 +01:00
jenkins-bot 2c9d207d57 Merge "[BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector" 2015-04-08 23:16:02 +00:00
Ed Sanders ed4278912c [BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector
Also fix up logic duplicated between ExtensionInspector
and LiveExtensionInspector.

BREAKING CHANGE:
* nodeModel property no longer exists, use NodeInspector's modelClasses
  property, which is an array.

Bug: T93592
Change-Id: Ib0131c9485a903d73b770090bf8a938056782ba3
2015-04-08 20:51:20 +00:00
Roan Kattouw 25c718bc96 Explicitly pass oldid to ApiParse after saving
If we don't explicitly pass the revid of the new revision we
just created, ApiParse will be lazy and get the latest revid
from the slave DB, which will probably be out of date.

Bug: T95466
Bug: T94367
Change-Id: I2149c7a710075eff9292d0c25ca40d10b325ad44
2015-04-08 13:48:30 -07:00
jenkins-bot 685e7ffacb Merge "Adding minimum width and height to MWAlienExtensionNodes" 2015-04-08 17:17:42 +00:00
Ritsyy d67543745f Adding minimum width and height to MWAlienExtensionNodes
Bug: T92868
Change-Id: I9387f17e0ff1cf88283f290488ce900418ef3150
2015-04-08 18:08:00 +01:00
James D. Forrester 91a4f4ddd3 Update VE core submodule to master (24e4428)
New changes:
cee21ec Test untested branch nodes
494bc38 build: Fix rename of test-coverage to coverage in clean task
24e4428 Follow-up facbde556a: Fix showSelection fixup

Change-Id: I213cded586bcc3419b68dc3579eb8587f2d7e794
2015-04-08 13:50:53 +01:00
Ed Sanders 4379275062 Update VE core submodule to master (7058807)
New changes:
4c1a5ea [BREAKING CHANGE] Give the converter a 'fromClipboard' mode
d855043 Add core tests for annotation merging
fae083e Localisation updates from https://translatewiki.net.
11710e9 Encode and decode HTML entities in comment nodes

Local changes:
* Update getModelFromDom signature

Change-Id: Ida1b9b33d5e25e7d467ef16dd2240442270b9d32
2015-04-07 18:13:06 -07:00
jenkins-bot 8000633fee Merge "Set default size to category popup widgets" 2015-04-07 21:18:13 +00:00
Translation updater bot fc01f12be8 Localisation updates from https://translatewiki.net.
Change-Id: Iba4edca318763cde388a77fd25f7d2dd1e8e36a4
2015-04-07 22:21:15 +02:00
James D. Forrester 9e5cfab5da Update VE core submodule to master (a2b79e5)
New changes:
d54822f fixupInsertion: Don't attempt to call .getClonedElement() on the DocumentNode
2ad6afe gitignore: Update test-coverage to coverage (follows-up 04fb668)
a2b79e5 build: Run lint before build in grunt-test

Change-Id: I11dd1a7ba93207c70c489dc94b932ad9ca8a5fb1
2015-04-07 16:44:34 +01:00
jenkins-bot e8d2a657be Merge "Fix opening of specific reference dialog" 2015-04-07 15:43:46 +00:00
Ed Sanders 7d38c3023f Fix opening of specific reference dialog
Don't bypass WindowAction which does necessary things to the surface.

Bug: T95069
Change-Id: I1a3a480f000aa7500d1954cbe13787cd23f68360
2015-04-07 16:35:30 +01:00
Roan Kattouw f120d63ff4 Update VE core submodule to master (8c99a87)
New changes:
f696ef7 Don't use a inputFilter on LinkTargetInputWidget
04fb668 build: Add 'doc' entry point and move coverage to "/coverage"
b784a01 Ignore href DOM attribute when comparing links
d0b00e6 Localisation updates from https://translatewiki.net.
cbb01cf Fix typo in ve.ce.RangeState#compareSelections

Change-Id: I6d74e398334915d0094b4c2afb6ba45ec780cb68
2015-04-06 16:21:04 -07:00
Alex Monk 411a5578b5 Fix constructor name for ve.ce.MWNowikiAnnotation
Change-Id: I7d69b6f836f94a611c3fc6197035d4a793ab31d1
2015-04-06 21:47:56 +01:00
Translation updater bot 5d0c0b575e Localisation updates from https://translatewiki.net.
Change-Id: I1fe2618ebf734e83eb876ad7023ab2b15cf78478
2015-04-06 21:51:44 +02:00