Now that we use staging in the meta dialog, the following
sequence is possible:
* Add Category:Foo in UI (adds to DM and adds a widget)
* Remove Category:Foo in UI (removes from DM, removes widget)
* Click Cancel to leave meta dialog
** popStaging()
*** Undo removal of Foo (adds to DM, does not add a widget)
*** Undo addition of Foo (removes from DM, tries to remove nonexistent widget)
Add a check so trying to remove an already-removed widget
doesn't cause a JS error.
Bug: 71471
Change-Id: I34690364ce302b858e2a4429dbb97b57d39aae5f
New changes:
28ebb29 ve.ui.CommentInspector.css: Fix documentation
b3b3b11 Followup a618491: fix JS errors when slugging near annotated inline nodes
b987d63 Record and show observation times in ve.Filibuster
60ac437 ve.ui.FragmentInspector: Remove #setDimensions
9f4a067 ve.ui.CommentInspector.js: Fix documentation
0677c3b Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's
Change-Id: I1f3c9d3e81eea9d380b2e2aa5deb9fdbf0ca9c93
Just hide them when opening the editor and show again afterwards. Will
need Parsoid for proper support.
Corresponding patch in core: I2389ff9a5332a2b1d033eb75f0946e5241cfaaf4.
Bug: 23796
Change-Id: I3ce5e7869be50dcd189ca24e2b3d7ebc62de4fc4
New changes:
b9bd135 Fix getUsedStoreValues and allow a range to be passed
33f4026 Update OOjs UI to v0.1.0-pre (98e770ce46)
c78efc5 DesktopContext: Ensure that inspectors/menus are fully visible when created
1dff977 ve.ui.DesktopContext: Fix comment typo
3aafc81 Localisation updates from https://translatewiki.net.
Change-Id: Icba3f7bb3916be19832387e3ef541613a78bdda8
New changes:
4ad56e9 Be more cautious about placing the cursor
b39c9e2 Fix some getSelectionRects edge cases
cbb4197 Don't perform focus node native selection trick while dragging
817ef5f Follow-up I99acd6c6: More files' header comment fixes
d28aacb Localisation updates from https://translatewiki.net.
Change-Id: I42ba31b3428d98695c5a51d194cf972d649fef48
* Add type hints
* Use $skin->msg instead of wfMessage where available
* Minor doc fixes
* Use Title::inNamespace()
Change-Id: I406a0a40e785947fbdc09707597ccf9c50d6f9be
Fixes Icb62b9b2. I have no idea how I managed to screw this up.
Was also causing an error in console when one of the categories was a redirect
Change-Id: I0321c8be1386cb010c3babb33e08fae0fcaf75ce
This doesn't happen in real life (as resource is always set) but
it allows us to contruct these nodes from the factory with no data.
Change-Id: Iea146f5dc128ad9d0f36a79b6fe67d622767d46c
New changes:
c06fa64 Account for isValid() becoming async
12e4840 Account for WhitespacePreservingTextInputWidget#getValue being called early
Local changes:
* Make MWLinkTargetInputWidget#isValid asynchronous
Bug: 71237
Bug: 71246
Change-Id: Iab83e743f99973f01a54b23fd5ddf1081f7effd6
New changes:
8d5ec7a [BREAKING CHANGE] Rename ve.Document.getNodeFromOffset to getBranchNodeFromOffset
Local changes:
* Update calls for rename of getNodeFromOffset to getBranchNodeFromOffset
Change-Id: Ibc69f5a5deeed5698368bb19b30f14497c579e90
New changes:
78dfa9d Move deletion part of handleDelete logic to surface fragment
2f964f9 Tweak traverseUpstream documentation and code style
54dd25d Add expand method to ranges, finish unit test coverage
a0d94c0 Make newFromTranslatedRange a method (translate)
5eafb4d Tolerate null boundingRect in all code paths in DesktopContext#updateDimensions
35b1f0d Prevent page elements from displaying on top of highlights
c864eff ve.dm.Surface: Fix documentation typo
5f869bc Don't drop 1px rects for FocusableNodes if all we have is 1px rects
65c782d Update OOjs UI to v0.1.0-pre (880100c45e)
b149390 Calculate selected node on change and emit contextChange
e032cea Fix documentation in ve.Document
eaab57b [BREAKING CHANGE] Remove ve.isArray and use Array.isArray instead
Change-Id: I1367c721b285ca093ac78aee59a9e9a188ad552f
New changes:
e066826 Localisation updates from https://translatewiki.net.
dabe910 Localisation updates from https://translatewiki.net.
3fc0e0a SurfaceObserver should observe the surface
d86d4df Update OOjs UI to v0.1.0-pre (bab8befc94)
563666a Converter: Allow Nodes to return empty arrays if they want not to be output
Change-Id: Iba784d8278609e3c1f95eafd595528e8097be8ff
Allow for an auto-value for parameters in TemplateData, and make sure
this autovalue is inserted as text when parameter is loaded. This is
mostly useful for referencing date or other dynamic templates inside
parameters.
Bug: 52029
Change-Id: I6203530798ffaa62cb26190c70f7ce391bddf123
New changes:
65d4858 README: Add devDependencies badge
4d88b3a Replace boolean checks of getSlugAtOffset with hasSlugAtOffset
b0edb58 Add getNativeRange method with optional DM range argument
f59bb20 Separate computation of highlights from rendering
4face58 Remove getSelection*Client* methods
c94234a Rename inlineRects to startAndEndRects everywhere
69c42c2 Allow specification of range when getting selection rectangles
7883250 Provide a method to get all the rectangles for a given selection
c346ebd Work around Chrome's Range.getClientRects bug
Change-Id: Idb695a64353177e5e5210bae3c4202e701f4d95e
New changes:
925ed5c Move sluggability methods to model
a618491 Calculate slug positions in the model
b8fb05e Make the trigger demo kind of work again
e41d22e Update OOjs UI to v0.1.0-pre (ec785c2c64)
4119470 build: Make headers atop dist files suitable for distribution
fca4fec Follow-up cc657c4: Change strikethrough key command to not clash with Macs
a29a561 Add hasSlugAtOffset to DM document
9f47efb Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model
aa35e96 Remove hard coded types from canHaveSlugBefore and fix logic
49a239b Emit 'position' and 'contextChange' events correctly
3c50321 Refactor out finding of CE focusedNodes
d6904b5 Update OOjs UI to v0.1.0-pre (f2c3f12959)
Local changes:
* Move ce.Document tests to dm.Document
Change-Id: Ifa5abd0341e858b20e73e9071d597a25112cadfb