Commit graph

8313 commits

Author SHA1 Message Date
Roan Kattouw ff587f4f61 Account for categories being removed twice in MWCategoryWidget
Now that we use staging in the meta dialog, the following
sequence is possible:
* Add Category:Foo in UI (adds to DM and adds a widget)
* Remove Category:Foo in UI (removes from DM, removes widget)
* Click Cancel to leave meta dialog
** popStaging()
*** Undo removal of Foo (adds to DM, does not add a widget)
*** Undo addition of Foo (removes from DM, tries to remove nonexistent widget)

Add a check so trying to remove an already-removed widget
doesn't cause a JS error.

Bug: 71471
Change-Id: I34690364ce302b858e2a4429dbb97b57d39aae5f
2014-09-30 11:11:09 -07:00
James D. Forrester 9127e80bcf Update VE core submodule to master (0677c3b)
New changes:
28ebb29 ve.ui.CommentInspector.css: Fix documentation
b3b3b11 Followup a618491: fix JS errors when slugging near annotated inline nodes
b987d63 Record and show observation times in ve.Filibuster
60ac437 ve.ui.FragmentInspector: Remove #setDimensions
9f4a067 ve.ui.CommentInspector.js: Fix documentation
0677c3b Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's

Change-Id: I1f3c9d3e81eea9d380b2e2aa5deb9fdbf0ca9c93
2014-09-30 07:58:26 -07:00
jenkins-bot c8a408e8ce Merge "mw.LinkCache: Clean up" 2014-09-29 23:36:03 +00:00
Timo Tijhof 94c2c6c745 mw.LinkCache: Clean up
Pompidom.

Change-Id: Ia4e05d62845a7bce685cc9926101a238fe4bbce9
2014-09-29 16:33:46 -07:00
Translation updater bot 7641160262 Localisation updates from https://translatewiki.net.
Change-Id: I4b8568e0a5b626327722b45d69b5150e315389c8
2014-09-29 23:34:08 +02:00
jenkins-bot ff9e5ee191 Merge "Add rudimentary support for page status indicators" 2014-09-29 17:56:31 +00:00
jenkins-bot cd1496f81f Merge "Update VE core submodule to master (3aafc81)" 2014-09-29 17:42:44 +00:00
Bartosz Dziewoński c81ed82fa8 Add rudimentary support for page status indicators
Just hide them when opening the editor and show again afterwards. Will
need Parsoid for proper support.

Corresponding patch in core: I2389ff9a5332a2b1d033eb75f0946e5241cfaaf4.

Bug: 23796
Change-Id: I3ce5e7869be50dcd189ca24e2b3d7ebc62de4fc4
2014-09-29 13:45:10 +02:00
Translation updater bot 8146fe213c Localisation updates from https://translatewiki.net.
Change-Id: Ieb47c49b357469adb62593088d99d48e37333a32
2014-09-28 22:37:03 +02:00
James D. Forrester 55a35e9011 Update VE core submodule to master (3aafc81)
New changes:
b9bd135 Fix getUsedStoreValues and allow a range to be passed
33f4026 Update OOjs UI to v0.1.0-pre (98e770ce46)
c78efc5 DesktopContext: Ensure that inspectors/menus are fully visible when created
1dff977 ve.ui.DesktopContext: Fix comment typo
3aafc81 Localisation updates from https://translatewiki.net.

Change-Id: Icba3f7bb3916be19832387e3ef541613a78bdda8
2014-09-27 21:30:02 -04:00
Translation updater bot 00dfc45919 Localisation updates from https://translatewiki.net.
Change-Id: I6900022d921e939a0d8c887f45785ac288deea15
2014-09-27 20:32:43 +02:00
James D. Forrester 5ed0f35e11 Move IE10 to the greylist too
Also add a test for IE11 being on the greylist.

Change-Id: I45f1b9f00320237597fa1974932c04102328f0b6
2014-09-26 12:56:04 -07:00
Vikas S Yaligar 9a5caf8dd2 [BrowserTest] Fixed failing language screenshot scenarios
Bug: 71298
Change-Id: Ifcd52935e782e292f9289a72d5e7c4ad12921b4b
2014-09-26 17:49:24 +00:00
jenkins-bot 7c1c8cfe2e Merge "Remove test for functionality tested in core" 2014-09-26 02:51:33 +00:00
jenkins-bot 64b2568465 Merge "Use mw.Title#getRelativeText to deal with titles relative to specific namespaces" 2014-09-26 02:50:43 +00:00
Alex Monk ef1cebd111 Use mw.Title#getRelativeText to deal with titles relative to specific namespaces
Added in MW core in Ie554adef, was backported to 1.24.

Change-Id: Iedc0319042529d41d29846d1734b5481850e9552
2014-09-26 02:47:18 +00:00
jenkins-bot cad82852c0 Merge "Update VE core submodule to master (6012dc5)" 2014-09-25 22:52:23 +00:00
jenkins-bot 3d0aae0dcd Merge "Stop "Edit pages on double click" from affecting VE" 2014-09-25 22:52:19 +00:00
James D. Forrester 9772524748 Update VE core submodule to master (6012dc5)
New changes:
4ad56e9 Be more cautious about placing the cursor
b39c9e2 Fix some getSelectionRects edge cases
cbb4197 Don't perform focus node native selection trick while dragging
817ef5f Follow-up I99acd6c6: More files' header comment fixes
d28aacb Localisation updates from https://translatewiki.net.

Change-Id: I42ba31b3428d98695c5a51d194cf972d649fef48
2014-09-25 15:48:00 -07:00
jenkins-bot 5e92ee61e0 Merge "Prevent exception throwing in getFilename of MWImageNode" 2014-09-25 21:50:43 +00:00
jenkins-bot ab7c72e0fd Merge "Clean up various PHP hook functions" 2014-09-25 21:31:53 +00:00
Translation updater bot dbc976927b Localisation updates from https://translatewiki.net.
Change-Id: I9f63163e0ad6c10f13d2aa5347aed1ec556c7df3
2014-09-25 23:08:13 +02:00
Alex Monk 77fc7e7d6c Stop "Edit pages on double click" from affecting VE
Relies on I0f6225b2

Bug: 53058
Change-Id: Ibd363dfb9da7d91055c541a83969d23401297603
2014-09-25 21:19:18 +01:00
Željko Filipin ac804a537a [BrowserTest] Disable screenshots for broken scenarios
Workaround for bug 71298.

Change-Id: I23ed22f8859a09821b6ef5edac8eff4ca0f3b17c
Paired-with: Amir Aharoni
Bug: 71298
2014-09-25 15:18:47 +02:00
Kunal Mehta 1470d7cf39 Clean up various PHP hook functions
* Add type hints
* Use $skin->msg instead of wfMessage where available
* Minor doc fixes
* Use Title::inNamespace()

Change-Id: I406a0a40e785947fbdc09707597ccf9c50d6f9be
2014-09-24 22:11:47 -07:00
jenkins-bot 5dcd099862 Merge "Really fix CategoryWidget checks for redirects to hidden categories this time" 2014-09-24 22:50:32 +00:00
Alex Monk 89f8334d58 Really fix CategoryWidget checks for redirects to hidden categories this time
Previous commit dealt with only part of a related problem.

Change-Id: Iffe319d5b6d1a5ea91acca26a9613e07bea0d8fe
2014-09-24 23:18:44 +01:00
jenkins-bot a6557cb051 Merge "Unbreak category widget check for hidden pages" 2014-09-24 22:08:33 +00:00
Alex Monk ea9ce0f5b0 Unbreak category widget check for hidden pages
Fixes Icb62b9b2. I have no idea how I managed to screw this up.
Was also causing an error in console when one of the categories was a redirect

Change-Id: I0321c8be1386cb010c3babb33e08fae0fcaf75ce
2014-09-24 22:59:53 +01:00
Translation updater bot 421bcc506e Localisation updates from https://translatewiki.net.
Change-Id: I6356e966774626f830769f4e546b4859ce98ae21
2014-09-24 22:21:13 +02:00
Ed Sanders 26751dc4a1 Prevent exception throwing in getFilename of MWImageNode
This doesn't happen in real life (as resource is always set) but
it allows us to contruct these nodes from the factory with no data.

Change-Id: Iea146f5dc128ad9d0f36a79b6fe67d622767d46c
2014-09-24 20:43:57 +01:00
Roan Kattouw 6347274f47 Update VE core submodule to master (6e68242)
New changes:
c06fa64 Account for isValid() becoming async
12e4840 Account for WhitespacePreservingTextInputWidget#getValue being called early

Local changes:
* Make MWLinkTargetInputWidget#isValid asynchronous

Bug: 71237
Bug: 71246
Change-Id: Iab83e743f99973f01a54b23fd5ddf1081f7effd6
2014-09-24 12:18:16 -07:00
Roan Kattouw 8517777b9f Update VE core submodule to master (8d5ec7a)
New changes:
8d5ec7a [BREAKING CHANGE] Rename ve.Document.getNodeFromOffset to getBranchNodeFromOffset

Local changes:
* Update calls for rename of getNodeFromOffset to getBranchNodeFromOffset

Change-Id: Ibc69f5a5deeed5698368bb19b30f14497c579e90
2014-09-24 11:34:14 -07:00
Roan Kattouw 679b880ce7 Update VE core submodule to master (9e69dba)
New changes:
78dfa9d Move deletion part of handleDelete logic to surface fragment
2f964f9 Tweak traverseUpstream documentation and code style
54dd25d Add expand method to ranges, finish unit test coverage
a0d94c0 Make newFromTranslatedRange a method (translate)
5eafb4d Tolerate null boundingRect in all code paths in DesktopContext#updateDimensions
35b1f0d Prevent page elements from displaying on top of highlights
c864eff ve.dm.Surface: Fix documentation typo
5f869bc Don't drop 1px rects for FocusableNodes if all we have is 1px rects
65c782d Update OOjs UI to v0.1.0-pre (880100c45e)
b149390 Calculate selected node on change and emit contextChange
e032cea Fix documentation in ve.Document
eaab57b [BREAKING CHANGE] Remove ve.isArray and use Array.isArray instead

Change-Id: I1367c721b285ca093ac78aee59a9e9a188ad552f
2014-09-24 11:10:25 -07:00
jenkins-bot f67989eaa5 Merge "Replace use of ve.isArray with native Array.isArray" 2014-09-24 03:05:57 +00:00
jenkins-bot 02a85676b9 Merge "Use LinkCache instead of an object in MWCategoryWidget to store hidden status (to be shared with the input widget)" 2014-09-24 01:06:38 +00:00
Timo Tijhof 66de06b0fa Replace use of ve.isArray with native Array.isArray
Change-Id: Ibc45e0fd80db7da872f6ef934cef915be9366e06
2014-09-23 17:58:09 -07:00
Alex Monk 93e4c59e4f Use LinkCache instead of an object in MWCategoryWidget to store hidden status (to be shared with the input widget)
Change-Id: Icb62b9b27ea1d61097d059fa268cc4834d46fc9f
2014-09-23 23:56:27 +01:00
jenkins-bot a5d8b636eb Merge "ve.ui.MWLiveExtensionInspector: Fix comment typo" 2014-09-23 21:57:31 +00:00
Bartosz Dziewoński 5849e7b8f8 ve.ui.MWLiveExtensionInspector: Fix comment typo
Change-Id: I6e35a5006364ba44de2804e6cd6cd79d6b73c0c3
2014-09-23 23:54:33 +02:00
Translation updater bot 625669f12b Localisation updates from https://translatewiki.net.
Change-Id: I55f61f07576931a694a9686495d899761f4a32fb
2014-09-23 22:04:58 +02:00
James D. Forrester 52a69e24f1 Update VE core submodule to master (563666a)
New changes:
e066826 Localisation updates from https://translatewiki.net.
dabe910 Localisation updates from https://translatewiki.net.
3fc0e0a SurfaceObserver should observe the surface
d86d4df Update OOjs UI to v0.1.0-pre (bab8befc94)
563666a Converter: Allow Nodes to return empty arrays if they want not to be output

Change-Id: Iba784d8278609e3c1f95eafd595528e8097be8ff
2014-09-23 11:32:56 -07:00
Translation updater bot c1d2851241 Localisation updates from https://translatewiki.net.
Change-Id: I3b09d38f6b8ab3652c0338acbdc34319b848e643
2014-09-22 21:50:45 +02:00
Translation updater bot ab3474f032 Localisation updates from https://translatewiki.net.
Change-Id: I80bb743ce8f0dd0e29ee3518e42841de7ea18cd6
2014-09-21 22:01:15 +02:00
Translation updater bot ba97a1ac6e Localisation updates from https://translatewiki.net.
Change-Id: Ief48d85ab343584bf2b230894a7b5c1f67c83a3a
2014-09-20 21:44:23 +02:00
Seb35 8029ffb16b Check the existence of BetaFeatures before adding the 'visualeditor-enable' preference
To avoid adding it two times.

Bug: 71088
Change-Id: I687b2344731188133d32faac48e36245e9b03e76
2014-09-20 20:05:42 +02:00
Moriel Schottlender f4dc6fd240 Add 'autovalue' to TemplateData
Allow for an auto-value for parameters in TemplateData, and make sure
this autovalue is inserted as text when parameter is loaded. This is
mostly useful for referencing date or other dynamic templates inside
parameters.

Bug: 52029
Change-Id: I6203530798ffaa62cb26190c70f7ce391bddf123
2014-09-20 00:52:23 +00:00
Translation updater bot e88150cc05 Localisation updates from https://translatewiki.net.
Change-Id: Icb41461e1f20dc79e5f6fee637c7fadd319a79b0
2014-09-19 22:07:38 +02:00
James D. Forrester 889d8e6d5f Update VE core submodule to master (90bb24f)
New changes:
65d4858 README: Add devDependencies badge
4d88b3a Replace boolean checks of getSlugAtOffset with hasSlugAtOffset
b0edb58 Add getNativeRange method with optional DM range argument
f59bb20 Separate computation of highlights from rendering
4face58 Remove getSelection*Client* methods
c94234a Rename inlineRects to startAndEndRects everywhere
69c42c2 Allow specification of range when getting selection rectangles
7883250 Provide a method to get all the rectangles for a given selection
c346ebd Work around Chrome's Range.getClientRects bug

Change-Id: Idb695a64353177e5e5210bae3c4202e701f4d95e
2014-09-18 17:49:40 -07:00
Roan Kattouw 34ec304ec7 Update VE core submodule to master (d6904b5)
New changes:
925ed5c Move sluggability methods to model
a618491 Calculate slug positions in the model
b8fb05e Make the trigger demo kind of work again
e41d22e Update OOjs UI to v0.1.0-pre (ec785c2c64)
4119470 build: Make headers atop dist files suitable for distribution
fca4fec Follow-up cc657c4: Change strikethrough key command to not clash with Macs
a29a561 Add hasSlugAtOffset to DM document
9f47efb Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model
aa35e96 Remove hard coded types from canHaveSlugBefore and fix logic
49a239b Emit 'position' and 'contextChange' events correctly
3c50321 Refactor out finding of CE focusedNodes
d6904b5 Update OOjs UI to v0.1.0-pre (f2c3f12959)

Local changes:
* Move ce.Document tests to dm.Document

Change-Id: Ifa5abd0341e858b20e73e9071d597a25112cadfb
2014-09-18 17:03:46 -07:00