Commit graph

9107 commits

Author SHA1 Message Date
Moriel Schottlender 3d60389ea0 Add a layout queue to media result widget
Use a queue for the method that lays out the result images in
the rows; this queue will only run if the widget is visible,
to make sure that the calculations of the masonry view work
as they should.

In better words: Only cue the queue if the widget is visible.

Bug: T86802
Change-Id: Ia8a30a6a5cccd98a1201443d672e4a6ab4aa946f
2015-01-28 18:01:47 -08:00
Moriel Schottlender e454b81f4d When changing image source, use already-available API info
When the user changes an image to another in the media dialog, we
already have API info that includes the original dimensions, media
type and other information that is required for the Scalable object
to compute the new current dimensions. We can use this info if it
exists instead of asking for another API call. Also make sure to
update the filename when we change an image in the dialog.

Bug: T87267
Change-Id: I9d86959b99b3f3dfed92255a9dba9a8fdd352dcb
2015-01-29 01:58:07 +00:00
Moriel Schottlender a44e0d2e5d Lazy load the media search results
* Set the src attribute only when the image is actually
  visible in the search results.
* Display the thumbnail image we have from the search
  results and then update with a larger one from the API.
* Request for more media results on a higher threshhold,
  when the user views 2 rows above the last available
  result.
* Correct the resizeToBoundingBox and simplify it to work
  properly for a non-square bounding box regardless of
  constraints.

Change-Id: If024b0335ce6a5d2d0eafdbfdfe1030dcaac3a75
2015-01-28 17:56:54 -08:00
jenkins-bot e9d770ed11 Merge "MWMediaDialog: Add contextual help for controls" 2015-01-28 23:42:01 +00:00
jenkins-bot a0a6937450 Merge "Use DOM methods instead of jQuery .html() in references DM code" 2015-01-28 23:38:01 +00:00
jenkins-bot f42d2ce23e Merge "Update permanent link and PDF download link oldids on save" 2015-01-28 23:33:53 +00:00
Translation updater bot 3be58aae9c Localisation updates from https://translatewiki.net.
Change-Id: I43042d50f50d6c610cd12f53e31e8bba95bf5b6f
2015-01-28 22:39:11 +01:00
Alex Monk f6bf40a19a Update permanent link and PDF download link oldids on save
Bug: T74461
Change-Id: Ic66de6e685d23cac1c9870529f42e1aa6348ac7a
2015-01-28 13:16:12 -08:00
Translation updater bot d64aa82c4a Localisation updates from https://translatewiki.net.
Change-Id: I1df981d0ac9a4eadf6bcdb81f3c0b50f10e61e43
2015-01-27 22:17:10 +01:00
Amir E. Aharoni c80e311a02 [BrowserTest] Fix VisualEditor toolbar actions scenario
The save button changed from constructive (green) to progressive (blue).

Change-Id: Ic410d5ed3847da803d6d83df7f77b6e0edc5d81b
2015-01-27 04:15:51 +00:00
Amir E. Aharoni 896c8b5d5f [BrowserTest] Change "Headings interface" to "Headings menu"
Change-Id: I8a50bdf1c49d80ec89c1d87d2a4e353f0aa1a3f9
2015-01-27 04:15:43 +00:00
Amir E. Aharoni 5b0e34fa4a [BrowserTest] Clean up the 'I am editing' scenario in language screenshots
Change-Id: Ieecbad486e4b0d2256452c66493ae3cec1643658
2015-01-27 04:15:20 +00:00
Amir E. Aharoni a58e2c31d2 [BrowserTest] Update Ruby gems
Change-Id: Icac23b024e75559dc25466895e6030f77b7340a6
2015-01-26 23:42:42 +00:00
jenkins-bot 7dee4f18d7 Merge "Don't rely on 'user' and 'site' modules working correctly" 2015-01-26 22:31:28 +00:00
Roan Kattouw a10fe01f8b Use DOM methods instead of jQuery .html() in references DM code
Bug: T87417
Change-Id: I40df6258cd076911c68351300a488645db1d65d5
2015-01-26 14:06:56 -08:00
Translation updater bot f89fcadaa4 Localisation updates from https://translatewiki.net.
Change-Id: Iccd7bb8e1b399f4632ebe17c1f108b0864acdab0
2015-01-26 22:43:13 +01:00
James D. Forrester 9f574bc96b Update VE core submodule to master (e56f537)
New changes:
3122891 Add keyboard commands for find next/replace
6b2969c Localisation updates from https://translatewiki.net.
65c1419 Fix resizeable CSS layers
6fc57d4 Don't use .hide() in ve.ui.Context constructor
7bbfc4e Re-implement ve.ce.ResizableNode#showHandles using CSS
3e004f6 Localisation updates from https://translatewiki.net.
a926617 ce.GeneratedContentNode: Import DOM elements into target document early

Change-Id: I45ce461da1a650c75e5bc1a24b4c38fafe456f9e
2015-01-26 10:38:02 -08:00
Roan Kattouw 6623ff4197 Use DOM rather than jQuery for <base> resolution
Avoiding a Sizzle context switch, see https://github.com/jquery/sizzle/issues/311

Bug: T87416
Change-Id: I40dd2cb17f9c3d14d0ee1aa5b542263775feedb7
2015-01-26 10:00:32 -08:00
Roan Kattouw 711c509f81 dm.MWBlockImageNode: Use DOM methods rather than jQuery
To avoid triggering state thrashing in Sizzle
( https://github.com/jquery/sizzle/issues/311 )

Also account for the fact that missing attributes are returned
as undefined by jQuery but null by .getAttribute().

Bug: T87416
Change-Id: Ib3bc7971920c084568abb6ea0bd822d763b276f2
2015-01-26 09:46:55 -08:00
jenkins-bot fd6a2c0f74 Merge "ce.MWReferencesListNode: Remove unnecessary .show() call" 2015-01-26 06:30:55 +00:00
Translation updater bot 2eaf4bc7f1 Localisation updates from https://translatewiki.net.
Change-Id: I7d4da590bc19bc83e64b99a31ee5762c28bb1180
2015-01-25 21:52:03 +01:00
jenkins-bot e49a75a6cf Merge "Focus the add template input in the template dialog" 2015-01-24 03:24:43 +00:00
Moriel Schottlender 34f93bef08 Focus the add template input in the template dialog
Focus the page in the booklet layout so the add template
input is also focused at the opening of the template dialog.

Bug: T85484
Change-Id: Id9ae4653dc2a2e1d1dc16c83c540e22e30f4ea55
2015-01-23 17:55:26 -08:00
Roan Kattouw 154d2cb118 ce.MWReferencesListNode: Remove unnecessary .show() call
ce.InternalItem used to .hide() its .$element, but it doesn't
do this any more, so we don't need to counteract this with
.show() any more either.

Bug: T87160
Change-Id: Ic367508d821cc5c65678d4c878edc84911fd8178
2015-01-23 15:08:50 -08:00
Translation updater bot fb6eba3028 Localisation updates from https://translatewiki.net.
Change-Id: Iec49a3b85c54c8bf208e663887504243fe5a4e26
2015-01-23 22:31:26 +01:00
James D. Forrester 80e930ac98 Update VE core submodule to master (8b83816)
New changes:
751a65c Localisation updates from https://translatewiki.net.
77047b6 Localisation updates from https://translatewiki.net.
82679b9 Kill grey border on find-and-replace dialog in MediaWiki theme
15ae875 Localisation updates from https://translatewiki.net.
a279340 Localisation updates from https://translatewiki.net.
8b83816 Update OOjs to v1.1.4

Change-Id: Ibafcd3e47e445a3509122bdaea3b678ee226e0fa
2015-01-23 12:36:21 -08:00
Moriel Schottlender d0f1a02aec Increase the space between the title and text in media dialog
Make the spacing between the image title and the description
the same as the space between the description and the metadata.

Bug: T87451
Change-Id: I0d0051cd66072861019b904980c405fa05145b2b
2015-01-23 12:19:51 -08:00
Alex Monk 34e4c6a51b Check for venotify on page load, not when VPT is created
Not sure what could have broken this or when. Or if it ever worked to be honest...

Bug: T58921
Change-Id: I069b5ccb4a78a6790e5791354402503676faa7fa
2015-01-22 23:50:02 +00:00
Translation updater bot c9f6bfbbfa Localisation updates from https://translatewiki.net.
Change-Id: I7f7750931f23b1b569a6926f863ce18c90f8d81a
2015-01-22 23:24:06 +01:00
James D. Forrester d8f342a640 MWMediaDialog: Add contextual help for controls
Bug: T53798
Bug: T75731
Change-Id: Ideae0052c366a8c4e03285270569e5c5ca608ad8
2015-01-20 15:53:31 -08:00
Translation updater bot c6f3da6d46 Localisation updates from https://translatewiki.net.
Change-Id: I3a7f7e1e0130bffe5ac246cb1e52926a38ee0c51
2015-01-20 22:01:56 +01:00
jenkins-bot d7c80d4cf2 Merge "MWMediaDialog: Make the dialog bigger when searching for media to insert" 2015-01-20 19:52:11 +00:00
jenkins-bot 9db4e1ffd9 Merge "Don't load OOjs UI i18n strings as core does this already" 2015-01-20 16:54:31 +00:00
jenkins-bot dc7248031d Merge "Don't add __STATICREDIRECT__ whenever the user sets up redirect details" 2015-01-20 01:09:52 +00:00
Alex Monk d94c25a5b1 Don't add __STATICREDIRECT__ whenever the user sets up redirect details
OO.ui.CheckboxInputWidget#getValue was returning strings "true" or "false"
We want to use isSelected (and setSelected to set things instead of setValue,
I guess.)

Bug: T86827
Change-Id: I0b4b8dca00a4aeae4498a30d73e5eaa7c804115f
2015-01-19 23:32:55 +00:00
Alex Monk f0f2912c9d Actually perform interwiki check in MWLinkTargetInputWidget
Fixes my idiocy in I4b08f1c6

Bug: T72504
Change-Id: I1a7f14fc7f7169ac85eacd4e12a56acff1fe32ae
2015-01-19 22:49:38 +00:00
Translation updater bot e2d953449b Localisation updates from https://translatewiki.net.
Change-Id: Ief7e3f530425a52b78da8099bab104bafc86808d
2015-01-19 22:05:44 +01:00
Translation updater bot 037d49c4ac Localisation updates from https://translatewiki.net.
Change-Id: I1d27554446b015c5192ff7295dd82f0fc7d19b40
2015-01-18 22:23:12 +01:00
James D. Forrester 6730d48d2b Update VE core submodule to master (916d1b9)
New changes:
28d2c33 Localisation updates from https://translatewiki.net.
916d1b9 Unwrap slug wrappers when converting to a real paragraph

Change-Id: Ib517646da3dfd238267e7723c7ae6113246316fa
2015-01-16 18:09:12 -08:00
jenkins-bot f7c41fe181 Merge "Revert "Temporarily disable JSON content type on visualeditor-cite-tool-definition.json"" 2015-01-17 01:00:57 +00:00
James D. Forrester 7daf17fadc MWMediaDialog: Make the dialog bigger when searching for media to insert
Bug: T86397
Change-Id: I40e78441dd555dff837516220653b1c54bf5af92
2015-01-16 16:29:26 -08:00
James D. Forrester 9625bd2c99 MWSaveDialog: Make the diff screen a larger rather than large size
Bug: T78823
Change-Id: If14acbeb8449e27e692bc52556c1d31305b4c54a
2015-01-16 16:04:05 -08:00
Jforrester a1293e5161 Revert "Temporarily disable JSON content type on visualeditor-cite-tool-definition.json"
This reverts commit 74a3933572.

Now that the issue is fixed in MW-core, this is not longer needed.

Change-Id: I4d3468a5abfed9299ba180342e1a8d904d06e723
2015-01-16 22:04:10 +00:00
Translation updater bot e9e44ac3b8 Localisation updates from https://translatewiki.net.
Change-Id: I436fb1af5eeddbeb5212134bb1551731971c8f16
2015-01-16 21:22:10 +01:00
jenkins-bot f82b486e74 Merge "Mark interwiki links as known in LinkTargetInputWidget" 2015-01-16 19:18:47 +00:00
Moriel Schottlender 061925be87 Add filename to the media dialog
Show the currently used filename at the top of the media dialog so
it can be copied and used in other pages if needed.

Bug: T54459
Change-Id: Ib1844c997189f7ead0656c5a811d3cab70030f89
2015-01-16 17:40:40 +00:00
Ed Sanders e3284dd078 Tweak margins on media info page
Change-Id: I5434c3ade332de22f6b6cf058dc2f1e402524959
2015-01-16 13:34:25 +00:00
jenkins-bot 2ebdf34c29 Merge "Transform the search widget to show image details" 2015-01-16 13:26:25 +00:00
Moriel Schottlender 4947420650 Transform the search widget to show image details
Add an info panel to the MediaDialog to show the user information
about the chosen file from the new extmetadata API.

Also, change the way results are viewed:
* Present the search results with their proper ratio.
* Use masonry fit for the search results.
* Change the resizeToBoundingBox method in ve.dm.MWImageNode to accept
  a specific side constraint, either 'width' or 'height'. This is also
  going to be useful for adding and calculating 'scale' considerations
  that affects the image height.
* Add info panel with details from extmetadata including author, license,
  date of upload and creation, etc.
* Get descriptions and data according to wiki language.

Bug: T78161
Bug: T74061
Change-Id: I7b4d019825aa89dd178665bd9492a07af15954ac
2015-01-16 13:22:54 +00:00
jenkins-bot 0e11587d52 Merge "Temporarily disable JSON content type on visualeditor-cite-tool-definition.json" 2015-01-16 03:34:32 +00:00