Commit graph

8053 commits

Author SHA1 Message Date
Roan Kattouw fbd7923741 Make MWMediaDialog not crash on API errors
resp.query won't be set if resp.error is set instead.

Also rename alignButons to alignButtons.

Change-Id: Ie69fe1ddae393ee02b44e9288a35e0dd47d17e4e
2014-08-16 00:30:16 -07:00
jenkins-bot 14e4a915d7 Merge "Use Config instead of globals" 2014-08-15 22:55:02 +00:00
Kunal Mehta 5575bed67c Use Config instead of globals
Change-Id: Iecf6358fcd15fe578b3e0dcdfa6022e0a1a763c8
2014-08-15 15:50:26 -07:00
Roan Kattouw 924e3c026d Update VE core submodule to master (03975f8)
New changes:
a28e085 Restore QUnit web UI
8e2477c [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib
26adfaf Fix path prefix for tests/index.html so it actually runs
d87dab5 Work around getSystemPlatform() race condition
6682ebc Make getParsedMessage() test actually test getParsedMessage()

Local changes:
* Update paths from lib/ve/modules/ve to lib/ve/src or lib/ve/tests
* Update paths from lib/ve/modules/unicodejs to lib/ve/lib/unicodesjs
* Rename unicodejs.wordbreak module to unicodejs
* Update code for getSystemPlatform() and isInternetExplorer()
  being made static

Change-Id: I7bb3bb74addfd3fbb64795c5ac3ff791b8874a4f
2014-08-15 14:42:08 -07:00
Ed Sanders 03231e5a1c Fix teardown of live extension nodes
* Separate teardown into (insertOrUpdate|remove)Node
* Override insertOrUpdate completely to avoid generating
  extra transactions. Surface#applyStaging creates all the
  transactions we need.
* Override remove to popStaging before calling parent.
* Fix isEmpty check to use getInnerValue (ignoring whitepsace)

Change-Id: I903302af178d6f923de00aff9c58e5330d682813
2014-08-15 17:40:25 +01:00
Translation updater bot 9fcece72d1 Localisation updates from https://translatewiki.net.
Change-Id: I10b1d8a872bd9071314f19f9420ceee8107a0a15
2014-08-14 23:41:24 +02:00
James D. Forrester 9b27df0de9 Update VE core submodule to master (ce51e22)
New changes:
2075a46 Embed CSS images in dist
9e15b04 Localisation updates from https://translatewiki.net.
ce51e22 Make sure image attribute is cleared if set to null

Change-Id: I8edefe662d5d3c88abef242fdaf4d45644a130b1
2014-08-14 12:48:10 +01:00
jenkins-bot 3d475420cb Merge "Update VE core submodule to master (8e56dd5)" 2014-08-14 11:34:49 +00:00
jenkins-bot afd32fb267 Merge ""Fix" hack in ve.test.utils to prevent immediate surface setup" 2014-08-14 11:34:35 +00:00
Translation updater bot 1434b450fe Localisation updates from https://translatewiki.net.
Change-Id: I2eb25beb67927d74d8fcd7da60d0ea31a74ec152
2014-08-13 23:07:48 +02:00
jenkins-bot e3e53bb5b6 Merge "Fix use of visualeditor-mweditmodesource-title instead of …-tool" 2014-08-13 19:46:16 +00:00
jenkins-bot 15efa202a2 Merge "Update token handling for MediaWiki API change" 2014-08-13 19:45:34 +00:00
Roan Kattouw 7eee4604f7 Update VE core submodule to master (8e56dd5)
New changes:
36705e9 Replace setModulesPath with addMessagePath

Change-Id: I7b95d1f10bf2d131343613bc5e6bc334d3ad40d0
2014-08-13 12:37:53 -07:00
Roan Kattouw e72f804565 "Fix" hack in ve.test.utils to prevent immediate surface setup
This used to work because loading i18n files took time. However,
we now don't register any message paths with the platform, so
platform initialization is now synchronous, which breaks the hack.

Instead, explicitly assign an unresolved deferred to the platform's
initialization promise, and resolve it after the mw.Target has been
constructed.

*barf*

Change-Id: I287cb86ce8c4c534fd723532f34463359a8ccc7c
2014-08-13 12:37:31 -07:00
jenkins-bot cda1ee5402 Merge "Remove unused modules URL" 2014-08-13 17:13:08 +00:00
jenkins-bot b6800003c4 Merge "Remove unused globals, add some type-hinting" 2014-08-13 16:43:55 +00:00
jenkins-bot 81360d0be3 Merge "Don't use RequestContext::getMain() if a context is available" 2014-08-13 16:35:58 +00:00
jenkins-bot 9b2383589f Merge "Rename MWLinkInspector → MWLinkAnnotationInspector to match file name" 2014-08-13 16:29:53 +00:00
Eloquence 3fb6e72263 Change label in dialog: "Change image" -> "Choose a different image"
The media dialog has an "Apply changes" primary action and a "Change image"
secondary action. These two labels are confusingly similar. "Choose a
different image" is a long label, but even on mobile a longer label
should fit nicely in this context, and this seems to me to avoid the
issue of ambiguity.

Change-Id: Id8be8b4cf70f7eee689b72d88b0aeac20c2eca93
2014-08-13 16:20:58 +00:00
Bartosz Dziewoński ede9dfcbb1 Rename MWLinkInspector → MWLinkAnnotationInspector to match file name
There is a MWLinkNodeInspector too, renaming the class instead of the
file to avoid name confusion.

Change-Id: Idaa26503ecd9b0fd0903937bb209397672138054
2014-08-13 16:20:15 +00:00
Brad Jorsch 6dd98b5f3b Update token handling for MediaWiki API change
MediaWiki change I2793a3f2 changes API handling in a way that needs
updates to extensions for proper operation:
* needsToken() now returns a string
* Most custom token types are being replaced with a 'csrf' token (the
  former 'edit' token); any others need a new hook.
* All tokens must use a static salt. Compat with web UI using non-static
  tokens is supported and also serves to handle the now-deprecated token
  fetching.
* Documentation in getParamDescription() should return a string (not
  array) for 'token', as the signal to core that it should be replaced
  with a standardized message.

When compatibility with earlier versions of MediaWiki is no longer
maintained, the entry for 'token' from getAllowedParams() and
getParamDescription() may be removed, as may getTokenSalt(). This patch
leaves them in place.

Note this is intended to be compatible with earlier versions of
MediaWiki, and so should be safe to merge before the core change.

Change-Id: Ia6e512aae366996de4e73a8d7f4f03fcddd77286
2014-08-13 16:19:42 +00:00
James D. Forrester af3ab5997d Fix use of visualeditor-mweditmodesource-title instead of …-tool
Bug: 69203
Change-Id: Ib3d84f7ddffa3a9d0c21393d92a29ebf8bf1eef5
2014-08-13 16:19:31 +00:00
jenkins-bot 0edc2a09c2 Merge "[BrowserTest] Language screenshot job should run specific scenarios" 2014-08-13 15:08:28 +00:00
jenkins-bot 41bb9bb2d3 Merge "Remove messages defined in core" 2014-08-13 14:46:50 +00:00
Vikas S Yaligar 438f0a0fcc [BrowserTest] Language screenshot job should run specific scenarios
Change-Id: Ia8ab136018b434b4d53db06f8c91af95e3ef8474
2014-08-13 14:15:03 +00:00
Vikas S Yaligar d39f014058 [BrowserTest] Added browser tests for formula, reference list and save button
Change-Id: I96a7dfd09336ae919775f7d0234dd9c11ce93268
2014-08-13 13:39:10 +00:00
Ed Sanders 797f764ca4 Remove messages defined in core
Depends on Ia1c2ca2 in core.

Change-Id: I2d6aeb7f41e445c7b400187220f113aacd0a3bf2
2014-08-13 13:00:49 +00:00
Kunal Mehta 58aabdcc7f Remove unused globals, add some type-hinting
Change-Id: I9d257c6b149b0734a5b7ae312b16f109534923d3
2014-08-12 22:57:21 -07:00
Kunal Mehta 4b1a3eb059 Don't use RequestContext::getMain() if a context is available
Change-Id: I2b16cf8f437ccda7cb0feb137710394e4a90d3b5
2014-08-12 22:54:51 -07:00
Ed Sanders 7c923c2044 Remove unused modules URL
Change-Id: I1e66866388ee862bc122faacebbd5f3883bd90f8
2014-08-12 23:54:30 +00:00
jenkins-bot 3b277a7a28 Merge "Fix bad jquery 'append' calls" 2014-08-12 22:58:54 +00:00
Moriel Schottlender c4c5add175 Fix bad jquery 'append' calls
There are several incorrect usages of jquery .append() method that
uses an array instead of an argument list. This isn't the proper use
of the method and while it does work now, according to Krinkle,
this might stop working in the near future.

Also see I76decb67db086bb387 for the same fix in ve-core.

Change-Id: I78a0d54ad76ab5401bc0532e636a9aaa2c0c0e04
2014-08-12 22:57:11 +00:00
Roan Kattouw bea40f6a93 Update VE core submodule to master (f443f90)
New changes:
c23d345 Localisation updates from https://translatewiki.net.
2662be5 Localisation updates from https://translatewiki.net.
f04910e Set selection before focusing document
31fc043 Localisation updates from https://translatewiki.net.
b4eed30 Localisation updates from https://translatewiki.net.
40016d7 Disable basic reference on mobile
e4bad2e Localisation updates from https://translatewiki.net.
e476e79 Fix `Transaction.isNoOp` test
3cfccf8 Update OOjs UI to v0.1.0-pre (0e50d2e336)
55d1d03 Add bidi isolation to language annotations
3f2a1c6 Localisation updates from https://translatewiki.net.
a399aee Actually check annotations in paste test
b3b7d67 Add missing messages from MW
c327e1f Localisation updates from https://translatewiki.net.
d52a40a Show metadata in the debug bar
d9c3b90 build: Switch from qunit directly to karma for code coverage reports
b421ac3 tests: Fix some minor issues flagged up by karma and related MW references
35f76d1 Fix bad jquery 'append' instances
7766751 Localisation updates from https://translatewiki.net.
f443f90 Followup 95ee357: make remapStoreIndexes() work again

Change-Id: I04e2ad1ecc31aefc482e81724e28271704fbfd35
2014-08-12 14:57:47 -07:00
Translation updater bot f5681d4900 Localisation updates from https://translatewiki.net.
Change-Id: I8e86d5dcaa3204893733734acf1439414656fc0f
2014-08-12 21:40:40 +02:00
Translation updater bot 306451a7bd Localisation updates from https://translatewiki.net.
Change-Id: I73db49fee0cb6504c640b2c4a7959790a8742be1
2014-08-11 23:15:23 +02:00
Translation updater bot 27e3b03781 Localisation updates from https://translatewiki.net.
Change-Id: Ia9aadb80e468d07e38c28195e9896f0d719bfeb6
2014-08-09 23:31:50 +02:00
jenkins-bot 623b59e4a5 Merge "[BrowserTest] Browser can now zoom out whenever required" 2014-08-07 08:56:49 +00:00
Vikas S Yaligar d6836f1ac5 [BrowserTest] Browser can now zoom out whenever required
Change-Id: I50c3a0a0473d487249fbf7c830cf7d9f5fc528bc
2014-08-07 14:11:42 +05:30
jenkins-bot 402a47044e Merge "[BrowserTest] Added support for highlighting the page object elements" 2014-08-06 14:01:51 +00:00
Vikas S Yaligar 69c665979f [BrowserTest] Added support for highlighting the page object elements
Sample screenshot => http://www.mediawiki.org/wiki/File:VisualEditor_Media_Insert_Menu-en.png

Change-Id: I92e204db4c3e4101bc8a88093359ce199d3dbba1
2014-08-06 13:49:55 +00:00
Amir E. Aharoni 268c8677ee Flip direction buttons in media dialog in RTL
Flip the order of the buttons in the alignment widget
so that they display the directions correctly in both
ltr and rtl.

Bug: 69165
Change-Id: I7bd1d6c89aaef09492ae07eadababd68305b245e
2014-08-06 14:09:43 +01:00
James D. Forrester 48fd057775 Kill off two references to there being a Cancel button
Change-Id: I36f13b2fffcb442c0a4b27d64d388f24c3c3766e
2014-08-06 11:11:12 +01:00
Translation updater bot fce9297b32 Localisation updates from https://translatewiki.net.
Change-Id: Icbd246229cf88a36d82361b4c8d5718e5039b03a
2014-08-05 21:59:55 +02:00
Alex Monk e74e32b5af Tear down meta dialog pages when cancelling
Currently it's only being done when applying, caused by Ia74732e6. We
need the teardown event to reach the page so they can do things like
clear categories.

Bug: 68484
Change-Id: I6c31229121c1477a55ce955354770ed7cdde470d
2014-08-05 16:24:26 +00:00
jenkins-bot 82e979ef87 Merge "Don't send API requests to preview empty (or whitespace-only) edit summaries" 2014-08-04 17:50:34 +00:00
jenkins-bot 7a60841fec Merge "Blacklist annotating link node with more links" 2014-08-03 20:47:27 +00:00
Translation updater bot b360786e97 Localisation updates from https://translatewiki.net.
Change-Id: Ia3d32677f46448d525fd3b7bd018856d5b5adee4
2014-08-03 22:12:44 +02:00
Roan Kattouw c9e04f2211 Don't send API requests to preview empty (or whitespace-only) edit summaries
Change-Id: I1b75a012eebececa5fd53d5ceedb9221648182fb
2014-08-02 19:12:25 -07:00
Translation updater bot 0279f8b512 Localisation updates from https://translatewiki.net.
Change-Id: I3c58c4d41cbfe08951e0b07d4d209f387f21bad3
2014-08-02 22:25:17 +02:00
Bartosz Dziewoński 694c454dcd Blacklist annotating link node with more links
Previously one could select over a link node and linkify the
selection, with tremendously funny results.

Change-Id: Ic5a2132b2d18280099a6024bc4ec2b1333eca98f
2014-08-02 12:34:30 +02:00