Commit graph

15560 commits

Author SHA1 Message Date
jenkins-bot f9f8ce8919 Merge "Fix mobile done/tick button" 2019-04-12 16:12:50 +00:00
jenkins-bot 3a0848f0d6 Merge "ve.ui.MWSaveDialog: Work around review panel disappearing on iOS Safari" 2019-04-12 14:27:09 +00:00
Translation updater bot 756be89b7b Localisation updates from https://translatewiki.net.
Change-Id: If57d5876c4de074b2d2dcf32199ab2043a9f4a86
2019-04-12 08:32:41 +02:00
jenkins-bot 53db6727b3 Merge "Rename 'citefromid' to 'citoid'" 2019-04-11 11:01:00 +00:00
Ed Sanders 79cee8d820 Fix mobile done/tick button
Change-Id: I53eebfe9b94354521763743ab70e4d1a919286f8
2019-04-10 22:51:08 +01:00
Bartosz Dziewoński b7f7cf3734 ve.ui.MWSaveDialog: Work around review panel disappearing on iOS Safari
No idea what causes it, but I've seen a similar issue when working on
Ic35f084d019afd1782292c831765ceb1444fb14a (in OOUI) and this hack
worked there too.

Bug: T219680
Change-Id: Ifb49ede450cabdcd8303b298b62f2ac632809b53
2019-04-10 22:56:08 +02:00
Esanders 23b5dbead2 Merge "SurfaceView: Use new #isDeactivated method" 2019-04-10 11:27:53 +00:00
Translation updater bot 2fe6b20d6c Localisation updates from https://translatewiki.net.
Change-Id: I10bc0fa563df5b7b5a1d3eff3e90c8cf48e19dde
2019-04-10 09:23:42 +02:00
Ed Sanders 72df5f690f Update VE core submodule to master (f039957f3)
New changes:
f039957f3 [BREAKING CHANGE] Use keyed objects for importRules blacklists

Local changes: Use extendObject to set importRules

This allows us to inherit the ruleset from the parent
so we don't have to worry about keeping it up to date.
(For example alienTableCell from upstream was missing
in MW).

Media/Gallery dialogs: Add missing mwTable types.

Change-Id: I366a091ff4def66cc25200b3d1b2c23ba6b716f7
Depends-On: I8ff7e8242c8db235a0f9e11e2e52f90d62d368a0
2019-04-09 16:58:26 -07:00
jenkins-bot afdd97c58f Merge "EditSummaryWidget: Disable pending animation" 2019-04-09 20:13:07 +00:00
jenkins-bot c5fb5b4562 Merge "EditSummaryWidget: Don't show suggestions on focus" 2019-04-09 20:11:19 +00:00
Ed Sanders ed0105b5a1 EditSummaryWidget: Disable pending animation
Animation shows breifly on every keystroke, even though
only one server request is made, as the promises always yield
to a browser animation frame.

A pending animation isn't really required for autocomplete
as the results are only optional suggestions.

Change-Id: Ifa257592b10d84dccfa3e0c819c1edf1f7ef9cfa
2019-04-09 19:54:39 +00:00
jenkins-bot 2ab08d7275 Merge "InternalLink: Add special case for fragment with no title" 2019-04-09 18:11:34 +00:00
jenkins-bot 1b2c1425ee Merge "Allow external link pasting to be enabled by config" 2019-04-09 16:05:26 +00:00
Ed Sanders 476d64957e SurfaceView: Use new #isDeactivated method
Change-Id: I5a53f331b6417b72b9f78f3f869579573ea05fef
Depends-On: I043a213fb4a06b02e160315fe3a846a1dd4d7cc1
2019-04-09 15:51:03 +00:00
James D. Forrester 8ce3893acc Update VE core submodule to master (6cc4cd1f0)
New changes:
3a4e42a9a Don't make selection grey on mobile preparePasteTargetForCopy
c312ead04 Fix appearance of deactivated alien node
9ac03103d ce.Surface: Rename deactivatedForCopy to showAsActive
47dfe7cea AuthorListPopup: Remove deactivate hacks

Bug: T219829
Change-Id: I2ef99e643043a81e3adc4dcce1809400408d8dbc
2019-04-09 08:50:01 -07:00
Ed Sanders dbd692b5ed InternalLink: Add special case for fragment with no title
Bug: T218581
Change-Id: I11e2de90e582d184a3f8cdd65dfc0858571aa397
2019-04-09 14:43:24 +01:00
jenkins-bot 2fc64107f4 Merge "Give mobile document a min height based on 100vh" 2019-04-09 11:59:04 +00:00
jenkins-bot 49969c92d2 Merge "Use nullSelectionOnBlur=false for ArticleTargets" 2019-04-09 11:34:31 +00:00
James D. Forrester 6228467ddd Update VE core submodule to master (3cfdc4311)
New changes:
7dd81816e Filibuster: display backward selections differently from forward ones
bfb5d0e12 Move filibuster initialization to ve.debug
abcf65dc6 Localisation updates from https://translatewiki.net.
f09413aaf LanguageInputWidget: Set value on 'closing' not 'closed'
03990f5fd LinearContextItem: Fix typo in isDeletable

Bug: T220438
Change-Id: I041989b1f4bcc651350841b3d15e2b4ee0db51f5
2019-04-08 11:55:43 -07:00
jenkins-bot 6eb12b285e Merge "ve.init.mw.MobileArticleTarget: Remove code causing scrolling issues" 2019-04-08 18:37:17 +00:00
Ed Sanders d0a3237f1c Give mobile document a min height based on 100vh
Makes the whole page focusable.

Bug: T109508
Change-Id: I93e9269a89281d342551be5de43a2c60c848ef33
2019-04-08 13:32:31 +01:00
Translation updater bot 310e8627d8 Localisation updates from https://translatewiki.net.
Change-Id: I4ea9efc57cb5fa071cad9cfd85044459263341f6
2019-04-08 08:39:25 +02:00
jenkins-bot 08fa82bbe5 Merge ".phpcs.xml: Drop unnecessary exclusions" 2019-04-06 04:23:30 +00:00
James D. Forrester 358d2fa01c .phpcs.xml: Drop unnecessary exclusions
Already ignored, or don't have any PHP files.

Change-Id: I644148617e2d6ce2fdb1d406ca2cc9c2b5aabbd7
2019-04-05 17:43:18 -07:00
jenkins-bot a9f3d0dac5 Merge "Hooks: Don't set wgVisualEditorToolbarScrollOffset in RL when 0" 2019-04-05 23:07:06 +00:00
Translation updater bot 31f6fb1ed2 Localisation updates from https://translatewiki.net.
Change-Id: I52310f4645dc916f8f1669c7a48c3cdb83a2b19d
2019-04-05 22:27:54 +02:00
James D. Forrester 4df2558910 Hooks: Don't set wgVisualEditorToolbarScrollOffset in RL when 0
We should also move this to packageFiles, but that's more work.

Bug: T220158
Change-Id: I438dc13802d744877921dc612b16cc22b0713e00
2019-04-05 11:42:05 -07:00
Ed Sanders 64b02f97ce Use nullSelectionOnBlur=false for ArticleTargets
Bug: T208826
Depends-On: I2c464ec2bbf799cbe1d9bfed1aad05c5a1bfb094
Change-Id: I5bcd6947c1c6e8f278d0cc9f9c95afb835d1b56b
2019-04-05 13:54:00 +00:00
Ed Sanders e2dfdf0ef7 EditSummaryWidget: Don't show suggestions on focus
Bug: T220176
Change-Id: Iffad075929d8835eb4f8677b33c3edd30a27b3f8
2019-04-05 14:04:29 +01:00
James D. Forrester 7f18b4b9d0 Update VE core submodule to master (8653ce4bd)
New changes:
c4b17a604 Remove deprecated ve-test-toolbar- classes
f31d3be06 Update OOUI to v0.31.3

Bug: T220091
Change-Id: Ib479fe6a7d9f43f7177c5125f9b1c324f0451964
2019-04-04 15:26:12 -07:00
Bartosz Dziewoński 9143155722 Update VE core submodule to master (2dc41ef9b)
New changes:
eeaebe220 Make deactivated selections grey
58b96ec5d Make null-selection-on-blur optional

Bug: T219813
Bug: T219829
Change-Id: I0660c60860fd62e838a63aa841253ef19fb2a78a
2019-04-04 20:46:10 +02:00
jenkins-bot 96dfb99016 Merge "Edit summary autocomplete" 2019-04-04 17:44:36 +00:00
Bartosz Dziewoński 17a0b407fc ve.init.mw.MobileArticleTarget: Remove code causing scrolling issues
This code is supposed to check if we have scrolled past the end of the
page, and if we did, scroll back up to a more reasonable position.

However, it seems to incorrectly trigger in other cases, and scroll
the page back to the top, because getBoundingClientRect() occasionally
still returns bogus values (even though we try to avoid that). This
happens inconsistently when focussing the surface or closing a dialog.

We can't correctly display the toolbar while scrolled past the end of
the page. Removing this code causes it to go into an endless animation
loop in that case. But that may be preferable…

Bug: T219200
Change-Id: I152f2b39351ffd3c9799eea33cce95e05d2f9ab9
2019-04-04 17:07:39 +00:00
Translation updater bot 2455b94f18 Localisation updates from https://translatewiki.net.
Change-Id: I5bb495971e5970f033da8f4f6367e79a8dfe8e9d
2019-04-04 14:55:17 +02:00
Bartosz Dziewoński 362df66b47 Remove support for page title "hrefPrefix" other than './'
Parsoid does not use relative links anywhere anymore (T72743). There
is no reason for us to support this. And previous code allowed
"hrefPrefix" to be empty '' sometimes, which is scary, as it could
lead to XSS vulnerabilities if titles starting with 'JavaScript:' are
not handled correctly elsewhere.

Bug: T206357
Depends-On: I8728f63084902c76d1c61193be4367939b069f1a
Change-Id: I99be18877aae2b505cf261bd7cdef6cf0d7a8670
2019-04-03 20:10:05 +00:00
jenkins-bot f0053e1644 Merge "Avoid keeping excess keys from storeInSerializationCache() in cache" 2019-04-03 19:06:08 +00:00
Aaron Schulz 1a5fc05dda Avoid keeping excess keys from storeInSerializationCache() in cache
Remove overkill $VisualEditorSerializationCacheTimeout config setting
and just use a simple constant instead (convention over configuration).

Bug: T203786
Change-Id: I94424088a03a3262fcea30132883a612465c546e
2019-04-03 18:34:07 +00:00
Bartosz Dziewoński 15745d9dd1 Update VE core submodule to master (5c8fd26b8)
New changes:
0a3a4578a EventLogger demo improvements
e8468dd10 Localisation updates from https://translatewiki.net.
7a98936b2 Remove border radius from buttons in MobileContext
69078dc22 Remove blur/focus event listeners from DesktopContext.
9750d8931 Redraw deactivated linear selections on 'position'

Bug: T219916
Change-Id: I092c01a07799d895ff0b75c05853da0b744f6356
2019-04-03 19:59:31 +02:00
jenkins-bot 42eb7e0cf4 Merge "Suppress slugs between floated images" 2019-04-03 15:59:09 +00:00
jenkins-bot 0d4e843132 Merge "trackSubscriber: don't populate all fields, to make validation happy" 2019-04-03 13:18:19 +00:00
Ed Sanders d784304ed1 Rename 'citefromid' to 'citoid'
Backwards compatible change can be merged ahead of change
in Citoid repo.

Bug: T219512
Change-Id: I2d7e389cc01808e41353681dd2448a0385543f2e
2019-04-03 13:19:45 +01:00
jenkins-bot 62d5c60b82 Merge "ve.init.mw.MobileArticleTarget: Fix placeholder being hidden by the toolbar" 2019-04-02 18:33:17 +00:00
jenkins-bot aeeffb912a Merge "Treat ambiguous values in $wgVisualEditorAvailableNamespaces as names" 2019-04-02 15:20:59 +00:00
Bartosz Dziewoński ac3d5e7925 ve.init.mw.MobileArticleTarget: Fix placeholder being hidden by the toolbar
Follow-up to 500462f4b2.

Bug: T219066
Change-Id: Ie0c35339c440bf85545e51fb5398d0936757432a
2019-04-01 22:48:36 +00:00
Derick Alangi 37e978d169 SpecialCollabPad: Remove unused variable $request
Change-Id: Ie5cce0771c2b7f1f5a521d3129deb2063b5cbf5b
2019-04-01 23:08:02 +01:00
Translation updater bot 748b3d17c7 Localisation updates from https://translatewiki.net.
Change-Id: Ib37aa5b29c0ea2f8050dd2492447fe790f1bf0b9
2019-04-01 22:41:30 +02:00
David Lynch 415cc0d022 trackSubscriber: don't populate all fields, to make validation happy
The EditAttemptStep schema doesn't have some of the fields we attempt to
submit, because we're generalizing and it only wants specific ones. Be more
selective about what we submit, so validation messages in the console will be
quiet.

Bug: T218163
Change-Id: Iaf9f47b61c138bb0106b2dfc4be2caec02a10d1d
2019-04-01 11:56:15 -05:00
Translation updater bot c634ea2e99 Localisation updates from https://translatewiki.net.
Change-Id: I755ca10ff4c352d3857e310d20ff6206f748406e
2019-03-31 22:17:23 +02:00
jenkins-bot ab17c1095a Merge "ve.init.mw.MobileArticleTarget: Save/restore scroll position on surface (de)activation" 2019-03-29 23:18:17 +00:00