wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 18:39:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
1559 commits 161 branches 1 tag 190 MiB
Commit graph

237 commits

Author SHA1 Message Date
Catrope f7445b37b8 Retain attributes when reopening closed nodes 
* Push entire elements onto openingStack rather than type strings
* When closing an element, build a clone of the opening and push it onto
  closedElements, then insert that clone when reopening the element

Change-Id: I8b0fb44394aed6c471dc6dacaab03e44c2333733
 2012-06-04 16:07:16 -07:00
Catrope b167453f0d Add ve.dm.Node.getAttributes() to get a reference to the attributes object 
Change-Id: Ic2463d4f7053a5f6defd212f04deb5ea71542843
 2012-06-04 16:01:14 -07:00
Catrope 109624e8b3 fixupInsertion fixes, wrapping content works now 
Change-Id: I1eee6afcffbf09955578b7f0534aa5b7234802df
 2012-06-04 16:01:13 -07:00
Rob Moen fd5eb80dd7 Document annotate method in surface model. 
Comment cleanup

Change-Id: Ifd3eeab9046f376529a827dfafdc28506845ac15
 2012-06-04 15:06:37 -07:00
Rob Moen c338304d33 Rewrite annotate as more low level method in Surface model. 
TODO: follow up with annotate tests

Change-Id: If0e68bd3a09840b1e5f3e8d85fd22a8c10134b58
 2012-06-04 14:29:27 -07:00
Trevor Parscal 73c5dd8f1d Added ve.dm.Node.getOffset 
Change-Id: I4fb99040af44c063ad3b6489f2fd895d843fcf0c
 2012-06-01 17:44:01 -07:00
Christian Williams cf63a2dd36 Support for pasting into a range 
Change-Id: I13e29caba4d912db2477a2c3c4edeca5d21d06b4
 2012-06-01 16:38:27 -07:00
Christian Williams 2bd615c6d2 Cut, copy, and paste now working with images 
Change-Id: Ic3b99d39bd41a8fe39e015ca05d159a5a4ea2b15
 2012-06-01 15:52:51 -07:00
Trevor Parscal 386faa5569 Fixed ve.dm.Transaction.newFromRemoval so it supports trimming off extra openings and closings 
Change-Id: Icbcf4129a51aa92d47aa89738facd0d288337cbd
 2012-06-01 14:34:59 -07:00
Trevor Parscal e7f03c6d70 More cleanup, removed ObjectAnnotation (they are inline elements now) 
Change-Id: I2c53c145eed1a801392c954001de7641f928216c
 2012-05-31 17:18:28 -07:00
Trevor Parscal ba8d1b46f2 Cleanup 
Change-Id: Ida9c94d5aa410ee699b706492f444a6449922ede
 2012-05-31 17:11:01 -07:00
Trevor Parscal 294abb0a38 Simplified converters data structures 
Change-Id: I1734bc7e06462595ea2f27715948fbb3d9e552ad
 2012-05-31 17:03:03 -07:00
Trevor Parscal 042ffb4e3b Added foundation for new converter 
* Added converters to all relevant node implementations
* Added new annotation objects with their own factory

Change-Id: I9870d6d5eac45083929d74d2e58917d0939ca917
 2012-05-31 16:50:16 -07:00
Trevor Parscal f6864b0c04 Changed use of "factory" to "nodeFactory" to make way for other kinds of factories 
Change-Id: I96db0f28bb220f1c3b23990824e9523278cb8f9b
 2012-05-31 15:20:58 -07:00
Trevor Parscal 32bddaf088 Added ve.dm.Transaction.newFromRemoval 
Also:
* Refactored tests
* Added tests for ve.dm.Transaction.newFromInsertion
* Added tests for ve.dm.Transaction.newFromRemoval
* Fixed problems with ve.dm.Transaction.newFromInsertion
* Added ve.dm.Node.canBeMergedWith which is partially a port of ve.Node.getCommonAncestorPaths merged with canMerge from within ve.dm.DocumentNode.prepareRemoval from the old ve codebase

Change-Id: Ibbc3887d08286d8ab33fd6296487802d65b319fa
 2012-05-31 14:39:34 -07:00
Catrope 2f18605a1a Fix buggy replace behavior when inserting content that contains nodes 
Copy-pasting things like "text<IMAGE>moretext" failed spectacularly,
this commit fixes that.

* Check for content rather than structure in the inserted/removed data
* In the content case
** Run selectNodes() over the removal range, rather than just the cursor
*** i.e. no longer assume that content replacements only affect one node
** If there is structure involved, rebuild all affected nodes

Change-Id: I80e40b5b7c514a3fb105d57e4a17770d0fefaaea
 2012-05-31 07:27:36 -07:00
Catrope f6ca37926d Add ve.dm.Document.isContentData() 
Some of the replacement code was assuming that "does not contain
elements" and "is content" were the same. They're not any more, because
we have content nodes (like image) now, so I need a separate function
to distinguish between these cases.

Change-Id: I206ccdf082b7baddf99d382eb3cdd77ea34fb479
 2012-05-31 06:19:34 -07:00
Catrope e92db86046 Fix bug in ve.dm.Document constructor for input ending with text 
If the last element of the input data array was text, the resulting text
node would have length=0 rather than the expected length value.

Change-Id: I3d089a80b8a447a12ba411b2e11c1b84f14f2959
 2012-05-31 06:17:23 -07:00
Rob Moen b59d49a80d Restrict edit access to VisualEditor namespace to sysops 
To allow non sysops to save via VE, refactored ve save api
to use doEdit which bypasses namespace protection.
Add edit link in view nav for non sysop so that they may edit
Add View source link in dropdown for non sysops
Add Edit source link in dropdown for sysops
Cleaned up some of the integration core code
UI tweaks

Change-Id: Ib4249bc5fb7ffa6410e4f2d278aafbb871800981
 2012-05-30 17:12:25 -07:00
Inez Korczynski 43a6abec2d Introduce two different types of slugs - inline and block - this is in order to fix bug in IE with placing cursor inside slug by clicking next to it 
Change-Id: Idf31a742ee98067688becf46b357c25cd10ddbc6
 2012-05-30 16:45:06 -07:00
Inez Korczynski f7fb4bee5c Refactoring and performance optmization to method getNodeAndOffset - previously named getDOMNodeAndOffset 
Change-Id: I067331f539bc86779c98be38e6a56ca04137c70f
 2012-05-30 15:19:39 -07:00
Trevor Parscal 46d26b9f22 Added getNodeFromOffset to ce 
WARNING: This is not as fast as the implementation of getNodeFromOffset in dm

Change-Id: I5fbe9b6edc66169b9caaa6751fde1b7b752814d1
NOTE: ve.ce.getNodeFromOffset and ve.dm.getNodeFromOffset should be renamed to getBranchNodeFromOffset to clarify that they only return branch nodes.
 2012-05-30 14:38:18 -07:00
Trevor Parscal 8328fc8786 Removed aliases for node type constants, on the client we have them already in Node 
Change-Id: Id68dd43930a51a857e73af0215fd215c89e9bbbe
 2012-05-30 14:38:18 -07:00
Inez Korczynski 5f9ea545cf Refactoring and performance optimizations to getOffset method in Surface view. 
Change-Id: I8b57c9dc069894c82a6bafc5f282aefda505d061
 2012-05-30 14:06:44 -07:00
Christian Williams e216a6f8ab Fixed scroll jumping when pasting 
Change-Id: I9607dee6d1b0ca1820a9da5f48966310214e5edf
 2012-05-30 13:06:19 -07:00
Christian Williams 11b1bd8884 Using string constants for node types 
Change-Id: I2d18d4f54c776e299bc10206386b655605dae839
 2012-05-30 11:41:31 -07:00
Inez Korczynski 8a52b41076 Working (but dirty) implementation of getOffset, getDOMNodeAndOffset and handlers for keydown/mousedown - to be refactored very soon 
Change-Id: I57923218fc8e5f3e1cdde339cdc1cb5e859cdedf
 2012-05-25 23:52:52 -07:00
Inez Korczynski e5897dffa4 Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-05-25 23:36:54 -07:00
Inez Korczynski e9230968fe Set contenteditable=false for Alien wrappers (both inline and block) 
Change-Id: I5fd8fcfd0b6d98b525a75b3818cc77e3aca833c9
 2012-05-25 23:36:18 -07:00
Christian Williams 8db39d0bb5 Support for plain text paste 
Change-Id: I60846900d61b50138fe06dacee4693166e59651e
 2012-05-25 16:26:46 -07:00
Christian Williams 64b9b33eec IE and its silly events 
Change-Id: I81f46eca20cc5197305cbd355751c4c90e3b670b
 2012-05-25 16:12:58 -07:00
Christian Williams 83e7eddfaf Support for paste 
Change-Id: Id0a3d5d421aef56eb3296a56d00686ef7d07b433
 2012-05-25 15:46:58 -07:00
Inez Korczynski 1e5e14c2c1 Add method hasSlugAtOffset to ve.ce.BranchNode 
Change-Id: Id107bf890710096bb49111ae3d0d60e3315ecb89
 2012-05-25 13:44:12 -07:00
Trevor Parscal 14862a1212 Fixed bug in isStructuralOffset which didn't consider neighboring a non-content leaf to be a structural offset 
This was caused by the fact that a non-structural leaf can not have children, which makes it appear incompatible as a sibling to an arbitrary structural element (like a paragraph) but since it can not contain content we can check that instead.

Change-Id: Ie3c58b4b43f2aa6921f8f82aa82511e231207854
 2012-05-25 13:19:56 -07:00
Rob Moen 7b47af516a Merge branch 'dmrewrite' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor into dmrewrite 2012-05-25 12:52:46 -07:00
Rob Moen 61413c49eb Create base integration core module 
Works on VisualEditor Namespace
Created VE api wrapper for parsoid service to roundtrip pages

Change-Id: I3f2967730c1a3ece31b7262a46bef31ea8b38613
 2012-05-25 12:50:48 -07:00
Christian Williams 80ed03f2a2 Support for copying 
Change-Id: Icf4665f9c48896e26cb536af033ca55410af49db
 2012-05-25 12:02:56 -07:00
Inez Korczynski 8f4f076340 Added handles for mouse events (down, up, move). Implemented method SurfaceView.getOffset and applied significant fixes to SurfaceView.getDOMNodeAndOffset. 
Change-Id: I06cbfa9e0e7afc7aaf19d5cda8b91fe93aeb51f8
 2012-05-24 20:55:45 -07:00
Inez Korczynski afe18a685a Fix methods getNearestStructuralOffset and getNearestContentOffset for case of passing offsets that are already structural or content 
Change-Id: I23cd2daab9cef181b01131b3b9c6ead5ec47f9f4
 2012-05-24 20:53:50 -07:00
Inez Korczynski b56b6bad6d Just for purpose of testing add some hardcoded border and cellspacing to all tables 
Change-Id: I97ff937d7e7d6a91ee3f411d7f77d5e3798ba567
 2012-05-24 20:51:31 -07:00
Inez Korczynski 6017050b3f Add class ve-ce-imageNode to all image nodes, also comment out mousedown event handler 
Change-Id: I7565d8822bbe0547e731df1859cdde4ac78de6f2
 2012-05-24 20:50:36 -07:00
Trevor Parscal ea9191b5b4 Copied CSS styles from ve to ve2 
Change-Id: Iabd5ee3edde5747952c4b78ef6e9cd5949016050
 2012-05-24 15:15:29 -07:00
Christian Williams 0a3b5df6de Image nodes are not draggable 
Change-Id: Ie1080045939af7c9b7ac8c30527ad6057fe7e3f6
 2012-05-24 15:10:16 -07:00
Christian Williams 88e25e77f2 Merge branch 'dmrewrite' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor into dmrewrite 2012-05-24 14:47:41 -07:00
Christian Williams 1cc8aca16d Using invisible space character in slugs 
Change-Id: I36752f4bea96bad61dedfbbb4fc00422d773227b
 2012-05-24 14:47:24 -07:00
Trevor Parscal f6eef19021 Added copying of .data( 'node' ) from old wrappers to new wrappers on wrapper updates 
Change-Id: Ibd9535bd9ebb712910d963eedc5941f8512aaf8d
 2012-05-24 14:01:42 -07:00
Trevor Parscal c8ccdb9813 Moved ve.ve.BranchNode.canNodeHaveSlug to ve.ce.Node.prototype.canHaveSlug 
Change-Id: I6d5d9ca5a1c9878acb15e9526feb94986822b491
 2012-05-24 14:01:17 -07:00
Trevor Parscal ebfafac3e2 Added missing documentation to methods in ve.ce.BranchNode 
Change-Id: If6833e3d639e0455025762987b7f41a43892ca4a
 2012-05-24 13:22:57 -07:00
Christian Williams 933ff678a4 Focus can now be set in slugs using showCursor or showSelection. 
Change-Id: I12ab361a30d277a4752579bf885fd37bc46b32ed
 2012-05-24 13:18:30 -07:00
Trevor Parscal 3ce705313e Replaced static array with real logic inside of ve.ce.BranchNode.canNodeHaveSlug 
Also added more static config getters and fixed some typos in prototype definitions

Change-Id: Ib9093a625b944e6a4ca4da50c51fb475b5895b8d
 2012-05-24 13:12:45 -07:00