This is mostly cleanup from 4cd67004d removing Diff, which was the
original caller of the moved functions.
Change-Id: I015cb310527d9e7593e4ba6ac15ac204435d9ab4
This lets us encapsulate everything about a check in its JS definition,
which makes it much simpler for other extensions or gadgets to create
checks.
Change-Id: Ica23fc26a576d55addb001e4baf78b3702927208
This object just contained a pointer to the surface and dm,
and had one utility method.
Move the method to mw.editcheck, and pass around a surface model
or document model to other methods as appropriate.
Change-Id: Ie81d76dea2823b633328f982ee20027808bfc8e3
This method is highly specific to reference insertion. If we ever need
it for another check it can be moved back with a more specific name.
Change-Id: Ia629c8672281f33d45ea1fff6630af9bd331d80e
* Pass just the ve.dm.Document to shouldApplyToSection, instead
of the whole diff.
* Do the quicker range check first in getModifiedRangesFromDiff
Change-Id: I1bda3a77c1c51f50fd7baadaa3619cf6719a073a
Clean up accountShouldSeeEditCheck since nothing is calling it but the
new method inside BaseEditCheck
Follow-up to e947e53f98
Change-Id: Ic55187bb77f5ef003369313b76a65897fb3be392
This was accidentally removed in d69d366469 during its refactor.
Because of the change to how checks are decided to be shown, I've made
AddReferenceEditCheck always be required -- later code in
hasAddedContentNeedingReference assumes that it's loaded anyway, so a
wiki deciding to configure it to not load at all for some account types
would have broken saving.
Bug: T373692
Change-Id: I007cd705451581ebacfa12e8ac5502bd1bc56a38
