Ed Sanders
f2e0b408b4
Teardown the toolbar properly
...
Depends-On: I53a86bf5e0322dc9766ae4ddf31ff0ae5568df7e
Change-Id: If9cc876a57272679584ebc653cf2ee8e17ddb821
2016-11-12 14:28:11 +00:00
James D. Forrester
26e7267f02
ArticleTarget: Use an OOUI MessageDialog, not window.alert()
...
We should avoid using alert()s as much as possible due to their unhealthy
interaction patterns with any other open tabs or user tasks.
Change-Id: Ib6a217c988322ad17bc7e649c3281eb053b54bbc
2016-11-10 12:55:49 -08:00
jenkins-bot
28787b0f3c
Merge "Rename methods used for setting up multiple edit tabs"
2016-11-09 00:45:01 +00:00
jenkins-bot
45a75047fa
Merge "Move save dialog checkbox code up from DAT into ArticleTarget"
2016-11-08 17:14:45 +00:00
jenkins-bot
efb4133119
Merge "Use onEditTabClick handler in SingleEditTab"
2016-11-08 17:10:06 +00:00
Ed Sanders
55fcded32e
Replace non-standard whitespace in comments
...
This is required to pass eslint:recommended.
Change-Id: If8c4876a366e5c021c414e54328ed1913b679969
2016-11-08 14:15:12 +00:00
Ed Sanders
2fa4cfef16
Rename methods used for setting up multiple edit tabs
...
Change-Id: I71d6dd0848e9cc3ee8531b0b914c29219b4697bd
2016-11-08 12:47:30 +00:00
Ed Sanders
f6a205d77f
Use onEditTabClick handler in SingleEditTab
...
Gives us extra functionality like checking for
isUnmodifiedLeftClick which makes CTRL+click on SET
not change the current page, as expected.
Change-Id: Icb37d7383374ee63798443659a2bcb2f1545c8c5
2016-11-08 12:39:15 +00:00
Alex Monk
e81c6e5b43
Move save dialog checkbox code up from DAT into ArticleTarget
...
So it applies to MobileArticleTarget.
This shows the checkboxes on mobile.
Bug: T148914
Change-Id: Ib6559d5601004e58b72903805059e04f42acc85f
2016-11-05 06:24:49 +00:00
Alex Monk
7c80976f5b
Remove 'vesection' parameter
...
Just use the normal section parameter, haven't been able to figure out why VE
would need to be special about that.
Bug: T149958
Change-Id: I9338d0f1498fbb579fa8c340d6e7274c6d48155b
2016-11-05 02:08:13 +00:00
jenkins-bot
b6d3dabfbf
Merge "Add binding for when only tab is new wikitext editor"
2016-11-02 21:36:21 +00:00
jenkins-bot
65236ae67f
Merge "Try to make client and server code to get last editor work the same"
2016-11-02 20:07:07 +00:00
jenkins-bot
254e77a296
Merge "Set section to null when switching from NWE to VE"
2016-11-02 19:45:14 +00:00
Ed Sanders
3fb757c307
Add binding for when only tab is new wikitext editor
...
Bug: T149796
Change-Id: I675c5876fbb9ca8427983e9d4252cccda35775f9
2016-11-02 19:10:28 +00:00
Ed Sanders
56679dfb35
Set section to null when switching from NWE to VE
...
This prevents the discard warning from being shown if the user
switches back to NWE then back to VE, as by this point they
have left section editing.
Change-Id: I734684c54a8900aab3332ed8421cb42f7f845738
2016-11-02 15:53:29 +00:00
Ed Sanders
7db58ab3d8
Fix binding of onEditTabClick to section links in SET
...
Bug: T149797
Change-Id: I0f753718ccddb9c2b68cdc82ff379bd59d7006ad
2016-11-02 15:50:30 +00:00
Ed Sanders
e655880d14
eslint: Remove unused exception and fix documentation errors
...
Don't enable valid-jsdoc yet though, due to @chainable bug.
Change-Id: I4d2a6de19c72c6e4c20733446616d8046419d431
2016-10-28 12:02:36 -07:00
James D. Forrester
36befda61c
build: Replace jscs and jshint with eslint
...
It's new, it's fresh, it's amazing, it's here.
Change-Id: I5dc784411f704685ed5cc763a2b2b1c5d3e5a610
2016-10-28 18:33:15 +00:00
James D. Forrester
c45c79eca2
ve.init.mw.DesktopArticleTarget: Fix missing '&&'
...
Change-Id: I0e91cde3d38d3f5bdd7dde790093db21d8a64036
2016-10-27 16:53:55 -07:00
Ed Sanders
244eeb9ea1
Update VE core submodule to master (e4c8003)
...
New changes:
e4c8003 Bring in target 'mode' property from MW
Local changes:
Use upstream Target#setMode functionality
Depends-On: I9d501cb77c714fbd299b5816d302b0bdde7833cd
Change-Id: I2fcda6ca7d82d880101d9ba2a027d4ef066aa238
2016-10-27 16:12:31 -07:00
Ed Sanders
fad3b429c8
Make meta dialog tools visibile but disabled in NWE
...
Following our unwritten rule of trying to keep the interface
as consistent as possible.
Change-Id: I58668acb5bac12de73b7b8f52e670f68336c399f
2016-10-27 14:48:51 -07:00
Ed Sanders
dc902b4c93
Pass edit token when saving/diffing in new wikitext editor
...
Change-Id: Ia14a4d204e367a3d0d46165a51b0cdc6fc3d57e7
2016-10-26 17:39:14 -07:00
jenkins-bot
3c443724e2
Merge "Follow-up I64a8ed73: Fix NWE getWikitextFragment"
2016-10-26 23:57:44 +00:00
Alex Monk
53f8aac0d5
Follow-up I64a8ed73: Fix NWE getWikitextFragment
...
Also fix the rejection Deferred line if things go wrong
Change-Id: I8f060de1972dd0ae79c81162c61efd5956e48955
2016-10-27 00:37:22 +01:00
jenkins-bot
3750081797
Merge "Don't show confirm dialog when switching to NWE"
2016-10-26 21:48:15 +00:00
jenkins-bot
60565711ff
Merge "Fix handling of API responses"
2016-10-26 20:42:35 +00:00
jenkins-bot
035987b9be
Merge "Create init.isWikitextAvailable and add page content check"
2016-10-26 20:42:06 +00:00
jenkins-bot
b5317b694f
Merge "Fix edit source links for NWE"
2016-10-26 00:25:22 +00:00
Ed Sanders
460df1f25f
Don't show confirm dialog when switching to NWE
...
Bug: T148099
Change-Id: Icd756dc31ef8628795915ea972bb0ded385532ed
2016-10-25 17:20:16 -07:00
Ed Sanders
de2f07d523
Fix handling of API responses
...
NWE can return data in 'visualeditoredit' instead of
'visualeditor'. We may want to change this later.
Also restore removed hack code that popuplates missing
VE API data when requesting wikitext.
Change-Id: I9a782a85444d37a3e21c071db7e175ee9b0b1c4f
2016-10-25 17:20:16 -07:00
jenkins-bot
b341e3406a
Merge "Fix arguments passed to requestPageData when switching"
2016-10-26 00:04:34 +00:00
Ed Sanders
7b9229f5b8
Fix toolbar transition
...
The contents of the bar to should appear to move in to place, not
just be revealed.
Change-Id: I01a85e3455462cf70b6c3f25a236ab6cb82c706c
2016-10-25 15:55:41 -07:00
Ed Sanders
702f931ef2
Fix arguments passed to requestPageData when switching
...
Change-Id: I890d782829fd077096be364c26a41b56ec4a2df3
2016-10-25 15:52:52 -07:00
Ed Sanders
e977ca4336
Fix edit source links for NWE
...
We fixed these to use vesection instead of section.
Change-Id: I0aa6530b6707239c41216421394379301b0878a7
2016-10-25 15:50:14 -07:00
Ed Sanders
751853942f
Create init.isWikitextAvailable and add page content check
...
Bug: T149007
Change-Id: I2e16c6361c32f3c1ebd2ae7c9f41089d56b67b06
2016-10-24 15:36:44 -07:00
jenkins-bot
50e102da0c
Merge "Send RB errors through the normal error handling process"
2016-10-20 23:01:02 +00:00
jenkins-bot
0f566448ed
Merge "Switch to the wikitext editor if VE fails to load"
2016-10-20 23:01:01 +00:00
Ed Sanders
2dfdd82317
Prevent edit source from acting twice
...
Bug: T148309
Change-Id: I5ef3f4b7cbc7298e89aa531c174657b1d1bccdf6
2016-10-16 19:06:06 -07:00
jenkins-bot
23eb869d9d
Merge "Get rid of ?venotify= from URL post-save"
2016-10-14 23:30:16 +00:00
Alex Monk
b5815e9ffd
Send RB errors through the normal error handling process
...
Change-Id: I230ff6d3c9a6a183fb483f5adfd7ccdc025a07af
2016-10-14 11:17:56 -07:00
Alex Monk
39aa3021a7
Switch to the wikitext editor if VE fails to load
...
Also kill some dead HACK code in DesktopWikitextArticleTarget#switchToWikitextEditor
Bug: T135748
Change-Id: Ie5aaa0f3c3bd20755abaac9b86af015b71eb777b
2016-10-14 18:15:16 +00:00
jenkins-bot
246e2ebb4e
Merge "Tidy up DAT load failure handling"
2016-10-14 00:32:30 +00:00
Alex Monk
70bf00e9b0
More NWE-SET integration fixes
...
Also stop calling $skin->getUser() so much, store the result
Change-Id: Ic91a660bc4b97a82f1d2b0bffb55425564696da1
2016-10-13 22:46:16 +01:00
Alex Monk
49283f7250
Fix typo in DAT.init.js
...
Change-Id: I75f7de16ea06d62a1bdfa0e04294fef5560fd5c9
2016-10-13 22:22:57 +01:00
Alex Monk
6b87b2671e
Fix another case where we need to pass the section
...
Bug: T144654
Change-Id: I5f91b9329525ceaeb971d02f93c959d908d748f7
2016-10-13 20:28:21 +01:00
Ed Sanders
4040442ad8
Section editing in NWE
...
Bug: T144654
Change-Id: Ida6e721e0d980b47e3fda6a1f0744cbce1b2235a
2016-10-12 12:55:11 -07:00
Kunal Mehta
6c93a49244
Get rid of ?venotify= from URL post-save
...
Use history.replaceState if available to get rid of the venotify query
parameter to avoid polluting URLs.
Ideally this would just use a cookie like the core post-edit
notification.
Change-Id: I6ce142012053e2fc18dd44fd0f7b82914acea076
2016-10-12 11:05:12 -07:00
Ed Sanders
4fc2904a87
Follow-up I9547dfd: Only enable VE tabs if VE is available
...
Otherwise VE is launched on namespaces where it is disabled
(but NWE is enabled).
Bug: T147890
Change-Id: I62f4ff96b991553a4eb0be9efb2e84bc80ca2bb4
2016-10-11 14:19:36 -07:00
Ed Sanders
605f7b625b
Hid category links in source edit mode
...
Change-Id: Ib44e393d3a8d070a4ced002a11cb26f58447e67c
2016-10-07 16:24:23 -04:00
jenkins-bot
7551b0e788
Merge "Use createTextNode in wikitext converter"
2016-10-06 23:20:21 +00:00
