Commit graph

20273 commits

Author SHA1 Message Date
jenkins-bot 7c0259a3c3 Merge "Handle temporary users when dealing with user preferences" 2023-05-05 15:55:49 +00:00
jenkins-bot d2d7a7886f Merge "Rephrase visual editor disable preference label" 2023-05-05 15:37:35 +00:00
Bartosz Dziewoński edec1ab393 Remove unused preferences code for "alpha" visual editor opt-in
Change-Id: I60601874f9442992c4f844304a842cf640f5b618
2023-05-05 16:22:46 +02:00
Bartosz Dziewoński 83d3d1f3ba Rephrase visual editor disable preference label
Visual editor is not in beta, and this preference is not temporary.

Change the message key to avoid outdated on-wiki overrides.

Unfortunately the internal preference name still has "betatempdisable"
in it. We should investigate renaming it later.

Bug: T197282
Change-Id: If1475a18474e85cd3a260224c738d087d472af70
2023-05-05 16:15:43 +02:00
Translation updater bot 2427ba1bde Localisation updates from https://translatewiki.net.
Change-Id: I5e8f948a97d69495c12750bce9911dfeffef3214
2023-05-05 10:41:29 +02:00
Bartosz Dziewoński c82ffc7dcd Update VE core submodule to master (abffa3e09)
New changes:
73ea114fa ve.init.Target: Fix actions toolbar teardown compatibility
fd1d6809f Update eslint-config-wikimedia to 0.25.0
36be98960 WindowAction: Allow users to specify a different fragment to the one currently selected

Bug: T335469
Change-Id: I53ee84bb7d19611ac19b949001b06e1769b3e13b
2023-05-04 18:02:38 +02:00
Bartosz Dziewoński 37ab4c2a80 Expose automatic temporary user info in the API
Depends-On: I62b4bb630decac92cbb8c7ddf00307df0dadb516
Bug: T332435
Change-Id: I84ce108b4d46b4e19fad032382f8b69a1b0065d5
2023-05-04 00:44:10 +02:00
jenkins-bot e85b565114 Merge "Update VE core submodule to master (985eb6da7)" 2023-05-03 16:05:47 +00:00
Sam Wilson 3658355cef Remove duplicated diff-mode selector in save dialog
The diff mode selector is now also being returned in the HTML
from the VisualEditorEdit API, but is already implemented
separately. This change just removes the element from the API's
HTML; it is perhaps not the cleanest, but it's not too far off
what is already being done for action=diff, and we want to get
a fix out for this bug as soon as we can.

Bug: T324759
Change-Id: I830b623963111f430640dd4d9a94639f753e4cda
2023-05-03 12:00:17 +08:00
jenkins-bot c2f79c7836 Merge "ApiVisualEditor: Support preloading from i18n messages" 2023-05-02 22:37:36 +00:00
Martin Urbanec c4839e21fb ApiVisualEditor: Support preloading from i18n messages
The `preload` parameter currently does not work with i18n
messages, as pages representing those messages are known, but
do not exist. Resolve this by running any NS_MEDIAWIKI page
through wfMessage() first.

This feature will be used by Personalized praise in GrowthExperiments,
which requires the preload from i18n messages capability. As a benefit,
it also makes it easier to create i18n'ed preload-based systems
(one can create MediaWiki:Foo, MediaWiki:Foo/cs and MediaWiki:Foo/de);
MediaWiki will select the best language version automatically.

MediaWiki core equivalent is uploaded as
I693bcaf71d7b8557c63538a426d7a6bd4c3edf3d.

Bug: T330337
Change-Id: I961ff7ae2263e61161e686107d80bdafa3fe3c32
2023-05-02 20:06:15 +02:00
Ed Sanders 83668ad512 Update VE core submodule to master (985eb6da7)
New changes:
10370c9fc Localisation updates from https://translatewiki.net.
3d5bdecff ve.ce.FocusableNode: Factor out getExtraHighlightClasses
d5f42c59e ve.init.Target: Add deprecation warning to #getActions
b23984a22 AUTHORS: Update for 2020–2023

Change-Id: I8e830fd10f75ecda28f13712245e55a04dbb19ea
2023-05-02 17:10:11 +01:00
Translation updater bot bef44229b0 Localisation updates from https://translatewiki.net.
Change-Id: I8d7af66df5c7153c3acf4568bc7268e4911a988a
2023-05-02 09:00:52 +02:00
jenkins-bot 0a28512624 Merge "Don't force the "view" flavor when using stashing!" 2023-05-01 13:46:25 +00:00
James D. Forrester 88fae93818 build: Upgrade api-testing from 1.5.0 to 1.6.0
Bug: T333134
Change-Id: Id660c24848a3c5cfbac71f5d7f0635c7bd90b913
2023-05-01 08:14:10 -04:00
Translation updater bot ea1ba707e9 Localisation updates from https://translatewiki.net.
Change-Id: I813a8579cdb2ede11575d297625e2cd034e21116
2023-05-01 09:58:50 +02:00
libraryupgrader 5a140d3af1 build: Updating eslint-config-wikimedia to 0.25.0
Change-Id: Ia7239b5750e51415c14145517c2a8d3c559fd895
2023-04-29 14:17:04 +00:00
jenkins-bot 86568aff16 Merge "Move the diff-mode selector to the new DifferenceEngineBeforeDiffTable hook" 2023-04-28 17:23:09 +00:00
jenkins-bot 0c88c0b639 Merge "lib: Drop promise-finally polyfill, now required by MW" 2023-04-28 14:37:44 +00:00
James D. Forrester a44cd6aea8 lib: Drop promise-finally polyfill, now required by MW
Follows-up Ia6cdb85d33d2b3e0e (c895c60907) from 2018. Was added to
support Chrome <= 64 within WMF CI at the time.

Change-Id: I870de7d148395926d60d8c360f8cae19ac7c4573
2023-04-28 14:01:13 +00:00
Bartosz Dziewoński 3b1a2d9dce Handle temporary users when dealing with user preferences
As temporary users will not have access to user preferences (T330815),
use cookies or localStorage to save them, like we already do for
logged-out users.

Also add some comments to point out where we intentionally distinguish
logged-out and temp users.

Bug: T332435
Change-Id: Ic83dd8bc8bc107f603a9b0340bd9e2bcaad8ff5a
2023-04-28 15:57:46 +02:00
Translation updater bot 9a87f0b353 Localisation updates from https://translatewiki.net.
Change-Id: I2809b8490de89b159ecdcf2a5f73861545856e9c
2023-04-28 08:57:48 +02:00
jenkins-bot 8f1ed26431 Merge "Log TransactionSquasher errors, in case any still occur" 2023-04-27 15:23:01 +00:00
jenkins-bot 26467c6cb4 Merge "Replace references to actionsToolbar" 2023-04-27 14:37:31 +00:00
Bartosz Dziewoński 51a8541255 Replace references to actionsToolbar
Target#actionsToolbar and Target#toolbar refer to the same object
since change dfaed62d3632d381db9682c603b3ddbeed182292 in VE/VE
(barring bugs like T335469). Once we no longer use the old name,
we'll be able to remove this backwards-compatibility alias.

Bug: T335469
Change-Id: I577e8ae6a857519eb0e8181543ca0a96b515e019
2023-04-27 15:51:35 +02:00
Translation updater bot 8cf5552b66 Localisation updates from https://translatewiki.net.
Change-Id: I9a87edaa517922527ed1d6ee4e078d0f31737e6d
2023-04-27 09:15:47 +02:00
libraryupgrader 9c99485fca build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.12.0 → 0.12.1

npm:
* grunt-eslint: 24.0.0 → 24.0.1

Change-Id: Ieeb1d06761805ff2f3e29c4d0977f515e0629d41
2023-04-27 01:04:37 +00:00
Ed Sanders 51759c3f7e Remove DiffPageEnable config option
Visual diffs are always enabled on history pages, there is no
long a need for this to be configurable.

Change-Id: I9cef558b2b9d32bc86c47f6a6095270220d036db
2023-04-26 17:05:57 +01:00
jenkins-bot 811fee005c Merge "Update moved class WikiMap" 2023-04-26 15:18:15 +00:00
Translation updater bot 175fa0d7ec Localisation updates from https://translatewiki.net.
Change-Id: I9959b5f6b7e2c5314ec55f7df9712ce565d33301
2023-04-26 08:44:25 +02:00
jenkins-bot b82f8283b9 Merge "Add test for MWTemplateSpecModel.getDocumentedParameterOrder" 2023-04-26 01:45:37 +00:00
thiemowmde 1a09676159 Add test for MWTemplateSpecModel.getDocumentedParameterOrder
It appears like this was never tested.

Now that it is covered it's much easier to play around with the
implementation and compact it a bit.

Change-Id: Ie9cc14082f69e7240380d352fb362d0a3fa4d341
2023-04-26 01:29:23 +00:00
jenkins-bot dda810c29d Merge "Update VE core submodule to master (35e9c8941)" 2023-04-25 17:06:28 +00:00
Bartosz Dziewoński 789d98266d Update VE core submodule to master (35e9c8941)
New changes:
4a1f1fcf1 ve.ce.Surface: Move other user selections to $selections overlay
e4f456b8e ve.ce.Surface: Create drawSelections method and use for deactivated selections
4868d26f0 Use new #drawSelections method for FindAndReplaceDialog
35e9c8941 ve.ce.Surface: Use #drawSelections for other users

Change-Id: Ib465c7816ea722c729bec8a75ef5cab8b90a1782
2023-04-25 18:47:08 +02:00
jenkins-bot 4d977ecebe Merge "Remove padding override from active external links" 2023-04-25 16:00:22 +00:00
gerritbot 5b8c2a3afa Update moved class WikiMap
See T321882. Moved in I60cf4b9ef02b9d5

Bug: T321681
Change-Id: If4a7ece606985b0e702288d1f3a08a270adcc760
2023-04-25 09:55:53 +00:00
Translation updater bot 9b3b9ee45e Localisation updates from https://translatewiki.net.
Change-Id: I1572d144f721878f326fbc4d24fd5ceb42e5984a
2023-04-25 08:48:50 +02:00
Bartosz Dziewoński d7521704a1 Remove some redundant PHPDoc comments
More could be done, but these are the ones that annoy me the most,
and I'm not willing to do more changes right now.

Change-Id: Ia02af09d631fea191e57da75420f0d2d1ed46c19
2023-04-24 21:11:26 +02:00
Ed Sanders fec0f4ecf5 Remove padding override from active external links
Since this was written, the specificity of the selector it was
overriding has increased, so isn't required any more.

Bug: T335292
Change-Id: Ib3494524f6ddfc2ea59d6d3d13a1a90138cd84af
2023-04-24 15:08:14 +01:00
Translation updater bot 1add952042 Localisation updates from https://translatewiki.net.
Change-Id: I1bd37533f49a0b4b779dcd709edc4c44bf22e5fb
2023-04-24 09:17:34 +02:00
jenkins-bot 115b4881e3 Merge "Minor documentation updates in the TemplateSpecModel class" 2023-04-23 12:31:33 +00:00
Bartosz Dziewoński f3b792f16f Log TransactionSquasher errors, in case any still occur
Bug: T333710
Change-Id: I49a0b22245307bb94de60776b5786732be72bf54
2023-04-22 10:16:12 +02:00
Bartosz Dziewoński 423feb6d99 Update VE core submodule to master (da7624d69)
New changes:
1a006f700 Allow attribute values that are reference types to compare equal
58d6eb28f TreeModifier: Check for inserting unbalanced open-close tag sequence

Bug: T333710
Bug: T334677
Change-Id: Ia59e7efa8ad6a9abf77bdee5d38dcd22a3d93dfe
2023-04-22 10:15:45 +02:00
Thiemo Kreuz 5b42d900cc Minor documentation updates in the TemplateSpecModel class
Change-Id: Idcbd600c1bee29c1ebdbc1acddbe9953b4e359a1
2023-04-21 16:16:22 +02:00
jenkins-bot 8cc29eca29 Merge "Fix template dialog when TemplateData contains empty parameter" 2023-04-21 13:14:54 +00:00
jenkins-bot 5c89247be9 Merge "Use new showPendingTakeover OutputPage method" 2023-04-21 13:11:54 +00:00
Sam Wilson 7dbe385773 Move the diff-mode selector to the new DifferenceEngineBeforeDiffTable hook
Use the new hook to add the diff-mode selector to the area directly before
the diff table.

Also toggles the new inline-diff legend, when the initial diff-type is 'inline'.

Depends-On: I6de30bf79eb5ac262285951792782b870d075e00
Bug: T324759
Change-Id: Ifc133856dd793693c3a2722a7b1319dfe74555a2
2023-04-21 16:03:16 +08:00
Translation updater bot b00e6a0996 Localisation updates from https://translatewiki.net.
Change-Id: I18dc19f7030296accf95d1df6eac220f736f83a4
2023-04-21 09:01:10 +02:00
jenkins-bot 9cb6f54d3b Merge "Remove the BetaFeatures integration for historical visual diffs" 2023-04-20 09:44:13 +00:00
jenkins-bot eab43d2025 Merge "Remove the "Report incorrect…" button on visual diffs in save dialog" 2023-04-20 09:44:10 +00:00