Ed Sanders
23267264ce
Load VE in read-only mode on protected pages
...
Bug: T53547
Depends-On: Ifaa74be266c048d87f94b4ae2df59cafc7aa155f
Change-Id: Ic90a0b86f45696a8782dec8e3d155ca91107b759
2019-02-22 19:09:23 +00:00
Ed Sanders
18907dde5a
Implementations for read-only mode
...
Depends-On: Ifaa74be266c048d87f94b4ae2df59cafc7aa155f
Change-Id: Iedd1bd9ce17750ad8528c1a053293c4a7321c5de
2019-02-22 18:20:51 +00:00
jenkins-bot
767614f0e1
Merge "ve.init.mw.ArticleTarget: Fix some doc comments"
2019-02-21 12:57:05 +00:00
Bartosz Dziewoński
0b1f445349
ve.init.mw.ArticleTarget: Fix some doc comments
...
Change-Id: I9d8b2553b40d56cf99bcd304c93d866b2a8ba77e
2019-02-20 22:46:39 +01:00
Ed Sanders
332aa1f3d2
build: Update eslint-config-wikimedia to 0.11.0
...
Change-Id: I5a294705eed1760e2d4dde33934d2ffb12e29525
2019-02-20 20:23:43 +00:00
jenkins-bot
8846e65e44
Merge "Support only surfacing part of the document"
2019-02-20 19:06:30 +00:00
Bartosz Dziewoński
1998a02b8e
ve.init.mw.ProgressBarWidget: Remove 'filter' property for IE 8 & 9
...
Per I7c083ff57db2fce9a06688d5801149253af6f6da this was only needed
for IE 8 & 9, which we don't support now.
Change-Id: I6e093b8ea6f8304ff296bb74297a465dd7334e07
2019-02-15 17:45:22 +01:00
Ed Sanders
3269d53632
Support only surfacing part of the document
...
Bug: T76541
Depends-On: I227a0d704b9b337cff2102d424be9795d6362ed7
Change-Id: Iac71a51c8696434658f24fbb41c8142237bd810e
2019-02-13 19:03:44 +00:00
Ed Sanders
bc02c44d36
rootNode/documentNode -> attachedRootNode
...
Change-Id: I56bb10749cac04e17ace2781b4d693ec5f522e7c
2019-02-13 19:03:36 +00:00
Bartosz Dziewoński
7b2bd6be09
ve.init.mw.MobileArticleTarget: Better match surface top spacing to read mode
...
Using margin instead of padding allows the surface margins to collapse
with the margins of first/last paragraph inside the surface, like they
do in read mode. This fixes the slight jump seen in T210630#4949865.
Bug: T210630
Change-Id: I69d4d4bd9390a1007bc40cda9e78a6b3e7a1bd1d
2019-02-13 13:37:31 +01:00
Bartosz Dziewoński
7fedb7be07
ve.init.mw.MobileArticleTarget: Change "back" tool icon from "<" to "x"
...
Icon name changed from 'previous' to 'close'.
This matches MobileFrontend's wikitext editor and other overlays.
Bug: T210630
Change-Id: I5f588c65887dd2247d3f816959807f943215e0c3
2019-02-13 00:29:24 +01:00
Bartosz Dziewoński
1faf0b00fa
Filter out duplicate categories in NWE preview
...
Use them as object keys, which naturally deduplicates the entries.
Bug: T214811
Change-Id: I6159021b95d78b1a163faebb289578d277ff110d
2019-02-12 19:18:09 +01:00
Roan Kattouw
b15f819fdf
ve.init.mw.Platform: Migrate away from deprecated specialCharacters API
...
Use require('mediawiki.language.specialCharacters') instead of
mw.language.specialCharacters.
Change-Id: I9cf525a1e1aadc12d72284d08b98882b0ab95f5e
2019-02-08 16:59:25 -08:00
jenkins-bot
d2fe2f7f8d
Merge "DesktopArticleTarget: Make the progress bar into a reusable widget"
2019-02-06 22:37:28 +00:00
jenkins-bot
72aff8c16a
Merge "mw.Platform.setUserConfig: Don't try to set for logged-out users, it doesn't"
2019-02-06 21:43:40 +00:00
Bartosz Dziewoński
6e076b3b6c
DesktopArticleTarget: Make the progress bar into a reusable widget
...
We want to add a similar progress bar on mobile without copy-pasting
all this code.
Bug: T210630
Change-Id: I7192869cb719114ffd04940eabf38cf0f0421c13
2019-02-06 22:20:37 +01:00
Bartosz Dziewoński
cb09d6a54d
DesktopArticleTarget: Fix position of progress bar if editor is reloaded
...
Change-Id: I5f181a9516ff64988aa67e54ebd342c56e4b7e70
2019-02-06 02:11:48 +01:00
Bartosz Dziewoński
28950a8b5c
DesktopArticleTarget: Match NWE toolbarPlaceholder height to real toolbar
...
Toolbar was made bigger in If5722df41e75a1d4bdf8afc83c81670d1be3a1b8.
Change-Id: Id85869e6ad0bfad1acebda3a64bab5328de3932d
2019-02-06 02:11:48 +01:00
James D. Forrester
3ab699f6ed
mw.Platform.setUserConfig: Don't try to set for logged-out users, it doesn't
...
Bug: T214963
Change-Id: Idc61685b6087c0fe0082bd0b039f2f454ca92970
2019-02-01 20:50:58 -08:00
David Lynch
f7fe245018
trackSubscriber: don't track activity here on mobile
...
Mobile needs to use a different sessionid
Change-Id: Iffac3d523b4c5774a23ddbe1a2d7ee380ac1b012
2019-01-31 01:22:28 +00:00
Bartosz Dziewoński
3dbff552dc
ve.init.mw.Target: Remove unused property
...
Unused since 6e64fba2f8
2019-01-24 21:05:48 +01:00
Ed Sanders
5461c56380
stylelint: Enforce class name pattern
...
Change-Id: Ia41a08424f840d353eb7fc213815f7992da4a2ef
2019-01-13 15:14:53 +00:00
Ed Sanders
74f6c4899c
build: Update eslint-config-wikimedia to 0.10.0
...
Change-Id: I63a0ebf0b31a0d5d4e680a4e2a5a0be4850be165
2019-01-08 17:00:09 +00:00
David Chan
0d362040bd
Update VE core module to master (469c6340e)
...
New changes:
6515e03e1 ve.ce.Surface: Rearrange #findBlockSlug test to check other cases
cbfdc8570 Localisation updates from https://translatewiki.net .
708ba0557 Prevent block slugs from overlapping floated elements
3703fd66d Separate the concept of a document node and a root node in CSS
Bug: T211844
Change-Id: Ia86cf9b23e561d3c32601d41c1bc5a9824e9953c
2019-01-06 07:47:17 +08:00
James D. Forrester
3c293ea00c
doc: Bump copyright year for 2019
...
Change-Id: I8991b97c980d4149f53eb5601036220ef3c0c440
2019-01-01 13:24:23 +00:00
Bartosz Dziewoński
0bd9270b3f
ve.init.mw.MobileArticleTarget: Remove unnecessary override
...
This is included in OOUI styles since OOUI 0.30.0.
Change-Id: Ic45e507fed5a40cfc3497551d1be396e1b2f3d5b
2018-12-24 10:06:37 +01:00
Ed Sanders
cdb238cfde
Remove document padding resets, upstreamed
...
Depends-On: I53307c931ad24b5ba76503c1dedd1109205b73c5
Change-Id: Id8632a3205d284d8091cae4d431be4faf7e6362b
2018-12-17 13:36:47 +00:00
Ed Sanders
ad5b8f99ee
Replace $( 'body' ) with $( document.body )
...
Better to use the actual element rather than a string selector.
Change-Id: I7d2c08cf1e3c6f14be5bf65ac040b7cdfdd8c594
2018-12-13 16:44:25 +00:00
jenkins-bot
a5be866ba3
Merge "Allow trackdebug to work independently of debug"
2018-12-11 16:44:45 +00:00
Ed Sanders
3e10592ab7
Allow trackdebug to work independently of debug
...
Bug: T211698
Change-Id: I28f4fa4d516195e5459484c5d3df1b0566357a25
2018-12-11 16:13:06 +00:00
Ed Sanders
ec42733225
Rewrite DOM junk filter as array concatenation
...
Avoids regressions like If399319b2675ac8c.
Change-Id: I43851931e3b9ee461abd0cfce0627bfb6a2bd041
2018-12-11 15:23:37 +00:00
Bartosz Dziewoński
27fdbe0581
Fix filtering out .donut-container again
...
Follow-up to a5c5176333
2018-12-11 01:12:35 +01:00
jenkins-bot
e0edd25855
Merge "Drop EducationProgram hacks, now that it's undeployed"
2018-12-07 19:50:21 +00:00
Bartosz Dziewoński
0f05dafa6f
Make SaveErrorHandler receive entire API response
...
Previously we passed either data.visualeditoredit.edit or data.error,
which was mostly okay since they are mutually exclusive, but it could
still theoretically conflict if both objects had identical properties
(and receiving different things could make debugging errors harder).
Change-Id: I818d916275b8451af6910ddaa7cd4d7c653085ee
2018-12-07 14:17:16 -05:00
James D. Forrester
dab9c26c4d
Drop EducationProgram hacks, now that it's undeployed
...
Change-Id: I65030e3e1b5ce006a458cfbe65a97e738a00a4c3
2018-12-06 12:14:03 -08:00
Ed Sanders
278789e27d
Remove TitleBlacklist handling code
...
This has been moved to the TitleBlacklist extension.
Bug: T211242
Change-Id: Ia15c2619e6c642b3ceb567c28f77b50ccf41731a
Depends-On: Ibaf8a37f1aaef510923bde5ed9114f1f00fff461
2018-12-06 15:00:06 -05:00
Ed Sanders
be548979fe
Pass error data to SaveErrorHandler on error
...
Change-Id: I9d7efbecfd954acff86f279f75aa80a9fcc10c89
2018-12-06 14:59:30 -05:00
jenkins-bot
1684f2ef0c
Merge "ve.init.mw.SaveErrorHandler: Correct code comments"
2018-12-05 22:24:35 +00:00
Bartosz Dziewoński
9177974c28
ve.init.mw.SaveErrorHandler: Correct code comments
...
Change-Id: I6e3a883b8c2600953da038aa4ad3601258e1d87d
2018-12-05 16:37:13 -05:00
Ed Sanders
be9c6800ad
Audit target hooks
...
* Move (de)activationComplete up to ArticleTarget
* Mark (de)activate to be deprecated in the future
* Fix some properties to ensure target.edited is boolean
Change-Id: Ie34139cb68f90f34eb243f1bb964ef578e90dfb2
2018-12-05 15:45:19 -05:00
jenkins-bot
d8cbff898b
Merge "Guard against Target#teardown being called twice"
2018-12-05 17:49:26 +00:00
Ed Sanders
a89908d58a
Guard against Target#teardown being called twice
...
Change-Id: Ifa8328ee865fadd6ddaf6b35b5ee34284068b620
Depends-On: Icef5b34abd40bfd21aac71a705ef21f6277d21a5
2018-12-05 11:11:09 -05:00
jenkins-bot
f583a0fb6a
Merge "Move ve.init.mw.saveErrorHandlerFactory and fix documentation"
2018-12-04 23:34:05 +00:00
jenkins-bot
a6b64b6b46
Merge "Remove AbuseFilter & SpamBlacklist code"
2018-12-04 23:03:29 +00:00
Ed Sanders
1ee9a739a1
Move ve.init.mw.saveErrorHandlerFactory and fix documentation
...
Change-Id: Icc8a4d1daf17a1a4cd0d7b2ad97f61916f2a222e
2018-12-04 17:55:35 -05:00
jenkins-bot
710aaced4b
Merge "build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass"
2018-12-04 14:59:06 +00:00
jenkins-bot
df125c3303
Merge "trackSubscriber: Set timing property to a number, not an object"
2018-12-04 00:07:53 +00:00
Roan Kattouw
611d9ca6c5
trackSubscriber: Set timing property to a number, not an object
...
The timing variable is a private closure variable containing an object
that tracks the timestamps of different events in the current cycle. The
duration variable is the result of using that information to compute the
difference between the current timestamp and the relevant anchor
timestamp. For the '_timing' property in the EventLogging data, duration
is the correct value, not timing.
(This is confusing and we should probably rename the timing variable.)
Change-Id: Iff78eb0ab83c84b73ad5c8f3eb85b1c7f120ebef
Follows-Up: Ifc2135d99f4bec917dac60992098958b72c37fc6
2018-12-03 15:33:18 -08:00
James D. Forrester
309d05cb38
build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass
...
Change-Id: I4c547757ed5a32ff98b1cf2670010db302bd8467
2018-12-03 13:06:59 -08:00
Ed Sanders
103a34bb75
Remove AbuseFilter & SpamBlacklist code
...
Moved to their respective extensions
Change-Id: If463068a862cfde15ab4d250a1424c88a5229176
Depends-On: Ib1354f0404209a15194895026ff9d179d16b1900
Depends-On: I1807a5d3d99ecab2bf4545a1bab3aa3f2ae64da8
2018-12-01 14:03:11 +00:00
