MWEntityNode representing is now displayed with a light
grey background and has a tooltip explaining that this is a
non-breaking space and not a random grey blotch.
This is not done for TextNode (in core VisualEditor), as that doesn't
actually work: Parsoid converts all in input to regular spaces.
It's still not easily possible to insert a non-breaking space.
Bug: T96666
Change-Id: Icbdf7cc3e5d675b199d08777a3439dc5dedceac1
Previous, reverted attempt: da9b6fffbd.
This attempt also includes 6037fefbe0,
and fixes minor conflicts with other changes.
* In normal images, parse relative 'href' attributes instead of
expanding them to absolute. This resolves Parsoid generating
|link= options for copy-pasted images (T193253).
Keep them in the underscore-form to avoid causing dirty diffs like
T237040 again. Unlike in the previous attempt, we don't need to be
super-careful about the 'resource' attribute, thanks to the Parsoid
changes in T108504.
* In gallery images stuff, prefix the 'resource' attribute with './',
same as normal images do. This causes no functional changes, but it
makes updating tests easier, and the consistency is probably good.
* Update test examples to also prefix 'resource' and relative 'href'
attributes with './', like the real Parsoid does.
Bug: T193253
Change-Id: I91131728a87c9406bf069d46d3c94c9a8905a003
New changes:
06a44681a Fix referencesListDiff variable names
eb70fd2df Localisation updates from https://translatewiki.net.
7ea4efb7c build: Upgrade eslint-config-wikimedia from 0.17.0 to 0.18.0 and make pass
becd23d48 Show ref list diffs which aren't found in the document
Bug: T272813
Change-Id: I5378230b3a86a91e67a2cfcba9e6f8ce1798c3ab
We need the whole DM doc to show reference diffs
correctly. We can filter down to the active section
after the conversion like we do with the editor.
Bug: T272813
Change-Id: I2081dd520ff414caadaed2efda955d600953c957
New changes:
c17816c5f Diff sidebar: Make font size slightly smaller
f8439f4cc Deep-freeze linear data
a8919f78e Deep-freeze linear data added by transactions
Local changes:
Fixes for deep-frozen linear model
Bug: T119236
Change-Id: Iae4362c8dab0f2bd335e24498f3e0522b8b1d4fc
New changes:
4589f5f00 Clear node offset cache when leaving read-only mode
68b0f8372 Show attribute changes as diffs when appropriate
Local changes:
Pull through for Ic6ec7f5ebabc912235ff7e688425f415f2c3ff20
Bug: T272603
Change-Id: I574fc56799ed165e63e16881429c4ed740850234
The conversion to a DM doc and subsequent cleanup is a generally
useful step that should be available as its own method.
Change-Id: Ia53c0a641b231bb81c25c011624357acf4dc42a3
New changes:
b92ce3445 Add missing check for move=null in internal list diff
f503f6aa9 Deduplicate logic for marking data/HTMLElement as moved
36e21385b Create a separate descriptionItemsStack for each reflist
Bug: T272314
Bug: T272315
Depends-On: I9a73d0e0ee3c8b12e0b5c3202eb5882258539920
Change-Id: Idcd11e864cde5ff3dab52898b9ce1f3797c69424
New changes:
5def0c76c setNullSelection: don't clear a selection outside the surface
da7ee751f Localisation updates from https://translatewiki.net.
af8193cf6 Cache offset keys used in adjustmentTree's adjustmentNodes
Bug: T272219
Change-Id: Ied5afcb46b7d75ecdcbd9ab5464ef1d1d6070c72
A couple of things make this quite a simple change:
* Most messages are generated from a single message key
* $title->getEditNotices() already returns an array
keyed in the same way, we just currently flatten it.
* The VE client already flattens the array immediately
in ArticleTarget#parseMetadata, so no change required.
* PHP preserves the order in which keys are added, not
that notice order is particularly important.
This partially undoes c824dc383a,
which changed the format from a mixed array to an indexed array.
Bug: T272188
Change-Id: I646667fe2513e371e0c8270761553253d1abe2b6
This was used when we used to pass API errors to showMessage, but
is now unused by the two remaining users (missing edit summary, and
"press ctrl+enter to submit").
Change-Id: I8a6b4db78d4e451cf3ec85fcdfd8293328aaaa3c
* Remove custom internal events in ArticleTarget for every error type.
The indirection was just making it harder to figure out what data
goes where.
* Centralize the actual logging in ArticleTarget, instead of doing it
in a dozen methods.
* Directly use the error code from the API for 'save_failure_message'.
Previously we'd lose the original error code and generate a new one
in the event indirection stuff, except for 'responseUnknown'.
* Update 'save_failure_type' map. Remove unused error codes, update
the ones that changed, and sort in the order in which the types are
listed on the schema page.
Bug: T272162
Change-Id: Ied602c456f4b0e7e9bb135e3200bec5ce65641ba
New changes:
2f20d3082 Localisation updates from https://translatewiki.net.
0bf82047b stripMetaLoadInfo: Call earlier, and use ve.copy instead of ve.cloneObject
462eee058 Update UnicodeJS to v13.0.2
Change-Id: I48630eac248a068d1e39d5b57892b4a3ac5cf35e
New changes:
dfa40a4a4 Localisation updates from https://translatewiki.net.
5324b686a Localisation updates from https://translatewiki.net.
ad72a726d Don't do whitespace substitutions in hasSignificantWhitespace nodes
Bug: T271198
Change-Id: Id5f6647cf95181f4898e0ff48bd61250fa957202
