Commit graph

9567 commits

Author SHA1 Message Date
jenkins-bot 720b97694e Merge "Change mid-upload 'cancel' button to 'back'" 2016-09-26 18:34:38 +00:00
jenkins-bot d9ed33208a Merge "MWAceEditorWidget: Configure Ace with its base path" 2016-09-26 13:50:42 +00:00
Derk-Jan Hartman 148c6b53b4 MWAceEditorWidget: Configure Ace with its base path
Configure the basePath for Ace, so that its own loader knows from where
to lazy-load additional resources. This will enable all known modes and
the worker scripts for linting.

Bug: T124419
Change-Id: Ie71518917ab966743e8397b23ffb050ca47e9ff4
2016-09-26 14:54:42 +02:00
Translation updater bot 2cb81c9973 Localisation updates from https://translatewiki.net.
Change-Id: I2a10ed479e33d9e37a3d90036d746f5b88b67b7a
2016-09-24 22:43:19 +02:00
Alex Monk d0abe11aca NWE: Don't show button to switch to VE if it isn't available
Bug: T146182
Change-Id: I4bd039726ebccfd4351ecc68e6d7662752412d1b
2016-09-24 02:43:38 +01:00
Translation updater bot c302e0804f Localisation updates from https://translatewiki.net.
Change-Id: I8052278bd63e4093cf4a84361fb116c232263ad8
2016-09-23 22:37:08 +02:00
Translation updater bot df68db60ab Localisation updates from https://translatewiki.net.
Change-Id: Ibab4cd837a2e55e65ad8bb1bd5acdb434811de45
2016-09-22 23:43:10 +02:00
David Lynch d28819f795 ui.MWLinkAnnotationInspector: skip internal link checking if the value has changed
If the value has changed since the event was fired, we're operating on old
data, *and* another event will have been fired for that change anyway. So
abort this check.

Bug: T146306
Change-Id: Ia6682ec0218fd3fbc573582753d815a56963eb71
2016-09-22 11:23:48 -05:00
jenkins-bot 80618cc629 Merge "dm.MWInternalLinkAnnotation: Fix href normalization for special characters" 2016-09-22 16:19:12 +00:00
Roan Kattouw bb45d984ca dm.MWInternalLinkAnnotation: Fix href normalization for special characters
<a href="Foo%3F"> would dirty-diff to <a href="Foo?"> and also render
as such, pointing to the wrong page.

We also called decodeURIComponent() on the href twice, which can't
have been good.

Move URI decoding and underscore normalization into
getTargetDataFromHref(), and add rawTitle for callers that need it.
Put rawTitle in the origTitle attribute, so that equivalence
comparisons (decode(origTitle) === title) work as intended.

Bug: T145978
Change-Id: I29331a4ab0f8f7ef059c109f6813fa670a2c7390
2016-09-22 09:10:41 -07:00
Matthias Mullie 2b4948b0b6 Change mid-upload 'cancel' button to 'back'
Bug: T114938
Change-Id: I964708e1267223b181630b9bea5b19e2bdf242be
2016-09-22 16:13:57 +02:00
jenkins-bot 6d583291bb Merge "Only unregister WT string handler in WT handler factory" 2016-09-22 04:09:18 +00:00
jenkins-bot a44a4d402e Merge "ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP" 2016-09-22 03:01:54 +00:00
Ed Sanders d8fb7b84d3 Only unregister WT string handler in WT handler factory
Bug: T144653
Change-Id: I91528b56ac3905a05e8da51455055537958e026e
2016-09-21 13:08:10 -07:00
David Lynch 5bc54fd036 dm.MWInternalLinkAnnotation: Add some test cases
Change-Id: Ie338d5538959ea2cc296886b623e9dc2cd84fa8f
2016-09-21 09:57:45 -07:00
Ed Sanders 4c8a97f9e8 Temporarily override broken toolbar border colour
Will be fixed in the next OOUI release via I91862c2e609.

Change-Id: I741bb8d5396bed256ee1907eaa4ba86e4697f325
2016-09-20 22:51:02 -07:00
Alex Monk 2b8cd0fa13 Pass document to preview through PST
Change-Id: I2712c26c94cf62f8ec8e68a9912e6a557f41f6a4
2016-09-20 18:11:42 -07:00
Alex Monk 8a80b5bbc3 Split isAvailable from visual-specific checks
Not fully tested

Bug: T146182
Change-Id: I5d7ae6e49991660ecdc2daf46b319947f83a1018
2016-09-20 23:53:53 +01:00
jenkins-bot 089e22ff6c Merge "(attempt to) make NWE work with SET" 2016-09-20 22:45:14 +00:00
Alex Monk 63fcefcfcd Education popup: Put localStorage check inside try/catch
Bug: T146139
Change-Id: I5faf5f4fce2f3161ad62d3617d1bb1d750a44728
2016-09-20 22:04:53 +01:00
Translation updater bot 7888fd05e5 Localisation updates from https://translatewiki.net.
Change-Id: I3a2e09923e60fecf9d3b57f01ad00585bd6e7b17
2016-09-20 22:41:42 +02:00
jenkins-bot 80e2b62c69 Merge "Simplify and fix category popup widget checks" 2016-09-20 01:00:17 +00:00
jenkins-bot f6b7c64e92 Merge "Open meta dialog to edit categories when user clicks on the category footer" 2016-09-20 00:58:29 +00:00
Volker E ecab9df8bb Update progressive color to WCAG 2.0 level AA compliant color palette
Aligning instances of `progressive` color to WCAG 2.0 level AA compliant
color palette similar to changes in
I6fdb90af8b9dc5e5e026eb0c1bd13138c73da4cd

Change-Id: I2eda190f0a68de6dc8aa33724f2c8975327a061f
2016-09-19 15:25:45 -07:00
Translation updater bot 7c3021dc88 Localisation updates from https://translatewiki.net.
Change-Id: I1fd2d120d3d595d4b1ce63e055fb61b82ed60273
2016-09-19 23:02:54 +02:00
Alex Monk 0c07caafc7 Open meta dialog to edit categories when user clicks on the category footer
Bug: T145267
Change-Id: Ie88c4d9c6327baffdb83c1affbc0515a68c0fc03
2016-09-19 21:35:45 +01:00
jenkins-bot 376a4520ea Merge "Use correct switch type when opening welcome dialog on NWE" 2016-09-19 18:16:59 +00:00
jenkins-bot 29ff6c43ef Merge "DesktopArticleTarget: Save scroll position before transformPage" 2016-09-19 17:00:00 +00:00
Translation updater bot 3af6091a58 Localisation updates from https://translatewiki.net.
Change-Id: I651c1febf65af00a07103806f428aacc4ef00648
2016-09-17 23:23:29 +02:00
Roan Kattouw cc8ca8e738 DesktopArticleTarget: Save scroll position before transformPage
transformPage() makes significant changes to the DOM, so measuring the
scroll position synchronously right after that results in a slow forced reflow.
Instead, measure the scroll position before reorganizing half the DOM.

Change-Id: I3baee5c11ca228696ddbfb30789745f5f0faa20a
2016-09-17 00:12:39 -07:00
Alex Monk edf5b60368 (attempt to) make NWE work with SET
Ugh.

Bug: T143578
Change-Id: I71e08508eb0914be9d624202b13a4369df512b80
2016-09-17 03:36:47 +01:00
Željko Filipin f3f432e722 Disable failing Selenium tests
The tests are failing with RSpec::Expectations::ExpectationNotMetError
for 2-3 days in a row.

Bug: T145861
Change-Id: Ieec2a67857b90033cdd0ddf63025d2af9de504a5
2016-09-16 13:12:02 +02:00
Translation updater bot d4177b929d Localisation updates from https://translatewiki.net.
Change-Id: I5caaa5d69075922483a3c354d921ceb34517b9bd
2016-09-15 23:05:10 +02:00
Alex Monk 926212dbae Use correct switch type when opening welcome dialog on NWE
Bug: T145225
Change-Id: I032652733576d1a9797cc3dbb3dd24ca69cb30e5
2016-09-15 01:30:01 +01:00
Translation updater bot 1d297d8bc1 Localisation updates from https://translatewiki.net.
Change-Id: I0c5603dd7f98780c10fb58a4a357a3bbc5f702b6
2016-09-14 22:38:50 +02:00
jenkins-bot f0a819455e Merge "Load icons where we can via RLIM" 2016-09-13 21:21:22 +00:00
Translation updater bot ce77acda5a Localisation updates from https://translatewiki.net.
Change-Id: I6d8b7495b94acacad438abb949d5c8573bd80ea4
2016-09-13 22:58:14 +02:00
Alex Monk 7888c688b7 Simplify and fix category popup widget checks
Bug: T86357
Change-Id: I9a85267f6da0077e2167a92f25a8dc41074e6548
2016-09-13 04:17:20 +01:00
jenkins-bot 9721998763 Merge "Provide the new wikitext editor as a beta feature" 2016-09-13 00:56:48 +00:00
Translation updater bot 049d059b50 Localisation updates from https://translatewiki.net.
Change-Id: I8aace5f4a8d6b59dd9d58ec01ead7397f2a98d61
2016-09-12 23:10:02 +02:00
Bartosz Dziewoński 2b1c3914ec ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP
Bug: T143279
Depends-On: Ic93d733cb9e1b1d7301f8975c68ab7ded778845a
Depends-On: I24c2819ec2adcab468f961c5c46b31c331324567 (for CA wikis)
Depends-On: I372e7bdff35400287b3d961da979d6f094d13bd9 (for CA wikis)
Change-Id: I14a1e5c9956d1b425eaacdf358db384df3be8115
2016-09-12 18:38:58 +00:00
jenkins-bot 645c947359 Merge "Move image-paste blocking to transfer handler match function" 2016-09-12 15:55:19 +00:00
Translation updater bot 590e144686 Localisation updates from https://translatewiki.net.
Change-Id: Ied64da27763dd6c9ad790c0c0a28ce4648bc6e1d
2016-09-11 22:53:57 +02:00
Translation updater bot 0f7fb468fa Localisation updates from https://translatewiki.net.
Change-Id: Icc3cb3d9ca0628e21ef2855f268caf3e7895bd61
2016-09-10 23:31:58 +02:00
James D. Forrester da422b18d5 Load icons where we can via RLIM
This gets us the variants (which we need for OOUI 0.17.9); note that I've
cheated and used 0.17.9's colour for the MediaWiki theme's progressive flag
rather than 0.17.8's value of 347bff.

Change-Id: Ic436970e9298ea31f48c6cfdd04b80847aaebbee
2016-09-09 18:10:56 -07:00
Translation updater bot 0d0f13f429 Localisation updates from https://translatewiki.net.
Change-Id: Ida1853cd7f0da6d3da7bcf19091932c62e3e2f8e
2016-09-09 23:00:32 +02:00
L10n-bot 229bd7de08 Merge "Localisation updates from https://translatewiki.net." 2016-09-08 21:49:00 +00:00
Translation updater bot c994dc216f Localisation updates from https://translatewiki.net.
Change-Id: I3605539ec3980896387c2413e71dd0a6c0237884
2016-09-08 23:49:06 +02:00
James D. Forrester feeb2c3906 ve.init.mw.Target: Drop <noscript> tags on serialisation
These aren't in the Parsoid HTML spec., so there's no valid way that they would
be in the original document from upstream, and we don't—at least intentionally—
allow users to insert them, so we can safely assume that they're resulting from
browser extensions and other items inserting content into anything that sort-of
looks like an HTML page.

Bug: T144891
Change-Id: I330ae05cd53eee5c18b18ad744ea0ec7b2eb09cc
2016-09-08 14:13:11 -07:00
James D. Forrester 1d64e3280c Provide the new wikitext editor as a beta feature
Still needs to be de-feature-flagged later.

Bug: T142644
Change-Id: I8e2588909ff95085b5a4d58f4394d9bc805f5598
2016-09-08 00:38:08 +00:00
Ed Sanders 5e22ef30fe Add show preview to save dialog when in NWE
Bug: T142642
Change-Id: I679eaddfe9037dcf258d3ff7d1eaa44214f0e730
2016-09-07 21:35:49 +00:00
jenkins-bot 8ff3ea60ec Merge "Cleanup getDocToSave API and use in source mode" 2016-09-07 21:31:19 +00:00
Translation updater bot 22875eaa27 Localisation updates from https://translatewiki.net.
Change-Id: I83408d6d2009cc39f4d1a1c3bc89ec201046d645
2016-09-07 22:47:09 +02:00
Ed Sanders d0bb5511a5 Cleanup getDocToSave API and use in source mode
Instead of getting wikitext from the HTML, which is probably
slower and leads to issues with the whitespace stripping hack,
override getDocToSave and get text from the linmod directly.

Bug: T144621
Change-Id: I6b6cf16ee8f3720398ba8f5c85e7715c2e68329f
2016-09-07 12:09:41 -07:00
jenkins-bot 4fbe06a15c Merge "Fix parent constructor call" 2016-09-07 02:50:03 +00:00
Ed Sanders 7a80fa57bc Fix parent constructor call
Got broken in switch to using 'super'.

Change-Id: Icea95b49ad48849af857bfa3b301d3bcf6039036
2016-09-06 19:16:24 -07:00
Ed Sanders 3c25f3aede Switch from NWE to VE using 'Edit' tab
Bug: T143577
Change-Id: I19d942c879c9ccf70e95beb5f8de589eb6363039
2016-09-06 17:23:24 -07:00
Translation updater bot ed54a4b676 Localisation updates from https://translatewiki.net.
Change-Id: I9ba021a347e63a3d9c923c5bec79d6ddeaabef9b
2016-09-06 22:47:45 +02:00
jenkins-bot 255fedba60 Merge "Search all RDFa attributes when looking for type" 2016-09-06 16:42:28 +00:00
jenkins-bot 06ca8ea7ba Merge "Disable veaction=editsource if NWE is disabled" 2016-09-06 15:52:27 +00:00
jenkins-bot c0b49e728f Merge "Make VE<->NWE switching progress bars non-cancellable and labelled" 2016-09-05 21:51:53 +00:00
Translation updater bot 620e073853 Localisation updates from https://translatewiki.net.
Change-Id: I1ea0ab3e8a05c69021aaf4875b4d50b9cf6e780a
2016-09-05 22:46:29 +02:00
Translation updater bot fa74ca1b12 Localisation updates from https://translatewiki.net.
Change-Id: I59d000170b0edce2f8e09ea5e99619517df3401c
2016-09-04 22:34:11 +02:00
Translation updater bot 7d733ff49c Localisation updates from https://translatewiki.net.
Change-Id: Iff76313d140f15e3e1c5f0e0b38a6a8baa49f90f
2016-09-04 00:25:40 +02:00
Ed Sanders 7b3deab5a1 Disable veaction=editsource if NWE is disabled
Bug: T144651
Change-Id: I6a1e42b2da267bc42adeee0c818046eab0b387f8
2016-09-02 17:55:37 -07:00
Ed Sanders edadf530e1 Make VE<->NWE switching progress bars non-cancellable and labelled
Soft dependency on Ifa41578164 in core to support the
non-cancellable flag.

Bug: T143582
Change-Id: I886a8f5ca90737938e4c0fedb2b456d851a12326
2016-09-02 16:47:17 -07:00
Ed Sanders adaa47804f Search all RDFa attributes when looking for type
Bug: T144561
Change-Id: Ib42daa52796cd72babbd8a317bae948cff779c99
2016-09-02 16:43:30 -07:00
Translation updater bot 18b057d984 Localisation updates from https://translatewiki.net.
Change-Id: Ifca681562c1834d3df710c29c405d62c4400c62e
2016-09-02 22:58:44 +02:00
jenkins-bot feb756dfb1 Merge "Update tab and history state when switching between NWE & VE" 2016-09-02 20:43:32 +00:00
Ed Sanders e3dcf029ce Update tab and history state when switching between NWE & VE
Bug: T143577
Change-Id: I729c0f4a8131f54f81be2d776bddf3020a21e704
2016-09-02 19:31:35 +00:00
Translation updater bot 1a60f06623 Localisation updates from https://translatewiki.net.
Change-Id: Ic34dabbe76174f46e403d7287a3359d20c9c367f
2016-09-01 23:28:29 +02:00
jenkins-bot 69b7a262ec Merge "Follow-up 51dd790 & c40070b: Drop T135171 debug tracking" 2016-09-01 19:26:14 +00:00
jenkins-bot b656f3d5f1 Merge "Use super property to call parent methods" 2016-09-01 17:04:39 +00:00
jenkins-bot dcbb8e2e90 Merge "Fix restoration of redirect HTML after exiting without saving" 2016-09-01 16:12:05 +00:00
Alex Monk d907e973fd DesktopWikitextArticleTarget#switchToVisualEditor: Use correct revision ID property
So we ensure we send the actual revision ID, not potentially undefined, to the
method. If we send undefined, it'll give us an etag for revision number 0...
And that will cause issues when we later attempt (in a future editor switch) to
pass an etag for revision 0 along with the correct revision.

Bug: T143920
Change-Id: I0c27956abdd26ae4f5f1b91010a5eab8ee0354ab
2016-09-01 02:45:22 +01:00
Translation updater bot 355f16e0b9 Localisation updates from https://translatewiki.net.
Change-Id: I4211dc8f05263175d5dbdd4a031c050f08505c14
2016-08-31 22:39:03 +02:00
jenkins-bot 572e7375d7 Merge "Preserve data when switching from NWE to VE" 2016-08-30 23:33:43 +00:00
Translation updater bot 9151afca86 Localisation updates from https://translatewiki.net.
Change-Id: I3ddd0d7432427ef021cf30e44a9750b4fd5dcabb
2016-08-30 23:05:20 +02:00
Translation updater bot aa3dcd35b3 Localisation updates from https://translatewiki.net.
Change-Id: I3b0565e6b6690091bdacf4b6759f4aa43530f64b
2016-08-29 22:41:25 +02:00
James D. Forrester ba4532aa9d Rename EditButtonPublishNotSave to EditSubmitButtonLabelPublish
Depends-On: I4fbe54876095378a476399bf5e336c8df3e91e14
Change-Id: Iface24f77775216a0ab9eb464e7e10624af7719d
2016-08-29 10:46:49 -07:00
Translation updater bot fb16967972 Localisation updates from https://translatewiki.net.
Change-Id: Ie985146be37405dd3a37e91f321b35f49446c44f
2016-08-28 22:43:43 +02:00
Translation updater bot 0559a1ba4e Localisation updates from https://translatewiki.net.
Change-Id: I1dece529d19466a72af1dffdbaa0954a38bc93d9
2016-08-27 23:29:02 +02:00
Translation updater bot 990ce5b345 Localisation updates from https://translatewiki.net.
Change-Id: I57242c6dd7e6da74bf5753b3e5441c3094b04a17
2016-08-26 22:35:15 +02:00
Ed Sanders 56c56e81fe Move image-paste blocking to transfer handler match function
By not matching, we allow other types of paste to happen, e.g. HTML/plain text.

Bug: T142622
Change-Id: I3a2224ab23b5073eb7b031134ecc3170ccc782c0
2016-08-26 00:54:39 +00:00
jenkins-bot f071b0380d Merge "Vary the 'save' labels to 'publish' for public wikis" 2016-08-25 21:36:41 +00:00
Translation updater bot 5af089bc13 Localisation updates from https://translatewiki.net.
Change-Id: Ieb87b5a04ece4b7931a8e9def6b5c8da3e1e5043
2016-08-25 22:40:56 +02:00
jenkins-bot 3063a9f23e Merge "init: Discard attempts to activate while we're already activating" 2016-08-25 20:12:45 +00:00
Ed Sanders 134b62eb09 Preserve data when switching from NWE to VE
Bug: T143917
Change-Id: I910e731914bd71fdb131dae79d233d4306facc5d
2016-08-25 11:06:40 -07:00
jenkins-bot d27863587a Merge "Show a different label for buttons on create vs. modify" 2016-08-25 16:40:21 +00:00
James D. Forrester deef47414a Vary the 'save' labels to 'publish' for public wikis
Bug: T131132
Change-Id: I4a497265661d5ce0f6144988b514509dfa1bddfd
Depends-On: I56634ed223778a0650cf36ac7256151b13c494f1
2016-08-25 09:37:52 -07:00
David Lynch c1a065295f init: Discard attempts to activate while we're already activating
Perhaps in the future we could enhance this so that clicking a different edit
link queues that up for after the current activation finishes / aborts the
current activation cleanly.

Also, error-checking on setting an invalid progress state when loading.

Bug: T143160
Change-Id: I6c78cb19953df6fb564c06bac807e6897b63df19
2016-08-24 19:57:47 -05:00
James D. Forrester b7c7d06968 Show a different label for buttons on create vs. modify
To align with the linked patch in MediaWiki core. Taking advantage of
the opportunity to use core's messages for these, and remove some dead
wood old messages that were never used like "restore" items in mobile.

Bug: T139033
Depends-On: Ie81b5edd275963a965cd44d0fd325cae9ee2f1a6
Change-Id: Ie00e94cc77cb750a7e8d1104366bb3dad65af8a4
2016-08-24 16:01:11 -07:00
jenkins-bot e433326b1b Merge "Fix insertion annotation for wikitext link inspector" 2016-08-24 20:46:58 +00:00
Translation updater bot da737c7854 Localisation updates from https://translatewiki.net.
Change-Id: I340323ac24871f3c4e30e011e0397dcb800eda60
2016-08-24 22:39:02 +02:00
Ed Sanders 5788340b49 Update VE core submodule to master (632f0a9)
New changes:
14b5fbc [BREAKING CHANGE] Move originalDomElements to the IV store and use MD5
c5d21f0 Provide methods to (de)serialize transactions

Local changes to move originalDomElements to IV store

Depends-On: I8a71c1a40ec35108d0a9a388da6f75632f8dc53c
Depends-On: I32c9b5f984fcf96e3354841ecfcd444149e8f159
Change-Id: I0fbb6324eede94558426178cbdad6b5daf0f8318
2016-08-24 18:14:14 +00:00
Željko Filipin 59d771e1ac Fix failing Selenium tests
There were a couple of pieces of language screenshots related Ruby code
left that was breaking Selenium tests.

Bug: T139613
Change-Id: I3d327b3cfd5f52e60fee07095eefdd8feecaba98
2016-08-24 16:47:14 +00:00
Željko Filipin 2fb5c18ced Upload language screenshot files using commons_upload Ruby gem
Use the latest version of commons_upload. Delete no longer needed files
from previous Ruby implementation.

Bug: T143563
Change-Id: I7c0ca64aeea54501c51eb56a950143d5af251cf7
2016-08-24 14:47:45 +00:00
Translation updater bot 6eded3baa0 Localisation updates from https://translatewiki.net.
Change-Id: I13d00f33fb7fa329889ed42381ba1c02d7980434
2016-08-24 10:38:15 +02:00
Ed Sanders 62bdaac13b Use super property to call parent methods
Change-Id: I76982b844cf2871d7583463def4393e5bdc33aa2
2016-08-23 11:56:47 -07:00
jenkins-bot 086202c540 Merge "init: port in isUnModifiedLeftClick without any VE core dependencies" 2016-08-23 00:01:52 +00:00