Commit graph

235 commits

Author SHA1 Message Date
Roan Kattouw 9eb121134f [Browser tests] Move "I can click the X on the save box" to shared_steps.rb
Doesn't belong in headings_steps.rb because it's used in other
*.feature files like bullets.feature

Change-Id: I23d3772653140e6e4639785c3622fc9a2b446801
2014-04-21 18:08:23 -07:00
James D. Forrester dd81908a50 [Browser tests] Disable svwikt production test as it's NS_USER-only
Unlike all other wikis with VisualEditor enabled, svwiktionary is set to
only allow VisualEditor in the User: namespace, so causing the production
test (which blindly tries to make a dummy edit in the main namespace) to
fail. For now, will just remove this one from the test.

Change-Id: I6f1eb8bd6bd384e1c9ca77c0036e3914f0dbe070
2014-04-21 19:29:29 +00:00
James D. Forrester 6e02932c3a [Browser tests] Updated list of production wikis to check
Now with no wikis deliberately skipped – all passing:

Newly-working wikis:

* bpy.wikipedia.org
* cv.wikipedia.org
* mzn.wikipedia.org
* new.wikipedia.org

Previously-working wikis that weren't added here yet:

* bat-smg.wikipedia.org
* be-x-old.wikipedia.org
* cbk-zam.wikipedia.org
* fiu-vro.wikipedia.org
* map-bms.wikipedia.org
* my.wikipedia.org
* nds-nl.wikipedia.org
* roa-rup.wikipedia.org
* roa-tara.wikipedia.org
* zh-classical.wikipedia.org
* zh-min-nan.wikipedia.org
* zh-yue.wikipedia.org

Newly-added wikis that weren't added here yet:
* meta.wikimedia.org
* incubator.wikimedia.org
* fr.wiktionary.org
* sv.wiktionary.org
* fr.wikibooks.org
* fr.wikiversity.org
* fr.wikinews.org

The file has been sorted into the same order as visualeditor.dblist for
the convenience of future changes – broadly:

* Test and meta wikis (inc. MediaWiki.org and Wikimedia Incubator)
* Wikipedias
* Wiktionaries
* Wikiquotes (none done yet)
* Wikibooks
* Wikisource (none done yet)
* Commons (not done yet)
* Wikispecies (not done yet)
* Wikiversities
* Wikinewses
* Wikimanaias (none done yet)
* Wikivoyages (none done yet)
* Wikidata (not done yet)
* Wikimedia (chapter wikis)
* Private wikis (not tested here)

Bug: 60842
Change-Id: I2678a3c716487bfd8dadff68d003d0039d730f36
2014-04-18 21:56:58 +00:00
jenkins-bot da475dd4b1 Merge "[browser test] increase wait for save to complete" 2014-04-18 16:41:02 +00:00
cmcmahon c4707a05fb [browser test] increase wait for save to complete
sleep() is evil, but let this stay at least for now

Change-Id: If3c98b2a05ea37dee0365afd5f17cf8b282ab29a
2014-04-18 09:38:27 -07:00
Željko Filipin 1236387abd [browser test] Run all Selenium tests in Firefox
Paired with: Chris McMahon
Bug: 58040

Change-Id: I83d4c391fc101bda8c18a6d0c533ca75795569ff
2014-04-18 17:33:12 +02:00
cmcmahon d62a9e939a [browser test] Save page is slow.
Change-Id: I550c462795f3e51555a21e0877985052610ad8cc
2014-04-16 08:52:21 -07:00
cmcmahon 219ca37909 [browser test] make test pass in both Chrome and FF
Change-Id: I36fc3eb31d0a97145cff5f43aef3a5365286de29
2014-04-14 12:10:02 -07:00
cmcmahon 8134988b48 [browser test] Fix edit mode test.
This test never worked.  Last week this feature broke but the
test continued to pass.  Let's not do that again.

Change-Id: I9819a3304191959b9b194b3e675dfdd273618881
2014-04-07 11:50:54 -07:00
cmcmahon 9f57feff2f [browser test] maintenance, locator changed
Change-Id: I9d9f410afe6d4fd90489ba7816b9c0dec92460b0
2014-04-04 11:51:30 -07:00
cmcmahon 85abbf7b4e [browser test] extend timeout waiting for edit surface to appear
Bug 63447

Change-Id: I0be4142817251147400ea34ebdb04bba760f2161
2014-04-02 14:37:46 -07:00
cmcmahon c83ef84cdc [browser test] updates for no beta warning to dismiss
See https://gerrit.wikimedia.org/r/#/c/119217/

Change-Id: If3b6f7c9b9a7ce3a4d4c5d8b822d123b50d3c106
2014-03-27 17:24:12 +01:00
James D. Forrester c149b1c071 Update VE core submodule to master (9c19df0)
New changes:
0318f64 Fix copyright year range for one file not updated to 2011-2014
4dbd57e Add <base> for relative URLs in tests
554cde9 Localisation updates from https://translatewiki.net.
c32448a Update OOjs UI to v0.1.0-pre (1c7875205a)
8f675c8 Localisation updates from https://translatewiki.net.
4fb929c Add a <base> to every test document by default
09c404c Protect against invalid/absent <base> in ve.resolveUrl()
05924db Use DOMParser in ve.createDocumentFromHtml() if available
9c19df0 Update OOjs UI to v0.1.0-pre (e697490c9b)

Local changes:
Use ve.dm.example.base for link tests in mwExample

Change-Id: I384e2a2edeebe9379de4910889a61670d9f734f5
2014-03-26 21:33:52 -07:00
cmcmahon b15627f0ec [browser test] Wait longer for save in multiedit workflow.
This timeout caused the only test failure overnight Mar 25.
Timeouts are bad.

Change-Id: I070c3362271ad23b7c38922858ad4079d0754a45
2014-03-26 08:49:56 -07:00
Roan Kattouw 0304b89db9 Add lookupTitle attribute
This is the normalized title without the fragment, which is what
should be used for existence check purposes. Also add a test for
an internal link to a page's section.

Change-Id: I0e04f64c1bebeff84a0c17ef9b6c8dc06876f769
2014-03-19 19:34:19 -07:00
cmcmahon ad6928376e [browser test] Fix a mistake in previous commit.
Earlier commit did not use _element properly

Change-Id: Id8d887af21cd83a2bfaddf8db7d5121a5213a13f
2014-03-17 13:54:46 -07:00
jenkins-bot d183c74d6b Merge "[browser test] dismissing beta 10X is overkill" 2014-03-17 20:07:18 +00:00
jenkins-bot c5c2cb809c Merge "Update VE core submodule to master (aaad03a)" 2014-03-17 18:52:50 +00:00
cmcmahon f0731084da [browser test] add when_present to link header check
I was surprised to find this missing, this was a mistake that
causes bogus failures

Change-Id: Iab38ef4db315993ca1f31c079f17be22ebf17d3c
2014-03-17 11:37:36 -07:00
cmcmahon 0a2f97d3b9 [browser test] dismissing beta 10X is overkill
Change-Id: Ic674bcb53d54948d6beb58338cbef030fc3e524f
2014-03-17 11:29:37 -07:00
James D. Forrester 5e4af875c1 Update VE core submodule to master (aaad03a)
Also update ContentBranchNode test for changes in VE core

New changes:
bdf9a9f Merge two Properties blocks in DesktopContext
d3c22bb Make ContentBranchNode echo suppression work in CBNs that contain inline nodes
aaad03a Localisation updates from https://translatewiki.net.

Change-Id: I3e1757b42307c3bd52ba0571068eb1c6bfb5ab89
2014-03-16 16:53:53 -07:00
cmcmahon 5da22148e8 [browser test] Navigate different path through template
Change-Id: I8f16353c6493ddac41b0856b4909c29a595f48d7
2014-03-13 10:06:57 -07:00
cmcmahon 806f29a79b [browser test] "Apply changes" is now "Insert template"
Change-Id: I2aaa88ade12a9f68d65b2025c79c93840177670c
2014-03-13 07:55:16 -07:00
James D. Forrester e85d840d64 Create remaining meta items in DM
Add meta items for the four remaining mwPageProp behavioural flags from Parsoid
that are added by MediaWiki core. These are each waiting for UX implementation,
based on the lack of context information in MWMetaDialog about the page, or
about the wiki:

* __NOGALLERY__
* __HIDDENCAT__

  — These only make sense in a Category: page.

* __NOTITLECONVERT__ // __NOTC__
* __NOCONTENTCONVERT__ // __NOCC__

  — These only make sense on wikis that have content or title conversion.

Change-Id: I752705f65cfbd79c7f3f71270659793996868aff
2014-03-13 01:57:48 +00:00
Roan Kattouw 0072aeb9a1 Update VE core submodule to master (8c017ae)
Also update VE-MW for the comment changes in VE core

New changes:
4ad6a3d Add text direction to SA demo
89503e8 ve.ce.Node: Emphasise slug transition with increasing outline offset
864046e Update oojs to v1.0.8
65d1338 Localisation updates from https://translatewiki.net.
b66d482 Stop special-casing comments and recognize them as tagName='#comment' instead
09dda12 ve.ce.getDomText: Document node types and use .data instead of .nodeValue
b0a3b2a Make ve.dm.Converter assertions actually display message
ef791cc Make 'comment' its own metaitem type
d5ef0d7 ve.dm.Converter: Refer to nodes instead of elements where appropiate
c22c8af Fix JS error when pressing Enter with selection across multiple paragraphs
a26a708 Add ve.dm.Transaction.newFromReplacement
a9e136e Don't cause needless surface refreshes on overwriting.
6fd35ee Split part of getOpeningHtmlTag out to getHtmlAttributes
2c31f67 ve.ce.Surface: Document version number in focus workaround for Opera
e069e74 Add some more characters to the special character inserter

Change-Id: I859805fb261468e8fae9454c4992115369066b49
2014-03-12 16:15:54 -07:00
cmcmahon 9de8448e8b [Browser tests] Remove dumb stuff from steps.
This might improve the flakiness in the Sauce runs. I am not
certain of that though

Change-Id: I80dd0829aba278ccbda9a4f34a15cbb140ce9e7d
2014-03-12 17:30:01 +00:00
cmcmahon 007538a520 [Browser tests] Updates to transclusion tests should turn build green
Change-Id: I9a504abff73f56535d26d3205a2a4345290ba987
2014-03-07 22:57:14 +00:00
vikassy 3486b0f424 [Browser tests] Updated Ruby version from 2.1.0 to 2.1.1
Bug: 62152
Change-Id: I61cbb10749fcc568429c626497a76c41074368e8
2014-03-04 19:48:48 +00:00
Ed Sanders b14326624b Consistency in DM MW test naming and comments
Move MWConverter to Converter and fix some comments.

Change-Id: I8b73d064c890e9cdae61f8118b092e5041febaa5
2014-03-03 14:34:08 +00:00
cmcmahon 5544333be9 Use regexes for text of headings links
Change-Id: I196e555c818dda0f9211e9e402255b29d93a3b7e
2014-02-26 14:37:05 -07:00
cmcmahon c6a1bbdacf Disable headings test while Bug 61856 is under investigation
This is an expensive test and I'd rather not run it than
have it always failing.

Change-Id: I8ee30bf3e6eb0841f51a4ab02610dd2b3ce8349e
2014-02-25 07:59:12 -07:00
cmcmahon dd02bef985 Update to latest mediawiki-selenium gem for better login
Change-Id: I8e75afcc25bdee692124faa63bbfc36c7777dedb
2014-02-24 11:10:12 -07:00
Antoine Musso c77d2d1ff6 [Browser test] @clean the Basic Edit feature
Merely for testing the browser test Jenkins job.

Change-Id: I425af4bd2f6e709252931dc49d64bb4f47539710
2014-02-21 21:28:24 +00:00
jenkins-bot 37c84dc3bb Merge "Ensure we use our references to certain native or upstream methods" 2014-02-20 23:35:39 +00:00
Timo Tijhof 58c647e3ac Ensure we use our references to certain native or upstream methods
Checked:
 ve.cloneObject       (oo|OO).cloneObject
 ve.getObjectValues   (oo|OO).getObjectValues
 ve.getObjectKeys     Object.keys
 ve.compare           (oo|OO).compare
 ve.copy              (oo|OO).copy
 ve.isPlainObject     ($|jQuery).isPlainObject
 ve.isEmptyObject     ($|jQuery).isEmptyObject
 ve.isArray           Array.isArray
 ve.bind              ($|jQuery).proxy
 ve.indexOf           ($|jQuery).inArray
 ve.extendObject      ($|jQuery).extend

Fixed:
* ve.dm.MWBlockImageNode.js (added in Iebb2081de)
* ve.dm.MWInlineImageNode.js (aded in I62ec12a6b)
* ve.dm.MWConverter.test.js (added in I90273786a)
* ve.ui.MWMediaInsertDialog.js (added in Ia5ad9a8c0)
* ve.dm.MWTemplateSpecModel.js (added in Ic3eb66538)
* ve.init.mw.MobileViewTarget.js
* ve.init.mw.ViewPageTarget.js
* ve.init.mw.Target.js

Skipped:
* ve.init.mw.ViewPageTarget.init.js
  - Feature test (which is for the very references from ve.js
    being ensured in this commit).
  - Misc code using $.inArray (can't use ve.js yet since that
    isn't loaded yet there).

Change-Id: I73ae005d3692e871fdcaea938641558c0b98ec69
2014-02-20 22:30:29 +01:00
Jeff Hall 4d2209e987 [Browser test] Headless browser test(s)
Ready for code review!

New headless browser test for use on a fresh Mediawiki install that
includes VisualEditor.  Using the gem mediawiki_api

Updated to use the create-user API method from the
mediawiki_api gem.

Bug: 53691
Change-Id: I07d4ae5fac346b0c2ee8c33a2dc2456299047ace
2014-02-20 08:44:11 -08:00
Jeff Hall 2c691ff666 [Browser test] Alternate solution for "headings" browser test
Change-Id: Iab455ba36817623b62b2c8fe881b2756d9023329
2014-02-19 10:48:15 -08:00
Jeff Hall 83404c4920 [Browser test] Repair broken "header" browser test
Bug: 61398
Change-Id: I527d535ba6cb242ea994671dcd51f461766c7230
2014-02-18 16:38:01 -08:00
Zeljko Filipin 982c20a42e [browser test] Updating to mediawiki_selenium 0.2.6
The new version of the gem remove configuration of Sauce Labs browsers
from mediawiki_selenium Ruby gem.
Paired with Jeff Hall.

Bug: 61067
Change-Id: I6af37e9e643490a55aae974d7d7f5067b7916b87
2014-02-18 17:38:08 +01:00
James D. Forrester 220d19dd7d Update list of production wikis that should be tested as working
I fixed af, am, kaa, ln and szl wikis' Common.js files.

Ptwikiversity's wiki is working fine as far as I can see.

Change-Id: Ia856d0f5be1a7cb988df58e3914116075e9dc98f
2014-02-14 12:30:59 -08:00
Jeff Hall a857e3079c [Browser test] Basic maintenance for headings browser test.
Change-Id: I85003448e41012af833a7b5754179da4a17cf652
2014-02-13 12:57:50 -08:00
Antoine Musso c2e1766fea [Browser test] bump mediawiki_selenium to 0.2.3
mediawiki_selenium 0.2.3 let us specify the destination of screenshots
via SCREENSHOT_FAILURES_PATH env variable.

Change-Id: Ieb6b6803c58760415dc45dc691556be774d4be8f
2014-02-13 15:22:14 +00:00
Jeff Hall 2962ca52b1 [Browser test] Update list of prod wikis to be verified.
Bug: 60797
Change-Id: Ib8fcc9a2a396bac8a2feadb535765b3f672baaa8
2014-02-11 13:20:26 -08:00
Zeljko Filipin 052b039074 [browser test] Fix failing tests, Watir and page-object API changed
Paired with Chris McMahon and Jeff Hall. Watir and page-object API
changed so it is now required to specify that a frame is an iframe.

Change-Id: Id269ec5bc9dc9c960fdf1f606cbc635a58659fa7
2014-02-11 17:47:17 +01:00
Zeljko Filipin 0b1fcc2231 [browser test] Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem
Bug: 56088
Change-Id: I9fdfcf0f9df8f1bd9df3c358d2e1a7925fa5928d
2014-02-11 15:17:31 +01:00
Jeff Hall 1a4cb81f6f [Browser test] VisualEditor availability on prod wikis
Ready for code review!

Bug: 60797
Change-Id: I0823e1d569410be5cfa57db77d402bd2c53a5ad8
2014-02-10 19:37:04 +00:00
James D. Forrester 2d834ec8c6 Blacklist Amazon Silk
User agent strings from http://docs.aws.amazon.com/silk/latest/developerguide/user-agent.html
Relies on I853e8861

Bug: 50777
Change-Id: I8830d56b9460a72d9a9880fb7120f338dd0f598c
2014-02-07 22:21:35 +00:00
Zeljko Filipin 674406adb9 [browser test] Renamed mediawiki-selenium Ruby gem to mediawiki_selenium
Bug: 60820
Change-Id: I37bc42b78a5a1dad2d1eb730c9d67ed085058415
2014-02-07 12:40:41 +00:00
jenkins-bot 527d432161 Merge "Revert "[Browser test] Reintroduce headless browser test support"" 2014-02-07 01:54:42 +00:00
Jhall 6d2447ca74 Revert "[Browser test] Reintroduce headless browser test support"
This reverts commit 8e8525dea9.

This change seems to have broken all of the VisualEditor browser tests, similar to our first attempt at solving the same problem - not good :(

Change-Id: I5fa70a1164ebe8de1ecc37f72ba7ceffdc31e7bd
2014-02-07 01:51:38 +00:00