Commit graph

18358 commits

Author SHA1 Message Date
jenkins-bot e4f444624d Merge "Only use aria description on multipart transclusions" 2021-11-15 15:34:44 +00:00
jenkins-bot 609f589557 Merge "Move feedback icon to correct position in template dialog" 2021-11-15 14:45:57 +00:00
jenkins-bot b84a6198db Merge "Update shortcut to add a part in the template dialog, take #3" 2021-11-15 14:34:52 +00:00
Thiemo Kreuz 0e1a5379da Move feedback icon to correct position in template dialog
Bug: T294839
Change-Id: Ib1a895735d795e0d38f38952fd8bce6ad3fee50e
2021-11-15 14:04:18 +00:00
WMDE-Fisch 26cab3125d Only use aria description on multipart transclusions
Moving responsibility to the part widget to check if we're in a
single transclusion.

Bug: T295353
Change-Id: I61b7891c04eb729647e2600318a97987fd88cb90
2021-11-15 12:22:12 +01:00
jenkins-bot 1cbeb7c4ac Merge "Move misplaced close button back to standard position" 2021-11-15 08:16:52 +00:00
Translation updater bot 7aa8ddc71d Localisation updates from https://translatewiki.net.
Change-Id: Ib80ef6784ba065d78d996e4759840cf716c65118
2021-11-15 08:13:10 +01:00
Bartosz Dziewoński 4ab6cb176e Update VE core submodule to master (ef47d7814)
New changes:
fce94628e build: Update eslint-config-wikimedia to 0.21.0
201f33491 Localisation updates from https://translatewiki.net.
df3700480 Handle TargetWidget submit events in dialogs
e12c2cbba createDocumentFromHtml: Add test for <body> wrapping logic
57cf7485c createDocumentFromHtml: Improve body wrapping logic with regex
ef47d7814 Inject meta tag to disable iOS tel: conversion in HTML head

Bug: T116525
Bug: T289092
Change-Id: Ibb70d0ed0fa8917c3bc4da7d6fffb2c937c69238
2021-11-12 23:20:31 +01:00
Ed Sanders e9dd51a71b Fix specificity for mw-body-content in VE overlay
Bug: T287733
Change-Id: I7eaef3ef89a23932edd5abdd74703eb3297ee061
2021-11-12 17:55:44 +00:00
jenkins-bot d8329b36a3 Merge "Minor fixes to floating help dialog in desktop mode" 2021-11-12 16:34:17 +00:00
jenkins-bot d4a25fdbe7 Merge "Use a fullscreen help dialog for templates on mobile" 2021-11-12 16:25:32 +00:00
Thiemo Kreuz 198e62be83 Move misplaced close button back to standard position
In OOUI the close button is always on the left side. See
https://doc.wikimedia.org/oojs-ui/master/demos/?page=dialogs&theme=wikimediaui&direction=ltr&platform=desktop

The CSS hack to move it to the other side doesn't work and must be
removed. You can see the problem the moment the text is longer (which
can easily happen in translated versions).

I tried to come up with a more official way to move the button to the
other side, but gave up. One way is to replace the existing

		flags: [ 'safe', 'close' ]

with:

		flags: [ 'primary', 'close' ],
		framed: false

But this causes other style problems. Let's remove the bogus CSS
first and possibly try again in a later patch.

Bug: T294839
Change-Id: Ia6ddefd99e4a03a87b0450ab94712ff19bb268e4
2021-11-12 16:48:13 +01:00
Translation updater bot fba26d7305 Localisation updates from https://translatewiki.net.
Change-Id: I601d8229d21592c214e74e3af75f121c43f50615
2021-11-12 08:29:57 +01:00
Thiemo Kreuz dd68dd38d7 Minor fixes to floating help dialog in desktop mode
There was a remaining issue when the window was made very narrow in
desktop mode (smaller than 500px). This patch doesn't aim to really
"fix" the dialog's design in this case. The goal is to make the popup
window appear less broken, so the text can stil be read and the
buttons clicked. That's all.

This patch should not have any effect in:
a) mobile mode,
b) desktop mode when the window is wider than 500px.

Bug: T294839
Change-Id: I3171dbb991533b91eaadba63b78d0ff40aa486dc
2021-11-11 12:23:26 +01:00
Translation updater bot d57b3ad10d Localisation updates from https://translatewiki.net.
Change-Id: I689a7432ef84b9801092c48d551b1172df1e3699
2021-11-11 10:03:12 +01:00
Ed Sanders 33840e88ee build: Update eslint-config-wikimedia to 0.21.0
Change-Id: I19465a5ab3bf71cd97967fd1fac41c645f05a419
2021-11-10 14:52:56 -05:00
jenkins-bot 4cafe5105e Merge "Implement floating help dialog for templates" 2021-11-10 17:05:14 +00:00
Andrew Kostka da2df5a118 Use a fullscreen help dialog for templates on mobile
Bug: T294839
Change-Id: I1effb6ea70bcf5e9ce4e84e65431765d0d2f8125
2021-11-10 15:33:25 +01:00
jenkins-bot 54ca8bd99f Merge "Update VE core submodule to master (d29db14ee)" 2021-11-09 22:08:50 +00:00
Željko Filipin 0593278d05 selenium: The first test
The first test just opens the page for editing and checks if it opened.

Bug: T284165
Change-Id: Ifffaf3e5ab14811605d96fcdcfdc1f773880e52c
2021-11-09 16:11:22 +01:00
jenkins-bot d5ac4f4900 Merge "Localisation updates from https://translatewiki.net." 2021-11-09 14:28:25 +00:00
Andrew Kostka 72641151e4 Implement floating help dialog for templates
Bug: T294839
Change-Id: Id224b61bd0cd57f5e970ab62db2d82dab1db9252
2021-11-09 15:28:23 +01:00
Thiemo Kreuz 5e13ccfb43 Update shortcut to add a part in the template dialog, take #3
Same as I980b72c, but with another shortcut. Again. We tried
Ctrl+Shift+X before (conflicts with RTL feature in VisualEditor), as
well as Ctrl+Alt+D (conflicts with "hide all windows" incUbuntu).

Bug: T294905
Change-Id: Iae7ba759fcd7c107ef586bd5d9ae3cdbe445cedc
2021-11-09 10:48:52 +01:00
Translation updater bot 8c1715713a Localisation updates from https://translatewiki.net.
Change-Id: Ifc15cbbc0439b407a8443fb1744c15ce7e7dc032
2021-11-09 07:30:03 +01:00
Ed Sanders 36eacb1095 assert.ok -> assert.true
Change-Id: I9987ae0cbe275bf492dcdef405454537119765ea
2021-11-09 00:30:20 +00:00
Bartosz Dziewoński b3925baed6 Update VE core submodule to master (d29db14ee)
New changes:
bde209a1c Add simple equality check shortcut to compareElementsUnannotated
79954cb58 Localisation updates from https://translatewiki.net.
2c84478ba Use null for deliberately empty values instead of undefined
18929710e assert.ok -> assert.true
d29db14ee ElementLinearData: Fix instance of data being modified in place

Change-Id: Ia307a129cc7725b2f5bfa168c48934f6f2aa1e67
2021-11-08 23:56:34 +01:00
Translation updater bot e9fd33f444 Localisation updates from https://translatewiki.net.
Change-Id: I1d2821d70762568cb906d26371dfe5193cf03def
2021-11-08 08:17:42 +01:00
WMDE-Fisch 3e28977087 Remove local aria-multiselectable
Added to OOUI v0.42.1 see I717ff53e18e95c72ace1c46b6236cfecb5cd8217

Bug: T291284
Change-Id: I45965181f22f9c5845f6dd44ab75e95305a43dce
2021-11-05 09:10:21 +01:00
Translation updater bot 4dddd70b5b Localisation updates from https://translatewiki.net.
Change-Id: I53a393fb92ce99ebcbd64375257d7a826d141503
2021-11-05 08:17:40 +01:00
jenkins-bot c93638db36 Merge "log restbase response body as attribute of response object" 2021-11-04 23:44:36 +00:00
Bartosz Dziewoński 39b6a8c521 Update VE core submodule to master (86aa5f8f8)
New changes:
f19ca060c Localisation updates from https://translatewiki.net.
0e82fee96 eslint: Fix errors from upcoming eslint-config-wikimedia
86aa5f8f8 Update OOUI to v0.42.1

Change-Id: I31aecaa3002c8dedc1dc787bd71d2e6781e1ecf1
2021-11-04 22:51:48 +01:00
Cole White 8b5bc61f43 log restbase response body as attribute of response object
Eliminates a source of log indexing failures.

Bug: T239458
Change-Id: I4f1cc06cdbd7e7ce02575b755aff6e9f7f9a8767
2021-11-04 15:27:07 -06:00
jenkins-bot f2ac725002 Merge "Update the shortcut for adding a template in the template dialog" 2021-11-04 15:12:35 +00:00
Translation updater bot 4877344048 Localisation updates from https://translatewiki.net.
Change-Id: I8f173862ffc847c3883d756461c6f71afa3b1333
2021-11-04 10:08:28 +01:00
Bartosz Dziewoński f5f26d848d ArticleTargetSaver: ve.init may be undefined
Bug: T294981
Change-Id: Ibd1cf9db9ebb58e7b7721e35991dd4027506c0dd
2021-11-03 22:12:33 +01:00
Andrew Kostka 7f3c24b48e Update the shortcut for adding a template in the template dialog
Bug: T294905
Change-Id: I980b72c98835865c065163fa17bfcc3b9434a80b
2021-11-03 15:40:16 +01:00
Translation updater bot 98c19c4a23 Localisation updates from https://translatewiki.net.
Change-Id: I8d58d90d344aca367b249764250f277d71bab7cb
2021-11-03 08:21:33 +01:00
jenkins-bot 3d3369298a Merge "Move id creation into AriaDescribe mixin" 2021-11-02 22:24:09 +00:00
vladshapik f17e84b331 Avoid using User::isBlockedFrom()
Replace User::isBlockedFrom with PermissionManager::isBlockedFrom since this method will be hard-deprecated.

Bug: T294823
Change-Id: Iea308ce73e4e91b21f55b60e0b3251d93ba18d7e
2021-11-02 13:13:12 +02:00
Thiemo Kreuz 56fb18243c Move id creation into AriaDescribe mixin
Change-Id: Ifef4f3c0fee13a241488f473b561ced7b327fd73
2021-11-02 09:44:02 +00:00
Translation updater bot 803641b05e Localisation updates from https://translatewiki.net.
Change-Id: I621e00525cf65ab1013c7fbe423dd1f6cccc46af
2021-11-02 08:07:43 +01:00
jenkins-bot f223046fc8 Merge "Introducing a mixin for ARIA descriptions on parameter selection" 2021-11-01 15:56:51 +00:00
WMDE-Fisch f9fda0594f Introducing a mixin for ARIA descriptions on parameter selection
Allows setting aria labels and descriptions on elements in a
convinient way. I did not use the the .mixin. convention here for
because there's already another mixin in that folder that's also
not having .mixin. as part of its name. And then there's also no
no need to open up that extra namespace here.

If we move this upstream at some point this can be changed though.

Bug: T291284
Change-Id: I1b3d40400d539f851f13719e16ced200968a7f92
2021-11-01 13:20:00 +01:00
Translation updater bot be30ca5ffd Localisation updates from https://translatewiki.net.
Change-Id: I59581127d4b7b586ab6a25b8e38a1a5ca96c844b
2021-11-01 09:34:52 +01:00
jenkins-bot b5a6e2e32b Merge "Support both DELETE and DEL when using template shortcuts on MacOS" 2021-10-29 16:10:37 +00:00
jenkins-bot c27c094cff Merge "Exclusively use CMD instead of CTRL for shortcuts on MacOS" 2021-10-29 16:10:34 +00:00
jenkins-bot f780c75b1f Merge "Add ARIA descriptions to sidebar widgets" 2021-10-29 10:37:55 +00:00
WMDE-Fisch dab5b5daae Add ARIA descriptions to sidebar widgets
When changing the source in the described-by attributes the screen
reader will read the text of the new source when the status changes.

Just changing the text within the elements holding the descriptions
does not work.

Bug: T291284
Change-Id: I31cc3061cf6c1f699babe41e99e0711f0eb03646
2021-10-29 12:07:53 +02:00
WMDE-Fisch 3e23d78d32 Hide more button on parameter descriptions for screen readers
Screen readers will read the collapsed content despite the fact that
it is not visible due to the way it is hidden with CSS. The more button
makes no sense for these users and is probably more confusing than
helpfull.

Bug: T291277
Change-Id: I71888d8b9565d5ee85c5e7a48965e9e9a76eb984
2021-10-29 08:48:32 +00:00
Translation updater bot 1a05bc2a73 Localisation updates from https://translatewiki.net.
Change-Id: I6c506371e0d864b1f4f14ef91edc0bf46fa6b38c
2021-10-29 08:22:35 +02:00