Commit graph

16868 commits

Author SHA1 Message Date
jenkins-bot bc963f4155 Merge "Support for defined template context items" 2019-08-30 18:50:27 +00:00
jenkins-bot 6cd05557d0 Merge "MobileArticleTarget: v1 of toolbar refresh" 2019-08-30 17:43:58 +00:00
Ed Sanders e5f5a49344 Support for defined template context items
Context items can be created for specific template titles. Titles
are mapped to context items using an on-wiki message.

Bug: T211243
Change-Id: Icfc39e350452da238d0e0c17cb2305c60d9ca16a
2019-08-30 13:02:47 +01:00
Translation updater bot e4c7fbe580 Localisation updates from https://translatewiki.net.
Change-Id: I54cc287abd7eb26b75ff305cbb0dca96dfead461
2019-08-30 10:05:42 +02:00
David Lynch 593d26b4ab Don't let double-clicking the save button trigger a save
Tapping the toolbar save button while the save dialog is open triggers a save
because of the accesskey. It shouldn't save on a double-tap, because that's
easy to accidentally do / trigger on a slow device.

Bug: T230816
Depends-On: I4c3afce9d57c9bca737272b40b9a4862b5794bac
Change-Id: I1925b1b97de6a811f73196b616ec09a2c30c336f
2019-08-29 22:43:53 +00:00
Bartosz Dziewoński 6295afa92b Update VE core submodule to master (4f3a331f6)
New changes:
4ea2bd352 ve.ui.DesktopContext: Reserve space above anchored inspectors
bb84989b9 Docs: Standardise "messages used" comments
c792023c8 Localisation updates from https://translatewiki.net.
b86d9cfce WindowAction: Expose a promise when opening a window
4f3a331f6 ve.ui.DesktopContext: Check for null viewport first

Bug: T229900
Bug: T230816
Change-Id: I615aaa630cabd61e676f92d6a95f035938cd6864
2019-08-30 00:43:21 +02:00
David Lynch 1761b6d6d6 MobileArticleTarget: v1 of toolbar refresh
Bug: T211789
Bug: T230807
Change-Id: Ifd2319039628a8143dc09f6fa35e4a9825d3062c
2019-08-29 15:27:56 +00:00
jenkins-bot dd86fc76aa Merge "Use upstream pulsating dot" 2019-08-28 17:31:52 +00:00
jenkins-bot 23f5488e93 Merge "Docs: Standardise "messages used" comments" 2019-08-28 16:58:12 +00:00
Ed Sanders 4a8947686d Docs: Standardise "messages used" comments
Change-Id: Ic563901a9439e86ca85ac6210323a35ab34736c3
2019-08-28 16:41:19 +01:00
jenkins-bot 5849de920c Merge "ve.init.mw.ArticleTarget: Use errorformat=html when saving" 2019-08-28 13:43:59 +00:00
jenkins-bot e7985003ab Merge "DesktopArticleTarget.init: Improve handling of 'preloadparams'" 2019-08-28 13:37:54 +00:00
Ed Sanders 7cc538fe51 Use upstream pulsating dot
Bug: T226719
Depends-On: Ibd035ea48b7d0316a7627a91623ff6116ccbae31
Change-Id: Iedf88e9c5ac8efa809ccb25f2081eff9946da395
2019-08-28 13:40:29 +01:00
Translation updater bot 7902d599aa Localisation updates from https://translatewiki.net.
Change-Id: I375166dcfd50df852b1f0b938a655a1fe06a89e8
2019-08-28 10:54:02 +02:00
James D. Forrester 48ae9852a6 Update VE core submodule to master (c4c37f4e0)
New changes:
c5f77d3b3 getNodeAndOffset: Check offset is in document range
c4c37f4e0 Follow-up I196f5bd88: Fix typo (set node=this)

Bug: T231381
Change-Id: Ie721788834b28e5d034b594ddb8ddbe204ff8d37
2019-08-27 14:49:09 -07:00
Bartosz Dziewoński 035f34dac9 DesktopArticleTarget.init: Improve handling of 'preloadparams'
Depends on MediaWiki change I48d4bb3f, which adds the 'arrayParams'
option to handle explicitly indexed array parameters like
`&preloadparams[0]=a&preloadparams[1]=b`. Previously we only handled
implicit indexes like `&preloadparams[]=a&preloadparams[]=b`.

Bug: T231382
Depends-On: I48d4bb3fdf0ea7f5eb133c59bf63651ba356fc42
Change-Id: I8c899bce1b19fa286bd385f89e102a4b87db4db3
2019-08-27 22:32:13 +02:00
jenkins-bot 8f21ec6a5d Merge "ve.ce.MWSignatureNode: Fix rendering" 2019-08-27 18:27:33 +00:00
Ed Sanders 20b1c6d752 Update VE core submodule to master (fe0ca590e)
New changes:
78d5b216d More documentation for ve.dm.VisualDiff#diffTreeNodes
fe0ca590e Link context: Add small spacing between link and label

Change-Id: Ie96de32a9ae6a96fad92781d84a685225bdbc911
2019-08-27 17:29:38 +01:00
jenkins-bot 9c3b03b479 Merge "Update VE core submodule to master (c6d271fa5)" 2019-08-27 16:02:17 +00:00
jenkins-bot aa3f94e5ca Merge "Remove usages of deprecated MWNamespace." 2019-08-27 15:41:04 +00:00
Bartosz Dziewoński 21f0f712e4 Update VE core submodule to master (c6d271fa5)
New changes:
c6d271fa5 Link inspector: Change "label" messages to "text"

Bug: T230794
Change-Id: I99809e53ca9ca62804f6a1ed6fbe4d3d62f51507
2019-08-27 17:38:06 +02:00
jenkins-bot 624bcbaf72 Merge "Link inspector: Turn off 'addQueryInput'" 2019-08-27 15:34:50 +00:00
jenkins-bot ff326a8ecc Merge "Update VE core submodule to master (aec8d85c5)" 2019-08-27 15:31:09 +00:00
Bartosz Dziewoński b5aa9e9c72 ve.ce.MWSignatureNode: Fix rendering
The API response format changed in formatversion=2.
Follow-up to 934572cdf7.

Change-Id: I383dfac8b0d10a39b8a9a1b11e11fd595f482619
2019-08-27 17:16:21 +02:00
Ed Sanders 3b09a0719c Link inspector: Turn off 'addQueryInput'
The double result creates more confusion that it clears up,
and now that the query input is always used for text insertion
it is less of an issue that we don't have a case-exact match
in the results list.

Bug: T230819
Change-Id: I58cbe740fa7d0327aadd5dd111161bb7087a4ddb
2019-08-27 12:17:44 +01:00
Translation updater bot de6fdb0b31 Localisation updates from https://translatewiki.net.
Change-Id: If2dfeec7d09526999a736754390030abbccd244b
2019-08-27 11:05:58 +02:00
Petr Pchelko c0d2d52e95 Remove usages of deprecated MWNamespace.
Bug: T11977
Change-Id: I6da497464a77286d5fd2d30a85e70de85fe1c868
2019-08-26 17:49:52 -07:00
James D. Forrester b28c4bd31e Update VE core submodule to master (aec8d85c5)
New changes:
aec8d85c5 build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issue

Change-Id: Ia2e5f94899fbb6d3ba036d820df95a3149df0a03
2019-08-26 14:35:29 -07:00
Bartosz Dziewoński 02d0936d90 Update VE core submodule to master (3a669b323)
New changes:
13477446b Localisation updates from https://translatewiki.net.
9ef837943 GeneratedContentNode: Re-apply model selection if DOM node count changes
45c37f702 ve.ce.Surface: Don't request offsets that are out of bounds

Bug: T231085
Bug: T231094
Change-Id: Iad370402c5645a0ed4078977155815a95715dab5
2019-08-26 20:29:01 +02:00
Translation updater bot b4d74b314b Localisation updates from https://translatewiki.net.
Change-Id: I300c93288d73642772ef33685b6bf55d4b2e5d2c
2019-08-25 10:32:38 +02:00
James D. Forrester 90eaa75878 Update VE core submodule to master (7c1d4680d)
New changes:
2e37aaea7 Localisation updates from https://translatewiki.net.
85011b54a Utils: Move ve.supportSelectionExtend to client-only utils
077dfaa59 ve.dm.Change: Remove no-longer used doc argument from #deserialize
586a91bc5 ve.dm.Change: Fix serialize to be recursive

Change-Id: Ia70f2a663899972e35ac0b077465f946ebc49ffc
2019-08-23 06:32:49 -07:00
libraryupgrader efe71172c8 build: Updating eslint-utils to 1.4.2
* https://npmjs.com/advisories/1118

Additional changes:
* Added .eslintcache to .gitignore.

Change-Id: I6a5730042aaeba30614cfca2692991493ba32574
2019-08-23 08:43:09 +00:00
Translation updater bot 3df39a1082 Localisation updates from https://translatewiki.net.
Change-Id: I3dd366aaffefb2ad96ebec5d6a017e71de13c8e9
2019-08-23 09:49:59 +02:00
Ed Sanders 042bfdfd9d Update VE core submodule to master (07687721b)
New changes:
77076f828 LinkAnnotationInspector: add a "label" field on mobile

Local changes:
* Updates for mobile link label editing

Bug: T229431
Change-Id: Ib0489f6f59b228ebc4a20f7a0a515be938a8f6d3
2019-08-23 00:25:51 +02:00
Bartosz Dziewoński 54cd987398 Update VE core submodule to master (663b34056)
New changes:
f373fbea1 Remove redundant @method annotations
ca2ea9246 Fix issue URL typo

Change-Id: I04cfc6b9cc98108261237642dae3be119d8a42a6
2019-08-22 21:22:49 +02:00
Translation updater bot 6dff2dd032 Localisation updates from https://translatewiki.net.
Change-Id: I0cefdc0b02238bb1d506522d8b95acc2825d43a0
2019-08-22 10:10:30 +02:00
Bartosz Dziewoński 756572ed8a ve.init.mw.ArticleTarget: Use errorformat=html when saving
When saving fails for a reason we don't handle explicitly, the error
message will have HTML formatting and will respect any on-wiki
overridden messages, rather than being plain text generic message.

Extensions providing custom SaveErrorHandlers may need to be updated.
The only one in Gerrit that requires a fix is TitleBlacklist:
Ibeae79c95557a7af699716c9d921f34c310bee6d.

* Remove handling for errors returned in .visualeditoredit.edit.info
  rather than .errors (.error in old format). AFAIK this is only used
  by some extensions, it is probably incorrect to do (T229539) and all
  extensions I know of that do this (AbuseFilter, SpamBlacklist,
  ConfirmEdit) have custom SaveErrorHandlers.

* Remove custom error messages for 'readonly' (identical to API
  response) and for 'hookaborted' (very unhelpful and there is a
  chance that the API response is better, if the extension causing
  this error generates any error message).

* Add a silly shim for MobileFrontend integration, because we allow it
  to handle error responses, and it expects them in the old format.
  This is probably subtly wrong in many ways, but MobileFrontend code
  only uses this for logging, so it shouldn't explode. In the future
  we will hopefully change it to use errorformat=html (T228897#5366960).

Bug: T229532
Change-Id: I3b9c4fefc0869ef7999c21cef754434febd852ec
2019-08-22 00:37:15 +00:00
Bartosz Dziewoński 84d548e7b1 Remove redundant @method annotations
A @method annotation is only necessary when the docblock is not
directly followed by a function declaration (in which case JSDuck
assumes it documents a property), e.g. when defining an abstract
function or referencing a function from another library.

I verified that JSDuck generates exactly the same output before and
after this change (docs/data-<hash>.js files are identical).

Change-Id: I7edf51a8560ab9978b42800ab1026f0b5555c3bf
2019-08-21 23:33:15 +02:00
jenkins-bot 5b5e573383 Merge "Update VE core submodule to master (3a7bad9c0)" 2019-08-21 17:29:08 +00:00
jenkins-bot eaeb3bde40 Merge "MobileArticleTarget: Tweak styling for editor switcher" 2019-08-21 17:00:41 +00:00
James D. Forrester bd0bcff6e4 Update VE core submodule to master (3a7bad9c0)
New changes:
92b32ff5e Localisation updates from https://translatewiki.net.
43950656f Rebaser: Listen to surface history event, not document transact event
3847440a4 Localisation updates from https://translatewiki.net.
5e3e913ea Consider focus, not anchor, in ve.ce.RangeState
56378e975 Prevent RangeState tests from hanging QUnit via a huge diff

Bug: T230814
Change-Id: Ib1f238c4800e3acb581122cbb999a8e59dd5b2c5
2019-08-21 14:33:14 +01:00
Translation updater bot 66223e011b Localisation updates from https://translatewiki.net.
Change-Id: Ie12883ab889384c3b36ed5417747ec8f8bce79e0
2019-08-21 10:11:51 +02:00
jenkins-bot d2c6d0f295 Merge "Fix 'paramter' typo in code and add to typos list, now covering PHP" 2019-08-20 11:32:21 +00:00
DannyS712 00a98dd8f2 Fix 'paramter' typo in code and add to typos list, now covering PHP
Bug: T201491
Change-Id: I28d3b3871a2de54e575163bec7c364b68da8d5a6
2019-08-20 12:10:04 +01:00
Translation updater bot e2348eef46 Localisation updates from https://translatewiki.net.
Change-Id: I9b858efabbf1a390d3984b62f368ec865312e825
2019-08-20 10:28:50 +02:00
Translation updater bot a2ac605ad3 Localisation updates from https://translatewiki.net.
Change-Id: Ib7a3436239f4aa463b6ce6ddee358e784fe5bf8e
2019-08-18 09:34:09 +02:00
Translation updater bot 08a5daeceb Localisation updates from https://translatewiki.net.
Change-Id: Ic6bb33d07dc484779b074ecc022227fb1ff1b71b
2019-08-16 09:19:41 +02:00
jenkins-bot 2d52d7e86c Merge "MWSaveDialog: On mobile show a back button rather than an x" 2019-08-15 09:32:32 +00:00
Ed Sanders 3cbe0a5a20 Update VE core submodule to master (c2c5149f3)
New changes:
62f06382c Localisation updates from https://translatewiki.net.
5fc25c0d9 LinkContextItem: Apply ellipsis directly to link

Local changes to fix link ellipsis styles.

Bug: T230267
Depends-On: I25bb4fa9b7288232b08bab9c88f281817a26d6bb
Change-Id: I8a4b04d45979a1f6c375a7c92a340e3e81d7753c
2019-08-15 10:12:22 +02:00
David Lynch ac471d47e9 MWSaveDialog: On mobile show a back button rather than an x
Bug: T230058
Change-Id: I370fedddf8475e5688ac4ce53f9ccd7d6137705b
2019-08-14 11:38:38 -05:00