Commit graph

16392 commits

Author SHA1 Message Date
Ed Sanders e3d3e0869d Move checkbox widget creation to mw.libs.ve
So this can be used other VE API users (e.g. DiscussionTools).

Bug: T245222
Change-Id: I1e0e9bb9da53a62f8a20126e579dcd6300bd2376
2020-03-13 18:00:44 +00:00
Translation updater bot e2489406e4 Localisation updates from https://translatewiki.net.
Change-Id: Ifbf60de2b50c050451793e238aedbafcb9d6d915
2020-03-03 08:15:29 +01:00
jenkins-bot becafcdadf Merge "Fix checkbox handling in the API" 2020-03-02 18:06:36 +00:00
Translation updater bot 0a6b794f1e Localisation updates from https://translatewiki.net.
Change-Id: I3e082282cde6fbcfba9bb97534bf6809bd47056b
2020-03-02 09:12:09 +01:00
Ed Sanders 42194ec411 Fix checkbox handling in the API
The code for setting 'watchlist' in the EditAPI request
was completely broken as it always evaluated to 'unwatch'.
Instead pass through 'watchlist' directly from the client
where it must be set to 'watch' or 'unwatch'.

Bug: T245579
Change-Id: Ia5a2bb76ef35a685b39bcc0c4727796acd0f510d
2020-02-29 17:35:29 +00:00
Translation updater bot cc557cfef5 Localisation updates from https://translatewiki.net.
Change-Id: I35ae5a73aedd7a3e759f0299d926134be29e2405
2020-02-28 08:23:08 +01:00
jenkins-bot f2cc6d9fc0 Merge "NWE: Don't change editor preference if visual mode not available" 2020-02-27 17:23:53 +00:00
Ed Sanders 71157aab76 NWE: Don't change editor preference if visual mode not available
Bug: T246259
Change-Id: I1513098be707ca5c1a40a061917487785f5100e8
2020-02-27 16:53:45 +00:00
jenkins-bot 983afd6793 Merge "Update VE core submodule to master (244656506)" 2020-02-27 14:38:11 +00:00
Translation updater bot b260f4196f Localisation updates from https://translatewiki.net.
Change-Id: Id2a5c1176cfeac39c180eeb1eedc73b12b9c327c
2020-02-27 08:38:02 +01:00
James D. Forrester 7c69172310 Update VE core submodule to master (244656506)
New changes:
d1c82e84e build: Updating npm dependencies
403f247bf Localisation updates from https://translatewiki.net.
1f6f21ed9 Localisation updates from https://translatewiki.net.
0ac184f4b README.md: Drop DavidDM badges, we use LibraryUpgrader now
6fbfe1a05 Fix: paragraph node image fix
05d04c90a Update OOUI to v0.37.0
3d6031eb8 Update OOjs to v3.0.1

Bug: T245319
Change-Id: I41b69b1645d66c3636d1a622c3cb8051a27f2e7b
2020-02-26 18:32:19 -08:00
Derk-Jan Hartman 9655bee7de Fix dimensions of WE2017 switch to VE
Correct dimensions are 32px, not 34px.

Bug: T223155
Change-Id: I74da7fc12b642984a680d58c20af054ebaf2e64c
2020-02-26 14:02:41 +01:00
jenkins-bot 4a2d636dab Merge "Fix: non descriptive announcement of version no." 2020-02-25 22:00:52 +00:00
Akinwale Alagbe dd91c3cd09 Fix: non descriptive announcement of version no.
When user navigate to the version number,
the screen reader only narrates the hexadecimal number
associated with the version label without providing context
about what this number represents

Bug: T245470
Change-Id: If9cccac0d71de2de5da96a3a053d21e3deb0d80c
2020-02-25 21:45:31 +00:00
jenkins-bot a2ceb67351 Merge "Fix:Internal and External Link annotation widget" 2020-02-25 16:03:01 +00:00
jenkins-bot a0cf9cb9f6 Merge "ve.ui.MWEducationPopupTool: Autofocus the button to close it" 2020-02-25 14:28:05 +00:00
jenkins-bot e736c3037b Merge "screenshots: Fix local test runner" 2020-02-25 13:51:03 +00:00
jenkins-bot 7c1b3d3af7 Merge "screenshots: Fix some timing issues" 2020-02-25 13:50:25 +00:00
Ed Sanders 5428f5452a screenshots: Fix local test runner
Broke after selenium-webdriver update

Change-Id: I424607c9ba741a88b993d2d279045f30c1d50ab7
2020-02-25 12:45:20 +00:00
Ed Sanders bd848eb386 screenshots: Fix some timing issues
Change-Id: I5cfb4025833699bffd4ade3fb659f41c268b8bb2
2020-02-25 12:45:20 +00:00
Translation updater bot 91debd78af Localisation updates from https://translatewiki.net.
Change-Id: Ic96374cc56315af5011207a135ebc7454f0e0c98
2020-02-25 09:37:33 +01:00
Akinwale Alagbe d3292378cc Fix:Internal and External Link annotation widget
Adding the ability to special aria-label for the link annotation widgets
in order to aid accessibility to visually impaired audience

Bug: T245294
Change-Id: I3e1fd4a3e3a951092b5212397acc38b2b89a23c2
2020-02-24 16:40:19 -08:00
James D. Forrester fc44f6c9b9 README.md: Drop DavidDM badges, we use LibraryUpgrader now
Change-Id: I1485727e8ed96f1be98c2c0bcbc1b443dbfbeb5d
2020-02-24 13:42:58 -08:00
Translation updater bot cae5f665b8 Localisation updates from https://translatewiki.net.
Change-Id: I4a355569d662dc1e8d9ad378d8cc7d9d1f23a1d1
2020-02-24 09:04:34 +01:00
Translation updater bot d5bb38c078 Localisation updates from https://translatewiki.net.
Change-Id: Id8f9087599424ccec471879e94b55a57b7c2933b
2020-02-21 09:39:51 +01:00
libraryupgrader 362e96e9d3 build: Updating mediawiki/mediawiki-codesniffer to 30.0.0
Change-Id: I60daaa0abe00ac7d4cc536e6d7baf3c6c3f6769d
2020-02-21 04:29:45 +00:00
jenkins-bot 119d3df502 Merge "Remove incorrect init special case for wikitext single edit tab" 2020-02-20 22:39:13 +00:00
Bartosz Dziewoński 387e0d3cb3 Remove incorrect init special case for wikitext single edit tab
This line was added in 9eebfbcac5
and I can't tell what it was supposed to do (that commit's message
only says "Fix NWE-only edit tab", thanks a lot).

Since then the init code was refactored a lot, at some point this
line was moved to be a part of a completely different check (???),
and now it's causing visual mode to be disabled even though the
user only set their preferences to *prefer* wikitext mode.

Bug: T243723
Change-Id: I3c1f502c3cd079fc5eeb2e9587b22d854ae3a72c
2020-02-20 22:37:45 +01:00
jenkins-bot 95c0f52f19 Merge "Purge autosave before submitting merged content" 2020-02-20 18:47:59 +00:00
Adam Wight c0ad11b960 Purge autosave before submitting merged content
When using TwoColConflict with VisualEditor, the autosave buffer wouldn't
be cleared after saving the successful merge.  This would cause a user to
see a "restore changes?" prompt the next time they entered the editor,
with the potential to confuse them and cause them to do extra work,
repeating the conflict resolution unnecessarily.

This change purges the autosave buffer before submitting a merge.

Note that it is not transactional, so there is a chance we're losing the
autosaved content even if the submit will fail.

Bug: T245119
Change-Id: I150023f548c5565412769d644a828176f907bc25
2020-02-20 09:43:26 +01:00
Translation updater bot c21380cd5a Localisation updates from https://translatewiki.net.
Change-Id: I58af5e859a97df404cc60cf23d904d7617c9e997
2020-02-20 09:28:08 +01:00
Translation updater bot e5de680272 Localisation updates from https://translatewiki.net.
Change-Id: I1f69b23613709c810ace50e22e984b01ec7b6f88
2020-02-19 08:27:05 +01:00
Bartosz Dziewoński 8c949955e6 ve.ui.MWEducationPopupTool: Autofocus the button to close it
Change-Id: I4c2a3620b0477492713580baab8c3ae503009ed5
2020-02-19 00:25:37 +01:00
Translation updater bot d20925df7f Localisation updates from https://translatewiki.net.
Change-Id: Icf185665f5be0b40e37f8acb46019cca0ccad8c7
2020-02-18 08:25:49 +01:00
Bartosz Dziewoński e25ef41c50 Update VE core submodule to master (a5f81e9fb)
New changes:
b95828590 ve.ui.Surface: Fix exception in #scrollSelectionIntoView during teardown
078e9731a Fix: Added aria-label attribute to elements in find and replace dialog.
2c7206491 ve.ce.ResizableNode: Include padding and border when measuring the element
6d4094caa Improve/add accessible titles for toolbar dialogs
3164cd81a Localisation updates from https://translatewiki.net.
d46cf946b Fix: Add aria-label to comment inspector

Bug: T245074
Bug: T245315
Change-Id: Ia3012964adb9ba0ecdf8df104ff346a202bfa54e
2020-02-17 21:38:21 +01:00
Translation updater bot f9f2ef6c8e Localisation updates from https://translatewiki.net.
Change-Id: I38496e87be951e9c540afe9862731272ad2093c0
2020-02-17 08:48:10 +01:00
jenkins-bot 13108d8f4d Merge "ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes yet again" 2020-02-16 00:13:18 +00:00
libraryupgrader 7b6124ae64 build: Updating npm dependencies
* grunt-stylelint: 0.13.0 → 0.14.0
* stylelint-config-wikimedia: 0.8.0 → 0.9.0

Change-Id: I03e09c1152d0d9bebfdd9278c5f410a24f306234
2020-02-15 20:15:05 +00:00
jenkins-bot 95a20dbc08 Merge "ve.dm.MWGalleryNode: Preserve 'class' attribute unchanged" 2020-02-15 16:59:56 +00:00
Bartosz Dziewoński a0c603a137 ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes yet again
This continues to take more effort than all other skins combined, but
still every time our overrides get less crazy. Maybe, and stay with me
here, maybe a year and five patches from now I'll remove the last one.
See 91f99ce78d for the last time.

Change-Id: Id880d1cd1ecef59635b347102dc2107204382fb2
2020-02-15 16:40:57 +01:00
Bartosz Dziewoński 26062fd3a0 ve.dm.MWGalleryNode: Preserve 'class' attribute unchanged
By removing this line, we fall back to the default behavior,
which is to copy the attribute from the original DOM element.

The gallery is supposed to have a class indicating the type (packed,
traditional, etc.). However, Parsoid doesn't care about that and
instead reads the type from 'data-mw'. Instead, changing the attribute
is causing dirty diffs.

Bug: T214649
Change-Id: I96b5a21777046b1caf07a3b1def9fad81bb15939
2020-02-14 22:05:50 +01:00
jenkins-bot 6f7ef2fd76 Merge "Improve rendering of audio files (for real this time)" 2020-02-14 16:04:23 +00:00
Translation updater bot e95bb8cc6c Localisation updates from https://translatewiki.net.
Change-Id: Icbc3acdecf9cd802141959b1825585687c8567ab
2020-02-14 08:26:51 +01:00
Bartosz Dziewoński 9119e57a2e Improve rendering of audio files (for real this time)
ve.dm.MWImageNode:
* Define sensible scalable properties for audio files. They are now
  scalable to any width but have a fixed height. (Ideally they would
  have no concept of height, but that would require many more changes.)
  This prevents them from resetting to 0x0 when resized.

ve.ce.MWBlockImageNode:
* Remove override for #isResizable, audio files can be resized now.
* Move #updateMediaType to MWImageNode mixin so it applies to
  MWInlineImageNode as well.

ve.ce.MWImageNode:
* Add #updateMediaType from MWBlockImageNode.
* Hide the real image 'src' using CSS rather than changing the
  attribute. It seems the previous solution depended on the order in
  which methods are called, because it stopped working when I moved
  the code here. (This depends on VE/VE change If5b1b5b5d.)

audioPlayer.svg:
* Make the file nicely resizeable. The dimensions of the "play" icon
  and time are fixed, the bar adjusts to the width of the container.

Bug: T206022
Change-Id: Ia0f38ca11e0d55a5b725fd9aeb6c79ec1345376d
2020-02-14 04:18:28 +01:00
Translation updater bot 6c6662b7d0 Localisation updates from https://translatewiki.net.
Change-Id: Ibb9127f6832356ccc762920b5fdb57d7dfe83413
2020-02-13 08:55:56 +01:00
jenkins-bot 5bcfdcd963 Merge "Localize remaining hardcoded English error messages" 2020-02-13 00:20:07 +00:00
James D. Forrester eb02880f20 Hooks::isSupportedEditPage: Re-format to make the logic clearer
Change-Id: I8959f1bc4c632fb80fc02374d6ecfc94ef06d9fc
2020-02-12 15:39:55 -08:00
James D. Forrester b7b526a8a5 Update VE core submodule to master (178f5e9e1)
New changes:
178f5e9e1 Update OOUI to v0.36.5

Change-Id: Ifb6ef2e1282fa3ba1f2cab2b969b157ac8e0ac41
2020-02-12 15:37:16 -08:00
jenkins-bot 2b8f2c276d Merge "Fix reporting of loading errors from ArticleTarget#loadSuccess" 2020-02-12 23:33:06 +00:00
jenkins-bot 99b0a33e99 Merge "ArticleTargetSaver: Fix error messages" 2020-02-12 23:33:03 +00:00