* Remove rounded corners.
* Change which borders are used as they change colour on focus.
* Fix margins.
Change-Id: I44f725dfeec5c26f95ba5368ca3848272d66e5be
Local teardown process was jumping to the front of the queue
resulting in the attributeInputs being emptied before they
were read in updateMwData.
Bug: T85818
Change-Id: I24cb490996048e514895c359dedf5945acdecb0a
The issue is that when running automatically, upon loading the
page to be edited a second and third time, the cursor ends up
in a random place within the existing text of the article.
The test expects the cursor to always be at the start of the
article text, and this happens in Firefox.
I did a cursory check and I could not reproduce the issue of random
cursor placement upon multiple edits to the same article. There
may be a bug here, but it is not trivial to reproduce.
So let's take this test out of the Jenkins builds in the service
of more reliable green tests.
Change-Id: Ie3dd76c5b40f3035d43e6f0a06327adb70900f60
MobileViewTarget.
Due to this being missed, pageName was getting set to a jQuery object,
which eventually got passed as a data value in a $.ajax call, causing
jQuery to emit a TypeError: Illegal invocation.
I guess this needs a MobileFrontend commit as well. Don't think it fixes
all the issues with loading VE mobile though.
Bug: T78710
Change-Id: I431a902563f608a7a33028cd60112f39c57000a4
Local changes:
* Call bindHandlers()/unbindHandlers() in activate/deactivate
* Extend onDocumentKeyDown rather than overwriting it
Change-Id: I0739e71781c5140c54512ab421bdcb6d1df5fbbe
Follows-up b0e8900, 447e8de, d3f26e65.
Contrary to binding a reference, this-overiddes for inline
functions gets messy and fragile. There's also a minor
performance overhead that can be avoided. No separation of
concerns, eiter, as the object is held by the closure.
Also:
* Remove left-over instances of @method.
* Remove redundant '0' argument to setTimeout.
* Use null instead of $ for apply() on static methods like $.when.
* Use .empty().append() instead of .html(). Does the same but
without additional overhead and without confusion association
with "html" which isn't used (it doesn't serialise and re-parse
or clone, it just appends when given one or more nodes).
Change-Id: I797a3667c67d52568150be9be5d043d149f22077
New changes:
fd433fa Add getter for toolbarDialogs in ve.ui.Surface
00c3eb7 Add 'done' button to find and replace dialog
3642dc8 Localisation updates from https://translatewiki.net.
fe2d908 Update OOjs UI to v0.6.0
Local changes to ve.ui.MWFormatTool.css for OOjs UI breaking change.
Change-Id: I6bf98ea988b3e1deb4824189ef8e6d59387b6ffc
