wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-30 00:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
14644 commits 13 branches 17 tags 198 MiB
Commit graph

537 commits

Author SHA1 Message Date
ryasmeen@wikimedia.org eea130381a [BrowserTest] Updating test for Media Settings interface 
Fixed the following:
1.The workflow was incomplete and incorporated new changes
2.Wrong css pointer to the first image
3.The Given statement was defined as When in step definition file
4.Removed unnecessary/obsolete steps that was making the test to fail while we can verify the basic functionality with miminum steps.

Change-Id: Ic8a265678900ed52bbed6d90e971d6c016ef610d
 2015-01-30 18:11:33 -08:00
Cmcmahon ee79759d5f [BrowserTest] remove old hack and fix "a is undefined" bug 
This patch removes an old hack from the early days of VE.

Coincidentally, this hack is the root cause of the bug reported
by me, Erik Berhardson, and Elena Tonkovidova: T87446

Thanks Elena for finding this!

Bug: T87446
Change-Id: I325f60586373427acc2cd8f6e2e7d7accac80695
 2015-01-30 22:56:15 +00:00
Cmcmahon fca9110172 [BrowserTest] make rubocop stop complaining 
extra lines in the language_screenshot unit test file

Change-Id: I898ad4c1ce5537c02574dd340866260c18d14cee
 2015-01-30 14:07:17 -07:00
Amir E. Aharoni f4d10e3ee6 [BrowserTest] Shorten all capture_screenshot lines 
Change-Id: I01c11dfc4f4706d45e7bc62261ed133a7bd72092
 2015-01-27 21:37:09 +00:00
Amir E. Aharoni 8da4c9b3cc [BrowserTest] Restore the indentation list screenshot scenario 
* Add a class to the indentation toolbar button, similarly to what was done in
  Ib0cb67151d893a5d2efccf798d6b25d197ed34d2
* Fix the definition of the indentation pull-down element acordingly.
* Restore the Indentation menu screenshot scenario, which was disabled in
  I3e892baa9cb2c8c1303fab232a2b1c64ebdd8f26

Change-Id: If2d92aab6d04aa487d6f753fa7cac94f8d8215c8
 2015-01-27 13:35:39 -08:00
Amir E. Aharoni d20d70cdd6 [BrowserTest] Show the complete insert pull-down in screenshots 
The "insert_pull_down" element only included the menu trigger.

Now it includes the complete pull-down with all the items.

This is consistent with other pull-down elements.

Change-Id: I3f6052eab1ee0322ebb7e6f2116e2d5d0e25f5b1
 2015-01-27 13:35:39 -08:00
Amir E. Aharoni 3f31715c09 [BrowserTest] Consistent names for variables that refer to down-arrow 
Change-Id: Ib7c799af449a9427f6ba25403cbd6b2d220133f0
 2015-01-27 13:35:39 -08:00
Amir E. Aharoni 39afc66a91 [BrowserTest] Shorten lines for clarity 
The 'I take screenshot of insert pull-down menu' step has many
similar very long lines. Shortening them makes
the code more understandable and conforming to the conventions.

Change-Id: I83b35211a6cbfdc420895469747884f3ae864479
 2015-01-27 13:35:39 -08:00
Amir E. Aharoni 024481baae [BrowserTest] Simplify the Selenium selector for the Save button 
The selector was very long and incorrect.

This patch simplifies and corrects the selector.

This also fixes the VisualEditor_save_dialog scenario
in the language_screenshots scenarios.

Change-Id: If822f1b2b8bda4d233dff5a88f6317ee1b0d57f1
 2015-01-27 13:35:39 -08:00
Amir E. Aharoni 401c526d8a [BrowserTest] Remove extra empty lines to make Rubocop pass 
Change-Id: I30be711ee021af3d33b52a957bddd6e76b23b9ae
 2015-01-27 11:09:16 -08:00
Amir E. Aharoni c80e311a02 [BrowserTest] Fix VisualEditor toolbar actions scenario 
The save button changed from constructive (green) to progressive (blue).

Change-Id: Ic410d5ed3847da803d6d83df7f77b6e0edc5d81b
 2015-01-27 04:15:51 +00:00
Amir E. Aharoni 896c8b5d5f [BrowserTest] Change "Headings interface" to "Headings menu" 
Change-Id: I8a50bdf1c49d80ec89c1d87d2a4e353f0aa1a3f9
 2015-01-27 04:15:43 +00:00
Amir E. Aharoni 5b0e34fa4a [BrowserTest] Clean up the 'I am editing' scenario in language screenshots 
Change-Id: Ieecbad486e4b0d2256452c66493ae3cec1643658
 2015-01-27 04:15:20 +00:00
jenkins-bot 049b5798f2 Merge "[BrowserTest] Add test for missing parameter error msg" 2015-01-14 16:14:42 +00:00
Cmcmahon 295f9f81b1 [BrowserTest] Add test for missing parameter error msg 
Test checks for 'Required parameter missing' message, 'Go back'
and 'Continue anyway'.

Paired with Rummana writing this

Change-Id: I9c3aab7f7af9ccde8f0dadd2839a7a698f7341ee
 2015-01-14 16:04:12 +00:00
Cmcmahon 7b9cf21dec [BrowserTest] update Cite test for new Journal fields 
Maintenance

Change-Id: I36d0c8b438e8fa1847c3947ad52e15d2aadbcfb6
 2015-01-13 15:14:26 -07:00
jenkins-bot c878a3e7e9 Merge "build: Bump copyright notices to 2015" 2015-01-13 16:21:37 +00:00
Amir E. Aharoni 7c128f9a4a [BrowserTest] Make the Save page element language independent 
This element used the English label. It should just use
the class to be language independent.

I tested by running VisualEditor_save_dialog scenario
in language screenshots for the Persian language. It fails
on master because of the English label and passes with this commit.

Change-Id: I77955b3dfabbf6a15885c085e3fbdd447b04b4db
 2015-01-13 13:05:35 +02:00
jenkins-bot 19270a31d0 Merge "[BrowserTest] Change the Heading menu item from a to span" 2015-01-13 10:25:31 +00:00
Amir E. Aharoni 7a4ec947fa [BrowserTest] Change the Heading menu item from a to span 
Change-Id: I214f8dbc73e38073f6e8dedfb61d75b1e829fa38
 2015-01-13 12:21:10 +02:00
Amir E. Aharoni 919d62e66c [BrowserTest] Remove the page settings scenario from language screenshots test 
It will be fixed later. It needs better element definition
to run successfully, and until it's properly fixed
it should be disabled to let other jobs pass.

Bug: T86634
Change-Id: Id41d1329d22679b6a61201ceafc81eafa222d909
 2015-01-13 12:14:44 +02:00
James D. Forrester 2f8b3e0d96 build: Bump copyright notices to 2015 
Change-Id: Ie92dab7411116d3410195c3fb0a3513c664c0c30
 2015-01-12 20:34:19 -08:00
Amir E. Aharoni cd4bd7a73c Add classes to toolbar UI elements 
This cleans up the selectors for the elements on the toolbar
so that they can be tested.

Class names in the form of ve-test-* are added to elements
that have words for labels: 'Paragraph', 'Cite', 'Insert'.
There is no other way to look up these elements in the DOM
except using the UI text, but it is different in different languages,
so this is unusable for the language_screenshots job,
which is multilingual by its nature.

Bug: T76143
Change-Id: Ib0cb67151d893a5d2efccf798d6b25d197ed34d2
 2014-12-30 12:16:44 +00:00
Cmcmahon 2ebbd0f038 [BrowserTest] This test is unreliable in any version of Chrome 
The issue is that when running automatically, upon loading the
page to be edited a second and third time, the cursor ends up
in a random place within the existing text of the article.

The test expects the cursor to always be at the start of the
article text, and this happens in Firefox.

I did a cursory check and I could not reproduce the issue of random
cursor placement upon multiple edits to the same article. There
may be a bug here, but it is not trivial to reproduce.

So let's take this test out of the Jenkins builds in the service
of more reliable green tests.

Change-Id: Ie3dd76c5b40f3035d43e6f0a06327adb70900f60
 2014-12-19 09:34:20 -07:00
Cmcmahon a479d04299 [BrowserTest] clear default text before entering search text 
Change-Id: Ief375c95ebee65a1add2fdf1b7c45e600df181a3
 2014-12-17 10:37:27 -07:00
Cmcmahon 4fbd141b49 [BrowserTest] update test for new selector 
Change-Id: Ic3bc3b416bc7ddadef7a05699f6181c0b7b84cdd
 2014-12-17 10:22:44 -07:00
Cmcmahon c34fd60a9b [BrowserTest] update general markup test 
refactor for new locator

Change-Id: I089aebb64a9d67d01c1bfa4682927c0de2575051
 2014-12-17 09:31:24 -07:00
Cmcmahon 30c3aa2242 [BrowserTest] update Links test 
another iframe gone it seems

Change-Id: I33767706675bbdcd1cb45f33da109858ec36986e
 2014-12-17 08:51:17 -07:00
ryasmeen@wikimedia.org 5eff6e8aa1 [BrowserTest]Fixing options test 
Fixed the unique selector for failing cases
Change-Id: I41bde7245328303fcc8c5afea8f7228c1d36b915
 2014-12-16 17:36:50 -08:00
jenkins-bot 6ca0046599 Merge "[BrowserTest] changing the css paths for Cite options for fixing the tests" 2014-12-16 22:36:50 +00:00
ryasmeen@wikimedia.org aa77e8ab4f [BrowserTest] changing the css paths for Cite options for fixing the tests 
Change-Id: Iea90e4bb656b30ec0839e6c843e30ba8ae1fd637
 2014-12-16 15:33:37 -07:00
ryasmeen@wikimedia.org a8807c6af4 [BrowserTest] Adding tests for checking fields under Page Settings 
Change-Id: I31d8d3327bd8abe6a7c5f3c4941174253104bbac
 2014-12-15 21:37:42 +00:00
Ed Sanders 45518019eb Update VE core submodule to master (9ac8136) 
New changes:
9929b6d [BREAKING CHANGE] Make ve.init.target an OO.ui.Element

Local changes:
* Fix target constructors now they generate this.$element

Change-Id: Ia6bf604c67305834a3f73863a10336cfbb83fa77
 2014-12-11 14:00:28 -08:00
Ed Sanders d6067d5718 Update VE core submodule to master (cf1e167) 
New changes:
776e801 Delimit text nodes in debug observations
72643bc Remove debug bar hiding now it is handled by the surface
cf1e167 [BREAKING CHANGE] Multiple surface support and demo

Local changes:
Account for detachable toolbars in core being setup in a different order.

Change-Id: I29156948711d55ba5f6dd4f6c35ca0e4cca32373
 2014-12-11 12:49:29 -08:00
Cmcmahon 122099fda8 [BrowserTest] issues with Chrome at SauceLabs causes test to fail 
This is one of several VE tests that do not work well with older
versions of Chrome

Change-Id: Id7afc51689557d9e86e67a07dc840a8e6ca8303e
 2014-12-10 15:00:05 -07:00
Cmcmahon 978308ee1f [BrowserTest] update Cite tests 
Seems that a set of invisible textareas have appeared

Change-Id: I2ee81c782220c632393d2bbdc66ca66a5c8bf667
 2014-12-08 10:43:35 -07:00
jenkins-bot 77b507dfc7 Merge "[Browsertest]Tests for options under Advanced Settings panel" 2014-12-02 23:03:37 +00:00
ryasmeen@wikimedia.org 416d62df4f [Browsertest]Tests for options under Advanced Settings panel 
Change-Id: I21765e9e3d7a004d24dd620dd0da35978632d02a
 2014-12-02 15:00:33 -08:00
Željko Filipin 15ed437331 [BrowserTest] Fixed a couple of page elements 
Change-Id: Ia4652896243705651c86ff5f83dbd03029757705
Paired-With: Amir Aharoni
Bug: T76133
 2014-11-27 11:39:02 +01:00
Bartosz Dziewoński e2d4f5b533 [BrowserTests] Fix class name: ve-ui-contextMenuWidget → ve-ui-contextSelectWidget 
Change-Id: I70f44e71819e9147886bd70baf3460daf9ebbaf2
 2014-11-22 01:56:29 +00:00
Cmcmahon 34f3572372 [BrowserTest] love for test that targets test2wiki 
Change-Id: Ie37d88e891b592745e8f430da4481f2f1d2bd530
 2014-11-21 21:28:25 +00:00
Cmcmahon f7a7a89d00 [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome 
No combination of WebDriver for any version of Chrome on Linux
works 100% correctly.

Remove the failing tests for now.

Change-Id: I46be2c2c857e93234c839d32f1c0d4224733d0f7
 2014-11-21 21:26:20 +00:00
Cmcmahon 2449ebde99 [BrowserTest] consolidate some duplicate elements 
and remove one unused

Change-Id: Ica50cf74edd9a21423800a7d58f4832b77a7e8bc
 2014-11-21 13:28:01 -07:00
Cmcmahon f6526cb0a9 [BrowserTest] comments for classes 
Change-Id: I3d5e063ee4dd36632ab9c2a433660567b70777ea
 2014-11-21 09:49:50 -07:00
Cmcmahon 473877202b [BrowserTest] rubocop change to an if() 
Change-Id: I5ae9ec4d94af88fa67ac8de58a38b6ea03b14acc
 2014-11-21 09:40:40 -07:00
Cmcmahon 95a798867c [BrowserTest] rubocop proper format for comments 
Change-Id: I2fe136f29e0bc430420a0931092695d3f4147112
 2014-11-21 09:21:53 -07:00
Cmcmahon 1b69fc97c7 [BrowserTest] Fixed Style/SpaceAfterComma RuboCop offense 
Change-Id: Ia11c32c74acf4c2226f84ea566f4074b193f4e20
 2014-11-21 16:15:58 +00:00
Cmcmahon ede14c75fb [BrowserTest] rubocop updates to replace double quotes with single 
Change-Id: I0608aea2bd634156bf800b3be47a5c2a6d9fadca
 2014-11-21 09:06:09 -07:00
Cmcmahon 2f05d1b10a [BrowserTest] more rubocop style fixes 
Change-Id: Ibc1cabbdc00f569b10fd6aae0e5bb998211745b1
 2014-11-20 12:07:45 -07:00
Cmcmahon 65e4d91cf0 [BrowserTest] Rubocop style fixes 
Change-Id: Ieb1ba49f2a987b41f82a3b66c542fba48313eb1f
 2014-11-20 11:55:40 -07:00
Cmcmahon 513031c4bf [BrowserTest] locator changed 
Change-Id: I3aeb1f60cf512c55f497f4ef6743b149bc0add43
 2014-11-20 10:02:20 -07:00
Amir E. Aharoni a513ba9583 [BrowserTest] Fix the index of the insert menu 
Change-Id: Id0e821d3cf01efff74fdb189cf09d24d9eb753e2
 2014-11-20 10:52:47 +00:00
ryasmeen@wikimedia.org 6cce39ee10 [BrowserTest] Extend options test 
Adding cases to test categories in options.feature

Change-Id: I6fbe8bc170306c5f2942bf3c7e87f7a3ff661bb2
 2014-11-19 16:26:07 -07:00
Cmcmahon c49b2a77f2 [BrowserTest] once more 
Change-Id: I34b4be6aadf991cf9d12c76fd8c8410697b2b500
 2014-11-19 14:53:08 -07:00
Timo Tijhof dc648e6b06 test: Omit 'window' in mw-preload.js 
Follows-up 92c38ea.

Change-Id: Ib8a37036a1a9dac980527bfccd506fff5ea8dce1
 2014-11-19 01:46:38 +00:00
Cmcmahon 210169c55b [BrowserTest] forgot a bit of dead code 
Change-Id: I249e229d449eb74ff341f511e84290a4ca731f92
 2014-11-18 13:09:17 -07:00
Cmcmahon 6489767bc7 [BrowserTest] remove sleeps from shared tests 
* remove dead code

Change-Id: Id95ff81746eb440124958bcc6dd9334b7ed299a4
 2014-11-18 12:59:34 -07:00
Cmcmahon 06aa53747c [BrowserTest] interim step, no functional change 
Change-Id: I3a7787c4ab9206c70f0f64b6c0986ae93ddb3d84
 2014-11-17 15:14:32 -07:00
Cmcmahon 94bab8f918 [BrowserTest] update transclusion test for Page Object vio and RS 
Change-Id: Ie80dce2d117d4d2dc836681dcd9362ae565f2aa8
 2014-11-17 14:59:14 -07:00
Cmcmahon 743d035fa1 [BrowserTest] update switch-edit-mode test for RSpec3 
Change-Id: Ia040f8b6e76a42c2c80bda382bf6ad6f30988ba1
 2014-11-17 14:42:59 -07:00
Cmcmahon fa02c60586 [BrowserTest] fix minor Page Object design violation 
Change-Id: I75d282a7e176347b0995f2c2ccda8ab051aca270
 2014-11-17 14:18:13 -07:00
Cmcmahon 4383dedcfc [BrowserTest] minor violation of Page Object design pattern 
and RSPec syntax also fixed

Change-Id: I2bbaf460f6ddae708ea243064dd9a596bdd006f1
 2014-11-17 14:07:16 -07:00
Cmcmahon 3c5e695c5d [BrowserTest] more update to Cite test for RSpec3 
Change-Id: Ia2fa25bffe9bbdffb0eafc19396c06be253216c3
 2014-11-17 13:56:08 -07:00
Cmcmahon 94c30f01da [BrowserTest] update Cite test for RSpec3 
Change-Id: I589a65e0fe1b21ca6476a5c31b97d7632da39b13
 2014-11-17 13:31:30 -07:00
Cmcmahon 87ad037442 [BrowserTest] remove sleep() from template test 
Change-Id: Ia564232e02db2e6be3070d98691097350e920a3b
 2014-11-17 13:13:25 -07:00
Cmcmahon ea0fac5e4f [BrowserTest] interim step to sort G/W/T statements properly 
no change to function

Change-Id: I2c2e9ccb6535c875d37ef59ab873a2f3280cca60
 2014-11-17 12:27:06 -07:00
Cmcmahon 9a4d2eeef9 [BrowserTest] interim step to alphabetize 
no change to function

Change-Id: Id655a9777e3b8bd3e3fbb974c73912f9f975bf7c
 2014-11-17 09:09:06 -07:00
Cmcmahon 17f6badf0a [BrowserTest] update references test for modern RSpec syntax 
simple update to a nice test

Change-Id: Iad00e779295ccc610d20241693a87b76b817fbd6
 2014-11-14 15:52:51 -07:00
Cmcmahon 6d22cebb62 [BrowserTest] remove sleep from multiedit test 
* put the shared step in shared_steps.rb
* replace "onfocus" with simple "click"
* update RSpec while we're at it

Change-Id: I77754abdbeba1314758f5fe10601f6601e8783bd
 2014-11-14 15:30:10 -07:00
Cmcmahon 36e07b247e [BrowserTest] simple upate to a nice test 
Change-Id: Ib52582a677d8dc2f22552bf7c60f48de8f20d3c7
 2014-11-14 13:43:31 -07:00
Cmcmahon ea9df60aa3 [BrowserTest] RSpec update 
Change-Id: I03f89eda4292482dedaa335e3546af724ee55024
 2014-11-14 13:32:59 -07:00
Cmcmahon 1aa5d8905b [BrowserTest] remove sleeps from links test 
Change-Id: Ib0e09735331dadd5bb494fe87683f6f08b6aee31
 2014-11-14 12:30:13 -07:00
Cmcmahon da42fe407c [BrowserTest] hygiene changes 
* alphabetize headings steps
* move diff view check to shared_steps.rb

Change-Id: I68ac8de2f67a61bdd50f4892f58368e1bbd71271
 2014-11-14 16:05:14 +00:00
Cmcmahon e4eeb40c17 [BrowserTest] interim alphabetization only 
Change-Id: I3a724d2cadbc40c63978058e4b2684ef86ceec03
 2014-11-13 10:04:19 -07:00
Cmcmahon 3ed807277e [BrowserTest] minor updates for hygiene, no functional changes 
Change-Id: I3d8ca33bd850caeb44b8e8e8017f2fa302676b1a
 2014-11-13 09:08:15 -07:00
Cmcmahon 41aaaf4886 [BrowserTest] make bullets test modern 
* remove unnecessary wait times
* remove unnecessary sleep() statements
* remove unused steps
* update for RSpec3.0 syntax

Change-Id: Ie76135154042834e2eb8b008872aced5ac210ee5
 2014-11-12 10:55:37 -07:00
Cmcmahon 87bd220eed [BrowserTest] refactor for alphabetization and space only 
preliminary to updating Then statements to RSpec3.0 syntax

zero change to function or syntax, just arranging things so
we can review them later.

Change-Id: Id0f006d0fcf74010c06cb7ae6386ea6bcaff0e55
 2014-11-12 09:22:30 -07:00
Vikas S Yaligar 901b0deeed [BrowserTest] Fixed failing language screenshot browser tests 
Bug: 73033
Change-Id: Iea3a03b1ec628bfe03f10b4cb2a4795d4fabb8bc
 2014-11-10 11:07:49 +00:00
jenkins-bot 209dbe2449 Merge "Allow headings in table cells" 2014-11-05 23:52:23 +00:00
Cmcmahon beebfff6f9 QA: sort remaining page elements that belong in the iframe 
We need to figure out where the language screenshot elements reside

merged as an interim step to share the code more easily, no change
to function

Change-Id: Icae480aaa526a9de6e6926e027c0cac0c7de997e
 2014-11-05 15:39:10 -07:00
Ed Sanders 26f567d84f Allow headings in table cells 
We possibly want to discourage this somehow but our current
functionality achieves this by doing an isolateAndUnwrap
which for a table is catastrophic.

Bug: 72990
Change-Id: I79f1348da20385dfec014afcac0fb5464580cf2f
 2014-11-05 22:34:13 +00:00
Cmcmahon f8b34e4e89 QA: remove stuff now that iframes are gone 
Change-Id: I6d520acd9d1e18d803f7e44f5ea45502658f14d9
 2014-11-05 10:01:55 -07:00
ryasmeen@wikimedia.org 4aa8be0e71 [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature 
Also:
* Fixed a typo in options_steps.rb
* Disabled Metrics/ClassLength Rubocop cop.

Change-Id: I7128ba8f7ebf9c63aef9399a9cdf24831e1a2d38
 2014-11-04 15:01:45 -08:00
Cmcmahon 3b53b23fb1 [BrowserTest] no iframes for switch mode test 
Change-Id: I99e4686144ded173f8d91be87f02a4c144284237
 2014-11-04 08:06:33 -07:00
Cmcmahon 0f2310a49d [BrowserTest] no more iframes for "no review" message 
Change-Id: I9f7429eff32043c26264faa48404e6f573330b7f
 2014-11-04 07:46:24 -07:00
Cmcmahon 666001ba1c [BrowserTest] no more iframes for transclusion 
Change-Id: Ifc50a50e98de18612e6ab4b548b1cf6ec05bc825
 2014-11-03 16:27:17 -07:00
Cmcmahon aab1680244 [BrowserTest] no more iframes for switch modes test 
Change-Id: Ifebc458f9ff9583954226d86759753b0314db649
 2014-11-03 15:51:55 -07:00
Cmcmahon 396d74053b [BrowserTest] no more iframes for References 
Change-Id: I7f5cf7b991cfcfd3ebebe0f17bb594802fe7dea0
 2014-11-03 15:41:38 -07:00
Cmcmahon 9b6e21cf0b [BrowserTest] no more iframes for options 
Change-Id: Iee2c88f693edb68017154a497aea05d16eb7453c
 2014-11-03 15:18:44 -07:00
Cmcmahon 6907583418 [BrowserTest] no more iframes 
Change-Id: I8090f95ccd1cf2744649084c863e6034db062d87
 2014-11-03 14:45:52 -07:00
Cmcmahon fcfb847276 [BrowserTest] no more iframes for Media test 
Change-Id: I724e071935f383185fdc44cf1a139931f8ded557
 2014-11-03 14:37:59 -07:00
Cmcmahon a51783983f [BrowserTest] no more iframes for Links test 
Change-Id: I72c01981b332a32711e929543a61a780de962a2e
 2014-11-03 14:18:21 -07:00
Cmcmahon 61f8cf7ca5 [BrowserTest] click More button, no iframes 
Change-Id: I1426f4dcfb65d6e38be5f7e495e9600f98894525
 2014-11-03 13:57:29 -07:00
Cmcmahon 3b57451863 [BrowserTest] no more iframes for Cite test 
Change-Id: Ic31521dc8124818df1451a57ae396ca2e9c6beef
 2014-11-03 11:57:55 -07:00
Cmcmahon 282afbbb2f [BrowserTest] Resume Editing no longer in iframe 
Also workaround for Bug 72911

Change-Id: Idbff05837dd97ace534ec732c0ba56b6b523bbe0
 2014-11-03 11:02:23 -07:00
Cmcmahon df039a6ee9 [BrowserTest] stuff moved out of the iframe to the main page 
step-wise update, probably more changes to come

Change-Id: Ia40c03dd59ab0b28af56176b6da4d30a1e66a195
 2014-11-03 10:31:26 -07:00
Ed Sanders cfee8047e4 Use ClassAttributeNode mixin in MWBlockImageNode 
This functionality was factored out into core for this purpose.

Depends on I2db6563 in core.

Change-Id: I4fc42e1468a9f0860c7c13e73967204bdf5ad78d
 2014-10-29 18:28:33 +00:00
Amir E. Aharoni b4e98c1490 [BrowserTest] Disable two failing scenarios 
To allow other screenshots to be created.

Change-Id: I3e892baa9cb2c8c1303fab232a2b1c64ebdd8f26
 2014-10-29 09:44:55 +00:00
Cmcmahon 0a3ac40288 [BrowserTest] Add "Then…" steps to Cite Basic test 
Change-Id: I43b28e8c95d3da0c3b94a8ea12ff3c376eedb1b5
 2014-10-22 01:00:08 +00:00
Cmcmahon bc76c6ea3e [BrowserTest] create simple test for Basic Citation 
We can make this more sophisticated later, but right now it
accurately checks that upon clicking Basic citation, the user
sees a true VisualEditor UI

Change-Id: Icea910e2bc1bbd4277a7e8eee08f2b0e49661062
 2014-10-21 12:10:19 -07:00
Željko Filipin 32736ae679 [BrowserTest] Prepare repository for running RuboCop after every push to Gerrit 
For now ignoring all problems.

Bug: 69245
Change-Id: I4f5db441725062c1ea1ad8ba0955f18f49973583
 2014-10-21 17:35:04 +02:00
Ed Sanders ecdfeb3892 [BrowserTest] Fix class name for ve-ui-contextMenuWidget 
Change-Id: Ia189ee285b5614ada69844b06545847caf21fd77
 2014-10-17 19:12:42 +00:00
Cmcmahon ceab7f8f76 [BrowserTest] update for autopopulated fields 
Website citation now auto-populates

accessdate = {{CURRENTMONTHNAME}} {{CURRENTYEAR}}

along with whatever the user puts in that field

Change-Id: Id72558f972be1ecc490fb196c941961871c21cf2
 2014-10-16 10:09:04 -07:00
Cmcmahon 08e7f55a51 [BrowserTest] suggest list is no longer in the iframe 
Change-Id: I20e58b4de436b09f08cbea01b05c5fa578e5721d
 2014-10-14 11:13:29 -07:00
Alex Monk 8bc150f901 Sort out some odd file permissions 
Bug: 71933
Change-Id: I520ee83a9b4d6adec4b430238640cfd58b49aeb4
 2014-10-12 03:01:31 +01:00
Ed Sanders eb81251401 Update method name in test description 
Change-Id: Idf01c167b5c7f3d930b23778e72c242bb5b61c40
 2014-10-10 10:20:35 +01:00
Amir E. Aharoni 97b9c1111a [BrowserTest] Handle a off-bounds image condition in language screenshots 
Paired-With: Zeljko Filipin.

Change-Id: I73cba5b5214798958aba6ed2a87361e2bd1b76a7
 2014-10-09 14:28:50 +00:00
Ed Sanders 1af18c3c12 Update VE core submodule to master (984b57a) 
New changes:
6bbcd6a Localisation updates from https://translatewiki.net.
b8d8a5b [BREAKING CHANGE] The Great Selection Rewrite of 2014

Local changes:
Update to use new selection/range API

Change-Id: I5480d5c77d599c93c2d374fac88bb2fdb68b0024
 2014-10-07 21:39:33 +02:00
jenkins-bot c823b736ec Merge "[BrowserTests] Put automatic language screenshots in more specific category" 2014-10-02 15:34:13 +00:00
Željko Filipin 4d036f6fe1 [BrowserTest] Fixed language screenshot scenario 
VisualEditor no longer has cancel button.

Change-Id: Ia06469c23cc527ae87170d6aa5b9066fbc9933a6
Paired-With: Amir Aharoni
 2014-10-02 15:34:04 +02:00
Željko Filipin 4ab4ad64dc [BrowserTest] Fix failing VisualEditor_save_dialog scenario 
Looks like VisualEditor does not allow saving the page, if the changes
to the page were made while the browser did not have focus.

Change-Id: I959bcb4cc2f72237d2ea75249a56e140d4f7c867
Paired-With: Amir Aharoni
 2014-10-02 14:45:24 +02:00
James D. Forrester 5ed0f35e11 Move IE10 to the greylist too 
Also add a test for IE11 being on the greylist.

Change-Id: I45f1b9f00320237597fa1974932c04102328f0b6
 2014-09-26 12:56:04 -07:00
Vikas S Yaligar 9a5caf8dd2 [BrowserTest] Fixed failing language screenshot scenarios 
Bug: 71298
Change-Id: Ifcd52935e782e292f9289a72d5e7c4ad12921b4b
 2014-09-26 17:49:24 +00:00
jenkins-bot 7c1c8cfe2e Merge "Remove test for functionality tested in core" 2014-09-26 02:51:33 +00:00
James D. Forrester 136510b1cc [BrowserTests] Put automatic language screenshots in more specific category 
Change-Id: I52f92a3e4da0f173596c8a68a572351deba46ade
 2014-09-25 10:45:41 -07:00
Željko Filipin ac804a537a [BrowserTest] Disable screenshots for broken scenarios 
Workaround for bug 71298.

Change-Id: I23ed22f8859a09821b6ef5edac8eff4ca0f3b17c
Paired-with: Amir Aharoni
Bug: 71298
 2014-09-25 15:18:47 +02:00
Roan Kattouw 34ec304ec7 Update VE core submodule to master (d6904b5) 
New changes:
925ed5c Move sluggability methods to model
a618491 Calculate slug positions in the model
b8fb05e Make the trigger demo kind of work again
e41d22e Update OOjs UI to v0.1.0-pre (ec785c2c64)
4119470 build: Make headers atop dist files suitable for distribution
fca4fec Follow-up cc657c4: Change strikethrough key command to not clash with Macs
a29a561 Add hasSlugAtOffset to DM document
9f47efb Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model
aa35e96 Remove hard coded types from canHaveSlugBefore and fix logic
49a239b Emit 'position' and 'contextChange' events correctly
3c50321 Refactor out finding of CE focusedNodes
d6904b5 Update OOjs UI to v0.1.0-pre (f2c3f12959)

Local changes:
* Move ce.Document tests to dm.Document

Change-Id: Ifa5abd0341e858b20e73e9071d597a25112cadfb
 2014-09-18 17:03:46 -07:00
Ed Sanders 69ae829737 Remove test for functionality tested in core 
Add comment to remaining test explaning its purpose.

Depends on Id7c291b in core.

Change-Id: Ia545edac3b2adbd6d45ed5427a9e5e6f9df0da54
 2014-09-18 13:15:24 -07:00
Ed Sanders 480d9c05fc Remove 'new' keyword where not used 
Factory methods create the instance internally.

Change-Id: I1daa9751536948edc98bd71305a942418806c459
 2014-09-18 12:54:41 -07:00
Cmcmahon b6b93fc860 [BrowserTest] inadvertent clash of identifiers from earlier update 
Change-Id: I1a86db0f4fa9ee0f327cf371b76c9ebf25ddc17e
 2014-09-15 14:48:49 -07:00
Cmcmahon e71699f06a [BrowserTests] Pick up the latest webdriver to run latest Firefox 
Pure maintenance

Change-Id: I709bcae2a609904c5ce75e22c61588d5012dec17
 2014-09-15 13:48:12 -07:00
Cmcmahon 954fec83e1 [BrowserTest] UI text changed s/Cancel/Resume editing/. 
Change-Id: I774b6a3cf02627ea0399377b9f6d57ca474ead07
 2014-09-12 10:53:59 -07:00
Cmcmahon aa67deaeef [BrowserTest] add one test to validate new ie11 build 
Change-Id: I9add1caf0083e757d0a7f6da513bd798fd74e97e
 2014-09-12 08:55:14 -07:00
jenkins-bot 050205ea85 Merge "Convert all instances of assert.equal to assert.strictEqual" 2014-09-11 21:37:45 +00:00
Ed Sanders c35d68d52b Convert all instances of assert.equal to assert.strictEqual 
We don't tolerate == in our code, so we shouldn't use it in our tests.

Change-Id: I6ed7aebbad8013839af2521819fc6507df014a1a
 2014-09-11 10:50:44 -07:00
Cmcmahon 3351241659 [BrowserTest] Add @safari and @internet_explorer tags for Jenkins build 
Change-Id: Ia39fd2cf40cea7f6c4df364a45b0744ca92bfb7d
 2014-09-11 08:11:47 -07:00
Cmcmahon 6a90a9070a [BrowserTest] Locator for template field remove changed 
Change-Id: I647a937c6e07e6bf3dae515fd684ebe2274ddc54
 2014-09-04 10:45:55 -07:00
Cmcmahon 16ca79057f [BrowserTest] updates for Cite test 
Test additional fields

Change-Id: I9368962bd2b8e7217c064c9b8779d5d53585154d
 2014-09-04 10:07:27 -07:00
James D. Forrester f2e22babaa Update VE core submodule to master (1f82a47) 
New changes:
5d063a2 Don't use three different coordinate systems in getSelectionRect()
feeb1ae Only focus the paste target if focusedNode has changed
2c1bb97 Update OOjs UI to v0.1.0-pre (4cef83f702)

Local changes:
* Update references to renamed classes
* Update calling patterns element mixins

Change-Id: I330c0e308807597dec31dad8dbf713eb29fdc290
 2014-09-03 17:20:09 -07:00
Cmcmahon 1b45b120e8 [BrowserTest] update Cite element locators 
Also small refactor for readability

Change-Id: I65c1b589413bdb7de784aa3c4e0e189fca10bab3
 2014-08-29 10:12:31 -07:00
Cmcmahon 3a964326a5 [BrowserTest] element locator changed 
Change-Id: I456cd0718513e6338ccbbae86634d3e3bd1464b9
 2014-08-29 09:12:50 -07:00
Cmcmahon af988015bb QA: update to fix deprecated API token call 
Change-Id: Ibad3aa773dcf5390eb7c729a2731ef2fe76b174c
 2014-08-27 09:27:52 -07:00
jenkins-bot aa95f70c4e Merge "Switch 'disallowQuotedKeysInObjects' jscs rule on and fix up" 2014-08-25 18:00:07 +00:00
Ed Sanders 9a1e3852fc Update VE core submodule to master (c231b71) 
New changes:
c9f1027 Remove broken ve.isMsie() function
6571da1 Fix case on language annotation CSS class
c231b71 Fix case in all annotation classes

Local changes:
Fix case in all annotation classes

Change-Id: Iba2596cde52d8f8be27e0257893ef8ec77798ae8
 2014-08-22 14:27:14 -07:00
James D. Forrester a232147b11 Switch 'disallowQuotedKeysInObjects' jscs rule on and fix up 
Change-Id: I75ac4b378ef485feead9d0eff34ed7877b94b5d0
 2014-08-22 13:50:48 -07:00
Cmcmahon 0755c16e85 [BrowserTest] language screenshot update 
I think I broke this by accident, fixing

Change-Id: I51051fdf71c593bf14ad3fca9a12c554ade5274a
 2014-08-21 15:46:53 -07:00
Cmcmahon b9b76bb5e1 [BrowserTest] UI has new text in buttons and headers 
Change-Id: Ifb2fac1ec47672751f9a585a2a60827d7981ac00
 2014-08-21 14:56:03 -07:00
jenkins-bot 60808e5d54 Merge "[BrowserTest] add News and Journal to Cite test" 2014-08-21 20:19:19 +00:00
Cmcmahon bc9ecd1d46 [BrowserTest] add News and Journal to Cite test 
Change-Id: I86922627de85371e6c5447a92f0671bea42cda5f
 2014-08-21 13:17:01 -07:00
James D. Forrester 1e68d0cb5e Re-label inserting mode of transclusion dialog from "New template" to "Add a template" 
Bug: 69692
Change-Id: Ia762d35117b01a908e04cf4b7ac1582f3d148f6f
 2014-08-21 01:52:23 +00:00
James D. Forrester 5148a0836a Rename "reference list" to "references list" internally 
That's what we call them in human-speak, and it makes sense to have them align.

Bug: 49923
Change-Id: I8dcfba249fb9ea13c2b4052e98a4d253c302b1ba
 2014-08-20 18:26:54 -07:00
Roan Kattouw c43dc5e362 Bring MWTransclusion example data out of the stone age 
The example data still used the old format for data-mw that predates
support for multi-template transclusions in Parsoid. The old format
has now been retired, and any attempt to interpret it will cause
JS errors.

Also removed data-parsoid from most of these examples while I was
at it.

Change-Id: I2b7816b7edc580cec0ed29fb166458351a0c6ed3
 2014-08-20 13:54:46 -07:00
jenkins-bot 14f02ac15f Merge "[BrowserTest] create new test for Cite tool" 2014-08-18 17:20:20 +00:00
Cmcmahon 0f5289294d [BrowserTest] create new test for Cite tool 
Change-Id: Ibc06377fa28bef53a5f8ca734026a4485888e0ad
 2014-08-18 10:17:17 -07:00
Roan Kattouw e72f804565 "Fix" hack in ve.test.utils to prevent immediate surface setup 
This used to work because loading i18n files took time. However,
we now don't register any message paths with the platform, so
platform initialization is now synchronous, which breaks the hack.

Instead, explicitly assign an unresolved deferred to the platform's
initialization promise, and resolve it after the mw.Target has been
constructed.

*barf*

Change-Id: I287cb86ce8c4c534fd723532f34463359a8ccc7c
 2014-08-13 12:37:31 -07:00
Vikas S Yaligar 438f0a0fcc [BrowserTest] Language screenshot job should run specific scenarios 
Change-Id: Ia8ab136018b434b4d53db06f8c91af95e3ef8474
 2014-08-13 14:15:03 +00:00
Vikas S Yaligar d39f014058 [BrowserTest] Added browser tests for formula, reference list and save button 
Change-Id: I96a7dfd09336ae919775f7d0234dd9c11ce93268
 2014-08-13 13:39:10 +00:00
jenkins-bot 623b59e4a5 Merge "[BrowserTest] Browser can now zoom out whenever required" 2014-08-07 08:56:49 +00:00
Vikas S Yaligar d6836f1ac5 [BrowserTest] Browser can now zoom out whenever required 
Change-Id: I50c3a0a0473d487249fbf7c830cf7d9f5fc528bc
 2014-08-07 14:11:42 +05:30
Vikas S Yaligar 69c665979f [BrowserTest] Added support for highlighting the page object elements 
Sample screenshot => http://www.mediawiki.org/wiki/File:VisualEditor_Media_Insert_Menu-en.png

Change-Id: I92e204db4c3e4101bc8a88093359ce199d3dbba1
 2014-08-06 13:49:55 +00:00
Vikas S Yaligar ca6816be63 [BrowserTest] Client logins only once to upload all screenshots 
Change-Id: Ic242d8b2f35ced23809d4454a44f28f260bb3eb7
 2014-07-29 12:35:19 +00:00
jenkins-bot 265de12b2d Merge "[BrowserTest] Language of images should be in subcategory of VisualEditor" 2014-07-29 12:35:05 +00:00
Vikas S Yaligar c6b96d10e5 [BrowserTest] Save button locator now supports language screenshots 
Change-Id: Ib3b6c577aee3e8fa61f76f19a170e4cf5c76bf45
 2014-07-28 20:02:04 +05:30
Vikas S Yaligar d4eb0ea00d [BrowserTest] Language of images should be in subcategory of VisualEditor 
Paired with Amir Aharoni

Change-Id: Ibf77dffbb3468446c3a5828fad053f8cac6861af
 2014-07-28 13:16:38 +00:00
Cmcmahon 2fb3375000 [BrowserTest] turn Headings test back on for the builds 
Change-Id: I58848fc8393ac2007dbb724e34a4c85e5142df7d
 2014-07-25 12:55:11 -07:00
Cmcmahon 9b93c2c4fd [BrowserTest] prevent premature click of Edit button 
Change-Id: Ibce2bf0f75e0639bbd3b90f2dc73716e43797841
 2014-07-25 11:16:20 -07:00
Vikas S Yaligar aee1b125fc [BrowserTest] Language screenshot feature runs only for language screenshot job 
Changes made in job which uses this patch is
https://gerrit.wikimedia.org/r/#/c/149012/

Bug: 68467
Change-Id: I8a28cfcf98b7cfcb64e809f08c7deadf086ba6d6
 2014-07-24 22:43:43 +05:30
Cmcmahon 90a58ffe17 [BrowserTest] Switching from VE to wikitext update workflow 
It got a little more complicated that it had been

Change-Id: I511aa1b6d5738f1c19d9ac395efccfef6b328798
 2014-07-24 13:57:33 +00:00
jenkins-bot 30bdf71193 Merge "[BrowserTest] Add parameter no longer exists" 2014-07-24 00:38:56 +00:00
jenkins-bot 3771aa92c1 Merge "Make the image model work without a node" 2014-07-24 00:32:54 +00:00
Moriel Schottlender 1bc7d074fe Make the image model work without a node 
The image model should go by image attributes (whether it comes from
an existing node or a new one) and not a node.

Bug: 68242
Bug: 68000
Change-Id: I4cabd678157619331b3c47d3b44bc16a28fd7bd7
 2014-07-23 17:27:30 -07:00
Moriel Schottlender e281f921f2 Update VE core submodule to master (4424195) 
Update tests and VisualEditor.php for comment node.

New changes:
5885b6a Update OOjs to v1.0.11
ab2d4cb [BREAKING CHANGE] Show comments inline to the user

Change-Id: Ie2787c3e29951cb7940f65bf104e7c9cccdbebd1
 2014-07-23 17:21:47 -07:00
Cmcmahon 5b439da8bc [BrowserTest] Add parameter no longer exists 
Change-Id: If422bedef833d0b97ca0105ad72c4ce69411bf38
 2014-07-23 17:00:21 -07:00
jenkins-bot f7c7efbad7 Merge "test: Move mw into the global list of globals for VE-MW" 2014-07-23 00:02:22 +00:00
James D. Forrester 413f6e82fa Mention at the top of the MW-specific ve.ce.Surface.test file what it is 
Change-Id: Icadbf6afbb7d1b9f3bf7bc65ac3d505b4c091275
 2014-07-22 23:41:27 +00:00
Vikas S Yaligar e0e1b38f13 [BrowserTest] Language screenshots are uploaded every 5 seconds 
Change-Id: I25b7842b827b9d9366aeafb423b1884271bb39f0
 2014-07-22 19:09:06 +05:30
Cmcmahon 7b7d8c02a4 [BrowserTest] update Save button locator 
Change-Id: I2383a279ab170c382f465d3a7c2f4a3e6b275c48
 2014-07-21 09:19:55 -07:00
vikassy 365453f2b3 [BrowserTest] Added @login tag to language screenshot feature 
Change-Id: I31f58d4321d8dd251d1a0fcb641ca939a60b1aa0
 2014-07-21 17:47:44 +05:30
James D. Forrester c2f37a0450 test: Move mw into the global list of globals for VE-MW 
Silly to have 38 MW-specific files needing to declare that they're using mw.

Change-Id: I97891ed922fe0c37d8c96425a4d23bd15098438b
 2014-07-19 17:42:45 +00:00
jenkins-bot 23a0fcb249 Merge "[BrowserTest] Updated random page step to language screenshot page" 2014-07-18 12:46:45 +00:00
vikassy 06f15fb7eb [BrowserTest] Updated random page step to language screenshot page 
Change-Id: Ica2ae78afcba264d222b02923863b8f23452e259
 2014-07-18 18:06:23 +05:30
vikassy 8e1c3de801 [BrowserTest] Fixed failing Media Icon test 
Change-Id: I1d07398f1b8f999c76dc278ed8950778ba1e8fd9
 2014-07-18 11:01:11 +00:00
Cmcmahon cda44f8a9e [BrowserTest] support for Chrome 
Chrome is strict about z-index stuff

Change-Id: Icc477891ce1a9ad0fa75a77bcdd387bf6ca13c48
 2014-07-17 12:08:16 -07:00
vikassy f58d98fcb9 WIP [BrowserTest] Modified conflicting step: I go to the (.*?) page 
Change-Id: Ie0ff326890efddf255320da62a2dd1ec46ffae20
 2014-07-17 17:09:47 +00:00
Cmcmahon dc4db46539 [BrowserTest] Chrome needs to wait for the inspector 
Change-Id: Iface30b72959b75d04beb54aa76d5798920a881e
 2014-07-17 09:28:31 -07:00
jenkins-bot a69ab13cf1 Merge "[BrowserTest] Added lots of new scenarios for language screenshot" 2014-07-17 14:40:59 +00:00
Cmcmahon 406a4c31ae [BrowserTest] update locator for correct page text 
Change-Id: Ida8ce2da1061d557520654d2a45369828eefad42
 2014-07-17 07:00:28 -07:00
vikassy 27390478b9 [BrowserTest] Added lots of new scenarios for language screenshot 
Bug: 62737
Change-Id: If30a9acbe772b76f8a2656ccf3f219dbede9853c
 2014-07-17 18:48:53 +05:30
Cmcmahon d0b8f62276 [BrowserTest] update switch-edit-mode test for new UI 
Also add new checks for switch-modal Discard and
Cancel options

Change-Id: I228b0dee1d110f6a72be4966bbc5918f294ab717
 2014-07-16 15:38:52 -07:00
Cmcmahon ea96b33c2c [BrowserTest] update template test 
Change-Id: I0956bf58e15b1998b995bbcaddbe2514a8d7a058
 2014-07-16 12:21:57 -07:00
jenkins-bot bb213db797 Merge "[BrowserTests] update References test for new UI" 2014-07-16 18:27:03 +00:00
Cmcmahon 48044d0ec5 [BrowserTests] update References test for new UI 
Change-Id: I9c91a195cb42136422dec59e22d4a3164deaa8d9
 2014-07-16 11:24:37 -07:00
Cmcmahon 0791e5c761 [BrowserTests] update Options test for new UI 
Change-Id: If435620bc730a3b9d04918fcd4181e08d286e5a1
 2014-07-16 11:12:46 -07:00
jenkins-bot 97d286aa0f Merge "[BrowserTest] update links test" 2014-07-16 15:27:24 +00:00
Cmcmahon a8c33dfdd7 [BrowserTest] update links test 
This may not be the last update, I want to see how this works in
the Jenkins build

Change-Id: Ib2123d030bc13e84099601a858a5f69aee3a03a4
 2014-07-16 08:24:22 -07:00
Cmcmahon 8d39658d6c [BrowserTest] update media test for new UI 
Change-Id: I35f75b8cb0fac27167d4f949069c48baac499b02
 2014-07-16 07:37:36 -07:00
Željko Filipin f850ddf73b Rename "test" folder to "tests" 
All other repositories have tests in “tests” folder. For more
information see:

http://lists.wikimedia.org/pipermail/qa/2014-July/001663.html
http://lists.wikimedia.org/pipermail/qa/2014-July/001667.html
http://lists.wikimedia.org/pipermail/qa/2014-July/001672.html

Change-Id: Ib1e4fa4b7203bd8217615db1ceac23a329c081f1
 2014-07-15 18:00:32 -07:00