The media dialog has an "Apply changes" primary action and a "Change image"
secondary action. These two labels are confusingly similar. "Choose a
different image" is a long label, but even on mobile a longer label
should fit nicely in this context, and this seems to me to avoid the
issue of ambiguity.
Change-Id: Id8be8b4cf70f7eee689b72d88b0aeac20c2eca93
There is a MWLinkNodeInspector too, renaming the class instead of the
file to avoid name confusion.
Change-Id: Idaa26503ecd9b0fd0903937bb209397672138054
MediaWiki change I2793a3f2 changes API handling in a way that needs
updates to extensions for proper operation:
* needsToken() now returns a string
* Most custom token types are being replaced with a 'csrf' token (the
former 'edit' token); any others need a new hook.
* All tokens must use a static salt. Compat with web UI using non-static
tokens is supported and also serves to handle the now-deprecated token
fetching.
* Documentation in getParamDescription() should return a string (not
array) for 'token', as the signal to core that it should be replaced
with a standardized message.
When compatibility with earlier versions of MediaWiki is no longer
maintained, the entry for 'token' from getAllowedParams() and
getParamDescription() may be removed, as may getTokenSalt(). This patch
leaves them in place.
Note this is intended to be compatible with earlier versions of
MediaWiki, and so should be safe to merge before the core change.
Change-Id: Ia6e512aae366996de4e73a8d7f4f03fcddd77286
There are several incorrect usages of jquery .append() method that
uses an array instead of an argument list. This isn't the proper use
of the method and while it does work now, according to Krinkle,
this might stop working in the near future.
Also see I76decb67db086bb387 for the same fix in ve-core.
Change-Id: I78a0d54ad76ab5401bc0532e636a9aaa2c0c0e04
New changes:
c23d345 Localisation updates from https://translatewiki.net.
2662be5 Localisation updates from https://translatewiki.net.
f04910e Set selection before focusing document
31fc043 Localisation updates from https://translatewiki.net.
b4eed30 Localisation updates from https://translatewiki.net.
40016d7 Disable basic reference on mobile
e4bad2e Localisation updates from https://translatewiki.net.
e476e79 Fix `Transaction.isNoOp` test
3cfccf8 Update OOjs UI to v0.1.0-pre (0e50d2e336)
55d1d03 Add bidi isolation to language annotations
3f2a1c6 Localisation updates from https://translatewiki.net.
a399aee Actually check annotations in paste test
b3b7d67 Add missing messages from MW
c327e1f Localisation updates from https://translatewiki.net.
d52a40a Show metadata in the debug bar
d9c3b90 build: Switch from qunit directly to karma for code coverage reports
b421ac3 tests: Fix some minor issues flagged up by karma and related MW references
35f76d1 Fix bad jquery 'append' instances
7766751 Localisation updates from https://translatewiki.net.
f443f90 Followup 95ee357: make remapStoreIndexes() work again
Change-Id: I04e2ad1ecc31aefc482e81724e28271704fbfd35
Flip the order of the buttons in the alignment widget
so that they display the directions correctly in both
ltr and rtl.
Bug: 69165
Change-Id: I7bd1d6c89aaef09492ae07eadababd68305b245e
Currently it's only being done when applying, caused by Ia74732e6. We
need the teardown event to reach the page so they can do things like
clear categories.
Bug: 68484
Change-Id: I6c31229121c1477a55ce955354770ed7cdde470d
Using the same tricks as ve.ce.MWReferenceListNode... Like listening to list
node updates, which will probably catch unrelated changes? I'm not sure about
this.
Bug: 68890
Change-Id: Id9443c9574063933bc8fb35d09ab8b80b69bcd44
Previously one could select over a link node and linkify the
selection, with tremendously funny results.
Change-Id: Ic5a2132b2d18280099a6024bc4ec2b1333eca98f
New changes:
96331bf Localisation updates from https://translatewiki.net.
ba0ba78 Followup 23a949844: fix typo in class name for WhitespacePreservingInputWidget
8a5945c Have LanguageInputWidget return lang+dir, not an annotation
Change-Id: If05f29a8680e9475e6b749d82db30a20859f1c41
This color is chosen because it is already present as a warning color in
other mediawiki elements like remove button in Link Inspector. A font
weight of bold is also given to make it more prominent.
Things done for this commit:
* A new CSS file 've.ui.MWLinkTargetInputWidget.css' is added.
* Warning text style is added to the class
'.ve-ui-mwLinkTargetInputWidget-warning' in this file.
* The CSS file is included in the style resources in the
file 'VisualEditor.php'.
Tested in latest stable firefox, chrome in Ubuntu 14.04.
Bug: 62761
Change-Id: I89e96e0444f8505123f3c653cf2dd6b74fc83623
Use $.when() to check if there were results to the search. This
also makes sure that the 'results not found' message only appears
when it actually should.
Bug: 65321
Bug: 67438
Change-Id: I437ef639918ace1041bb8c9f7fdd04a4e83885eb
New changes:
8cab432 ve.ui.AnnotationInspector: Allow content insertion without annotating
f5cbd05 ve.ui.AnnotationInspector: Stop truncating fragments to 255 elements
13d9f5e Update OOjs UI to v0.1.0-pre (dd294dc785)
50c4efd Set a default language for ve.dm.Document if we can't guess it otherwise
b28f2f1 Disable tools other than links and references on mobile
Change-Id: Ib4178c3c7e67135806046decff0bde05a2702f7d
