Commit graph

20612 commits

Author SHA1 Message Date
Thiemo Kreuz 8a42b05622 ve.dm.MWTemplateSpecModel: Document some large params as private class
While at it, also fix a few broken uses of `@see` where `@link` was
intended or for full names, there is no syntax needed, as JSDuck
already links those.

Change-Id: Iaeb46b05c6f2e6f00198bc2ae773c895935b4cea
2022-12-15 23:35:11 +00:00
daniel 3a50a092d9 Catch HttpException early
Catch HttpException from REST helpers, even when they are triggered
already during initialization. This will happen e.g. when the request is
asking for a render key for which the stashed rendering has expired.

Bug: T325310
Change-Id: I9e622b5bb253f5e40fe2b50ff08471beddac9acf
2022-12-15 18:12:37 +00:00
jenkins-bot e06122f86e Merge "ParsoidClient: Improve return type documentation for Phan" 2022-12-15 17:01:06 +00:00
Translation updater bot 0db9568ac8 Localisation updates from https://translatewiki.net.
Change-Id: If02a7a849fad5ee91ec10a72bcd164d72b1afc09
2022-12-15 11:37:14 +01:00
Bartosz Dziewoński ac946cff36 ParsoidClient: Improve return type documentation for Phan
Change-Id: I1aecdc5ab7a21e1ef43ddcec4f4dbea610822493
2022-12-15 00:00:41 +01:00
Bartosz Dziewoński b6929d5be1 Change mw.libs.ve.getTargetDataFromHref to not return bogus data for external links
For external links, `.title` and `.rawTitle` properties previously
contained the external link corrupted with some normalization intended
for MediaWiki titles.

This was useless, and in fact no caller actually uses this value:
they all check `.isInternal` first before accessing `.title` or
`.rawTitle`.

Also, correct other parameter documentation.

Change-Id: Ieeab56548f0a3b2f81a90f0d3ae0f81d744aa67b
2022-12-14 22:57:04 +01:00
Jon Robson 9c25161966 QUnit test module should explicitly target desktop
Setting to desktop as it has dependency
ext.visualEditor.desktopArticleTarget.init
which is a desktop only module

Bug: T127268
Change-Id: I5083cb6ccf9ab918a90c41afc6644fc839b8950e
2022-12-14 17:46:22 +00:00
Translation updater bot 3a63406fc5 Localisation updates from https://translatewiki.net.
Change-Id: Id2375bedae04a4a19be01e6a248f53e2650a1b91
2022-12-14 08:16:44 +01:00
jenkins-bot c31b3bde04 Merge "Set targets explicitly on desktop only module" 2022-12-14 05:35:58 +00:00
jenkins-bot 0c5f131976 Merge "Use new stable API for subtitle modification" 2022-12-14 04:12:38 +00:00
Translation updater bot 0175b7cdfc Localisation updates from https://translatewiki.net.
Change-Id: I0c96092eab8ccb79ab3640fed8776b1a896ed11e
2022-12-13 08:17:49 +01:00
Jon Robson 612a307d68 Use new stable API for subtitle modification
Bug: T324876
Depends-On: Id8436324e2ae2fd9f488b65b3b7bfc19611870d1
Change-Id: I8e538939a6d7d4474f2e96b93040f3c68c2f98ec
2022-12-13 01:13:46 +00:00
Jon Robson a1f939415f Set targets explicitly on desktop only module
I'd like to change the default targets value for ResourceLoader.
Doing that flags that VisualEditor has a few modules that should
be explicitly defined rather than relying on the default value
here.

Bug: T127268
Change-Id: I5bc4a24bc00dc338b113332a911c67241d139dfb
2022-12-12 14:38:56 -08:00
Bartosz Dziewoński 133cacc42d Remove obsolete browser support checks for HTML5 History API
It is available in all browsers we support.

Change-Id: I6c860eadd91e6e4061ed0364be0dc8c7b750d3e7
2022-12-12 20:47:32 +01:00
Bartosz Dziewoński 237ffde471 ve.ui.MWPopupTool: Update usage of 'mediawiki.feedback'
* bugsListLink option no longer exists (I0ea65bf97d)
* bugsLink doesn't require mw.Uri

Change-Id: I9ab9d8b096a58fe0c49b296b121e5fe9a8dfd8bd
2022-12-12 19:43:14 +01:00
David Lynch 2b49b3bde7 Try/catch around mw.Uri when decoding parsoid resources
An incorrectly-encoded fragment is allowed-in-wikitext but will make
mw.Uri throw an error. e.g. `[[foo#1%bar]]`

Bug: T324976
Change-Id: I97cb85507d9ae3d648300245dd7e48cc239c4d90
2022-12-12 09:37:30 -06:00
Translation updater bot e5c0d08716 Localisation updates from https://translatewiki.net.
Change-Id: I374b3c76918861d47d60575389a069a6b56fb966
2022-12-12 08:23:17 +01:00
jenkins-bot c4f9513110 Merge "Always sanitize href attribute in UI" 2022-12-09 23:40:22 +00:00
jenkins-bot 2b39fa6246 Merge "Always sanitize href attribute in CE nodes" 2022-12-09 23:38:16 +00:00
Željko Filipin 15c53f0576 selenium: Decrease logLevel from info to error
logLevel from info is very verbose. It is no longer needed. The default
error logLevel should be enough.

Bug: T296187
Change-Id: I1bde5b57f64df2d6c00b4a7b8e24f9887a865bb6
2022-12-09 13:36:56 +01:00
Translation updater bot 4769e06693 Localisation updates from https://translatewiki.net.
Change-Id: I2d817ce5556065a1c307081646a7477abc13d847
2022-12-09 08:47:51 +01:00
jenkins-bot 3f3bfc70a3 Merge "Don't index VE edit pages" 2022-12-08 17:16:37 +00:00
Translation updater bot 50f6afc3bd Localisation updates from https://translatewiki.net.
Change-Id: I7293229f967dec9243ef46f477b7750188bd3b58
2022-12-08 08:30:27 +01:00
Bartosz Dziewoński 9ca5c701f6 Update VE core submodule to master (1b0ea4928)
New changes:
84227ead9 Localisation updates from https://translatewiki.net.
1b0ea4928 Update OOUI to v0.46.0

Change-Id: If3dcd3f82736efb862251bcbb25ea7f20816a96c
2022-12-07 22:28:29 +01:00
jenkins-bot e6bcdb7e78 Merge "selenium: Toolbar should open insert menu" 2022-12-07 16:07:22 +00:00
jenkins-bot d6f577b3df Merge "Revert "selenium: Do not retry tests"" 2022-12-06 14:58:21 +00:00
Kosta Harlan 68f0539fa8 Revert "selenium: Do not retry tests"
This reverts commit 9b9304b13f.

Reason for revert: Selenium tests occasionally fail for many different
reasons. We should use the default specFileRetries, so that a single
failure doesn't cause ~20 minutes of delay when someone is backporting
a change. See also e.g. T324544

Bug: T324544
Change-Id: I043eb5e57bec13a16efb35bbdffda6d3ea65b8e9
2022-12-06 12:40:00 +00:00
Translation updater bot 72d5a8312b Localisation updates from https://translatewiki.net.
Change-Id: Ic9b2b6a2118ec2cf72d2cd6d85b159ccba94f261
2022-12-06 08:54:04 +01:00
Francois Pignon 1b27b12b66 Optimize some jQuery selectors
Bug: T324523
Change-Id: I5d749e222b01a4f6abbc4517a8b568ad3e73e47f
2022-12-06 00:05:06 +00:00
jenkins-bot f6047f8642 Merge "Handle errors when rendering visual diffs" 2022-12-05 23:35:01 +00:00
jenkins-bot 4263eb1786 Merge "Adjust to changes to redlink behavior from parsoid" 2022-12-05 20:26:34 +00:00
David Lynch 83a46a7817 Adjust to changes to redlink behavior from parsoid
Redlinks now come down with a `mw:LocalizedAttrs` typeof, and have the
display URL parameters rather than being bare titles.

Bug: T324352
Change-Id: Ia1776e6e1f171d227c7c402b39ca96d17fb56cdb
2022-12-05 11:55:33 -06:00
jenkins-bot 0e65c743ef Merge "Only hide #siteNotice on skins where it's shown in the editable area" 2022-12-05 17:24:15 +00:00
jenkins-bot 65b9d1d2c1 Merge "ve.init.mw.DesktopArticleTarget.init: Remove redundant selector" 2022-12-05 17:24:13 +00:00
Translation updater bot 6299282dfa Localisation updates from https://translatewiki.net.
Change-Id: Ic1786fed0899b0980a31d6356af3bd4ea1de5297
2022-12-05 08:34:46 +01:00
Esther Akinloose 5347c6adf6 selenium: Toolbar should open insert menu
Bug: T296187
Change-Id: I4af64851d95a5bca26d8ae6ed5fcd9b0d13aba55
2022-12-02 22:07:49 +00:00
Translation updater bot 08e72061ac Localisation updates from https://translatewiki.net.
Change-Id: I5cd552a61c766e46130b227fa1b00319f518d997
2022-12-02 09:10:12 +01:00
jenkins-bot 8a2ebc2e81 Merge "Update VE core submodule to master (56859eb96)" 2022-12-01 21:53:47 +00:00
Bartosz Dziewoński f1ca83aafd Update VE core submodule to master (56859eb96)
New changes:
364f0cef3 Fix eslint warnings
b07598a2c Add jsdoc for undocumented build functions
f5431894f Localisation updates from https://translatewiki.net.
56859eb96 Localisation updates from https://translatewiki.net.

Change-Id: I71a2dd10d9f0313b153854c93726cf5a9140228f
2022-12-01 22:34:46 +01:00
Bartosz Dziewoński b368d741a1 Don't index VE edit pages
Bug: T319124
Change-Id: Ia738698e93252f884b9045aab5840465d3f0d3d3
2022-12-01 22:26:45 +01:00
Translation updater bot 21d810f62b Localisation updates from https://translatewiki.net.
Change-Id: Ief8053ff0ec2f4e5ee025a1f08407b31dda3403b
2022-12-01 08:17:03 +01:00
Ed Sanders 5e503eb378 Always sanitize href attribute in UI
Bug: T322704
Change-Id: I19f722c40f1f8e5b55e44d9fb11109a6f9951c06
2022-11-30 18:26:37 +00:00
Ed Sanders 7afbe7516d Always sanitize href attribute in CE nodes
Bug: T322704
Change-Id: I0ce6d57adf7c688d11f6fc39af291b44c4b5aeeb
2022-11-30 18:26:37 +00:00
Bartosz Dziewoński 1ea3bf3013 Handle errors when rendering visual diffs
There are some known bugs that we probably will not investigate
(T313809, T317455). Do something better than an infinite loading bar.

Follow-up to ee7c5d9d1a.

Change-Id: I339de7662ff68c2ea9bb1a738bb4207d1c399e59
2022-11-30 18:17:54 +00:00
jenkins-bot d386acf9b0 Merge "selenium: Toolbar should open special characters menu" 2022-11-30 18:01:54 +00:00
jenkins-bot 79b64eb837 Merge "selenium: Toolbar should open notices popup as soon as it loads" 2022-11-30 14:18:35 +00:00
Esther Akinloose fb5cbbd6c8 selenium: Toolbar should open special characters menu
Bug: T296187
Change-Id: Iab55907f648a99f7a7a56dc49bc0686df619c6dd
2022-11-30 14:17:33 +00:00
jenkins-bot 0e4bda00e9 Merge "selenium: Toolbar should open help popup" 2022-11-30 14:08:37 +00:00
jenkins-bot ed3cb2fc61 Merge "selenium: Toolbar should open page options" 2022-11-30 14:05:23 +00:00
Esther Akinloose 5f8dbcf2dd selenium: Toolbar should open notices popup as soon as it loads
Bug: T296187
Change-Id: I705d4d3e8a0135b500ec63749f519f7b86855a2f
2022-11-30 13:43:32 +00:00