Commit graph

19509 commits

Author SHA1 Message Date
Bartosz Dziewoński 0d9d4029d8 Update VE core submodule to master (4eacee1c5)
New changes:
ee207db24 Localisation updates from https://translatewiki.net.
03e6e3022 build: Update QUnit from 2.16.0 to 2.18.0
53881dfac Localisation updates from https://translatewiki.net.
616754593 Fix some missed instances of var declarations that can be moved inline
4eacee1c5 Simplify done() calls in tests

Change-Id: If9ed1ad849e41ada2dda3b108ea93a6cb8c09357
2022-03-04 00:11:36 +01:00
Ed Sanders 4f578c269c Allow auto-save recovery notifications to be suppressed
Bug: T302327
Change-Id: If94e603458a385ba6eb15c4e29144f72e3ad12ca
2022-03-03 23:09:25 +00:00
jenkins-bot abff70ff2d Merge "Fix missing return value and related docs in MWTransclusionNode" 2022-03-03 21:49:54 +00:00
Translation updater bot 9887f32ec4 Localisation updates from https://translatewiki.net.
Change-Id: Ief3cb9ba8e24d24eb647b8803ce00556c3075de1
2022-03-03 08:23:20 +01:00
Ed Sanders 29b9c9c34a Remove logic for disabling VE when certain extensions are running
This logic has been moved to the relevant extensions which can
now disable VE using a hook.

Depends-On: I47880be15b6ce1a93f389a32aff304cc3b798bcb
Depends-On: If188e8fcceb248738fc625ddd5afec351c01c484
Bug: T174180
Change-Id: I245295373af3caffb1d4cbc288e8d2bd008520b7
2022-03-02 21:20:55 +00:00
Thiemo Kreuz eb25116734 Block Ctrl+Del/Backspace when Remove button is inaccessible
* I can't guarantee this fixes T301914. But I suspect the bug can not
be triggered any more with this plus If9b6050 in place.

* I wasn't able to reproduce the issue locally. But I learned that
  1. it's related to the hotkey, and
  2. it's because the dialog looses focus, and the focus ends on the
     VE surface in te background. Pressing Esc there closes VE. That's
     intended behavior.

* I tried to use .trigger( 'click' ), but it doesn't make much of a
difference. The only magic check is if the button is disabled. But no
visibility checks are done.

Bug: T301914
Change-Id: I2f66fc2411144c60cd08baae58452d336b4e9802
2022-03-02 11:56:29 +00:00
Thiemo Kreuz 836d36bc16 Skip initial creation of unused parameter widget
In a test case with 200 templates where all but a few parameters are
unused the loading time is cut in half.

Bug: T300974
Change-Id: Ice850cb9e5e95b9e3a19ff511b3a4f32117c7199
2022-03-02 10:19:46 +00:00
Translation updater bot 3dbbe89ae8 Localisation updates from https://translatewiki.net.
Change-Id: I802da1d9bb36edd162629e077334eb4cf9c83b5e
2022-03-02 09:37:31 +01:00
jenkins-bot b936d22f7d Merge "Show correct button label in the missing summary notice" 2022-03-01 23:38:20 +00:00
Ed Sanders 1b5550f485 Move var declarations inline
Mostly ve-mw/ui and a few left overs.

Change-Id: Idea0c94d974e661c49af8ad4545cd8fd98179ca8
2022-03-01 17:50:24 +00:00
jenkins-bot 221b1aae52 Merge "ApiVisualEditorTest: Assert properties in result" 2022-03-01 16:04:02 +00:00
Ed Sanders 131d940d99 ApiVisualEditorTest: Assert properties in result
Change-Id: Ibc63ec4c2fc9d3b002b016d01417f61f68b9dc54
2022-03-01 15:09:58 +00:00
jenkins-bot 976272fa41 Merge "Fix spacing between sticky find bar and field list" 2022-03-01 14:42:32 +00:00
Translation updater bot f7b2059856 Localisation updates from https://translatewiki.net.
Change-Id: I327db93b5acdec65f1a394eb63190790ccc1911f
2022-03-01 14:33:21 +01:00
jenkins-bot 46cfbc74bd Merge "Added check for hotkey action on input or textareas" 2022-03-01 12:00:20 +00:00
Matěj Suchánek 2d6b737209 Show correct button label in the missing summary notice
The button in the top-right corner says "Publish changes",
not "Publish page" (if you save an existing page).
Saving an existing page is more common then creating
a new one.

Change-Id: Ia9516932672820baa0344c77683836cc391cefc7
2022-03-01 10:57:26 +00:00
Svantje Lilienthal fb95572429 Added check for hotkey action on input or textareas
Bug: T301913
Change-Id: If9b6050c378836157fa1df5b9782ba4632890f1a
2022-03-01 10:14:52 +00:00
jenkins-bot a6d771dd00 Merge "MobileSaveDialog: Also add 'content' class to preview panel" 2022-02-28 23:45:18 +00:00
Bartosz Dziewoński aed5bcf7d0 ApiVisualEditor: Remove $wgTitle hack, set page for {{PAGENAME}} when needed
Depends on core changes I242e042317 and I6e9356a6cc to set the context
page for messages generated in Title::getEditNotices() and
LogEventsList::showLogExtract() too.

Set the context page for other messages whose overrides on Wikimedia
wikis commonly depend on it, which I checked using Global Search, e.g.
https://global-search.toolforge.org/?q=PAGENAME&regex=1&namespaces=8&title=Editingold

Depends-On: I242e042317a1e16c8d51edbf7800c8b7d70d468e
Depends-On: I6e9356a6cc3b9df9b508c3d37a0b9b75d6825efd
Bug: T300184
Change-Id: I0746618b1f6da3e5fd213d8adad9b1f4ec2fe23b
2022-02-28 23:43:54 +00:00
jenkins-bot 8eefaedf86 Merge "Make sure postEdit hook doesn't fire until after saveComplete is done" 2022-02-28 21:19:44 +00:00
jenkins-bot 2844df9615 Merge "Don't let MobileFrontend show abandonedit after saveComplete" 2022-02-28 21:19:41 +00:00
David Lynch 5012d2fa93 Make sure postEdit hook doesn't fire until after saveComplete is done
Follow-up to c8072f1af2

Bug: T302746
Change-Id: Iac76ac69a62b38282ae5aa6194a89ab9110b0954
2022-02-28 20:59:44 +00:00
David Lynch a6d11f5334 Don't let MobileFrontend show abandonedit after saveComplete
Follow-up to c8072f1af2

Bug: T302746
Change-Id: Id1ef6a02cde7a30eae7b36f1d10f07e9a363e974
2022-02-28 20:56:09 +00:00
jenkins-bot e6a1ccefec Merge "Add section fragment to keyboard help link" 2022-02-28 15:00:59 +00:00
Translation updater bot ed49a9f80f Localisation updates from https://translatewiki.net.
Change-Id: Idebb57875fc8aef064e958267bf60b87ade92c34
2022-02-28 14:29:43 +01:00
WMDE-Fisch 99a251c8e6 Add section fragment to keyboard help link
Bug: T302004
Change-Id: I656f4b4826c8528e304b387f762aef35ec6404b2
2022-02-28 13:33:57 +01:00
Thiemo Kreuz 5a92880da5 Fix bad visualization of empty suggested value
Bug: T299430
Change-Id: I9a0d26c7fc88e1a0c2c68152b3e15a9ba7662991
2022-02-28 08:49:08 +01:00
Thalia b0c0917f19 ApiVisualEditor: Support Special:MyLanguage for preload param
This allows nonexistent translated pages to fall back to the
corresponding page in a suitable language.

Bug: T299544
Change-Id: I43f461e9f595c364ecdaf2faccbd580fc0df6799
2022-02-25 12:23:16 +00:00
Thalia 0c5ed2e772 ApiVisualEditorTest: Avoid using VirtualRESTServiceClient
Use paction 'metadata' instead of 'parse' by default, to avoid
accidentally using VirtualRESTServiceClient when testing cases
that don't require it.

Change-Id: I02492a2dc444cf531a5c8767b0dcfe0d20ac7339
2022-02-25 12:15:37 +00:00
Translation updater bot 09e405386b Localisation updates from https://translatewiki.net.
Change-Id: Id7717ffa2fa37ec29cd883655c1b2610316e3725
2022-02-25 09:46:26 +01:00
Ed Sanders 3f1eb8992f Fix spacing between sticky find bar and field list
Bug: T300899
Change-Id: Ieac47d58eb1037edcd82e0d7ee5c98e125c4e78c
2022-02-24 10:40:37 +00:00
Translation updater bot 026a11357a Localisation updates from https://translatewiki.net.
Change-Id: I6c06fe5619c54ab31919705b2a46b8ee65d2013b
2022-02-24 08:50:19 +01:00
James D. Forrester 10526ca45a Update VE core submodule to master (a75d285a8)
New changes:
a75d285a8 ve.ce.Surface: Fix error on load when document has no content offsets

Bug: T302362
Change-Id: I55cb19b390461264316fc75a09ae90e26bc5f34d
2022-02-23 12:25:00 -05:00
Ed Sanders b0dcf1fc69 Update VE core submodule to master (492815b58)
New changes:
a50d13e3b Localisation updates from https://translatewiki.net.
a0c3637de Localisation updates from https://translatewiki.net.
17daebc83 ve.ce.Surface test: Add test for special image paste handling codepath
f4b688e1b Always use clipboard paste data if "important elements" have been dropped
f0e5c16c9 afterPaste: Add 'figure' to importantElement list
abd5894ef Show copy button when selecting focusable nodes on mobile

Local changes:
* Load new clipboard messages

Bug: T101113
Change-Id: I05f9dc850d3cac740916d26a0c2b0d390e47fbb1
2022-02-23 12:45:42 +01:00
Translation updater bot 5b2d70432e Localisation updates from https://translatewiki.net.
Change-Id: I68902cd40cb95a9d363b47d81c34ab01b56d0b7b
2022-02-23 08:19:42 +01:00
David Lynch 14f99d05fd Avoid undefined index for mobileformat
Bug: T302344
Change-Id: Icf051b6fdec627c6477a7b2abd1ba4ccd5b3a259
2022-02-22 21:23:07 +00:00
jenkins-bot f259cb3072 Merge "Never collapse newly added templates in transclusion dialog" 2022-02-22 15:03:45 +00:00
Translation updater bot e65c63f2ad Localisation updates from https://translatewiki.net.
Change-Id: I9029503fcc32f8c9555d5e173c6221d5b2e388e2
2022-02-22 14:20:50 +01:00
Thiemo Kreuz 0d989b6fee Never collapse newly added templates in transclusion dialog
Bug: T300640
Change-Id: Id400951cf98f1eda780700d726fc10afbc1eaa90
2022-02-22 11:37:21 +01:00
Translation updater bot 596d4e53dd Localisation updates from https://translatewiki.net.
Change-Id: I6dabdf19528a1577d0d019ea7b6ceedd00161903
2022-02-22 08:12:30 +01:00
Ed Sanders b4f3ecbc5c MobileSaveDialog: Also add 'content' class to preview panel
This isn't used yet as NWE is not enabled.

Change-Id: I2ea4697c2a5ba57f537e646e3d0fb7d89fd04c7b
2022-02-22 00:23:35 +00:00
jenkins-bot e9f8ffa5a1 Merge "Log whenever browser plugin spam is detected" 2022-02-21 23:29:39 +00:00
Ed Sanders 4501771243 Log whenever browser plugin spam is detected
Our theory is that browser plugin spam shouldn't reach
the DM document unless we've made a coding error like
I194ff1d57. Log future errors so if there is more plugin
spam in the future, we can investigate the cause.

Bug: T298147
Depends-On: I705195bc5d0f76a38da5d2cc09fab184a2c32401
Change-Id: I3403859906ceaa51be63b0d79f474f0289ab4408
2022-02-21 22:48:46 +00:00
Thiemo Kreuz 0b47a8c85b Improve messages about duplicate template parameters
There are some combinations that can result in a message that is
more confusing than helpful. For example, when a parameter is
already in a template, but via an alias, that alias is potentially
shown in the sidebar (only when the parameter doesn't have a
label). When the user enters the primary name of this parameter,
the message talks about a "duplicate", but the user can't
understand what this duplicate is.

Just make all messages repeat the parameter's label as shown in
the sidebar. This is often redundant, but sometimes crucial
information.

This patch also improves the qqq.json documentation. All messages
get 2 parameters, even if some of them use only 1.

Bug: T285869
Bug: T291059
Change-Id: I826e341cebd8f89dba63d64de67baba1ec8f2001
2022-02-21 17:35:47 +01:00
jenkins-bot 839a62829d Merge "Add and fix default values in parameter documentation" 2022-02-21 13:41:51 +00:00
jenkins-bot 8c1ad11a7d Merge "MWEditSummaryWidget: Handle multi-line comments" 2022-02-21 13:39:01 +00:00
jenkins-bot fe69e22761 Merge "tests: Mock wgVisualEditor instead of relying on SpecialPage value" 2022-02-21 13:32:51 +00:00
jenkins-bot d79527e1f2 Merge "Always scroll to top when loading VE source mode" 2022-02-21 13:23:28 +00:00
Thiemo Kreuz bc0a34b0ed Add and fix default values in parameter documentation
Same random finds while working on something else. I carefully
checked and made sure these methods are actually called without the
optional parameter.

Change-Id: Iab36fd130258322985b5d6e7f8e1f7b4ee235ba2
2022-02-21 13:19:21 +00:00
jenkins-bot aa8b08bd1a Merge "DesktopArticleTarget.init: Handle popState target reactivation properly" 2022-02-21 13:14:38 +00:00