Commit graph

604 commits

Author SHA1 Message Date
Ed Sanders 041e7b77a1 Create SaveErrorHandler class to better define structure
Change-Id: I036ee32847cc3b25a1cc478247cfe54599781098
2018-11-29 15:47:03 +00:00
jenkins-bot fc126c1260 Merge "Rename configs for tracking block notices on visual editor" 2018-11-29 00:43:31 +00:00
Thalia 2516753c53 Rename configs for tracking block notices on visual editor
* Also make sure block notices have type 'block'.
* Remove old flag for tracking since we'll be using one
  from core

Change-Id: I4b66e73c8a4c4dd7bffd7c0239b1d5ec06eed12f
Depends-On: I6bd1c95548616677e1f72ba6bcfc6f2b551c1ca6
2018-11-28 15:26:15 -05:00
Ed Sanders 0d54a62858 Use mw.Title.wantSignaturesNamespace
Change-Id: I60187f0a3eb9cf5d56a4fdaa3401b107758bd8e3
Depends-On: Ib2faa22c429096d545ddb829a6b4025427ad6071
2018-11-27 18:42:44 +00:00
jenkins-bot 44fcea9f65 Merge "Track when block notices are returned on the api" 2018-11-20 22:31:27 +00:00
Dayllan Maza 3269bb136c Track when block notices are returned on the api
Tracking is behind $VisualEditorTrackBlockNotices config flag
which is set to false by default. Additional data will be logged
into a different bucket on the client and both metrics will be
considered with their known limitations.

The reason behind this is to get an idea on how frequently blocked
users attempt to edit a page. Similar tracking is being added to
MobileFrontend and mediawiki/core.

Bug: T201718
Change-Id: I51576276b97be0716c2c22348eaa756ffb04fe50
2018-11-19 23:02:02 -05:00
Bartosz Dziewoński 7bcb1ac50c Update VE core submodule to master (f32c0be7c)
New changes:
61992def0 Remove dedicated annotation operation types
c18308313 Move 'enter' and 'f2' keydown handlers to command/trigger code

Bug: T205535
Change-Id: Ibbf578070c820ae63a8b8ab50e6e4520cabfebe6
2018-11-08 13:45:21 +01:00
Ed Sanders ff1a05e245 Bump version number due to recent breaking change
Specifically I715ae805f, which changes the signature of
ve.dm.*Selection objects.

Change-Id: Iffa657179dd8a126e9f16787f3b33743f6e3d489
2018-11-07 16:50:35 +00:00
jenkins-bot 73deda8f66 Merge "ve.init.mw.DesktopArticleTarget.init: Move Vector styles to separate file" 2018-11-07 13:18:47 +00:00
jenkins-bot 07856d2a16 Merge "ve.init.mw.DesktopArticleTarget: Edit surface padding and gutter for Minerva" 2018-11-07 13:18:42 +00:00
jenkins-bot 45c9ff5e21 Merge "ve.init.mw.DesktopArticleTarget.init: Make multi-tab mode compatible with Minerva" 2018-11-07 12:26:38 +00:00
Bartosz Dziewoński b0c0553dc2 ve.init.mw.DesktopArticleTarget.init: Move Vector styles to separate file
Change-Id: Iecf25bf71c1e4fca8964d608082e42ef0c929044
2018-11-06 16:47:31 +00:00
Bartosz Dziewoński c87b010da0 ve.init.mw.DesktopArticleTarget: Edit surface padding and gutter for Minerva
Bug: T208102
Change-Id: I0a43550c938144f79f04dc91c2c742229f939177
2018-11-06 16:47:23 +00:00
Bartosz Dziewoński 5996cf15e9 ve.init.mw.DesktopArticleTarget.init: Make multi-tab mode compatible with Minerva
* Make inserting secondary tab work with Minerva's non-standard structure
  of navigation menus
* Distinguish primary and secondary tabs with tiny icons, since Minerva
  hides their text
* Hide section edit link dividers (unnecessary when we use icons)

Bug: T208102
Change-Id: Ieaec60165617e3b423ec58857d6f0a0406e22b1d
2018-11-06 17:45:48 +01:00
jenkins-bot 314bfdfc3e Merge "Missing dependency resulting in a missing icon" 2018-11-05 21:56:26 +00:00
jenkins-bot 3f97176f7c Merge "Use upstream AbandonEditDialog" 2018-11-05 18:19:23 +00:00
Seb35 951fa31a7c Missing dependency resulting in a missing icon
Bug: T208686
Change-Id: I0780a66bc70fe25154322c256958cea0c67613c2
2018-11-04 18:47:07 +01:00
Roan Kattouw 817987466d Unbreak input debugging images
They're the only thing in ve.ce.debug.js, and that file is never loaded
by VE-MW.

Change-Id: I22e64dc55a4b9d44728a235cf9edf4019504cbc2
2018-11-02 10:58:36 -07:00
jenkins-bot 9ac196777a Merge "Blocked apply if redirect address is invalid" 2018-11-01 22:17:03 +00:00
flutters f847880292 Blocked apply if redirect address is invalid
Extracted extractValue to a separate method
Added checkValidRedirect method to MWSettingsPage
Added errors when redirect address is invalid
Added 1 error message to localisation strings
Added 1 TODO (more precise error messages)

Bug: T74971
Change-Id: I8bcf16e97e5211671759acdf0846243df2c03fc2
2018-11-01 21:20:01 +01:00
Bjornskjald 9490ff370c
Update the styles for VisualEditor's "Format" dropdown
Now when using the MonoBook skin, the text size for headings inside the dropdown is the same as their size on the page.

Bug: T72559
Change-Id: Ie0c30369021f8022b788730a6de90e44a288b13b
2018-11-01 20:40:56 +01:00
Ed Sanders eab2b728e9 Use upstream AbandonEditDialog
Bug: T192333
Depends-On: Ib581528363a3fe5461529515835bd7fb1ce66e56
Change-Id: I206366e096aafc02102357648b9f85f879479500
2018-10-31 13:38:31 +00:00
Bartosz Dziewoński 9e47873a65 Update VE core submodule to master (236effcd7)
New changes:
0e923fe1b Use initClass in test class
900962720 Add ve.deepFreeze for detecting inadvertent data modification during testing
0761cd90c Localisation updates from https://translatewiki.net.
0e44545b7 Update .gitignore
82b6b80bb Use consistent method for finding nearest cursor offset
0b604de30 ve.ce.TableArrowKeyDownHandler.test: Remove eww gross FIXME

Bug: T202359
Change-Id: I73c46edfbf66a0c76bc719010c017ef71670931b
2018-10-30 00:50:37 +01:00
jenkins-bot a022a27a30 Merge "Simplify handling of messages for section edit links" 2018-10-29 11:02:37 +00:00
jenkins-bot 9a5840d96d Merge "Define localisation messages for File namespace edit tab in visual mode" 2018-10-29 11:02:10 +00:00
Bartosz Dziewoński ac45e919ab Update VE core submodule to master (d89186159)
New changes:
d89186159 Add F2 keydown handler

Bug: T172042
Change-Id: I3bc2bb33bec2f5f08f26af49ab8b72e436dbe4cf
2018-10-24 20:51:36 +02:00
Bartosz Dziewoński aa137ef2ad Move styles that are not theme-wide out of themes/
Reasons why these files should not be in a directory named "themes/":
* They are specific to MediaWiki skins, not OOUI themes
* They are specific to one module, rather than affecting many widgets

The new locations/filenames are consistent with other modules that
have skin-specific styles.

Note that we have one more themes/ directory elsewhere in this repo
(and another in VE core) and that is okay.

Bug: T96704
Change-Id: I70bb61e339aeccb3afea657f665785ceaa091777
2018-10-23 05:04:27 +02:00
Bartosz Dziewoński 62273183a8 Simplify handling of messages for section edit links
Change-Id: I5b84fc3863747b4d092a7025475730bb28efeff2
2018-10-13 03:16:53 +02:00
Bartosz Dziewoński 6540bbd422 Define localisation messages for File namespace edit tab in visual mode
I think we must have not been allowing visual editing of File pages
when this code was written?

Bug: T206892
Change-Id: If38642492825877c4b65e395a00b789acdc27eef
2018-10-13 03:14:40 +02:00
Volker E a5a3d829a9 Update user avatar icon and make use of OOUI's built-in
Bug: T123810
Change-Id: I3ed04d3037836b47706d9f7284eeb9668712bdcb
2018-10-10 18:34:27 -07:00
Bartosz Dziewoński e354092417 Update VE core submodule to master (f9afaa3e4)
New changes:
3931cc33a Update OOUI to v0.29.1
5bcab0073 Move node-specific code into rebaser/
8aa80d88b Remove ES6 support for async/await
2536870f9 Separate files for protocol and transport server
b443b7a4f Update OOUI to v0.29.2
70b3ec210 Minor cleanup of ve.ui.MediaSizeWidget

Bug: T206236
Change-Id: Id3bbcd1a9ccb1563e4feb3572aa8f51932677693
2018-10-09 11:06:23 +01:00
Ed Sanders d44e7fb3e8 Mobile target improvements
Change-Id: If55097a45ae812b712a74f41af350bfaa69f6135
2018-10-07 12:47:53 +01:00
Ed Sanders 29b277260f Fix OOUI->MW theme mappings in extension.json
Bug: T206002
Change-Id: I1fcafa397d1054f4d380a60e0ba46c4ece34c7f0
2018-10-03 22:17:49 +01:00
James D. Forrester 22b40aeb2c Update VE core submodule to master (1191c3687)
New changes:
8a7a3f8a5 Fix margin override on block slug
786cb5266 ve.ui.MediaSizeWidget: Fix conditions for when we need error messages
1829982ed ve.ui.MediaSizeWidget: Remove "Make full size" button
1191c3687 ve.ui.MediaSizeWidget: Remove comments about full size button

Bug: T205645
Bug: T205874
Change-Id: I5c87c18088e754ec95bcf36775d046bb92870aa8
2018-10-02 12:18:50 -07:00
Bartosz Dziewoński d094bfa0d0 ext.visualEditor.mwlanguage: Actually load all of the code
Follow-up to bbed4307d7.

Bug: T205834
Change-Id: Idb2febd210891b62976919cd7c6a04784c156807
2018-10-01 20:37:04 +02:00
Bartosz Dziewoński 9cf5515ccb ve.ui.MWMediaDialog: Remove unused widget and messages
* visualeditor-dialog-media-size-originalsize-error
  Unused since 37b3c07b26.

* visualeditor-dialog-media-originaldimensions
  Never used (introduced in 4947420650).

Change-Id: I22f37b457cc6fbac03593fece003e97f4f5a2ccf
2018-09-27 18:31:20 +02:00
Thalia 9813d876e1 Enable the media dialog on mobile visual editor
Also make improvements to the layout, so that the dialog works
in desktop and mobile - most importantly, change from booklet
to index layout.

Bug: T190885
Bug: T118710
Change-Id: I1915d06c9b0e4b7907136e645f60be96e30cc287
2018-09-27 13:21:15 +01:00
Amir Aharoni d80c383ad2 Move VisualEditor apihelp/apierror messages to a separate i18n file
Should be merged along with the corresponding translatewiki change:
I89310a638e75f974af77db313bb9ca090c437bf2

Change-Id: Ie5be8dc09051907d3aea53e33bdd1b3f849ead1e
Big: T189982
2018-09-26 01:53:54 +03:00
jenkins-bot c68b0d9ea0 Merge "Update VE core submodule to master (2d668bdbb)" 2018-09-24 16:07:22 +00:00
Ed Sanders 1631a35c18 Update VE core submodule to master (2d668bdbb)
New changes:
2d668bdbb Separate node classes into individual files

Bug: T205231
Change-Id: Ib628149732e40b139876404867253d0ffa1fb0d0
2018-09-24 08:27:23 -07:00
Thalia bbed4307d7 Separate node classes into individual files
Bug: T205231
Change-Id: I84a6f2f7a842ab44e1f7103c0f288deda0451e79
2018-09-24 12:44:45 +01:00
James D. Forrester a70051d75e Update VE core submodule to master (7c9ceb939)
New changes:
bdd52111a Collapse this.getSurface().getView() to this in ve.ce.Surface
012f77c87 Localisation updates from https://translatewiki.net.
c40692bf5 Use rooms instead of namespaces
31360982e Fix author list when reconnecting
c176f8bba Remove $.isPlainObject warning
ad9edb87a Separate core module into model/view/ui
4475785d5 Merge author name/color data, make naming consistent
8601509c4 Move whitespaceHtmlCharacters to ve.utils.js and rename
361e5d646 Call parent in DimensionsWidget#setDisabled
3a53ca899 Update eslint-plugin-html to 4.0.6
5f88a02bc Allow '/' in path
2ad8dc94d Separate out client-specific utils from ve.utils.js
e8eb8dc97 Fix ve.sanitize to only depend on utils
cdcd7f19b Update UnicodeJS to v0.2.2
689baa436 Report html indent errors
d613e9d48 Create get/setSessionObject methods for JSON storage

Bug: T195111
Bug: T205096
Bug: T205123
Change-Id: Ia519138734ca0c174c20fec2d42f1437c903b82d
2018-09-23 13:53:29 -07:00
Ed Sanders 164ccecf4d CollabPad: Show current sub-page as separate tab
Change-Id: I15da5a3122e7a0dfeb5131e528efa498a7cd1356
2018-09-17 16:25:42 +00:00
Ed Sanders 7eb836adbc Update VE core submodule to master (7420443fe)
New changes:
a273ba69c [BREAKING CHANGE] Implement a SourceConverter

Local changes:
* Use SourceConverter
* Handle `this.doc` being a string in source mode now

Bug: T203114
Bug: T203156
Change-Id: I7bce7b57668e0c1dd511803a54178ae69694a86d
2018-09-14 11:42:34 +01:00
Bartosz Dziewoński 6ba42c6f12 Update VE core submodule to master (7926154e3)
New changes:
8fd23db41 Fix MediaSizeWidget#setDisabled: Call parent method
545f03b12 Don't trust client-supplied docName
e718ee115 Localisation updates from https://translatewiki.net.
a2aeb1c36 Update jQuery 3.2.1 -> 3.3.1
8d6ccce61 Fix alignment in visual editor table dialog

Bug: T203467
Bug: T203889
Change-Id: I91393ab3eb50cb3c320a406d880fcb459a03ad4b
2018-09-10 14:18:44 +02:00
jenkins-bot 048ac8193e Merge "Remove unnecessary IE10 blacklist" 2018-08-31 18:30:07 +00:00
Thalia 58f6fb8910 Add description link message for gallery dialog
Bug: T203262
Change-Id: Ic9ab5ffe5c4f8ea60cb7e9abf6ebea210aeef645
2018-08-31 17:38:42 +01:00
Ed Sanders 10ce48a57e Remove unnecessary IE10 blacklist
IE10 support was dropped from MediaWiki core in 1.31.

Change-Id: I1c8c790428df5afe019e10a65ba5e891f5895dfb
2018-08-30 19:01:59 +01:00
jenkins-bot bf9d3c1b06 Merge "Template dialog: Lazy resize multiline text inputs on first focus" 2018-08-27 20:43:38 +00:00
Ed Sanders 0f81aae133 Template dialog: Lazy resize multiline text inputs on first focus
Bug: T134814
Bug: T200834
Change-Id: I3ec84ad01db1ed896c41ac8ef38cce8eddb0b8c2
2018-08-23 17:34:25 +01:00