Commit graph

7152 commits

Author SHA1 Message Date
Trevor Parscal 926700fbca Re-split the transclusion dialog
We used to have two dialogs; a complex one, and a subclass that dumbed it
down - this was rubbish.

Then we merged them together - this was a'ight.

Now we have two dialogs again; a simple one, and a subclass that fancies
it up a bit - this is wicked keen broham.

Change-Id: I4b2ba31bed5c4f80940623702d635cacd19e0a66
2014-04-17 01:39:18 +00:00
James D. Forrester 0e4676e6a9 Allow MWExtensionInspector to be set to forced LTR status
This is used in e.g. the formula editor and it's potentially useful.

Change-Id: Ie05256285e517c2d0d464822befbf81f2d9209e3
2014-04-16 18:34:26 -07:00
jenkins-bot 537fbc95f9 Merge "Use the correct classname in MobileViewTarget" 2014-04-17 00:45:08 +00:00
Roan Kattouw 5b0d4b5286 Use the correct classname in MobileViewTarget
Change-Id: I7e0a5aa56116dd7f44cbac29e0b6bc5d760e157e
2014-04-16 17:41:18 -07:00
Roan Kattouw 4fc08d24c5 Make the Add template button not wrap to the next line
By default, MWTitleInputWidgets are now 30em wide, but this doesn't
work in the transclusion dialog where we want to put the "Add template"
button after an MWTitleInputWidget and have it not wrap to the next line.
So make the MWTitleInputWidget on the add template page 20em wide instead
(this is what they all were before the default was changed to 30em).

Change-Id: I2f33a87427657f4e27939c401436c4ce6441208c
2014-04-16 16:24:45 -07:00
Roan Kattouw 9312501824 Update VE core submodule to master (2d96306)
Add reference to DimensionsWidget.css

New changes:
2d96306 [BREAKING CHANGE] Separate Widget styles properly

Change-Id: I84c1a3576b8eca74d483e26a4affd21f790040ad
2014-04-16 16:02:51 -07:00
Roan Kattouw 2262073c9c Update VE core submodule to master (4366f20)
Use new dm.Surface method for checking undo history state
(hasPastState -> hasBeenModified).

New changes:
38776df [BREAKING CHANGE] Refactor history state methods to better suit uses
3412b41 Localisation updates from https://translatewiki.net.
0c5238c Add system to dm.Surface for staging changes
8f0077c Only hide popups on selection change
4575f82 Fix initial selection when focusing in Firefox
debfd4e Document focus/blur cleanup

Change-Id: Ic66c96a4f64ad82a01a84535ca8cd19332065b37
2014-04-16 15:57:28 -07:00
Roan Kattouw 9d1b7432fd Also focus surface in media edit dialog
16ec8ffdcf did this for the reference dialog, but the media edit
dialog needs it too. Additionally, we need to focus it when the
user switches to a different page then comes back.

Bug: 63909
Change-Id: If1b9587f4d10dbe6374e987b35c781954bcc566d
2014-04-16 15:12:39 -07:00
jenkins-bot 4d6a59b16b Merge "Focus the surface in the reference dialog after it opens" 2014-04-16 19:00:51 +00:00
jenkins-bot 266bc709f6 Merge "Always replace state with VE tag when loading" 2014-04-16 18:50:09 +00:00
Roan Kattouw d335e59330 Fix another surfaceModel.getFragment() in MWCitationDialog
Change-Id: Ic12652bf3d53396f84d558595ce1e4a2d0a22796
2014-04-16 11:42:15 -07:00
Roan Kattouw 16ec8ffdcf Make inserting reference lists work again
surfaceModel.getFragment() is a null fragment, use this.getFragment()

Bug: 64012
Change-Id: I995929ff0dda60220e17e579994b51ffb406f149
2014-04-16 11:40:26 -07:00
jenkins-bot e708595f14 Merge "Make fieldsets render properly" 2014-04-16 18:27:16 +00:00
jenkins-bot fb366c47f1 Merge "Hide inspectors using new method when saving" 2014-04-16 18:27:05 +00:00
jenkins-bot 544531d092 Merge "Update VE core submodule to master (69db959)" 2014-04-16 18:19:23 +00:00
Translation updater bot c83a165b3c Merge "Localisation updates from https://translatewiki.net." 2014-04-16 18:16:16 +00:00
Translation updater bot 7eeeccc841 Localisation updates from https://translatewiki.net.
Change-Id: I7b42029a5301cd0a3a3a4d2a095261aa036935b7
2014-04-16 18:15:39 +00:00
James D. Forrester 34d1e8356f Update VE core submodule to master (69db959)
New changes:
51bd18e Allow the context to close any open inspector
69db959 Update OOjs UI to v0.1.0-pre (c58b498573)

Change-Id: I62d8b4c2ec13022f33667e1050782b76f6d93a76
2014-04-16 11:09:42 -07:00
Moriel Schottlender fa72f5fdc2 Border checkbox disabling/enabling fix
Due to a lack of clarity in the wikitext documentation the border
checkbox wasn't set up right. This is the proper behavior: border is
allowed for all unframed images (frameless and basic) while the
framed images (frame and thumb) have it anyways. Wikitext
documentation was also clarified for prosperity.

Change-Id: I4dd4775da473d669781553796be99646240c13fe
2014-04-16 13:14:58 -04:00
Krenair e9153fdccf Always replace state with VE tag when loading
Instead of just when venotify is used. To stop the back button breaking.

Bug: 63739
Change-Id: I637818f34a9015076c85c6daccb337503ad2499d
2014-04-16 18:02:10 +01:00
cmcmahon d62a9e939a [browser test] Save page is slow.
Change-Id: I550c462795f3e51555a21e0877985052610ad8cc
2014-04-16 08:52:21 -07:00
Krenair 9c2e1d8048 Follow redirects in the category widgets
Display the redirects nicely in the UI, etc.

Bug: 52414
Change-Id: Ib62144cb90899d0c525d6f08f6b5f1159b7d2a86
2014-04-16 15:30:14 +00:00
Moriel Schottlender 8d99aa88c8 Fix border checkbox
Make sure border is enabled for unframed types and disabled for
framed images.

Change-Id: I716e9bc4140fbc09aac52930d1dd8213f31617a3
2014-04-16 00:03:35 -04:00
jenkins-bot 24071290a8 Merge "Fix name of advanced settings page in open command" 2014-04-16 02:57:30 +00:00
Krenair 96cdfe28ce Fix name of advanced settings page in open command
Bug: 63984
Change-Id: I924520be81a183a1de3f8f81c60d9ed26fb3a80e
2014-04-16 02:08:30 +01:00
James D. Forrester 957a2cb82a Update VE core submodule to master (f1dd298)
New changes:
f1dd298 Clear the surface observer when blurring

Change-Id: Ibb5a1020f4d4d9de68188cabde7615f9e181a37a
2014-04-15 16:45:52 -07:00
James D. Forrester aa3c520c1c Update VE core submodule to master (bb7124b)
New changes:
a997cc1 Debounce ce.Surface#onFocusChange
ef24608 Use document direction when a fragment has a null range
644243a Don't call select on a fragment if it's null

Change-Id: I22d00fd360539f286d815e747dd904bed87276c4
2014-04-15 15:42:37 -07:00
jenkins-bot c1f29636e8 Merge "Update VE core submodule to master (d1f5386)" 2014-04-15 22:41:49 +00:00
Roan Kattouw b764ecc7f4 Focus the surface in the reference dialog after it opens
Otherwise the surface ends up in a weird half-focused state which
causes it to behave strangely.

Bug: 63909
Change-Id: I3ebc30fde0202116b383a5b497aca65b66732922
2014-04-15 22:25:41 +00:00
James D. Forrester 42f9d3e45b Update VE core submodule to master (d1f5386)
New changes:
2909ff9 Update OOjs UI to v0.1.0-pre (eba79af989)
1737a76 Add .focus() to SurfaceWidget
6fc4026 Code style typos
d1f5386 Update OOjs UI to v0.1.0-pre (8197f2cd2e)

Change-Id: Ia8edc2319ed0a4578652fb7e5b257061edd0a7c0
2014-04-15 15:23:30 -07:00
James D. Forrester 37030882d1 Fix fencepost error with MWMoreParametersSearchWidget overflow
The logic was checking that there were at least three items to show, then triggering
the MWMoreParametersResultWidget widget with the number of items left in the overflow
if the limit was two. Whoops. :-)

Change-Id: Icec16a2d26bef8bf8d74ed619341afd494ca0479
2014-04-15 12:30:40 -07:00
Trevor Parscal 9cd05d05a0 Make fieldsets render properly
Depends on I797ec22 in OOJS-UI

Change-Id: I3841bc50346e67dfe92814ebe337fd92365ae1d4
2014-04-15 11:47:15 -07:00
Ed Sanders b019036a2c Hide inspectors using new method when saving
Previous hack caused unwanted blur events and subsequent range changes.

Depends on I8388318311 in core.

Change-Id: I9163f4d9928887a5eec09f0651ec0a66cc221cd4
2014-04-14 17:17:42 -07:00
jenkins-bot 0357df0e16 Merge "Pass required params to open for save dialog" 2014-04-14 23:21:55 +00:00
Ed Sanders 3bba5e4d3b Pass required params to open for save dialog
Change-Id: Ib2e8f6255544894d54d9a89a579241b40c58ef90
2014-04-14 16:18:22 -07:00
James D. Forrester 318f60365c Update VE core submodule to master (5aa55c5)
New changes:
f8a0e73 Followup 7e39f497: call parent method in DialogTool so disabling works
185a00f Fix typo in ve.dm.Scalable
63390ab Update OOjs UI to v0.1.0-pre (eca1fc20e7)
1f636cf Detect document focus properly and allow null selection in model
82ad081 Event sequencer cleanup
1b6a622 Create ve#contains
07132bc Prevent pasteTarget selection while already selected
32b7f47 Make the DOM hash ignore text node splitting
5243788 Revert "Make the DOM hash ignore text node splitting"
5aa55c5 Re-apply "Make the DOM hash ignore text node splitting"

Change-Id: I8c4ab05a0ff206fdca470c42008768626449e2bc
2014-04-14 16:16:22 -07:00
Trevor Parscal 9e6451d40c Fix inserting references list while selecting another kind of node
There are two ways dialogs determine if they are inserting or updating.

1. They evaluate whether the dialog is inserting or not and set a boolean
   flag, used later to steer the saving code

2. They evaluate whether the dialog is inserting or not and, if not,
   store the node to be updated in a property, used later to steer the
   saving code

In the reference list dialog, setup used strategy 1, and teardown used
strategy 2. We've now normalized to use strategy 2 in both methods, which
fixes this bug.

Bug: 61885
Change-Id: I1b077b2aef4121328bce2b373874dd7373e405a1
2014-04-14 19:44:28 +00:00
cmcmahon 219ca37909 [browser test] make test pass in both Chrome and FF
Change-Id: I36fc3eb31d0a97145cff5f43aef3a5365286de29
2014-04-14 12:10:02 -07:00
jenkins-bot 261fcbbbc0 Merge "Update VE core submodule to master (1064150)" 2014-04-12 00:34:36 +00:00
jenkins-bot ba7cf40ceb Merge "Also set requiresRange for CitationDialogTool" 2014-04-11 19:26:32 +00:00
Roan Kattouw 2d671a38a2 Also set requiresRange for CitationDialogTool
The citation tools weren't being greyed out when the selection was null

Change-Id: I7d4d486a010f4c1301f3081661e7f343c24452df
2014-04-11 12:19:04 -07:00
jenkins-bot d20ff82e5c Merge "Use updated tab labels on description pages for files in foreign repos" 2014-04-11 19:11:10 +00:00
James D. Forrester dc5ec4f256 Update VE core submodule to master (1064150)
New changes:
de81534 Put CommandHelpDialog keyboard shortcuts in kbd not div elements

Change-Id: I1070e824814f92ef322a58af9552e64fa3018d05
2014-04-11 12:06:45 -07:00
Roan Kattouw b54b517dbc Followup b2296bdd2: the property is called requiresRange, not requiresFocus
Change-Id: I09937603e1957f1acbdbe4cc56e47e00f31c892b
2014-04-11 11:59:55 -07:00
jenkins-bot d8453acff5 Merge "Remove remaining uses of surfaceModel#getSelection in dialogs" 2014-04-11 18:43:14 +00:00
Ed Sanders 340a939c97 Remove remaining uses of surfaceModel#getSelection in dialogs
These were being used indirectly in the MW*Model's. Use surface
fragments instead.

Fixes I0fae3e5ff2bd.

Change-Id: I1d6aa5e00a9315cf7088f87f9e9d828833feec64
2014-04-11 11:14:43 -07:00
Roan Kattouw 989fd6214c Fix JS error when opening VE on redirect page
Change-Id: I95dd2dc2c52ffa3d420a579592e84001bd2b10e8
2014-04-11 10:13:51 -07:00
jenkins-bot 49ce63020c Merge "Disable MW tools when surface loses focus" 2014-04-10 19:38:09 +00:00
Ed Sanders b2296bdd2a Disable MW tools when surface loses focus
Bug: 62410
Change-Id: I00fa2de637b2c1f2a57c8c1f09e90f71285feab7
2014-04-10 12:01:47 -07:00
Trevor Parscal afb182c23c Limit the number of citation tools to 5
Don't let too much toothpaste get out of that tube aye!?

Change-Id: I5cd92b7826d55ddde505f1bb883c6f8ed3223ec0
2014-04-10 11:47:34 -07:00