Commit graph

12520 commits

Author SHA1 Message Date
Ed Sanders 4fe6be1f34 Separate out ArticleTarget as a module
Also move save button command help registration to ArticleTarget.

Bug: T151096
Change-Id: I941d17254a2e20a82aa46fd538abf887d757c0c3
2016-11-24 12:35:41 +00:00
jenkins-bot 1909c445bb Merge "Allow the gallery dialog to insert duplicate images initially" 2016-11-24 04:13:03 +00:00
Ed Sanders 0334263718 Missing i18n in gallery dialog
Change-Id: I369d5b9d42a5fd6b4d1afc12508632a282591320
2016-11-24 00:09:49 +00:00
Translation updater bot 10d348af8b Localisation updates from https://translatewiki.net.
Change-Id: Ie8f35a953ffb6e24acd7aa555b2cad555ee6e9f6
2016-11-23 22:41:42 +01:00
jenkins-bot 69308abf87 Merge "Update VE core submodule to master (f4d2cd2)" 2016-11-23 20:23:34 +00:00
jenkins-bot f0a70ce6a2 Merge "Respect oldid parameter in NWE" 2016-11-23 17:55:30 +00:00
James D. Forrester c90e53a795 Update VE core submodule to master (f4d2cd2)
New changes:
d68bd23 DiffDialog: Use surface dialog manager for diff window
d68fe24 VisualDiff: Replace whitespace detection with wordbreak detection
dd65a44 VisualDiffs: Only show unchanged content adjacent to changed content
7f70f64 Fix some edge cases with adding classes to nodes in diff
f4d2cd2 Follow-up d68bd23: No need to list ve.ui.DiffDialog twice in modules.json

Change-Id: I6f46f3d14ad81e4efdde0c970a3102e577b12772
2016-11-22 17:39:43 -08:00
jenkins-bot fde5c3c2ff Merge "Follow-up I63ab27cb: Get rid of notices tool when there are no notices" 2016-11-23 01:17:42 +00:00
Thalia 003ec7b653 Allow the gallery dialog to insert duplicate images initially
Change I94f4fadd84cd3e prevents the gallery dialog from inserting
duplicate images into the gallery dialog after one request (e.g.
so double-clicking on an image in the search widget doesn't cause
the image to be inserted twice). However, galleries can
intentionally contain duplicates of the same image, so it is
possible to make a spearate request to insert a duplicate image.

When the dialog is first opened, it requests all the images in
the gallery at once, so the above change was causing the
duplicates in an existing gallery to be dropped. Duplicates
should be allowed to be inserted following this initial request.

Bug: T150894
Change-Id: I34353bc9b8db947488474c4be52292e0a1447705
2016-11-23 01:02:35 +00:00
Alex Monk b51720e165 Respect oldid parameter in NWE
Change-Id: I5a6388f50cc432421343974eb9f721f5e5a94d93
2016-11-23 00:47:42 +00:00
jenkins-bot 508b4164bd Merge "Let gallery dialog handle unprefixed filenames" 2016-11-23 00:33:39 +00:00
Alex Monk b89a6ee463 Follow-up I63ab27cb: Get rid of notices tool when there are no notices
Bug: T151423
Change-Id: I3dd9d2cbfb1fa536490eb8b4b7d630e9c6cfdd48
2016-11-23 00:30:06 +00:00
Thalia 2364f530a3 Let gallery dialog handle unprefixed filenames
The namespace prefix before image filenames is optional
in galleries, but the API requires it. If the prefix is
omitted, add the file namespace prefix.

Change-Id: I3d126550c2ad2e84454122f92307ba4bc943780b
2016-11-23 00:20:32 +00:00
jenkins-bot 3d8a749cf2 Merge "init: Initialise 'active' property in mw.Target instead of subclass" 2016-11-22 23:35:10 +00:00
jenkins-bot 8370b98e3f Merge "Move around code that sets up edit notices to ensure it runs after we receive the notices to display" 2016-11-22 23:27:26 +00:00
Alex Monk 16e294fba7 Move around code that sets up edit notices to ensure it runs after we receive the notices to display
Bug: T151236
Change-Id: I63ab27cb236169f300295b2ed4c88e01048092e7
2016-11-22 19:16:09 +00:00
Timo Tijhof cde3d2a7f8 init: Initialise 'active' property in mw.Target instead of subclass
This is set to 'true' in mw.Target#setupSurface(), but not initialised or
used there in that class.

It was previous initialised in an indirect subclass (DesktopArticleTarget).
Move this to the parent class instead for clarity.

Change-Id: Ie3e12d254aa4b689fdce64620e110164311bc60a
2016-11-21 18:06:52 -08:00
Ed Sanders 7f2d5b5bee Don't re-bind edit tab in DAT when using SET
In SET the tab's events are already bound in DAT.init.

Bug: T151258
Change-Id: I04529dbdea2d2ff5e52b0f11035a4ac11946617b
2016-11-21 22:09:26 +00:00
Translation updater bot 0757c5e242 Localisation updates from https://translatewiki.net.
Change-Id: I70248fdc2480098dd966d59db36306e2e923cb77
2016-11-21 22:42:09 +01:00
jenkins-bot 42bc9f39bd Merge "Allow 'wikitext' to be an empty string in save API" 2016-11-21 18:25:29 +00:00
jenkins-bot 2701e0de2d Merge "Update VE core submodule to master (0ef16f0)" 2016-11-21 17:15:48 +00:00
James D. Forrester 1d43607bd9 Update VE core submodule to master (0ef16f0)
New changes:
65399fa Localisation updates from https://translatewiki.net.
0ef16f0 Follow-up Ice6b167: Ensure metadata is inserted before the internal list

Change-Id: Ieb967a1e2e6f3a90ed26d25715e41cb9a3dbcb44
2016-11-21 08:15:32 -08:00
Ed Sanders 6e64fba2f8 Unbreak education popup
Tools only setup once now, and that is during the dummy surface
phase, so we have to setup the education popups then.

Change-Id: Idf46fe42c893c0692dc442226297253074ef9bd7
2016-11-21 15:19:58 +00:00
Translation updater bot 01cefc47db Localisation updates from https://translatewiki.net.
Change-Id: I21e87c04625b6c87ac50ebcf8c014e6d2e29ed92
2016-11-20 22:21:47 +01:00
jenkins-bot 8fd396151c Merge "Migrate DesktopWikitextArticleTarget code upstream" 2016-11-20 03:06:55 +00:00
Ed Sanders e1a887ccf8 Migrate DesktopWikitextArticleTarget code upstream
Change-Id: Icca4715411737a561302b44b127d91d117e7e29b
2016-11-20 02:52:14 +00:00
Translation updater bot 0b257c12db Localisation updates from https://translatewiki.net.
Change-Id: Ie9a1877be552d5492c483cc7cb2468eba901212f
2016-11-19 22:08:59 +01:00
Ed Sanders b9741d1cc2 Allow 'wikitext' to be an empty string in save API
Change-Id: Icdfd60c4a2de6a678cad995d5bcf80d07703537b
2016-11-19 14:09:16 +00:00
Timo Tijhof 7f613ed571 build: Change pathPrefix for eg-iframe back from '../lib' to 'lib'
Follows-up 94a7e34. The main fix there was adding the promise to
the example execution. The path change was not needed, and actually
breaks the demo, again. Only the 'docs' directory is published.
Accessing ../lib results in 404 Not Found after syncing to doc.wikimedia.org.

This is why we run 'grunt copy:jsduck', which copies those files into
the docs/ directory.

Change-Id: I2ea89bfbd980910510cbd8639f871ec931a768f1
2016-11-18 16:12:16 -08:00
Ed Sanders 94a7e34b9a build: Bring over eg-iframe fixes from core
Bug: T109170
Change-Id: Iccae8f92a19e76d6d203df68d483e0e1d8ca2c38
2016-11-18 15:17:14 -08:00
Translation updater bot f64099f7cb Localisation updates from https://translatewiki.net.
Change-Id: I314c1b19bc52e114055039301bf97ee7b4e0c36e
2016-11-18 22:17:43 +01:00
Translation updater bot dc0b0ea97a Localisation updates from https://translatewiki.net.
Change-Id: Idf5ec60855a5539b916f7a14aa44aea1e145600a
2016-11-17 22:56:27 +01:00
jenkins-bot c790944eb0 Merge "Setup htmlBlacklist and add rule for read-mode MW references" 2016-11-17 17:30:45 +00:00
James D. Forrester 910aa9cb0a Update VE core submodule to master (83ea152)
New changes:
6f28f19 build: Bump eslint-config-wikimedia to v0.3.0 and make pass
270fda6 Make $returnFocusTo a no-op in WindowManager

Bug: T150556
Change-Id: Iad3959fa836afd5b81ef9f668077d68effc69063
2016-11-16 14:19:46 -08:00
Translation updater bot 59b4c5910c Localisation updates from https://translatewiki.net.
Change-Id: I856a87673d7e11bc10d2e240d506a816729e2bad
2016-11-16 22:54:25 +01:00
Alex Monk 86719eb90f Prevent endless error loop if falling back to wikitext (after a load failure) fails.
Change-Id: Id48fa13a33aee9fabf857d20a75d26463c329f44
2016-11-16 18:52:26 +00:00
jenkins-bot 51adc1b37f Merge "Fix handling of failure to load visual mode" 2016-11-16 18:48:16 +00:00
jenkins-bot 3483055c29 Merge "Remove max-width from save summary" 2016-11-16 17:55:35 +00:00
Ed Sanders 4246ea72ef Follow-up I7f1d9fe: Add mwcore dependency
Change-Id: I2b30f0fd289e5bcb8bde64e83354a973ea4190f9
2016-11-16 17:02:39 +00:00
Ed Sanders 52f8b34473 Separate out resources for media search widget
Make this new modules a direct dependency of mwgallery so
that galleries work even if mwimage isn't loaded (e.g. mobile)

Bug: T150840
Change-Id: I7f1d9fe0c0133abe5cd56c1e5e34b93d9edde9bc
2016-11-16 14:27:17 +00:00
James D. Forrester f24e34de3c build: Bump eslint-config-wikimedia to v0.3.0 and make pass
Change-Id: I7449c11aa63c50fda667265c32021439cc53471f
2016-11-15 15:05:05 -08:00
jenkins-bot 65604802ac Merge "Fix attribute.style typo in gallery dialog" 2016-11-15 22:09:57 +00:00
Translation updater bot dccb137e0e Localisation updates from https://translatewiki.net.
Change-Id: Ia94028500a1e833f991162fb716b1bb7cbd9c6ef
2016-11-15 23:02:26 +01:00
Ed Sanders 134477a840 Setup htmlBlacklist and add rule for read-mode MW references
Logically depends on If1b20fefe4b.

Bug: T150418
Change-Id: I0e2249b64f3b452c0322e7a20515ee7b2b6c6f60
2016-11-15 17:20:17 +00:00
James D. Forrester 8407e71d14 Update VE core submodule to master (c8389bd)
New changes:
e9b392a dm.Surface: contextChange if non-collapsed selection moves in/out of annotations
efa129c Add HTML blacklist for content which doesn't have a model type yet

Bug: T126232
Bug: T149714
Change-Id: I456ed4dbd0ed0452e58d554f5c88a82c1bf2bb26
2016-11-15 08:47:58 -08:00
jenkins-bot 019aee30d4 Merge "Always set mode when activating the target" 2016-11-15 16:07:50 +00:00
jenkins-bot 961f59d8ce Merge "Normalise filename after image is chosen in gallery dialog" 2016-11-15 12:55:21 +00:00
Ed Sanders ff4761bbd9 Fix handling of failure to load visual mode
Reject the activating deferred making handleLoadFailure
redundant.

Fix logic for switching back to OWE aware of NWE.

Change-Id: I328fc944bb6b9152752742fe35c56b95e3255b88
2016-11-15 12:44:38 +00:00
Ed Sanders b4ff55a38c Always set mode when activating the target
Otherwise if the target was already loaded the mode will
not be changed, which can cause the wrong editor to load
in multi edit tab mode.

Change-Id: I64071dfdfc8511cce51bda20b9c62d7fc126c528
2016-11-15 12:44:38 +00:00
Ed Sanders 521c3c8436 Pass isModified when switching from VE to NWE
Bug: T150707
Change-Id: I9ae525aa7a5883bb45f91262db8abc082983ee1b
2016-11-14 23:05:21 +00:00