Commit graph

3611 commits

Author SHA1 Message Date
Volker E. 344add6080 styles: Update invalid border color
For the invalid border color we'll use the current border error color.
With CSS custom properties on the horizon, we'll easily replace them
consistently in the future.

Change-Id: I1ec266e90a974cf79576ee7db6287ea4eac94656
2024-03-28 20:40:27 -07:00
Ed Sanders c9c7c06e76 Nest LESS files
Change-Id: Ic9fad12fe4c20793dd54cb3169b9dffe3a6a18da
2024-03-19 13:56:41 +00:00
Ed Sanders 9ee1b51fbe Move CSS files to LESS
Change-Id: Ic818efe7315187bf96ead7bd6468ecb3d44d988d
2024-03-19 13:56:30 +00:00
Ed Sanders 960edae818 Move dialog CSS files to LESS
Change-Id: Ic91cbb285675116e62cb2546b21927c704ad5e65
2024-03-19 12:46:22 +00:00
jenkins-bot d9eebe04ef Merge "Remove unused ve-ui-educationPopup-header CSS" 2024-03-18 20:31:46 +00:00
gerritbot aa1924faf5 styles: Update color in CSS from #d33 to #d73333
This patch promotes a consistent design decision across projects in
MediaWiki core, extensions, and skins. The darker red color meets the
W3C Web Content Accessibility Guidelines (WCAG) at Level AA that text
or images of text must have a contrast ratio of at least 4.5:1 (or 3:1
for large text).

Bug: T343239
Change-Id: I0f8db861b029c61d524416379a1a842f5137c8cb
2024-03-14 12:15:29 +00:00
Reedy 42df4785e3 Fix casing of MediaWiki
Change-Id: Ic1240acbd90a8bedaeb875bbc393b9892e8dc23d
2024-03-12 15:40:46 +00:00
lwatson ec11ba3ade styles: Update color in CSS from #d33 to #d73333
This patch promotes a consistent design decision across projects in
MediaWiki core, extensions, and skins. The darker red color meets the
W3C Web Content Accessibility Guidelines (WCAG) at Level AA that text
or images of text must have a contrast ratio of at least 4.5:1 (or 3:1
for large text).

Bug: T343239
Change-Id: I517a8f5bee4f62267b37e66a8da7500ca547217e
2024-02-29 15:16:24 -05:00
Ed Sanders f7eef9ce12 Remove unused ve-ui-educationPopup-header CSS
We just use a standard <h3> in the popup.

Also document generated classes.

Change-Id: I8c61a240fe8c7222c70cad19ea9300b2105484ea
2024-02-28 15:44:36 +00:00
Ed Sanders 3badbe433a MobileSaveDialog: Remove checks for module existence
1. The module always exists because this file is only
   loaded from MobileFrontend.
2. If the module doesn't exist, mw.loader.using will
   just reject anyway.

Change-Id: I6724078b362782813576cad2459e7b7903655e5e
2024-02-27 15:11:18 +00:00
Ed Sanders 245e354b79 Numbered links on mobile: Show "Add label" button
Show this in place of the useless "No preview" message.

Bug: T358258
Change-Id: Ic525aa8cdac5f74b843927b488ace9adbda55a6b
2024-02-22 18:02:10 +00:00
Ed Sanders 37598015b3 Always use the label input for link insertion
Bug: T358258
Change-Id: I17011e0402d9bf84d8a2622b4420eb4a4b5bc722
2024-02-22 17:39:29 +00:00
Bartosz Dziewoński b119b633cf Update VE core submodule to master (58a24a62c)
New changes:
f5fe845bc ve.collab UI and bookmarklet
e096b57e9 Localisation updates from https://translatewiki.net.
5ed427d39 FocusableNode: Try to redraw highlights during setup
d966cf7be Exclude OOUI from generated JSDuck documentation
4abb6dfa6 Update OOUI to v0.49.0

Local changes:
* Exclude OOUI from generated JSDuck documentation
* ve.ui.MWConfirmationDialog: Remove copied documentation

Added files:
- .jsduck/external-ooui.js
- collab/ve.ui.CollabProcessDialog.js
- collab/ve.ui.CollabTool.js

Bug: T185396
Bug: T250843
Bug: T356983
Change-Id: I8fcacbbf4f9f213e58af91cc79ef8e89b65895b4
2024-02-08 20:46:40 +01:00
Jon Robson e17ff06c9b Dialogs: Avoid using the deprecated mw.mobileFrontend function
As mentioned in the ticket access to this library is now
deprecated and consumers should require the module. The existing
method is replaced with the method in the migration table in the
Phabricator ticket.

Bug: T348807
Change-Id: I72a5242399d2cd04b5c9fbee947dc59d94c0ba7c
2024-01-29 20:46:38 +00:00
David Lynch d5cd77b254 MWTocWidget should fetch the metaList from the correct location
Follow-up to 7954f5897c

Bug: T355944
Change-Id: I5070c7e958af918ffd5d5467219026ad114ca4a1
2024-01-26 10:26:48 -06:00
jenkins-bot d69bfd52b2 Merge "Link inspector: Use searchFragments feature in TitleWidget" 2023-12-07 16:44:26 +00:00
Ed Sanders d42a0772bb Move verbose copyright message to AUTHORS.txt
Avoids having to update the date in every file every year,
which we stopped doing.

Change-Id: I7bf7aa0937eef911e00772470091753a7b06fd3d
2023-12-01 16:07:39 +00:00
David Lynch 5db452f5fa Fix Gallery images always having |link=| and |alt=|
Link is fixed by having the gallery image search results automatically
link to the image, which will resolve down to there being no `link=` in
the output. This lets us preserve whatever existing link has been
applied from source when editing gallery images later.

Follow-up to Iefc520b8513e833665dae9d5c3a9dca2762264a6

Bug: T350912
Change-Id: Iab21f72b7f1625d75fe52471b33718606c469518
2023-11-28 11:42:56 -06:00
Ed Sanders 3966573f02 build: Update ESLint to 0.26.0 and autofix
Change-Id: Ia5e15684c1c3dcd69985445a09fc4e4910368b5b
2023-11-28 11:18:09 +00:00
Ed Sanders 60f9dc2191 Fix width of preview in Vector 2022
Change-Id: Iea3109239a8d6519e7f93c8447ccfd40f1dc3aab
2023-11-27 16:29:31 +00:00
Ed Sanders ededb6280f Link inspector: Use searchFragments feature in TitleWidget
Bug: T52881
Depends-On: Ic0a10935ad45846afc8feb75cec00a4bfcde3d86
Change-Id: I6e1c148a671abe87bb9e9ce153e9b0b70e5746ec
2023-11-17 15:12:05 +00:00
jenkins-bot 3c609d13c5 Merge "Convert MWSaveDialog.css to less" 2023-11-17 13:41:27 +00:00
Ed Sanders 7545b46d16 Convert MWSaveDialog.css to less
Change-Id: I13d23492bcd7264076df0679a6405d2e5969919e
2023-11-17 13:12:09 +00:00
Nardog 9b9f2c50b0 Recognize DEFAULTSORT again
Since Parsoid now treats DEFAULTSORT like any other template, we have to
scan mw:Transclusion spans.

Bug: T337398
Change-Id: Icba92fc14c1c56ec4711ba49407e8be368d57842
2023-11-09 21:26:20 +00:00
Ed Sanders 7a3120d9d5 Remove unused CSS classes
Unused since I5839ba62fe4.

Change-Id: I927e64f14f672b9fca6c7e8c6806a38cea07382a
2023-11-08 19:25:32 +00:00
Bartosz Dziewoński 5667832c1b Attach content to teleport target instead of <body>, remove Vector hacks
In MediaWiki, OO.ui.getTeleportTarget() is overridden to return
a different element (itself attached to body), which is supposed
to be styled appropriately by skins (e.g. z-index above any
floating header, font-size same as body text, etc.).

As a result, we no longer need to do weird things with the
'vector-body' class to achieve correct font size on Vector,
and we can remove some font-size overrides for Vector and MonoBook.

Bug: T348288
Bug: T339058
Change-Id: I6329b3023573b3dcfc8f471c4693be9bb1e9e430
2023-11-06 14:29:12 +00:00
Ed Sanders 3bbcb66e9a Wikitext table tool: Use different message for caption placeholder
The wikitext table tool is re-using messages meant for other
things anyway, so might as well use a message that is still
in use elsewhere, as opposed to one for a tool that was removed
7 years ago (in Ife3f3505b845d).

Change-Id: I305f5f5a67e0340f89160e6654ad86f81609f9ab
2023-11-03 15:48:55 +00:00
Ed Sanders 284fb20da4 Restore help toolbar title
Was lost when we converted it from a PopupTool
in I81d217bc1ab9.

Also visualeditor-help-title is unused since that commit,
and remove debugging code.

Change-Id: Ic1d40bac8ef76fbb6f009dd8cecec8dc74c1aa4b
2023-11-03 15:38:40 +00:00
jenkins-bot a7b7f659c7 Merge "Roundtrip media tag name in galleries" 2023-11-02 21:40:12 +00:00
jenkins-bot 979cc39472 Merge "Set alt in data-mw for non-img media" 2023-11-02 21:39:02 +00:00
Ed Sanders 09d60e784b Fix remaining uses of 'parent'->'super'
Bug: T120821
Change-Id: Id6ccb82d6d6027265d1595dbf11c1c4abeabc392
2023-11-02 16:42:31 +00:00
jenkins-bot a87cc5cb9f Merge "styles: Use 'mediawiki.skin.variables.less', remove WikimediaUI Base ref" 2023-10-30 18:07:49 +00:00
Volker E ba0ca0f0e3 styles: Use 'mediawiki.skin.variables.less', remove WikimediaUI Base ref
Using 'mediawiki.skin.variables.less' with Codex tokens now that
it's available. Also removing a comment that's OOUI variable specific.

Bug: T334934
Change-Id: Id697baa9537013c9e240dbfaa9ead1eb15280133
2023-10-26 17:18:54 -07:00
jenkins-bot e5c81199c9 Merge "Template dialog: Use wrapping/expanding input for "line" inputs" 2023-10-26 16:11:45 +00:00
jenkins-bot aac7f99742 Merge "ve.ui.MWEditSummaryWidget: Use built-in 'allowLinebreaks' option" 2023-10-26 15:55:41 +00:00
Ed Sanders 1fcf167028 Template dialog: Use wrapping/expanding input for "line" inputs
Bug: T348482
Change-Id: I5cbbd84723c042dee176be8d77a7beec7d86e226
2023-10-26 09:16:24 -05:00
Ed Sanders c6f732914f Template dialog: Remove height override of collapsed LazyMultilineTextInputWidget
The default rendering is already correct unless there are more
than 2 lines of text present.

Change-Id: I5be936d75f81dcbbb58793d93796240540555124
2023-10-26 14:22:10 +01:00
jenkins-bot 60b7420e3f Merge "Media Dialog: make the alt field wrap and autosize for longer values" 2023-10-26 12:48:31 +00:00
David Lynch e2a7592bab Media Dialog: make the alt field wrap and autosize for longer values
Bug: T349319
Change-Id: I60e0a9c85f24132651007b436f146be801e77ebb
2023-10-26 12:20:05 +00:00
Arlo Breault f909f87b02 Roundtrip media tag name in galleries
This should have been part of
If5dc6b794dacd6973d3b2093e6b385591b91d539

Bug: T348703
Change-Id: I85f83d8b336ab4d6799bbe8007ef0441570a84ca
2023-10-25 13:29:19 -04:00
Arlo Breault 2497a5254e Set alt in data-mw for non-img media
Follow up to I02ea8421e468635ba6297bb5cda488a5a79c9a1d the depends on
I7a5c24f6ffc15ff0455adf5b025b695ee71501b6 in Parsoid.

Note that the mediaTag isn't currently being passed around for gallery
image nodes so, for example, a <video> becomes an <img> as is.  But,
that's independent of this patch, and a follow up will fix it.
Noted in T348703#9278332

Bug: T348703
Bug: T214603
Change-Id: I5f7d3dfe0a41fac1568c97dccc41209c14e741d0
2023-10-25 13:23:47 -04:00
Bartosz Dziewoński 0167346cbb ve.ui.MWEditSummaryWidget: Use built-in 'allowLinebreaks' option
New in OOUI v0.48.2.

Change-Id: I28dfa2405167ee4b9d9cd2fd3bb3e15498247ac6
2023-10-25 08:26:59 -04:00
Volker E fa3f2781b7 styles: Replace WikimediaUI Base vars with equivalent skin variables
Replacing several values with MediaWiki skin variables featuring new
Codex design tokens, available since >= v1.41.0.

The values are 1:1 visual replacements in the default Codex
'WikimediaUI' theme, a continuation of the base vars, and the default
for Vector and MinervaNeue skins.

Also replacing
- other static color values with variables
- and outline value as the Codex default brings an accessibility
  advancement for free

Bug: T334934
Change-Id: I512427803cffce1c16879015c45cf1e35fe17480
2023-10-25 09:30:56 +02:00
thiemowmde c581f0e3bc Favor jQuery's .toggleClass() to reduce code duplication
Change-Id: Ic616ffbfac410849413e8fad6dde260514884efb
2023-09-25 18:59:10 +00:00
jenkins-bot a2d601b4ab Merge "Add mw-no-invert class to thumbnails" 2023-09-11 17:19:17 +00:00
Ed Sanders 1053204077 Add mw-no-invert class to thumbnails
Bug: T345281
Change-Id: I49d9b65fefd4fae15715d2a10db83b90c7021027
2023-08-30 19:02:52 +01:00
David Lynch 481dd52067 Track when edit notices are shown
VisualEditorFeatureUse as feature: notices, action: show.

This doesn't distinguish between the automatic on-load show and manually
showing them from the toolbar.

Bug: T344465
Change-Id: I5a0d7e87592c286afe51e02ae8436f7d2ce71021
2023-08-24 14:03:42 -05:00
Ed Sanders 2b4dab6703 build: Update stylelint-config-wikimedia
Change-Id: I4e56a07c0cd478fb2ea1908c79f584ea3e4d788e
2023-08-21 16:06:40 +01:00
Ed Sanders 241d3da05d Remove extra margins from visual diff in Minerva
Bug: T344181
Change-Id: I5a2a9413ee5125ca7dc416ce3e8b75060dc96b83
2023-08-14 19:13:50 +01:00
Ed Sanders 916b7beb22 Convert WikitextPasteContextItem to PersistentContextItem
Depends-On: Id2900c2d2c692b611e611b7eee6cacb74a737a8c
Change-Id: Ic539a41e8623c4ed12e4fa0e24db826ca967ee5a
2023-08-11 12:54:38 +01:00