David Lynch
5d19272aa1
ArticleTarget: Change rendering of category preview
...
Just generate the standard wiki skin markup for categories. Adjust linkcache to always know
whether links are hidden categories. (It previously knew *sometimes*,
depending on whether a MWCategoryWidget had interacted with that category.)
Make the save dialog preview use the same method as the bottom-of-editor preview.
Bug: T194092
Change-Id: I37fea15eaef0a5847f27ce41dd92370a4bf353b6
2018-05-13 16:40:59 -05:00
jenkins-bot
95d831c2de
Merge "Create getters for localised APIs (getContentApi/getLocalApi)"
2018-05-07 15:51:45 +00:00
jenkins-bot
25d2eb2848
Merge "Use ve.resolveUrl in MediaContext/Dialog"
2018-05-07 15:28:52 +00:00
Ed Sanders
478b0bcbb9
Create getters for localised APIs (getContentApi/getLocalApi)
...
Pass through the current document when available, otherwise
assume the current surface's document.
Also add a getter for getPageName, so that can vary based
on the target document.
Bug: T193856
Change-Id: Ifdc951fdc6a43b924d102e3fcd7e59e52023757b
2018-05-05 14:32:55 +01:00
Ed Sanders
3b4923fa74
Use ve.resolveUrl in MediaContext/Dialog
...
Change-Id: I53e28d6cec13ac77718ba3cae425c4c43c96e174
2018-05-05 14:04:15 +01:00
Ed Sanders
ebcf1e1151
Check imageModel exists in #checkChanged
...
Bug: T193879
Change-Id: Ic6eda7a056e5207042b575609b9da1869e3a759e
2018-05-04 14:52:03 +01:00
jenkins-bot
7b1d248ec1
Merge "ve.ui.MWMediaDialog: Use dropdown for image type selector"
2018-04-05 11:02:22 +00:00
Bartosz Dziewoński
0cf02e0155
ve.ui.MWParameterPage: Pass $overlay to PopupButtonWidget
...
Also, pass $overlay to all PageLayout subclasses used in ve.ui.MWMetaDialog
and ve.ui.MWTemplateDialog/ve.ui.MWTransclusionDialog, for consistency.
Bug: T191395
Change-Id: Ib7ed2e2c04ff7930be1161bd2b981180ee59557a
2018-04-04 22:45:13 +02:00
jenkins-bot
f04563faba
Merge "Show redirect link in preview"
2018-04-03 19:01:02 +00:00
Ed Sanders
36e0f8988d
Show redirect link in preview
...
Bug: T191128
Change-Id: I08fc03dd869e6b074a24698f9037380b26e3dd2c
2018-04-02 17:34:51 +01:00
jenkins-bot
45afe665c1
Merge "Visual diffs in source mode section edits"
2018-04-02 16:05:34 +00:00
jenkins-bot
476a590c3c
Merge "Parse title in show preview using hack"
2018-03-27 20:29:35 +00:00
Ed Sanders
d3e5385944
Visual diffs in source mode section edits
...
Bug: T190845
Change-Id: I938352eec8b49f27784c12ddea72bbe69fdd6cb2
2018-03-27 17:53:54 +01:00
Bartosz Dziewoński
b8bcba8cbe
ve.ui.MWMediaDialog: Use dropdown for image type selector
...
The dialog is not wide enough to fit four buttons side-by-side.
Bug: T74187
Change-Id: I6a4e5692b5f1b2ca9bb78d4e6c6103036f371a52
2018-03-27 14:40:39 +02:00
James D. Forrester
fe525e3bcc
*Dialog: Don't set to small size, which is the default
...
Change-Id: I3b7a19acd0ee5112d104257bdc1e9ff0e9b4ff24
2018-03-26 15:02:11 -07:00
jenkins-bot
44720da389
Merge "*Dialog: Drop verbose option, ignored since v0.20.0"
2018-03-26 16:18:49 +00:00
James D. Forrester
9e01553f0b
*Dialog: Drop verbose option, ignored since v0.20.0
...
Change-Id: If0bc7946b67aaae97886e8dbd956e9338b0e0b40
2018-03-26 08:55:03 -07:00
Ed Sanders
95fc150a4f
Remove unused static overrides from dialog
...
Change-Id: I31f0310baa5c438b17f16749368102d8cede22db
2018-03-26 15:49:04 +01:00
jenkins-bot
bfd4a5870f
Merge "Use single-line editor for image captions"
2018-03-22 01:32:09 +00:00
jenkins-bot
cf9ddabe23
Merge "Disable visual diffs on source mode section edits"
2018-03-20 23:02:33 +00:00
Ed Sanders
8bfb270168
Use single-line editor for image captions
...
Depends-On: I2be081c766fab41b152d03b43e7e936e3f636166
Change-Id: Ifcdc34826ad81e96c22fd68ceb637107cde24d4a
2018-03-20 22:51:27 +00:00
jenkins-bot
e23dd5fb6d
Merge "Make gallery dialog work with native gallery implementation"
2018-03-19 23:39:00 +00:00
Thalia
12cc56400b
Make gallery dialog work with native gallery implementation
...
Updates the model and re-renders the gallery.
Bug: T150621
Bug: T149602
Bug: T149596
Change-Id: I1e93c3af02eeeff1fcdaa5549cccc61ea755ee04
2018-03-19 23:55:17 +01:00
Ed Sanders
5e1c024d33
Parse title in show preview using hack
...
Really Parsoid should do this for us.
Bug: T189540
Change-Id: Ie3b5d458e7e6611565e5852f351d715a48be521a
2018-03-19 21:58:33 +00:00
Ed Sanders
81f3c2df38
Fix title preview when not overridden
...
Change-Id: I555b057d8f20704c0676646afd03c78ad3353f23
2018-03-19 21:56:54 +00:00
Ed Sanders
c6653b6a2d
Show page title in preview
...
Bug: T189540
Change-Id: Idc203f7fcafcf944108938168b492e90091e3255
2018-03-13 10:15:16 +00:00
jenkins-bot
540cb864ca
Merge "ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image"
2018-03-12 12:28:10 +00:00
Ed Sanders
4fc2b32b17
Disable visual diffs on source mode section edits
...
Bug: T183938
Change-Id: I0d03c47e9b4c30760b7d3bd7bf90d91e79eb8569
2018-03-10 22:54:54 +00:00
Bartosz Dziewoński
3c676013f8
ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image
...
Currently this only handles the caption, but there will be more.
Change-Id: Ia8a25de89375d0ba873f4891b053c7aceab15534
2018-03-10 17:16:16 +00:00
David Lynch
4e10d5b975
Update rel attribute checks to be aware of multiple rel values
...
Various checks didn't think a rel attribute could contain multiple values.
Mostly they don't, but to play it safe let's adjust the checks.
Change-Id: I29823b7c8c65ef6b2ff41ce9a801840000972e9c
Depends-On: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
2018-03-08 14:34:56 -06:00
Ed Sanders
43ea4c2b51
Fix infinite recursion in positionDiffElement
...
updateSize eventually calls setDimensions, which calls
positionDiffElement, so protect against infinite recursion.
Change-Id: I07992f337394712000e6e12c637c6e1442869722
2018-03-03 18:47:08 +00:00
Bartosz Dziewo??ski
dbfe6c0b5a
ve.ui.MWSaveDialog: Allow limiting comment length by characters rather than bytes
...
Bug: T185948
Change-Id: I882d69beb1cd442868c8d73988f5b3a2bbb084bc
2018-02-27 22:35:08 +01:00
Bartosz Dziewoński
3d422bac2a
ve.ui.MWGalleryDialog: Handle galleries with 0 items
...
We still don't allow inserting such galleries, but we can handle them
in existing content.
Bug: T75230
Change-Id: I5d7350f00871ac295b0ebc00a633b44570347d85
2018-02-21 22:11:41 +01:00
Ed Sanders
ee5b80aeee
Avoid jQuery.parseHTML
...
Bug: T187713
Change-Id: Ic156d6fb670fa2f79cf3c1d5fe0c6272b53b6440
2018-02-19 15:41:20 +00:00
Ed Sanders
33858c6818
MWSaveDialog: Another check to see if visual diff is still visible
...
Bug: T187282
Change-Id: Ia29a335bf6b1bad0eeb55b54094475c7fcc18dfe
2018-02-16 15:21:12 +00:00
Ed Sanders
e0b7fbe6f8
NWE preview: Avoid skin style clash
...
Bug: T187075
Change-Id: I6ac6eebca3bd89ce19fb64f6e95809c4d595bc8b
2018-02-13 16:22:56 +00:00
Ed Sanders
9770c80615
Load modules for preview
...
Bug: T147702
Change-Id: I94f6bdf122d4e2c9fba3103f36c438980ce8228d
2018-01-29 22:35:00 +00:00
jenkins-bot
d7d026425c
Merge "Make visual diffs the default in visual mode"
2018-01-27 00:21:24 +00:00
jenkins-bot
d5bf4d41de
Merge "Remember preferred diff viewer"
2018-01-18 15:37:35 +00:00
Ed Sanders
0169701257
getSelectedItem() -> findSelectedItem()
...
Change-Id: Idf90335d06800b690063c7b2a781e822f0ee7ba9
2018-01-17 13:39:13 +00:00
Ed Sanders
e70fe7c1a1
Make visual diffs the default in visual mode
...
Bug: T178248
Change-Id: I9fe22862d4415df034a0054f934c9ebd1d731a5d
2018-01-17 13:31:07 +00:00
Ed Sanders
7661081ab9
Remember preferred diff viewer
...
Separate the preference by surface mode, so you can
use a different preference for NWE.
Bug: T178691
Change-Id: Ib8494a4562ce766a7c8ef7ec1447d06f5d0f17c5
2018-01-17 13:31:07 +00:00
jenkins-bot
2ea64bdd27
Merge "Change save dialog accesskey to be entirely off the trigger"
2018-01-10 21:30:51 +00:00
jenkins-bot
9768750cd3
Merge "Use findItemFromData instead getItemFromData"
2018-01-10 19:54:30 +00:00
David Lynch
a89c79dc79
Change save dialog accesskey to be entirely off the trigger
...
Accesskeys in this situation are unreliable cross-browser. Firefox won't
trigger the accesskey inside the dialog. We can manually simulate it, via the
existing trigger.
Bug: T121183
Change-Id: Ib919d8b9fcd9324a517037bcc6ef93a26d1488b9
2018-01-08 11:52:06 -06:00
James D. Forrester
0a7a845a42
doc: Bump copyright year
...
Change-Id: I0b299c840ede1a1b8552cecfc70c5760ab036181
2018-01-03 17:45:07 +00:00
Prateek Saxena
ecd663c4a0
Use findItemFromData instead getItemFromData
...
Depends-on: Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
Bug: T76630
Change-Id: I379da96a42c440c7d2d5dc2f3de2773c03546c04
2017-12-28 11:53:29 +05:30
Ed Sanders
8a356b19d7
Enable spellchecking on media caption inputs
...
Bug: T182393
Change-Id: I23d3f1b37225f9e5a9a9651b6e7b590d38dc99b3
2017-12-12 16:42:55 +00:00
David Lynch
7777f69e7b
Use rel="noopener" on links targeted at new windows
...
Bug: T180932
Change-Id: I93bda6aaebf97727a187774cccbeba4f27fcddd5
2017-11-30 13:15:38 -06:00
David Lynch
efbfcd8b35
ui.MWSaveDialog: consistent handling of preview category links
...
Category links weren't being checked for redlink status, and weren't opening
in a new window.
Bug: T179913
Change-Id: Ic665583128bf51710178c5674cd35c273f5f207e
2017-11-29 11:24:32 -06:00