Commit graph

16574 commits

Author SHA1 Message Date
jenkins-bot b00787b572 Merge "Factor out save logic into ArticleTargetSaver" 2019-11-02 01:16:18 +00:00
Ed Sanders 76d0f02116 Use MobileFrontend check for loading DesktopArticleTarget.init
Bug: T236944
Change-Id: I3fd41d0fbb3087d4052db1cb1537e289defa737e
2019-11-01 22:05:59 +00:00
Ed Sanders ffa3742ce1 build: Update linters
Change-Id: I03d1a8e63b730ad98ec07ad5f630ba82698de5be
2019-11-01 16:20:22 +00:00
Ed Sanders 381b58585c Factor out save logic into ArticleTargetSaver
Change-Id: I63fa04598e0d703fe1ba715c9c5a0abbb0d7ba5b
2019-11-01 15:45:27 +00:00
jenkins-bot 6341a4ddb7 Merge "Fix visualeditor-dialogbutton-media-tooltip message" 2019-10-31 22:13:37 +00:00
Bartosz Dziewoński 00eb79d4d7 Revert "Parse relative hrefs on image nodes like on regular links"
This reverts commit 6037fefbe0.
This reverts commit da9b6fffbd.

Bug: T237040
Change-Id: Id6ea5784512e4d4c3cb00927b859d713c3814f89
2019-10-31 22:40:42 +01:00
jenkins-bot f24c823212 Merge "Expand collapsible blocks in editor, like we do with collapsible tables" 2019-10-31 16:27:45 +00:00
Bartosz Dziewoński 95f0d5f428 ve.init.mw.MobileArticleTarget: Improve toolbar scrolling behavior on iOS 13
With this patch, the toolbar slides into place place nicely after
scrolling again, but it still occasionally flickers during the scroll.

* window.innerHeight is now smaller or something, and we have to
  twiddle the scroll position by a larger value.
* document.body.scrollTop no longer works for setting or getting the
  scroll position, so use different methods.
* requestAnimationFrame() now generates an insufficient delay to make
  scrolling happen, so use setTimeout() instead. We actually have to
  add a nonzero delay there, otherwise the toolbar sometimes doesn't
  animate like it should or flashes in random places on the screen.
  This delay is bad because the user can't start scrolling again
  during that time, but I think we can live with that.

Bug: T233470
Change-Id: I6c40ee8ce5994e12eadb085bbffd120ef160d4ee
2019-10-31 16:55:58 +01:00
Translation updater bot dd65c0fac6 Localisation updates from https://translatewiki.net.
Change-Id: I97267311e73ad710c27301753f45758a03bf9995
2019-10-31 09:30:10 +01:00
jenkins-bot 84d9c984a4 Merge "Replace deprecated easy-deflate.deflate with mediawiki.deflate" 2019-10-31 02:40:29 +00:00
Ed Sanders c83d129f6a Expand collapsible blocks in editor, like we do with collapsible tables
Bug: T236247
Change-Id: I6389d2fbb4a5a5d58bfb08f38bd4c598e20c7aaa
2019-10-31 03:18:34 +01:00
James D. Forrester 03ef2e0dc8 Update VE core submodule to master (8f850a718)
New changes:
78c94bc49 Localisation updates from https://translatewiki.net.
6bc33d318 FindAndReplace: Remove results = 0 special case

Bug: T226604
Bug: T231245
Change-Id: Ie918f40aa3ca69f227c75e150e6bd9aa330b3fc1
2019-10-30 18:03:04 -07:00
Ed Sanders 1bb72f0bb5 Replace deprecated easy-deflate.deflate with mediawiki.deflate
Change-Id: I5c77d4818074fd3dc937d7688d449952b92ee358
2019-10-30 19:13:47 +00:00
Translation updater bot 9cfe9714c5 Localisation updates from https://translatewiki.net.
Change-Id: Ied0521d893e03e94a14a8ab5562281b73adc3839
2019-10-30 09:34:22 +01:00
jenkins-bot 235b238c69 Merge "Drop use of wgParser, replaced in 1.32 and to be removed in 1.35" 2019-10-29 08:45:34 +00:00
Translation updater bot c26c8dc6b1 Localisation updates from https://translatewiki.net.
Change-Id: Ia141cef7662939b9a06f4793b19a61d00bdfcedc
2019-10-29 09:39:48 +01:00
James D. Forrester 2479f5c7f8 Drop use of wgParser, replaced in 1.32 and to be removed in 1.35
Bug: T160811
Change-Id: Id7332a19d64d83bcbccfd3ac89464dfea593cdc2
2019-10-28 20:10:14 +00:00
Translation updater bot a5eb16f681 Localisation updates from https://translatewiki.net.
Change-Id: I6f2849f46d2cc875a52aefc41fbc971c1b57137e
2019-10-28 16:37:05 +01:00
Bartosz Dziewoński f31bcc219f ApiVisualEditor: Fix preload handling further
Follow-up to 57ad605dc4.

Pass parameters like when switching from wikitext editor:
* bodyOnly=false
* stash=true

Bug: T233320
Change-Id: Ied2d9a48e884e033ef9d41b2da9cfa3599784ae0
2019-10-28 13:42:00 +01:00
Ed Sanders 4da31e7c9e Update VE core submodule to master (3075d3f8c)
New changes:
4af3f84f7 Mark surface as "showAsDeactivated" when opening a window
79eb0e4e5 ve.ce.Surface: Guard against focusing a un-initialized surface
4124c275e [BREAKING CHANGE] ve.ui.TargetWidget: Construct a real target inside the widget

Local changes:
* Use new target widget
* Remove calls to deprecated methods
* 'surfaceReady' event was upstreamed

Bug: T236400
Change-Id: I765d657c172d96c3b2e2ae5998083e4926a31f15
2019-10-25 17:16:17 +02:00
Bartosz Dziewoński 641fc9cc56 Update VE core submodule to master (ab3e5b918)
New changes:
990a0e959 ve.ui.ToolbarDialog: Update after OOUI changes
ab3e5b918 Localisation updates from https://translatewiki.net.

Change-Id: I54272071507f06042b32a4c9d1563c6ab5c9b371
2019-10-25 16:57:22 +02:00
jenkins-bot d52f6e8dec Merge "Tweak dependency on 'mediawiki.diff.styles'" 2019-10-25 13:39:30 +00:00
Translation updater bot 96ee9ebd5d Localisation updates from https://translatewiki.net.
Change-Id: Ia44b81d8161cddbc10871f52edc5dac23477370e
2019-10-25 09:19:46 +02:00
jenkins-bot 51a84ffef7 Merge "ApiVisualEditor: Return 'etag' with 'content' for preloaded content" 2019-10-24 20:06:11 +00:00
jenkins-bot a249a7b69b Merge "Don't log missing ETags when creating a new page, that's normal" 2019-10-24 20:05:53 +00:00
Bartosz Dziewoński 372f04fc6f Tweak dependency on 'mediawiki.diff.styles'
It's only needed for the save dialog.

Change-Id: Ifada463e95e2e911161f6ba898de6656412b4f83
2019-10-24 18:35:53 +02:00
Ed Sanders b345ae203b Fix documentation position
Change-Id: I8e1045f38e0cca3a937a5e2a07b1db820f64bee1
2019-10-24 14:31:38 +01:00
Translation updater bot e1f09e45c7 Localisation updates from https://translatewiki.net.
Change-Id: I9db7be57966bbda4751160c818ec2ce8e3d96960
2019-10-24 10:48:51 +02:00
Bartosz Dziewoński 57ad605dc4 ApiVisualEditor: Return 'etag' with 'content' for preloaded content
Previously we were not returning it, so when saving the edit, wikitext
syntax would not be preserved. This was probably not a big problem,
but I noticed it coming up in the logs for T233320.

Now making an edit starting with preloaded content behaves like
switching from wikitext to visual mode, rather than like starting the
edit in visual mode.

Similar to 679e777cfa.

Bug: T233320
Change-Id: Id1ee6877b103fa4274deec11b1b3cacbdcdae606
2019-10-23 22:24:52 +02:00
Bartosz Dziewoński cbd500a9ee Don't log missing ETags when creating a new page, that's normal
Same idea as f3dfd98e55. Oops.

Bug: T233320
Change-Id: Id31bd4806da5489a4438d385553a22d33676fc3a
2019-10-23 22:15:03 +02:00
Ed Sanders b676b2295b Update VE core submodule to master (3fac5f1f2)
New changes:
8cbedc3c8 build: Update linters
a211e9fd8 TargetWidget: Use surface view focus/blur events
57aeb8b38 Separate utilities required for DOM parsing into separate file

Local changes:
* Setup modules for new parsing utils files

Change-Id: Ie4e59650fdb869e7e4148c97cd03d79ce35187dc
2019-10-23 18:34:17 +02:00
Translation updater bot bcfd96477f Localisation updates from https://translatewiki.net.
Change-Id: Id718c4eb13106f3ce0f899e29b4c0511c1b491d0
2019-10-23 09:54:17 +02:00
Bartosz Dziewoński 4086de5a9a ve.ui.MWEducationPopupTool: Respect default preferences for anon users
Bug: T231762
Change-Id: I05dccf79becab9487ee2a67c4970c938d52e25d7
2019-10-22 20:02:21 +02:00
jenkins-bot e4efbe2a46 Merge "ve.init.mw.MobileArticleTarget: Remove error handling hacks for MobileFrontend" 2019-10-22 15:42:32 +00:00
jenkins-bot 23e5ff5572 Merge "Update VE core submodule to master (6c506a6aa)" 2019-10-22 12:57:32 +00:00
jenkins-bot 182b9c78ad Merge "Try using structured logging again" 2019-10-22 12:39:41 +00:00
James D. Forrester 7c40a7ecd7 Update VE core submodule to master (6c506a6aa)
New changes:
4ae766c0f Grammar fix in doc
5b2dac1aa Use plugin to ensure all message keys are documented
6c506a6aa Localisation updates from https://translatewiki.net.

Bug: T235502
Change-Id: I827d14a3ea78369321c557cca8fb16726a1dc03a
2019-10-22 13:12:39 +01:00
jenkins-bot 0f1281750e Merge "Don't retry when etag is undefined because the page doesn't exist" 2019-10-22 10:37:53 +00:00
Translation updater bot 43f1ee59f7 Localisation updates from https://translatewiki.net.
Change-Id: I877cb15aa7086decef34ca74d34ff6c620056055
2019-10-22 09:15:38 +02:00
zoranzoki21 3aed6486fc Fix visualeditor-dialogbutton-media-tooltip message
Bug: T223775
Change-Id: Iba7e77ea523215bcdd1831db1274549829bdecb1
2019-10-21 21:33:19 +02:00
Bartosz Dziewoński f3dfd98e55 Don't retry when etag is undefined because the page doesn't exist
Follow-up to 5d1a67757a.

Bug: T233320
Change-Id: Ice27187862dde75c69bbdb666c0981fce94249ba
2019-10-21 19:21:59 +00:00
Bartosz Dziewoński e82f5ccf02 ve.init.mw.MobileArticleTarget: Remove error handling hacks for MobileFrontend
As of commit c65ed0e7a8ac5f32a3a6e4cb2760dae03e4fca22 in MobileFrontend,
it uses errorformat=html queries (the same as we do), so we no longer
need to massage the responses to make it happy. The same commit also
turned parseSaveError() into a no-op, so we can remove that as well.

Change-Id: I4f0109ce120ebf94e5709d47d775a8178ce216fa
2019-10-21 20:26:10 +02:00
Bartosz Dziewoński f7ee7dc807 Try using structured logging again
The configuration of Wikimedia wikis should be fixed.

This reverts commit 04407e9eb1
and also makes similar changes to new logging code added in
5d1a67757a.

Bug: T234564
Change-Id: Ic999b050e68b71f5a1737366e16f133e5a557307
2019-10-21 17:04:23 +02:00
James D. Forrester 618225d4ed Update VE core submodule to master (b2939de73)
New changes:
fe82a8073 Update OOUI to v0.35.1
c9ed3a117 Localisation updates from https://translatewiki.net.
552d703b7 Localisation updates from https://translatewiki.net.
cab4264f1 build: Unbreak language lists, swapping 'szy' language for old 'ais' code
25b446256 Localisation updates from https://translatewiki.net.
0cd49c0c8 Avoid a "wiggle" when inserting a missing table cell
0babef010 Make test names clearer
b2939de73 TreeModifier: Ignore removed nodes properly when normalizing from a text node

Bug: T234108
Bug: T235959
Change-Id: Ifef6a96828a388f38f58ca4440f8ea6d31b1743a
2019-10-21 12:06:57 +01:00
jenkins-bot 0abcda599d Merge "build: Bump mediawiki-phan-config to 0.8.0" 2019-10-21 10:31:49 +00:00
Translation updater bot 7792044600 Localisation updates from https://translatewiki.net.
Change-Id: If5f9fd6cd9fbf7027f311bd87ba2d86488c0b68a
2019-10-21 10:01:17 +02:00
Daimona Eaytoy dd1d022c9d build: Bump mediawiki-phan-config to 0.8.0
Change-Id: Iafcf36672189c7729e9936634d95e585ed2247be
2019-10-20 12:27:16 +00:00
jenkins-bot 23213a17bd Merge "eslint: Add extra restrictions to ve-mw/dm/ folder" 2019-10-18 23:12:20 +00:00
Ed Sanders 837b01b534 Use consistent tag style when constructing nodes
Change-Id: I6a2d4d7d791a74b26770ef84d15659642401b0e7
2019-10-18 23:42:54 +01:00
Ed Sanders 2846144e96 eslint: Add extra restrictions to ve-mw/dm/ folder
Same as in core, follow up to I63fa04598e.

Change-Id: I4b63ef9d07205d91d6c20db310ab350f4160c3bc
2019-10-18 23:26:26 +01:00