Ed Sanders
d44e7fb3e8
Mobile target improvements
...
Change-Id: If55097a45ae812b712a74f41af350bfaa69f6135
2018-10-07 12:47:53 +01:00
jenkins-bot
95eb279cc6
Merge "ve.ui.MWGalleryDialog: Fix setting of expanded/scrollable panels"
2018-10-04 21:45:24 +00:00
jenkins-bot
c43f1589d4
Merge "ve.ui.MWGalleryDialog: Switch innerMenuPanel/innerContentPanel"
2018-10-04 21:38:41 +00:00
Ed Sanders
485b257278
ve.ui.MWGalleryDialog: Fix setting of expanded/scrollable panels
...
There are 4 scrollable panels:
* Image list content
* Edit panel
* Search panel
* Options panel
Remove non-existent 'expandable' property.
Change-Id: Ia0d0a66be8a2bcb243a39ef632151d7fb99486ef
2018-10-04 21:23:10 +00:00
Ed Sanders
61cfce8c32
ve.ui.MWGalleryDialog: Switch innerMenuPanel/innerContentPanel
...
These two panels were named the wrong way around.
Also change 'inner' prefix to 'imageList'.
Change-Id: Ie1c3e2160c81b898795fb1fd4d0a027e8f06c4d4
2018-10-04 21:22:05 +00:00
jenkins-bot
0a4cee1cd6
Merge "Use correct OOUI hierarchy in gallery dialog"
2018-10-04 20:41:13 +00:00
jenkins-bot
577c2c7a03
Merge "Move 'done' tool out of static config"
2018-10-03 22:09:39 +00:00
jenkins-bot
40f03a3b0f
Merge "Use correct OOUI hierarchy in media dialog"
2018-10-03 21:59:44 +00:00
jenkins-bot
03023758d8
Merge "Refactor media dialog initialize method"
2018-10-03 21:56:59 +00:00
Ed Sanders
e176ecceae
Move 'done' tool out of static config
...
Bug: T206132
Change-Id: I3319fc56209cab303448f7abe1e6334c50100947
2018-10-03 22:37:48 +01:00
Thalia
f422ae2dcc
Use correct OOUI hierarchy in gallery dialog
...
Make sure fieldset layouts contain field layouts. Also remove
meaningless parameter icons.
Bug: T205615
Change-Id: Ia104cd60ffa9f5d636bee5611f265a2bb5ac0051
2018-10-03 22:22:25 +01:00
Thalia
a4f033a1e6
Use correct OOUI hierarchy in media dialog
...
In the "advanced settings" tab, make sure widgets are wrapped in
field layouts, then fieldset layouts.
Bug: T205615
Change-Id: I141f9954e482f9d5afd84bfa63384b90a2911d00
2018-10-03 21:54:41 +01:00
Thalia
56cd18e674
Refactor media dialog initialize method
...
Change-Id: Ida7b50a89ab454ba023334cd2203d2e2e6150931
2018-10-03 20:50:36 +01:00
David Lynch
e2cf367a95
Make RDF attribute splits more robust
...
Split on regexp for whitespace instead of a single space. Avoids multiple-
spaces causing `'foo bar'` to become `['foo', '', 'bar']`.
See also: I1f467f51017e2deae30905163bf5e6b07048cecf
Change-Id: Id7a887a20fac99715b79045f01e861b4efe9f2c7
2018-10-02 16:11:58 -05:00
jenkins-bot
542004dcb9
Merge "Require Parsoid HTML 2.0.0, and handle its <audio> tags"
2018-10-02 20:47:59 +00:00
Ed Sanders
d5d23ee4be
Require Parsoid HTML 2.0.0, and handle its <audio> tags
...
Bug: T201081
Depends-On: I6514b9b0a85588c7eaae5e6989789656cfc3253a
Change-Id: I6052dcf3e414d9506ff7ec7a6b5d8f4eeb4a703a
2018-10-02 12:15:45 -07:00
Bartosz Dziewoński
7a18889ddd
ve.ui.MWMediaDialog: Remove unused CSS
...
This rule was being overridden by a more specific rule from OOUI with
the selector `.oo-ui-fieldLayout.oo-ui-labelElement`. I don't think
the margin tweak would be useful.
Change-Id: If6321ba7ea1cfad83f65f137b2a440957bf2fea6
2018-10-02 00:02:03 +02:00
Thalia
dc6e7027a8
Make extension dialog done action messages match other dialogs
...
Bug: T205807
Change-Id: Icd7e4fddcee8687d9c3dbbda144aa0989d659ac8
2018-09-30 21:18:18 +01:00
jenkins-bot
04689a37f9
Merge "ve.ui.MWMediaDialog: Remove unused widget and messages"
2018-09-27 20:37:43 +00:00
Ed Sanders
349c2f3638
Avoid jQuery in ve.dm.Model.static.describeChange(s)
...
Change-Id: Ide3ad119f8c111b78b9adfe4a07079d143070fd1
2018-09-27 20:26:47 +01:00
Bartosz Dziewoński
9cf5515ccb
ve.ui.MWMediaDialog: Remove unused widget and messages
...
* visualeditor-dialog-media-size-originalsize-error
Unused since 37b3c07b264947420650
2018-09-27 18:31:20 +02:00
Thalia
9813d876e1
Enable the media dialog on mobile visual editor
...
Also make improvements to the layout, so that the dialog works
in desktop and mobile - most importantly, change from booklet
to index layout.
Bug: T190885
Bug: T118710
Change-Id: I1915d06c9b0e4b7907136e645f60be96e30cc287
2018-09-27 13:21:15 +01:00
Bartosz Dziewoński
42ebd10090
Correct some doc comments' syntax
...
I ran Closure Compiler over the codebase just to see what would happen,
and it printed some useful warnings.
Change-Id: I56d40b11e6d1dd7ce68a5e59da511f66e928647f
2018-09-26 14:49:52 +02:00
jenkins-bot
f6cea616ef
Merge "Remove #ca-edit from required skin elements on edit pages"
2018-09-26 11:27:22 +00:00
Bartosz Dziewoński
f67dfea29d
Remove #ca-edit from required skin elements on edit pages
...
I suppose technically you don't need it if you're already on an
?action=edit page, since that will cause the editor to load as well.
At a glance nothing seems to break if it is missing (other than the
fact that there is no way to launch the editor, obviously).
Bug: T179427
Change-Id: I3c221ded302702b881857930da5dc41630680c02
2018-09-25 20:39:12 +02:00
jenkins-bot
bb6afe3e8b
Merge "MWTemplateSpecModel: Factor out getLocalValue, avoid isPlainObject"
2018-09-24 18:48:50 +00:00
Ed Sanders
e2a5bfd224
MWTemplateSpecModel: Factor out getLocalValue, avoid isPlainObject
...
Change-Id: I0fe009c899e8b6f44658253bf5c21c3b767067da
2018-09-24 18:36:31 +00:00
jenkins-bot
a4d73025e3
Merge "Turn off CSS transforms after toolbar has been opened"
2018-09-24 16:38:00 +00:00
jenkins-bot
add7b4d96f
Merge "Change type from 'frame' to 'thumb' when resizing"
2018-09-24 16:07:19 +00:00
jenkins-bot
5a679ed8f4
Merge "Use renamed ve.visibleWhitespaceCharacters utility"
2018-09-24 15:37:03 +00:00
jenkins-bot
5e1c0030a4
Merge "Update comment"
2018-09-24 15:36:58 +00:00
Ed Sanders
78a3c0dfb6
Provide platform when tracking mwedit.ready for tempWikitextEditor
...
Bug: T205241
Change-Id: Icf77ad9028e7e87c0189ef2b4cad5dbea20cb2f1
2018-09-24 16:03:55 +01:00
Ed Sanders
985a94777a
Change type from 'frame' to 'thumb' when resizing
...
Bug: T204185
Change-Id: If40c70a074263b870aee4e5c87c3f4b5e98d0c4b
2018-09-24 15:31:58 +01:00
Thalia
bbed4307d7
Separate node classes into individual files
...
Bug: T205231
Change-Id: I84a6f2f7a842ab44e1f7103c0f288deda0451e79
2018-09-24 12:44:45 +01:00
Ed Sanders
253e7e6c59
Update comment
...
Change-Id: Ie6b2b3512fb9e31014040c3cd0f9c75d7330ccbe
2018-09-24 12:41:58 +01:00
Ed Sanders
a2c04973a2
Use renamed ve.visibleWhitespaceCharacters utility
...
Change-Id: I2df52341009cbc715c801accdf59cc5d5ce2e9ff
2018-09-24 12:41:13 +01:00
jenkins-bot
ae037e77ca
Merge "Use mw.Title.isTalkNamespace"
2018-09-18 15:00:34 +00:00
jenkins-bot
1917945588
Merge "ve.init.mw.MobileArticleTarget: Simplify margin/padding for debug bar"
2018-09-18 10:58:08 +00:00
Bartosz Dziewoński
165fe4ad45
ve.init.mw.MobileArticleTarget: Simplify margin/padding for debug bar
...
Requires I28278449512ed1e5e8c4ac6ae390334a26d1bad6 in
mediawiki/skins/MinervaNeue to be merged at the same time.
There should be no visual change if both are merged.
Change-Id: Ia13f758a6870be2e6c89fd11f2ee3544ac61a1d7
2018-09-17 21:47:46 +00:00
jenkins-bot
b1cab3e06c
Merge "ve.init.MWVESwitchConfirmDialog: Fix gap above dropdown on MonoBook"
2018-09-17 21:44:49 +00:00
jenkins-bot
93664630a9
Merge "ve.init.mw.MobileArticleTarget: Fix keyboard shortcuts to be hidden"
2018-09-17 21:41:33 +00:00
Bartosz Dziewoński
5badbfed10
ve.init.MWVESwitchConfirmDialog: Fix gap above dropdown on MonoBook
...
In WikimediaUI theme, the height of the toolbar is defined with
'padding-top', but in Apex theme, it is defined with 'height'.
Set both properties to make this work with both themes.
Remove unused styles for the dropdown. It is now positioned by OOUI
(since T192505). This should have been done at the same time as
e1635fdc52
2018-09-17 22:22:48 +02:00
Bartosz Dziewoński
14777e89ad
ve.init.mw.MobileArticleTarget: Fix keyboard shortcuts to be hidden
...
This should have been done at the same time as
e1635fdc52
2018-09-17 22:18:32 +02:00
jenkins-bot
742127ad8d
Merge "dm.MWTableNode: include paragraph in suggestedParentNodeTypes"
2018-09-17 20:14:46 +00:00
Ed Sanders
164ccecf4d
CollabPad: Show current sub-page as separate tab
...
Change-Id: I15da5a3122e7a0dfeb5131e528efa498a7cd1356
2018-09-17 16:25:42 +00:00
David Lynch
e050bb9ecf
dm.MWTableNode: include paragraph in suggestedParentNodeTypes
...
This allows cleanup of empty paragraphs following block-level insertions to
work.
Bug: T201573
Change-Id: Id537d86c72c01ab2c71d2043e906f4c32ef755eb
2018-09-17 09:26:38 -05:00
Ed Sanders
338bccc6f2
Follow-up I6b13dad: Wait for surfaceReady before first focus
...
Change-Id: I984d8c00489efd013fed6bc18881c1d0606e0cbf
2018-09-15 00:19:54 +01:00
Ed Sanders
3c8bb3801e
Turn off CSS transforms after toolbar has been opened
...
Leaving this property applied seemingly triggers strange
rendering bugs in Safari.
Bug: T202935
Change-Id: I65e742918c3670b99cf05efb4722a0c23a9347f5
2018-09-14 13:48:07 +01:00
Ed Sanders
917645eb27
Use mw.Title.isTalkNamespace
...
Depends-On: Ie57243bac1aa5e23bc8b1c027bcb1b83090ee433
Change-Id: I303401ff34425831cb3c32d25df635aefa5b5926
2018-09-14 13:37:17 +01:00
Ed Sanders
7eb836adbc
Update VE core submodule to master (7420443fe)
...
New changes:
a273ba69c [BREAKING CHANGE] Implement a SourceConverter
Local changes:
* Use SourceConverter
* Handle `this.doc` being a string in source mode now
Bug: T203114
Bug: T203156
Change-Id: I7bce7b57668e0c1dd511803a54178ae69694a86d
2018-09-14 11:42:34 +01:00
