Commit graph

42 commits

Author SHA1 Message Date
libraryupgrader 702677220d build: Updating eslint-config-wikimedia to 0.28.0
The following rules are failing and were disabled:
* modules/ve-mw/tests:
  * implicit-arrow-linebreak

Change-Id: If857233c0de24c8cf619dbb1347ebb375f3ab1ba
2024-06-04 03:40:00 +00:00
Ed Sanders 3966573f02 build: Update ESLint to 0.26.0 and autofix
Change-Id: Ia5e15684c1c3dcd69985445a09fc4e4910368b5b
2023-11-28 11:18:09 +00:00
Ed Sanders ea03287908 Convert MWPopupTool into MWHelpListToolGroup
The popup contains three buttons, one of which already exists
in core as a tool. By converting them all to tools we can reduce
some duplication, and better integrate with other features
that use the tool factory, such as HelpCompletionAction.

Bug: T339153
Change-Id: I81d217bc1ab9a1a6a9bf7c7ad588c2a3216b10db
2023-07-01 11:10:53 +01:00
jenkins-bot 4077345c73 Merge "selenium: run tests concurrently" 2023-06-30 08:18:03 +00:00
WMDE-Fisch 70128a0f21 selenium: run tests concurrently
Especially useful to reduce the job runtime here because the VE
tests are executed in a couple of CI selenium jobs of other
extensions.

Bug: T226869
Change-Id: I8a8eae8cf2d548b7c905f00e748974bc5a88d337
2023-06-29 15:14:05 +02:00
Kosta Harlan 85c3f13c2c
selenium: Disable flaky test
See https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/43144/consoleFull

Bug: T296187
Change-Id: Iba71488ffb10b85598461c0d85fac99cc491a69e
2023-06-21 22:07:17 +02:00
Esther Akinloose 99f9899193 selenium: Toolbar should open format paragraph menu
Bug: T296187
Change-Id: Icb1fabcf054a2fb1b290815d6cc9945bda0433a4
2022-12-21 14:10:31 +00:00
Esther Akinloose d5825af59d selenium: Toolbar should open style text options
Bug: T296187
Change-Id: I909176da40faa64b23d0dfcafa4b9a6f62c0820e
2022-12-20 15:36:13 +00:00
Esther Akinloose 4df16fac5b selenium: Toolbar should open structure options menu
Bug: T296187
Change-Id: Ia8abb12c911174c2c6778b5aff4272a9b14fbbe0
2022-12-19 15:05:28 +00:00
Željko Filipin 15c53f0576 selenium: Decrease logLevel from info to error
logLevel from info is very verbose. It is no longer needed. The default
error logLevel should be enough.

Bug: T296187
Change-Id: I1bde5b57f64df2d6c00b4a7b8e24f9887a865bb6
2022-12-09 13:36:56 +01:00
jenkins-bot e6bcdb7e78 Merge "selenium: Toolbar should open insert menu" 2022-12-07 16:07:22 +00:00
jenkins-bot d6f577b3df Merge "Revert "selenium: Do not retry tests"" 2022-12-06 14:58:21 +00:00
Kosta Harlan 68f0539fa8 Revert "selenium: Do not retry tests"
This reverts commit 9b9304b13f.

Reason for revert: Selenium tests occasionally fail for many different
reasons. We should use the default specFileRetries, so that a single
failure doesn't cause ~20 minutes of delay when someone is backporting
a change. See also e.g. T324544

Bug: T324544
Change-Id: I043eb5e57bec13a16efb35bbdffda6d3ea65b8e9
2022-12-06 12:40:00 +00:00
Esther Akinloose 5347c6adf6 selenium: Toolbar should open insert menu
Bug: T296187
Change-Id: I4af64851d95a5bca26d8ae6ed5fcd9b0d13aba55
2022-12-02 22:07:49 +00:00
jenkins-bot d386acf9b0 Merge "selenium: Toolbar should open special characters menu" 2022-11-30 18:01:54 +00:00
jenkins-bot 79b64eb837 Merge "selenium: Toolbar should open notices popup as soon as it loads" 2022-11-30 14:18:35 +00:00
Esther Akinloose fb5cbbd6c8 selenium: Toolbar should open special characters menu
Bug: T296187
Change-Id: Iab55907f648a99f7a7a56dc49bc0686df619c6dd
2022-11-30 14:17:33 +00:00
jenkins-bot 0e4bda00e9 Merge "selenium: Toolbar should open help popup" 2022-11-30 14:08:37 +00:00
Esther Akinloose 5f8dbcf2dd selenium: Toolbar should open notices popup as soon as it loads
Bug: T296187
Change-Id: I705d4d3e8a0135b500ec63749f519f7b86855a2f
2022-11-30 13:43:32 +00:00
Esther Akinloose 329574d645 selenium: Toolbar should open help popup
Bug: T296187
Change-Id: Ic818a97405e93e7545b6655073a62fd7e5b4e8a3
2022-11-30 12:36:42 +00:00
Esther Akinloose 552e82c308 selenium: Toolbar should open page options
Bug: T296187
Change-Id: I46b5c7c2c3dd4d823a9727ea0c4eb8c2e9aaf207
2022-11-28 15:02:47 +00:00
Esther Akinloose b96f0bc411 selenium: Toolbar should open switch editor
Bug: T296187
Change-Id: Ife5b833acc39596b7e40a2c5a5512a6fd61150af
2022-10-19 13:08:55 +00:00
Željko Filipin e63bedb988 selenium: Content editable should insert a table
Bug: T296187
Change-Id: Ic0395637690a40a9b6f889072f80b56e5f02390c
2022-10-12 16:00:25 +02:00
Esther Akinloose 529f004fc6 selenium: Move code to beforeEach and afterEach hooks
Bug: T296187
Change-Id: Iad8482e432491895eac070692fd3448e6362e4ce
2022-10-10 14:36:33 +01:00
Esther Akinloose b69c89e378 selenium: Enable all tests
EditPage.activationComplete() was flaky.
We have replaced it with EditPage.toolbar.waitForDisplayed().
We have run all the tests 100 times in a row in CI and it works fine.

Bug: T310772
Change-Id: I321b4114ca03ebd02a79d8bd3863ea0e68494dc2
2022-07-04 12:22:38 +00:00
Kosta Harlan b736f35740 selenium: Disable flaky test
Bug: T310772
Change-Id: I19df39298129ac911ed79c1ba5731638ab0332d3
2022-06-22 17:24:59 +00:00
Esther Akinloose 9b9304b13f selenium: Do not retry tests
Bug: T296187
Change-Id: Iddfff777d783ad372eebf9ff285361fa129ebe02
2022-06-14 14:31:21 +01:00
Željko Filipin f91253b0ef WIP: selenium: Enable Content Editable should save an edit
Bug: T309712
Change-Id: I342bd53fb461d5194a1c8320c26125f54f6717e9
2022-06-13 14:00:51 +02:00
Esther Akinloose 3e93410e68 selenium: Add EditPage.saveComplete()
Add new check for page saving.

Bug: T296187
Change-Id: I07639c58377f6f285df1bfeccfb5e037a3e619d5
2022-06-09 14:42:02 +01:00
jenkins-bot bffaab97fb Merge "selenium: Better assertion after saving the page" 2022-06-08 14:32:52 +00:00
Željko Filipin 4b7d505891 selenium: Better assertion after saving the page
The 'should save an edit' test is skipped because saving an edit fails
in CI because of T309712.

Bug: T296187
Bug: T309712
Change-Id: Ie4f067ed9b49a993acadaa01c953a9fe46aaae81
2022-06-02 15:51:41 +02:00
Željko Filipin ba0b671fa9 selenium: Run only one test in Jenkins daily job
selenium-daily-beta-VisualEditor Jenkins daily job became really
unstable. Let's run just the simplest test for a few days to see if that
would help with job stability.

Bug: T296187
Change-Id: I858a3c5614277ea029fdabfd4468bb0d124e94d5
2022-06-02 15:43:43 +02:00
Esther Akinloose 9de7c6743d selenium: Improve debugging
Looks like Selenium tests are flaky. To improve debugging:

- Move code from beforeEach hook to specs.
  (Video recording happens only in specs, not in hooks.)

- Increase logLevel from error to info.

Bug: T296187
Change-Id: Iffcfae9a76085670eb8858fbcf622e596a4ff2f0
2022-05-20 16:44:23 +02:00
Željko Filipin e9ee23aace selenium: Content Editable should save an edit
Bug: T296187
Change-Id: I5a48662bb271fd49b6cfa0365e4775c8865dc5c7
2022-05-16 15:11:56 +01:00
jenkins-bot 6336e996b8 Merge "selenium: Check if content editable is editable" 2022-05-09 15:05:18 +00:00
Esther Akinloose 1e030bcde5 selenium: Check if content editable is editable
Bug: T296187
Change-Id: I7a7808bf5cabdccc3f0a01ccecfdadeb7fdc9b91
2022-05-02 13:11:57 +01:00
Ed Sanders c9046685fa eslint: Lint all files except those in .eslintignore
Fix resulting errors (mostly useless escape in i18n files).

Change-Id: Id29c6aecece75d4a462bddb7e547ca5b4eb5c2db
2022-04-13 15:44:49 +01:00
Željko Filipin 636ffbbb98 selenium: Check if editing toolbar is displayed
A better assertion if the VisualEditor is opened would be to check for
editing toolbar instead of checking for a notices popup.

Bug: T296187
Change-Id: Ide816646254bc856b44725490c25b2b9962188c9
2022-03-21 15:54:47 +01:00
Željko Filipin 09668285d6 selenium: Wait for VisualEditor to load
Bug: T296187
Change-Id: Iac98690dd49b6e82062973da05ce30c6f08ba8bc
2022-02-16 14:57:13 +01:00
osamaahmed17 40c5c4fe9e selenium: Refactor WebdriverIO tests from sync to async mode
WebdriverIO has dropped support of sync mode, hence changed to async.

Update npm packages: @wdio/*, wdio-mediawiki and webdriverio
because async mode needs at least webdriverio v7.9.

Remove npm package: @wdio/sync.

Bug: T299756
Change-Id: I4a09ccddd8049f84232b035b664b42a4e98d7ff0
2022-02-03 10:41:35 +11:00
Esther Akinloose 698075a6df selenium: Rename load test to content editable
Bug: T296187
Change-Id: I2e4f1f672bb3414444839013cc82897d56bf48b5
2022-01-24 16:24:56 +01:00
Željko Filipin 0593278d05 selenium: The first test
The first test just opens the page for editing and checks if it opened.

Bug: T284165
Change-Id: Ifffaf3e5ab14811605d96fcdcfdc1f773880e52c
2021-11-09 16:11:22 +01:00