Commit graph

10 commits

Author SHA1 Message Date
Christian Williams 97a3cccca7 Removing alienblock tag
One of our demos literally used an <alienblock> tag to trigger alienBlock behavior. Since this is not registered in ve.js blockTypes array, I'm just switching it to a <div> for the demo.

Change-Id: I68bff80fcbdd794eeae94dff43f7ef82f972cdb5
2013-01-16 16:04:46 -08:00
Christian Williams b740e694b9 BugID 43076 - Fixes to alien and phantom corner cases
The {{coords}} template is correctly rendered as an inlineAlien, which previously did not have shields. However, the template has a deeply nested span that is positioned and floated. The fix is to shift shielding logic up to AlienNode (from AlienBlockNode) and to show phantoms on all shields (both block and inline). I've also updated the aliens demo to exhibit this corner case.

Change-Id: Ifce60c7762c0ead5c6fe29d6eabf601c1565cbfa
2012-12-21 15:20:15 -08:00
Catrope e123a39b4e Handle annotated inline nodes in the converter
Was broken both on the way in and on the way out.

* Move alien restoration (data->DOM) out of the main getDomFromData()
  function and into getDomElementFromDataElement(). This means the
  comment about District 9 is gone (sniff), but moving this here ensures
  all code paths hit it (previously, it was assumed annotated nodes
  could never be aliens).
* In the DOM->data converter, add annotation application to
  getDataElementFromDomElement() (for content nodes) and createAlien()
  (for aliens). Previously, these nodes would not get annotations.
** ve.AnnotationSet doesn't have a constructor that takes an array, we
   should fix that.

Change-Id: I65f8e9a322111ca3af275bf9997b0b1e7ee93769
2012-11-27 14:41:40 -08:00
Catrope 8cf9193b39 Add moar demo pages
Change-Id: Id25803821ea0913f36a3c851c0542de12f7e408b
2012-11-21 13:24:38 -08:00
Christian Williams e03cef06a7 Nicely highlightable alien nodes
Browsers handle highlighting of our alien nodes differently. This change normalizes by hiding the native selection on the aliens, inserting blank image "shields" with native highlighting enabled.

Change-Id: Ica3576ef0e3c42b4aeae1da374cd1dc92f203d7d
2012-11-13 10:25:05 -08:00
Christian Williams 901eea203e Styling aliens with a yellow background; preventing absolute positioning
Change-Id: I86fbbda841d69beeabf4e683de3b032fb70b1ac6
2012-11-05 14:22:10 -08:00
Inez Korczynski 6bed13e0e7 Added some inline aliens to complex demo - helpful for testing
Change-Id: I3063096145994abd36493e7ee182fdd7b48e1bf2
2012-08-06 16:13:45 -07:00
Inez Korczynski 10a3f2bafb Added <alienblock> to complex demo document
Change-Id: Ic26c916a02b1e4f45990d099ff7c12b90734e906
2012-08-06 15:25:11 -07:00
Inez Korczynski aa281166ff Added some Arabic text to complex demo - to make testing bi-directional text easier.
Change-Id: I9d5ed8a4d3e57cece0c6dda5e14850151bb0e9da
2012-07-24 17:38:35 -07:00
Trevor Parscal 9a0380c67d Removed Special:VisualEditorSandbox and refactored demo
Also renamed ext.visualEditor.editPageInit to
ext.visualEditor.viewPageTarget

Change-Id: I8bdd04b3442067e87bccbc60dd4947aae1c7dfd2
2012-07-18 17:57:50 -07:00