OnInternalLinkChange happened post-validation, and received an already title-
normalized version of the href. Thus `file://` would become `:File://`. As
such, hook up to the raw internal link input change event, and judge what the
user actually entered.
Bug: T138956
Change-Id: I0f9f3de3b7bf6e5430e55fa69626522b0c74296a
Currently the switch only happens if it's a valid schema. Instead, switch if
any schema at all is detected, so we can tell the user it's invalid. If they
really meant to link to an internal wiki-page that just happens to start with
a "schema://", they can switch back to the internal tab to force it.
Bug: T138956
Change-Id: Icfd74157fd8439920668a417661265ddd52c9a21
If you viewed a page with an ?oldid= query parameter set to the ID
of the current revision, some parts of VE would believe we were
in oldid mode (because there's an oldid present), but others
wouldn't (because the revid we're editing equals the newest revid).
This caused bugs when opening the editor a second time after saving
(which is normally impossible to do after an oldid-mode edit, because
we navigate to a new page after an oldid save, but we don't do that
in this case).
Ensure that:
* The internal state of DesktopArticleTarget is updated correctly
after saving in this case
* The ?oldid= parameter is removed from the URL after saving
* DesktopArticleTarget.init doesn't preload the article HTML
on a second/subsequent editor load: this causes issues because
it caches the oldid, and generally speaking the Target's internal
state is not considered
Bug: T141330
Change-Id: I74034328797c59f7249f1f6f4f53a92ee1c26334
New changes:
d1a3e7d TabIndexScope: respect aria-hidden
4cbd630 Localisation updates from https://translatewiki.net.
531335a TabIndexScope: skipAriaHidden not respected, and applied to FragmentDialog
d00caf3 Ensure document slices which consist of content nodes get wrapped
baac5bd Use innerText for setting clipboard plain text
a1cf57c Check surface is set up in toolbar
2351bea Allow newDocRange to be passed to SurfaceFragment#insertDocument
5a27227 Make no change to selection if insertDocument is a no-op
1675e30 Fix table paste tests to use dynamic retain-to-end operations
2939527 Add test for internal copy/paste
Change-Id: I6a34c61eeedd8a61a8cb16116f8f67293921f2dc
New changes:
694c97f Update OOjs UI to v0.17.6
35da0d9 Use transition timing from OOUI theme config
b1777ea Move cursor holder debug styles to stylesheet
af5f22a Use surface fragments in ListAction methods
9710c76 Use surface fragment in FormatAction
39581ac Use surface fragment in LinkAction
a3ea25c Check surface exists before trying to execute keydown command
Change-Id: Ia95a40db7d63a5e767cf590538952790457377d7
If internal link detection is in the LinkAnnotationInspector, it falls down
when a valid URL which isn't also a valid page title (e.g. percent-encoded
titles) is pasted into the input. This is fixed by moving the detection to the
input's change handler before any validation can occur.
Bug: T119431
Change-Id: I1eb2040dd918fdcc22c28594b5cbad835cf384a8
Ideally we would get an exception when trying to load
a non-existent module, but there is no difference between
a genuinely missing modules, and one which just doesn't exist
on this target (e.g. a desktop-only module on mobile or vice-versa).
This stops mobile VE from crashing every time a desktop-only
module is added to VE plugins.
Change-Id: Ia9ac0dd21b26c54ad779c6f499e68786c34ec873
Fixing `z-index` issue of floating toolbar dialog not overlapping when
Special Character dialog is active.
Bug: T140237
Change-Id: I24e9ed5b1f65c6ea4cffbd408953623540542bca
If width or height attributes are left empty in the form,
they are now undefined in mwData.
Bug: T140094
Change-Id: I76dadbd07a89ce762e42ce714f364ce74a9cc1f0
Create an ext.visualEditor.mwextensionmessages module in our
ResourceLoaderRegisterModules hook and load them there as available instead.
Bug: T139550
Change-Id: I89e942052f86291085652ae93ae8d10efefb5f44
Assume the person setting up the wiki knows what they're doing since
we've warned them quite a bit already in the on-wiki documentation.
Bug: T140129
Change-Id: I1c7ffb22eba5ab5b5e7f92ae23da8fe9edf2606d
