Commit graph

4476 commits

Author SHA1 Message Date
Ed Sanders e073a431fc Remove translations of messages since moved to Cite/Citoid
Change-Id: I692f03b374ec28ec6d81aab2d2d6fcd7705cedc5
2016-02-10 00:39:18 +00:00
Translation updater bot 829b2cd430 Localisation updates from https://translatewiki.net.
Change-Id: I28e88ed6e5da7567693ee2833e501696251deecd
2016-02-09 21:42:50 +01:00
jenkins-bot d5f6c220d3 Merge "Follow-up I7e1edcf05c: Remove MonoBook z-index hack" 2016-02-09 14:28:16 +00:00
jenkins-bot 1844af1588 Merge "ve.init.mw.trackSubscriber: Sample at 6.25%" 2016-02-09 01:06:23 +00:00
James D. Forrester a1db489d95 ve.init.mw.trackSubscriber: Sample at 6.25%
Bug: T125598
Change-Id: I1915a6456ba5dfc10e4a52df24cee2e68b27e526
2016-02-08 13:22:33 -08:00
Translation updater bot 047517fa22 Localisation updates from https://translatewiki.net.
Change-Id: I475a76215ab50328eb2c65d68b2c4be2a5afd6e2
2016-02-08 22:17:32 +01:00
jenkins-bot e5eb83ff8b Merge "build: Bump various devDeps to latest and make pass" 2016-02-08 18:18:03 +00:00
Ed Sanders 25be46a57d Fix transclusion node cloneElement method
* Override the static cloneElement. getClonedElement shouldn't
  be overridden as doing so misses static invocations.
* Apply the same fix to extension nodes
* Fix DOM loop to reference clone.originalDomElements[ i ]

Logically depends on Id8024c171c to work.

Bug: T126169
Bug: T126114
Change-Id: Icf4d3115db5b12b97a6c805ff3d0b71d9e88b804
2016-02-08 15:29:19 +00:00
jenkins-bot a996356e12 Merge "MWImageModel: Use clearDefaultDimensions" 2016-02-08 12:52:10 +00:00
Ed Sanders cfe21d317d MWImageModel: Use clearDefaultDimensions
setDefaultDimensions( {} ) is a no-op.

Bug: T126078
Change-Id: I1ef7cae04574e2561d21d4071d19a0067d81b263
2016-02-08 12:37:26 +00:00
James D. Forrester e6e492efc6 build: Bump various devDeps to latest and make pass
* grunt-contrib-jshint: 0.11.3 -> 0.12.0
  This version of the linter cleans up a number of options. 'es5' is now assumed to be
  true by default, and replaced as 'esversion'; 'latedef' is extended to also cover
  functions' defintions, disabled for us for now; 'futurehostile' is introduced to aid
  future-incompatible names for ES6+ support.

  I adjusted ve.init.mw.DesktopArticleTarget.init.js based on this, as this file is
  meant to be loaded by all JS-capable clients to determine if it is (amongst other
  things) capable of ES5, so now we assert ES3 compatibility via jshint.

* grunt-jscs: 2.5.0 -> 2.7.0
  Minor version bump that doesn't affect us.

* grunt-jsonlint: 1.0.6 -> 1.0.7
  Trivial version bump that doesn't affect us.

Change-Id: Ieb7b6748b0cecf275cfc284fc66617189372461f
2016-02-07 19:41:21 -08:00
jenkins-bot 2b01e43777 Merge "DesktopTarget: Move generic VE desktop styles into a separate module" 2016-02-08 01:59:56 +00:00
Ed Sanders 739f924e98 Follow-up I7e1edcf05c: Remove MonoBook z-index hack
The cited reasons were that the the logo and search bar
have a z-index of 3, but that doesn't matter as they are
nested in other elements with z-indexes.

Change-Id: I7ff279efe7c01ba1ffb1fa0d460d59a493ccc47a
2016-02-07 17:40:50 -08:00
Ed Sanders c51cef07b9 DesktopTarget: Move generic VE desktop styles into a separate module
Here they can be re-used by other VE desktop targets,e.g. Flow.

Change-Id: I18431ff73fc1c6ab5639a579e85b0f0cc48cb9ce
2016-02-07 17:39:57 -08:00
Translation updater bot 0138f6a71f Localisation updates from https://translatewiki.net.
Change-Id: Ia7c748204f03aa2be7f403846118753c5f174669
2016-02-07 22:22:53 +01:00
jenkins-bot 16c498fa97 Merge "DesktopArticleTarget#editSource: Use actionFactory to create a window with the surface" 2016-02-07 10:30:06 +00:00
Ed Sanders efd41fbc74 Remove global overlay hack now fixed in Vector
Change-Id: Ic5cfb7ae4d244799be56e12b4b0a44b6ddd00303
Depends-On: I5ebb4e59e3714dfaa3d755ecf6285009efe7b62a
2016-02-07 03:26:02 +00:00
Ed Sanders 9bf010c33c DesktopArticleTarget: Cleanup styles
* Use more specific ve-init-mw-desktopArticleTarget class
* Add comments and reorder in places

Change-Id: Ic9291d3e50304fe3a0efa7ace1ce93c7fba91d98
2016-02-06 19:26:06 -08:00
Alex Monk 138fafbbb9 DesktopArticleTarget#editSource: Use actionFactory to create a window with the surface
So the normal logic is used to close other windows etc.

Bug: T125479
Change-Id: Iee9ef7484de745f3adced28cdbcc87a0c2b597f5
2016-02-06 02:02:39 +00:00
jenkins-bot e0de4c4447 Merge "Remove all Extension:Cite code, now moved there" 2016-02-05 22:17:08 +00:00
jenkins-bot 5a360f4cbb Merge "Remove mwReference tests, moved to Cite extension" 2016-02-05 22:16:24 +00:00
James D. Forrester 1e0486a679 Remove all Extension:Cite code, now moved there
Depends-on: I39936ed83d5a60471a0a75da753f498e80aef234
Depends-on: Ifd853bf9f901065798bd0063aeaa786a3761aa71
Depends-on: I32c93c5118eafe5f071252290c58d3de8dacc81a
Change-Id: Iba0f25b3ebe4e5e63377da57afb760d6980f9907
2016-02-05 21:36:56 +00:00
Ed Sanders 094555cb3c Remove mwReference tests, moved to Cite extension
Change-Id: I07a2bf45117c2d14c7b00875c0a710e20980a23a
2016-02-05 21:36:56 +00:00
Translation updater bot bd848ac4f1 Localisation updates from https://translatewiki.net.
Change-Id: Ic65af97f6c29c1e0c47317997b18ab064f80a2f5
2016-02-05 21:54:43 +01:00
Translation updater bot 7c07b2706b Localisation updates from https://translatewiki.net.
Change-Id: Ibd8991424c15ff9d6700c5103c75aff17aa452d9
2016-02-04 22:18:02 +01:00
Ed Sanders 5864a62134 Default extensions to not use the 'invisible icon'
Bug: T125767
Change-Id: I58c58080382974a887ebc52c1ac80cb5970db8c7
2016-02-04 19:38:16 +00:00
Translation updater bot 622ca082ca Localisation updates from https://translatewiki.net.
Change-Id: I29d93111a508e8af12752b6b93dc13d106f01d5f
2016-02-03 23:09:41 +01:00
Translation updater bot 0acd4160f4 Localisation updates from https://translatewiki.net.
Change-Id: Id1d12847d0c09993453c889af16266b9bac9d9ee
2016-02-02 21:33:11 +01:00
jenkins-bot 804ab26fb2 Merge "Check xhr.responseText is set before trying to send it to $.byteLength" 2016-02-02 19:08:08 +00:00
Alex Monk 9808d04bfe Check xhr.responseText is set before trying to send it to $.byteLength
Bug: T125399
Change-Id: I09881fe8b6db7d95e32732129d043c4a13fa7a9a
2016-02-02 18:52:56 +00:00
Ed Sanders 98bc5daba1 Use new iconWhenInvisible feature in Transclusion/Extenion nodes
Change-Id: Iba55676c06a1cd625187c38c1ae0c9c20b065827
Depends-On: I127bb5d34850cdc545ea3c05d0fc41a8ae1c6dea
2016-02-02 18:07:13 +00:00
Translation updater bot 9ec0705a2b Localisation updates from https://translatewiki.net.
Change-Id: If02911bde5c9cdbaeeaf52a45f4746b1b61b7d16
2016-02-01 21:56:13 +01:00
Ed Sanders db5ed236dd Add controls for wikitable and sortable to table dialog
Bug: T95189
Depends-On: Ife3f3505b845db28dd29a07e9be1533c39726ce1
Change-Id: I1672d8cd2e138df1fad19dcfd948700942e87f2c
2016-02-01 10:58:42 -08:00
Ed Sanders 74358498da Update VE core submodule to master (70ff8cc)
New changes:
242ab45 DesktopContext: Float the context when it goes beyond the viewport
405c44d Rename TableContext to TableLineContext
6c564be Sort messages alphabetically
70ff8cc Introduce table and table cell context

Change-Id: I4357162bc192c90f99ca0aec12eb67bf848e5504
2016-02-01 10:51:26 -08:00
Ed Sanders 5e296a959b Sort messages alphabetically
Change-Id: I45b440b1b020ea79ab4c1eba78effb526c41ddc4
2016-02-01 17:36:43 +00:00
Translation updater bot 122d76bfbe Localisation updates from https://translatewiki.net.
Change-Id: Ib037f762e584c8b6bc153a469057b362e31393fc
2016-01-31 21:42:24 +01:00
Translation updater bot 1b33f7b912 Localisation updates from https://translatewiki.net.
Change-Id: I499a7c36f46bed65f06c881de3df9fdf53e20036
2016-01-30 22:50:35 +01:00
Alex Monk 8cc034b9af Run VE->WTE modification checks regardless of how the user got into VE
I think this fixes a bug similar to the one described in the bug below.

Bug: T124708
Change-Id: I61558227315bec36b71dac281b8da311a3d6bb1a
2016-01-30 03:06:46 +00:00
Translation updater bot de5f372ac5 Localisation updates from https://translatewiki.net.
Change-Id: Idfb5e5fdd92cae124b428c768fd89baa6239541c
2016-01-29 22:43:50 +01:00
Ed Sanders 0ed45dbf61 MWTable: use new sanitization method
This prevents tables from getting sanitized even on
VE to VE copy. Also by calling ClassAttributeNode sanitize
extra CSS classes are removed.

Bug: T97462
Bug: T125220
Depends-On: Ia3ce386b2a03bc227818b10423bca72c736c0656
Change-Id: Ifd91e00b40665b446bbdcdf8859d2bb641bc0e67
2016-01-29 10:29:19 -08:00
jenkins-bot 66b0ff5111 Merge "ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl" 2016-01-29 17:00:38 +00:00
Translation updater bot 77a11811fb Localisation updates from https://translatewiki.net.
Change-Id: If88cee4c9c766aabdccc4d996d48c0151e5611bb
2016-01-28 21:11:06 +01:00
Bartosz Dziewoński fb54d03a59 ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl
Change-Id: Iae61d13a6c776c86bcec6744a2153b14c07722e9
2016-01-28 19:02:38 +01:00
jenkins-bot e4e7fce00e Merge "Create a more neutral warning message" 2016-01-28 07:57:33 +00:00
Justin Du 854f0a3692 Create a more neutral warning message
Change was made because editing mode is not always left to go to view mode,
but for example also because of clicking on "History".

Bug: T121754
Change-Id: Ibc1ba697081e60b8a797f5ea1b814a320ba812c3
2016-01-28 07:29:09 +00:00
Translation updater bot e181ca806b Localisation updates from https://translatewiki.net.
Change-Id: I694abc3d49df4ed6b580a10bdc37ba24fc288ac0
2016-01-27 21:46:32 +01:00
jenkins-bot f78dd8ad72 Merge "MWWelcomeDialog: Let the user switch editors" 2016-01-27 00:20:10 +00:00
James D. Forrester d8769edd01 MWWelcomeDialog: Let the user switch editors
Change-Id: If88942d866278f3012dae7972d464a3d2a6a4f82
2016-01-27 00:14:07 +00:00
jenkins-bot fc43d61ec5 Merge "MWTargetWidget: Add missing indent commands to blacklists" 2016-01-26 23:53:51 +00:00
Ed Sanders abb094babd MWTargetWidget: Add missing indent commands to blacklists
Bug: T124619
Change-Id: If2a5d98673db6e2d29fe49f1e7f5307437ba3866
2016-01-26 23:46:12 +00:00
James D. Forrester 2c76dc5b50 MWEditingTabDialog: Use 'small' size
Change-Id: Icb30d4fbea21653cf2fb6c782a4314be97a3e0a2
2016-01-26 14:51:55 -08:00
jenkins-bot 75b0a8de63 Merge "Don't try to load VE over the top of the wikitext editor we just switched to" 2016-01-26 17:01:24 +00:00
Alex Monk 589437a772 Don't try to load VE over the top of the wikitext editor we just switched to
(if we discarded changes)

Bug: T124316
Change-Id: Ic5e6ee8f4b6e75c3ae877021bcb29733b881e6d2
2016-01-26 16:49:50 +00:00
Alex Monk d7183d7e64 Check user permissions for viewsource before loading VE on-load on action=edit/submit etc.
Clicking 'View source' should probably not cause VE to load

Bug: T124650
Change-Id: I236de38b0f90f1aaa5d04b57cb7759e5951baf2b
2016-01-26 16:47:26 +00:00
Alex Monk bfa15c44a5 Check user preferences before loading VE on-load on action=edit/submit etc.
Bug: T124743
Change-Id: I2e8a19014464a2b7fb76de08676e7cb808e06956
2016-01-26 02:48:27 +00:00
Translation updater bot 71c0473094 Localisation updates from https://translatewiki.net.
Change-Id: I159863f04ee8af735dde305b24d8f5cd0a5c8b2b
2016-01-25 22:33:02 +01:00
jenkins-bot 6666bfcaea Merge "MWTableNode: Mixin ve.ce.ClassAttributeNode" 2016-01-25 20:54:15 +00:00
Ed Sanders ba0b084813 MWTableNode: Mixin ve.ce.ClassAttributeNode
The DM side already had the mixin, the CE side was still using custom
logic that has since been moved to ce.ClassAttributeNode.

This fixes the issue of tables not getting the wikitable class in VE
as it was only applied on attribute change previously, which never happened.

Change-Id: I197347762fc9228034f7664484539e5888722bcf
2016-01-25 16:35:49 +00:00
Translation updater bot 8e5a9e71a9 Localisation updates from https://translatewiki.net.
Change-Id: I401186574b88f3c5c810644799b55f2af5740f8c
2016-01-24 21:22:34 +01:00
Translation updater bot d246540ccf Localisation updates from https://translatewiki.net.
Change-Id: Ie90b5f4eb9a6303d4374b99c98c0dfeb8e595fbc
2016-01-23 22:30:32 +01:00
jenkins-bot d29524c8b3 Merge "When loading VE from action=edit/submit, replace the title shown" 2016-01-22 20:43:02 +00:00
Alex Monk 38180b5d4d When loading VE from action=edit/submit, replace the title shown
Bug: T117643
Change-Id: Ice21389d02ea10adc668c5b0a64ba2b0b9cf5744
2016-01-22 20:27:01 +00:00
Ed Sanders b66aa990ba Follow-up I9714cf3: Add tests for wikitable paste
Bug: T85577
Change-Id: I8e2893c9a6f80fafe6cae142e4f50ffbe6d550ac
2016-01-22 20:13:26 +00:00
jenkins-bot e6c61052a0 Merge "MWTableNode: Apply wikitable class to pasted tables" 2016-01-22 19:10:41 +00:00
Ed Sanders bf50e2a570 MWTableNode: Apply wikitable class to pasted tables
Bug: T85577
Change-Id: I9714cf3e8ccc165f91af939481c845c3ec9c5f6b
2016-01-22 18:43:47 +00:00
Thalia 16330ac05d Add method for setting minimum number of rows in Ace editor widget
Bug: T123891
Change-Id: Ia2e094071f385628449f1935f0250cbeb75196f0
2016-01-22 17:05:35 +00:00
Translation updater bot b382eced8c Localisation updates from https://translatewiki.net.
Change-Id: Idce091710bdb8936a362df1ce2f000b792b1b286
2016-01-21 21:56:24 +01:00
Translation updater bot 27261322b4 Localisation updates from https://translatewiki.net.
Change-Id: I6f9e970a0cb80e33849c67d1a850ce019cdcd76e
2016-01-20 21:09:24 +01:00
jenkins-bot 3bc62ba61d Merge "SaveDialog: Fix alignment of checkboxes" 2016-01-20 18:36:46 +00:00
Translation updater bot 5b95d6c1e6 Localisation updates from https://translatewiki.net.
Change-Id: I5b3ed86498fcc81cb448d056d32b53cb9a15a579
2016-01-19 21:22:21 +01:00
Ed Sanders 74e4450c92 SaveDialog: Fix alignment of checkboxes
Change-Id: Ia7718e7cebe7c533a76533dc82bcf93f8da49d15
2016-01-19 16:40:32 +00:00
jenkins-bot ee70cc5c44 Merge "Single Edit Tab: simplify logic; make 'prefer-wt' just disabled" 2016-01-18 21:28:26 +00:00
Translation updater bot 9b0ba61924 Localisation updates from https://translatewiki.net.
Change-Id: I45ba38e70875a2e7783144aa0756f4bc8989c835
2016-01-18 21:38:20 +01:00
James D. Forrester aa08d34318 Single Edit Tab: simplify logic; make 'prefer-wt' just disabled
Change-Id: I090375933656f29636c355c4d2ce358dd7f7f074
2016-01-18 11:23:59 -08:00
James D. Forrester 68ea08cd5e Drop support for adding prefix/appendix labels to edit tabs/links
Depends-On: I264599a1c4f60b37a46d49c808cf271ba0a8f882
Change-Id: Icebc378f5c00aac57ad361f8ba85da93b8178650
2016-01-18 03:06:33 +00:00
Translation updater bot f0b2ce2ded Localisation updates from https://translatewiki.net.
Change-Id: If3cb31818a635b6f5b4ac4796fced777f5517dd0
2016-01-17 22:35:39 +01:00
Translation updater bot 81a33e1ddc Localisation updates from https://translatewiki.net.
Change-Id: If2e5f3a07d289d3575ada8cc712b80ed11e2f532
2016-01-16 21:59:41 +01:00
Translation updater bot 5a8b1c294e Localisation updates from https://translatewiki.net.
Change-Id: I1653aca5124b19dbd879d82196ec381070ccce13
2016-01-14 22:26:26 +01:00
Translation updater bot 6606c25902 Localisation updates from https://translatewiki.net.
Change-Id: I913124a4a85545e9abc179a225ec3ee5746bda11
2016-01-13 23:32:14 +01:00
Translation updater bot cec85b9e3c Localisation updates from https://translatewiki.net.
Change-Id: I76a506a5fb58dee87fd3459d557b29190ad7e777
2016-01-12 22:49:13 +01:00
Translation updater bot c37fbf1f70 Localisation updates from https://translatewiki.net.
Change-Id: Ie52c778d1291121d3d78dcae9ae8a5d23d5c27b8
2016-01-11 22:55:11 +01:00
Translation updater bot 946163d758 Localisation updates from https://translatewiki.net.
Change-Id: Ib5d617cc8a22b6c5e5248c3a374d10d08cd3434f
2016-01-10 23:15:09 +01:00
Translation updater bot f26501b4f6 Localisation updates from https://translatewiki.net.
Change-Id: I6c324c98c20cc8d4b7b1b51f7eec5b5a608eee2b
2016-01-08 22:22:26 +01:00
Translation updater bot d1386ae5b8 Localisation updates from https://translatewiki.net.
Change-Id: Icf5edd18f9fa08c0ff63808c750b2f64698066bf
2016-01-07 23:39:13 +01:00
jenkins-bot 7a39be3798 Merge "Stop using broken image links in tests" 2016-01-07 01:21:25 +00:00
David Lynch 3cffb489bb Stop using broken image links in tests
They make it a little bit more cluttered to hunt down problems when
testing. So, use the minimum image instead of just "Foo" or similar.

Bug: T121636
Change-Id: I3209c377ad870f669cac7d40d991968cff52c39e
2016-01-06 17:11:38 -08:00
Dan Duvall 96677fb74a [BrowserTest] Experimenting with JS object references
References to JS objects for VE elements can determined by referencing
the VE and OOUI API documentation[1][2] and interrogating the objects in
a browser console. Errors should be closer to what developers understand
but testers should pair with developers to better understand how to
define new page elements and where to go for documentation/help.

The VE entrypoint for the singleton reference is `ve.init.target` (if
there's only one instance of VE target; there may be multiple in some
cases like Flow).

[1] https://doc.wikimedia.org/VisualEditor/master/
[2] https://doc.wikimedia.org/oojs-ui/master/js/

Change-Id: I1f642807cdd3059d8e7e885a8b239ac01b9b3024
2016-01-06 17:07:35 -08:00
Translation updater bot 739b4c796d Localisation updates from https://translatewiki.net.
Change-Id: I406227f147f21b4deed2a5a6e9f556e84cd32a65
2016-01-06 21:56:55 +01:00
Translation updater bot 94126edb04 Localisation updates from https://translatewiki.net.
Change-Id: I1d7295d5aee0dd72a7469c6467b12177187988dc
2016-01-05 22:31:09 +01:00
Translation updater bot b3a11a9325 Localisation updates from https://translatewiki.net.
Change-Id: I79bdcd360cf4c879b8344f75af927fdfac89dcd2
2016-01-04 22:38:41 +01:00
jenkins-bot 3591a0e63d Merge "Education popups: Only show for DesktopArticleTarget" 2016-01-04 20:00:58 +00:00
Ed Sanders e7ee5c20c6 Education popups: Only show for DesktopArticleTarget
For now they are not well supported by other targets
(e.g. Flow and Mobile).

Change-Id: Ibd1f3c8994611661b52c0cf36438b41f623b9451
2016-01-04 10:43:43 -08:00
James D. Forrester ada58df361 build: Bump file copyright notices for 2016
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
2016-01-03 14:57:25 -08:00
jenkins-bot e59e36e225 Merge "Refactor MediaResources(Provider/Queue)" 2016-01-03 22:55:39 +00:00
James D. Forrester 4a781a3a16 EditingTabDialog: Shorten the copy to make snappier, drop 'Edit' tab name
Change-Id: Idd5f373d9fef364318efddcc98ea2de5e91860a8
2016-01-03 13:44:54 -08:00
Translation updater bot 93b4a43b18 Localisation updates from https://translatewiki.net.
Change-Id: I26cf69fe5f4593ca22c9a170fd16fb02549b187e
2016-01-03 21:45:19 +01:00
Alex Monk 85bb085418 DesktopArticleTarget: Preserve oldid when switching from WTE into VE
Change-Id: I8682a2a2b90ae2e42f1a8e01e16d0f9f3d66a2d5
2016-01-03 10:59:21 -08:00
jenkins-bot 26e3c0ad1d Merge "Preserve oldid when switching from VE into WTE" 2016-01-03 06:35:58 +00:00
Translation updater bot f80e0c7482 Localisation updates from https://translatewiki.net.
Change-Id: I58460ed4632db989f00464d0401a7bba5cd072da
2016-01-01 20:07:11 +01:00
Translation updater bot f1df0e0df4 Localisation updates from https://translatewiki.net.
Change-Id: I88a173f67541d0a5d1c8628e81871cbfce6db393
2015-12-30 21:46:23 +01:00