Commit graph

15240 commits

Author SHA1 Message Date
jenkins-bot df125c3303 Merge "trackSubscriber: Set timing property to a number, not an object" 2018-12-04 00:07:53 +00:00
Roan Kattouw 611d9ca6c5 trackSubscriber: Set timing property to a number, not an object
The timing variable is a private closure variable containing an object
that tracks the timestamps of different events in the current cycle. The
duration variable is the result of using that information to compute the
difference between the current timestamp and the relevant anchor
timestamp. For the '_timing' property in the EventLogging data, duration
is the correct value, not timing.

(This is confusing and we should probably rename the timing variable.)

Change-Id: Iff78eb0ab83c84b73ad5c8f3eb85b1c7f120ebef
Follows-Up: Ifc2135d99f4bec917dac60992098958b72c37fc6
2018-12-03 15:33:18 -08:00
Translation updater bot 6ff740e758 Localisation updates from https://translatewiki.net.
Change-Id: Ifb437de9423b68550458ce0850ba5f89e8fe5c59
2018-12-03 22:35:40 +01:00
James D. Forrester 309d05cb38 build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass
Change-Id: I4c547757ed5a32ff98b1cf2670010db302bd8467
2018-12-03 13:06:59 -08:00
Translation updater bot 7cb3e042c2 Localisation updates from https://translatewiki.net.
Change-Id: Ie63d71f5527ea719347a7126295b2b557a016680
2018-12-02 22:15:10 +01:00
Ed Sanders 103a34bb75 Remove AbuseFilter & SpamBlacklist code
Moved to their respective extensions

Change-Id: If463068a862cfde15ab4d250a1424c88a5229176
Depends-On: Ib1354f0404209a15194895026ff9d179d16b1900
Depends-On: I1807a5d3d99ecab2bf4545a1bab3aa3f2ae64da8
2018-12-01 14:03:11 +00:00
James D. Forrester 84ce7f1c4f Update VE core submodule to master (52b89a9db)
New changes:
ac8b90baa Use ve.dm.SurfaceFragment#hasMatchingAncestor where possible
3008ac425 ve.ui.FormatTool: Remove unused property
bae540ab3 eslint: Drop 'dot-notation' rule
0df7b6921 build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass
b1e836eac Localisation updates from https://translatewiki.net.
48b1be92d ve.dm.Change: Fix guessing selection for internal-list-only transactions
5722bab84 Enable jquery/no-(show/hide/toggle) rules
ed14182e0 Guard against Target#teardown being called twice

Bug: T208914
Bug: T210552
Change-Id: I0ba709bec3399e3d595ea830fe44e6ede1c6c2e6
2018-11-30 15:35:56 -08:00
jenkins-bot 7927a8e395 Merge "Create SaveErrorHandler class to better define structure" 2018-11-30 23:06:11 +00:00
Translation updater bot 85e4bc7846 Localisation updates from https://translatewiki.net.
Change-Id: I9844de6eb5a64d9c72d6a7f62e6f37ec55a39367
2018-11-30 22:50:13 +01:00
jenkins-bot cb5608693a Merge "Enable jquery/no-(show/hide/toggle) rules" 2018-11-30 19:38:49 +00:00
jenkins-bot 685533c86f Merge "ve.ui.MWTransclusionDialog: Remove unneeded code re-setting insert label" 2018-11-30 17:12:40 +00:00
Ed Sanders 5801273cbb Enable jquery/no-(show/hide/toggle) rules
Change-Id: I1ab177467fb9e8d0319c02d7770704b16456751d
2018-11-30 12:27:29 +00:00
Bartosz Dziewoński a659c4eaea ve.ui.MWTransclusionDialog: Remove unneeded code re-setting insert label
This sets the label to be the same as the default value inherited from
ve.ui.MWTemplateDialog. Looks like it's no longer needed since change
Ia8fb88d3501ffa2c26add4419da5463a926f45d1 (2014).

Change-Id: I1dd40d2428c0221dfdc79e5f34e411b127624eb6
2018-11-29 23:10:56 +01:00
Translation updater bot 6b44441632 Localisation updates from https://translatewiki.net.
Change-Id: I26661ef7a280d1c5b95e2c60261cc49a37d8f964
2018-11-29 22:27:56 +01:00
jenkins-bot 98955dfafd Merge "ve.init.mw.ArticleTarget: Stop when we fail to load metadata" 2018-11-29 19:54:36 +00:00
Ed Sanders 041e7b77a1 Create SaveErrorHandler class to better define structure
Change-Id: I036ee32847cc3b25a1cc478247cfe54599781098
2018-11-29 15:47:03 +00:00
jenkins-bot 3878db588d Merge "Remove captcha handler, moved to ConfirmEdit extension" 2018-11-29 03:33:54 +00:00
Bartosz Dziewoński 32f5256736 ve.init.mw.ArticleTarget: Stop when we fail to load metadata
This early return in loadSuccess() has been incorrectly removed in
b2718b186a.

As a very unexpected result of loading the editor twice in case
loading metadata is retried, the "Publish" button was staying
disabled. See the task for investigation.

Bug: T209542
Change-Id: If528afe1ca052062005937f03fe822c5c8d0958b
2018-11-29 04:23:42 +01:00
jenkins-bot fc126c1260 Merge "Rename configs for tracking block notices on visual editor" 2018-11-29 00:43:31 +00:00
Ed Sanders f0295ee01c Remove captcha handler, moved to ConfirmEdit extension
Change-Id: I6938d10d10be80e780294e4d4a32152827ccb5f9
2018-11-29 00:29:09 +00:00
Thalia 2516753c53 Rename configs for tracking block notices on visual editor
* Also make sure block notices have type 'block'.
* Remove old flag for tracking since we'll be using one
  from core

Change-Id: I4b66e73c8a4c4dd7bffd7c0239b1d5ec06eed12f
Depends-On: I6bd1c95548616677e1f72ba6bcfc6f2b551c1ca6
2018-11-28 15:26:15 -05:00
jenkins-bot 4de0e1a04c Merge "MWSaveDialog: Use ve.targetLinksToNewWindow" 2018-11-28 17:05:05 +00:00
Ed Sanders b76e40b2f3 MWSaveDialog: Use ve.targetLinksToNewWindow
Change-Id: I1515901f05de1a7b1ef2aa3cb34f3043ab02acce
2018-11-28 15:44:52 +00:00
Ed Sanders 41bb0a5fd2 Show timings of mwedit events in trackdebug
Change-Id: Ifc2135d99f4bec917dac60992098958b72c37fc6
2018-11-28 12:50:01 +00:00
Ed Sanders 1df0564690 Don't require editSchema to be setup to use trackdebug
Change-Id: I030f5e903d152b1e663f9155ee5235cb611ad63b
2018-11-28 12:49:27 +00:00
Ed Sanders 7dafd87829 eslint: Drop 'dot-notation' rule
Also upstreamed max-statements-per-line

Bug: T210552
Change-Id: Iea5036d5acab8dba46b573ee58da901169b5ab95
2018-11-27 22:41:53 +00:00
jenkins-bot 11f73e89da Merge "Debug flag for tracking" 2018-11-27 21:50:16 +00:00
jenkins-bot e0e40561e7 Merge "Blacklist javascript links" 2018-11-27 21:39:46 +00:00
Translation updater bot ec74391bed Localisation updates from https://translatewiki.net.
Change-Id: I3a93523a02f956183915aac30eb291b0cf4a7ef5
2018-11-27 22:14:46 +01:00
David Lynch bff72c679d Debug flag for tracking
Change-Id: Ie21c9e3a7bbbf4c3575af50acedf0f002d11cfcc
2018-11-27 14:10:55 -06:00
Derk-Jan Hartman 71ceb51c81 Blacklist javascript links
These aren't supported by VE-MW, so must just be
garbage from a browser plugin, possibly Citavi.

Bug: T200971
Change-Id: I9f34e9890e7f59d76cd464778481c415cc3c5dbd
2018-11-27 21:10:09 +01:00
jenkins-bot 23c6c3b6e0 Merge "Use mw.Title.wantSignaturesNamespace" 2018-11-27 19:31:13 +00:00
Ed Sanders 0d54a62858 Use mw.Title.wantSignaturesNamespace
Change-Id: I60187f0a3eb9cf5d56a4fdaa3401b107758bd8e3
Depends-On: Ib2faa22c429096d545ddb829a6b4025427ad6071
2018-11-27 18:42:44 +00:00
Bartosz Dziewoński b983538038 ve.ui.MWSaveDialog: Improve handling of links in edit summary preview
* Pass the page title, so that links to section point to the current
  page rather than "API"
* Make all links open in a new window, instead of producing a warning
  about losing your changes

Bug: T208978
Change-Id: Ia1924e1af644ee41ebcaa1da40ca004cb72dcdaf
2018-11-27 02:39:47 +01:00
jenkins-bot b34e625f4c Merge "ve.init.mw.ArticleTarget: Fix typo" 2018-11-27 00:04:20 +00:00
Bartosz Dziewoński c3dcdbe5f0 ve.init.mw.ArticleTarget: Fix typo
Change-Id: Ic4e886ca37c41e9c488b960c06a8de1d2fd1bb07
2018-11-27 00:45:24 +01:00
Bartosz Dziewoński c9ddb8b204 ApiVisualEditorEdit: Add a comment to a tiny but important line
Code added in 393807462e.

Change-Id: I0393a68939c8b103f09d4b25585637faeb76090d
2018-11-26 23:11:29 +01:00
Bartosz Dziewoński eb064877f8 Update VE core submodule to master (6a2233f68)
New changes:
73a231157 Only handle document selectionchange events when focussed
083272487 Localisation updates from https://translatewiki.net.
b5f36f1ea Localisation updates from https://translatewiki.net.
6a2233f68 Workaround native selection bug for number inputs in Firefox

Bug: T209646
Change-Id: I78fc21e88ead9ff6e181e1a88f3f0ddbdcd8e4d8
2018-11-26 20:28:48 +01:00
jenkins-bot 827e3661ec Merge "Track when block notices are shown on visual editor" 2018-11-26 12:35:21 +00:00
Translation updater bot cd1d40e691 Localisation updates from https://translatewiki.net.
Change-Id: Ib46f74af0dde52d38a3987c480e4faa5f2f91a78
2018-11-25 22:34:22 +01:00
jenkins-bot 3562de0c9e Merge "Move extension save error handlers into a registry" 2018-11-24 02:41:07 +00:00
jenkins-bot c6563ebdec Merge "Update VE core submodule to master (c9b894467)" 2018-11-23 17:28:56 +00:00
Ed Sanders 7bd58c52a5 Move extension save error handlers into a registry
These can now be moved to their respective extensions.

Bug: T136859
Change-Id: I2c35b9443208928db43bcfd515864641b10cc602
2018-11-23 17:19:36 +00:00
Ed Sanders 70253d450a Cleanup save-error handling
* Use ve.getProp
* Use .abusefilter key instead of string search (the key
  didn't exist when we first implemented AF support)
* Move AF handler next to captcha handler, and comment
  both as should-be-moved-to-plugin.

Change-Id: I171d63844b84b5a12396b6d6746f92110fc06c6c
2018-11-23 15:42:39 +00:00
Thalia a5c5bc5116 ve.dm.MWExtensionNode: check for body in describeChanges
Bug: T210257
Change-Id: Iffda3dc0b5b9dc84d294240546193e4b55c45bb7
2018-11-23 12:27:13 +00:00
Translation updater bot 9441222619 Localisation updates from https://translatewiki.net.
Change-Id: If1e3578d855ea739c8bf7aec41e978c9a0411b1e
2018-11-22 22:22:28 +01:00
jenkins-bot c5252fd968 Merge "Avoid HTML string parsing" 2018-11-21 21:46:33 +00:00
Translation updater bot abbdb1354d Localisation updates from https://translatewiki.net.
Change-Id: I1d8665aa451f415a02692c921d1ceb1a31475c8e
2018-11-21 22:29:34 +01:00
Bartosz Dziewoński 89126ad660 Update VE core submodule to master (c9b894467)
New changes:
d5d971214 Replace $.isFunction with typeof
b185014a2 Avoid stray tabs
c9b894467 build: Upgrade eslint to 0.9.0

Change-Id: I8d2b663a1b6b612f3ee90d56af0bc3450a1f3f4c
2018-11-21 21:40:58 +01:00
jenkins-bot 6291dff109 Merge "build: Use eslint-config-wikimedia v0.9.0 and make pass" 2018-11-21 20:25:39 +00:00