Commit graph

1967 commits

Author SHA1 Message Date
jenkins-bot ccdc215a98 Merge "Don't show PostEdit message if we made a null edit" 2014-07-30 00:45:08 +00:00
Alex Monk 1468ab8277 Don't show PostEdit message if we made a null edit
Bug: 51243
Change-Id: I63b2405c854e2953976dc8ca7a5a136308a7dcf0
2014-07-29 17:42:57 -07:00
James D. Forrester 1fcc9fa035 Update VE core submodule to master (61dea59)
New changes:
76bbf3b [BREAKING CHANGE] Fix camel-casing of countNonInternalElements

Local changes:
Use renamed countNonInternalElements function

Change-Id: Ib5f86ea5cfeb5e577f61349ed4bbb231ea155638
2014-07-29 17:15:35 -07:00
Ed Sanders c9c10cf5b8 Update VE core submodule to master (0709218)
New changes:
20c220a Remove unused CSS classes
9bdcc65 Comment icon positioning
e50e790 [BREAKING CHANGE] Fix ve.ui.Overlay classes
1ac4927 ve.ce.TextNode: Use getChar() helper
29fd0f8 ve.ce.TextNode: Simplify #getAnnotatedHtml logic
18336eb ve.ce.ResizableNode: Run find() once instead of 4x in showHandles()
febf125 Use getDescription for title attribute
ab3cb6c Localisation updates from https://translatewiki.net.

Local changes:
* Rename overlay class rules

Change-Id: Ia90b6afbd4abdf3267f4ccaac0b2a7d4101ccc7b
2014-07-29 16:31:42 -07:00
jenkins-bot 3783d6e328 Merge "Remove unused CSS classes" 2014-07-29 23:30:22 +00:00
Juliusz Gonera a43a87226d Remove timeout in scrolling to heading on mobile
No longer necessary after 859d8525.

Change-Id: I5b92a8c6acd3bbb8c563184fb2dda56e894a2c66
2014-07-29 15:07:36 -07:00
Roan Kattouw 859d85257b Delay scrollToHeading() until after the selection is rerendered
Otherwise either the focusing of the surface or the resetting
of the selection seems to cause the viewport to scroll back
up on mobile.

Change-Id: Ie3b104e04800d2753f99739f877c76e334965fc1
2014-07-29 14:58:24 -07:00
jenkins-bot 7072345c22 Merge "Delay scrolling to a heading more on mobile" 2014-07-29 20:10:42 +00:00
jenkins-bot 775d52f53a Merge "Focus the caption surface on initialization" 2014-07-29 20:00:18 +00:00
Translation updater bot 60304c9410 Localisation updates from https://translatewiki.net.
Change-Id: I152544935593d61a04ca835a7374ac2859127af0
2014-07-29 21:58:08 +02:00
Moriel Schottlender 50dae0ab16 Focus the caption surface on initialization
Whenever the edit mode is active, focus the caption surface. This
is also true for cases where the dialog starts in the 'insert' mode
and then switches to 'edit'.

Bug: 68806
Change-Id: I60b862dc5738a65a6bb31eb32184c35cc108b232
2014-07-29 15:34:09 -04:00
Vikas S Yaligar ca6816be63 [BrowserTest] Client logins only once to upload all screenshots
Change-Id: Ic242d8b2f35ced23809d4454a44f28f260bb3eb7
2014-07-29 12:35:19 +00:00
jenkins-bot 265de12b2d Merge "[BrowserTest] Language of images should be in subcategory of VisualEditor" 2014-07-29 12:35:05 +00:00
Juliusz Gonera 3224ceb41d Delay scrolling to a heading more on mobile
200ms are not enough for the surface to be rendered on iPad (especially
on older models).

Change-Id: I518312b3a038f2e5c9cc2022c51fc4e1e63f599d
2014-07-28 14:54:12 -07:00
Translation updater bot 38e47682de Localisation updates from https://translatewiki.net.
Change-Id: Ib5fd5f9bf90907aa5793072ae2548389ddbe689a
2014-07-28 21:26:27 +02:00
Ed Sanders 840c871a97 Remove unused CSS classes
By searching for CSS classes that don't exist in the code.

In some cases the classes were used but had been renamed.

Change-Id: I76442a632c18d2133cdf78c4555da149c0a7888c
2014-07-28 19:43:35 +01:00
jenkins-bot 10bc13c602 Merge "[BrowserTest] Save button locator now supports language screenshots" 2014-07-28 17:15:00 +00:00
jenkins-bot e67fdc0091 Merge "Comment used messages" 2014-07-28 16:19:34 +00:00
Vikas S Yaligar c6b96d10e5 [BrowserTest] Save button locator now supports language screenshots
Change-Id: Ib3b6c577aee3e8fa61f76f19a170e4cf5c76bf45
2014-07-28 20:02:04 +05:30
Vikas S Yaligar d4eb0ea00d [BrowserTest] Language of images should be in subcategory of VisualEditor
Paired with Amir Aharoni

Change-Id: Ibf77dffbb3468446c3a5828fad053f8cac6861af
2014-07-28 13:16:38 +00:00
Ed Sanders c23cebd5f6 Comment used messages
Change-Id: I22594b11f06f349c43162d52646a5c647c6ad0a3
2014-07-28 13:08:39 +01:00
Translation updater bot b74679c823 Localisation updates from https://translatewiki.net.
Change-Id: I05378bd550f36c036e9efcfc3085726f1d9c97b6
2014-07-27 22:26:07 +02:00
jenkins-bot 629f0c6908 Merge "SVG fixes" 2014-07-27 01:40:45 +00:00
Ed Sanders 61d40bd5ac SVG fixes
* Fix encoding
* Remove unused attributes
* Fix some IDs
* Fix pixel snapping in gallery icons

Change-Id: I084b3d7e3e5ba9b4ec234b94622cac076c7665e1
2014-07-26 18:38:11 -07:00
Translation updater bot c50c60ab67 Localisation updates from https://translatewiki.net.
Change-Id: I1dd18c5d92dfd25aec78f3c4dd4a79d489bca510
2014-07-26 21:49:46 +02:00
Ed Sanders 5e5755f09c Implement getFocusableNode for MWGallery nodes
Instead of using ve-ce-noHighlight we can just set and maintain
this.$focusable using getFocusableNode.

Change-Id: I0a6b2d6444df531b7c235ac9ff08a3ed8a0e99b3
2014-07-26 02:24:56 +00:00
Roan Kattouw c7fce9b2be Fix corruption bug in sortkeys containing underscores
We normalize underscores to spaces in sortkeys in toDataElement,
but when toDomElements recomputes the normalization to decide
if the sortkey really changed, it doesn't normalize underscores.
This is broken, both code paths need to use the same normalization;
we do this correctly for the category name.

This bug appears to date back to the introduction of category
support in March 2013 :(

Spotted in https://it.wikipedia.org/?diff=67220927

Change-Id: Ie3257fa335f3bd24a36c8654f3f5a24e89d7a9b9
2014-07-26 00:24:01 +00:00
jenkins-bot e49138a8c6 Merge "Actually clear diff viewer after closing save dialog and changing document" 2014-07-26 00:11:16 +00:00
jenkins-bot 4d58b106f8 Merge "Attach mobile surface to the toolbar" 2014-07-25 23:24:21 +00:00
Roan Kattouw 1042733ee2 Attach mobile surface to the toolbar
Trevor promised to do this in Iafe64a6f but never did.

This needs styling changes to look right. It also means that
VE mobile standalone doesn't have a context at all right now,
which is horrible, but at least this makes MW mostly work.

Bug: 68546
Change-Id: Id8cc4b07905f777f667f36cbcc65e821847142d5
2014-07-25 23:10:15 +00:00
Translation updater bot 20c96f34c8 Localisation updates from https://translatewiki.net.
Change-Id: I40c516f30a94b3dd756993a4d25b1fcc87dbb87f
2014-07-25 23:07:52 +02:00
Roan Kattouw a6d94256d8 Actually clear diff viewer after closing save dialog and changing document
The window refactor removed the 'teardown' event from windows,
but ViewPageTarget was still listening to this event on the save dialog.
Instead, use the opening promise to be notified when the save dialog
closes and call onSaveDialogClose() at that time.

Change-Id: I31a9a359eb14a56b214a1240db08632bda6bc8b9
2014-07-25 13:14:07 -07:00
Cmcmahon 2fb3375000 [BrowserTest] turn Headings test back on for the builds
Change-Id: I58848fc8393ac2007dbb724e34a4c85e5142df7d
2014-07-25 12:55:11 -07:00
jenkins-bot 6ad2b0fb08 Merge "Actually show the corruption warning in the save dialog" 2014-07-25 18:50:59 +00:00
Roan Kattouw 7cc31d0c34 Actually show the corruption warning in the save dialog
It was being set, then immediately cleared again.

Also remove the unused dirtymsg div.

Change-Id: I22e5fbe814d14684626a7502d2401f414838709b
2014-07-25 11:39:03 -07:00
Cmcmahon 9b93c2c4fd [BrowserTest] prevent premature click of Edit button
Change-Id: Ibce2bf0f75e0639bbd3b90f2dc73716e43797841
2014-07-25 11:16:20 -07:00
Alex Monk 14753500a6 Don't overwrite #contentSub just to try to get the correct subtitle for redirects
Because this breaks other subtitles such as subpage breadcrumbs
Instead, deal with the #redirectsub (added in I780c965) directly.

Bug: 68432
Change-Id: I646868916a4480404f6d466fd89f84798d0e9df5
2014-07-25 18:57:08 +01:00
Translation updater bot af91451ddd Localisation updates from https://translatewiki.net.
Change-Id: Ie01fdcf4830f42bc176b337d3d221dbaf34c801e
2014-07-24 23:52:14 +02:00
Ed Sanders 97813e2696 Use faster (and more accurate!) computation of directionality
Per the comment above, dm doc direction will be a better
estimate of wiki direction than CSS, which is very slow.

Change-Id: I231738d660b429df1598eaaadf7397b47d35ea0c
2014-07-24 19:44:58 +00:00
Vikas S Yaligar aee1b125fc [BrowserTest] Language screenshot feature runs only for language screenshot job
Changes made in job which uses this patch is
https://gerrit.wikimedia.org/r/#/c/149012/

Bug: 68467
Change-Id: I8a28cfcf98b7cfcb64e809f08c7deadf086ba6d6
2014-07-24 22:43:43 +05:30
Cmcmahon 90a58ffe17 [BrowserTest] Switching from VE to wikitext update workflow
It got a little more complicated that it had been

Change-Id: I511aa1b6d5738f1c19d9ac395efccfef6b328798
2014-07-24 13:57:33 +00:00
jenkins-bot 04abfb3e79 Merge "Revert "Provide contextual help for the page settings dialog's controls"" 2014-07-24 02:12:35 +00:00
Jforrester f84c33f074 Revert "Provide contextual help for the page settings dialog's controls"
This reverts commit 9ba9b35b41.

Change-Id: I95dd24ec94f4e0ecc3a32fbcdac689cee4116ed5
2014-07-24 02:09:27 +00:00
jenkins-bot 9774ceed20 Merge "Bump the height of the references list a little" 2014-07-24 00:43:02 +00:00
jenkins-bot 7a41e9fba9 Merge "Allow for a custom mechanism for scrolling to a section" 2014-07-24 00:42:55 +00:00
jenkins-bot 30bdf71193 Merge "[BrowserTest] Add parameter no longer exists" 2014-07-24 00:38:56 +00:00
Juliusz Gonera 8563668978 Allow for a custom mechanism for scrolling to a section
When I05f11246ca90a1ce3f741fd93194a827528cd597 gets merged, we will need
this to be able to scroll to a section on iOS (where the content will be
scrolled within a div, not as a whole page).

Change-Id: I6e47edfa8c3a3a46fd7a4f11e4a54955f3694b9b
2014-07-23 17:34:39 -07:00
jenkins-bot 3771aa92c1 Merge "Make the image model work without a node" 2014-07-24 00:32:54 +00:00
Moriel Schottlender 1bc7d074fe Make the image model work without a node
The image model should go by image attributes (whether it comes from
an existing node or a new one) and not a node.

Bug: 68242
Bug: 68000
Change-Id: I4cabd678157619331b3c47d3b44bc16a28fd7bd7
2014-07-23 17:27:30 -07:00
jenkins-bot c7026baf26 Merge "Defer building of MWReferenceSearchWidget index" 2014-07-24 00:27:16 +00:00