Instead, use getCheckboxesDefinition(), and build our save form
checkboxes from that rather than extracting them from the HTML.
The ability to have non-checkbox fields there is removed, as that was
never intentional and is now impossible.
To avoid transient problems during deployment (old JS code cached in
the user's browser receiving the new format of API responses), the old
property is kept in the API response. We should remove it next week.
Bug: T174613
Bug: T174686
Change-Id: I5bfca5e116fe790302c3b6ac1357e80237fb1ed2
There's no need e.g. in API documention queries to actually create the
RESTbase service connection, and it's quite an expensive operation to
do there.
Change-Id: I114fe0718338db7233ed94e4ffa90861b4e9ff50
Wikitext editor doesn't need to know about redlinks
on the page, so this is a waste of time. If the user
switches to VE, they will do a fresh metadata request
at that point.
Change-Id: I57f3fe3fca47dde03bba7905f763abc8a43d0653
This should just result in an empty `td` for the language name, rather than
any more-severe breakage.
Bug: T154962
Change-Id: I59d429777ab790e922f08e01a1c262fa2b082292
Linker::link was deprected in 1.28. This replaces all usages of
Linker::link with an instance of LinkRenderer in ApiVisualEditor.php, as
this seems to be the only file generating links with Linker::link.
Bug: T149346
Change-Id: Ib395f137787e7dd7c5cfe91905f5feb88ce9f604
See Iae0e2ce3. Since VisualEditor master requires core master, this just
depends on the master patch instead of trying to maintain BC.
Depends-On: Iae0e2ce3bd42dd4776a9779664086119ac188412
Change-Id: I0e802a47302725f062334a437bff84e3b2b8b9a6
These require POST, especially paction=serializeforcachekey because
it calls ApiStashEdit::parseAndStash() which needs a master DB connection.
Move them to the edit module so we can require POST for that one and keep
allowing GET for the main module. This fixes the warnings we currently get
for using parseAndStash() in a module that does not require POST.
Change-Id: I64a8ed7305105fa4c46902b99984306a7ff468cc
When no langlinks are returned by the API, it just doesn't set the langlinks
property.
Also, get rid of indexpageids while we're here.
Change-Id: Icfb8c0abb02aeb3e9cdbefe0df7bb6b5476b78a4
Since this extension uses extension.json, it already requires 1.25+ so
no need to keep the old code around.
Change-Id: Iff2eeb2bbfba15c84a4fcec85b6647c28886e9aa
Assume the person setting up the wiki knows what they're doing since
we've warned them quite a bit already in the on-wiki documentation.
Bug: T140129
Change-Id: I1c7ffb22eba5ab5b5e7f92ae23da8fe9edf2606d
While that commit fixed the issue it was intended to address, it also
completely broke VE everywhere else. Basically you'd end up with a result
like this:
array(5) {
[0]=>
int(14)
[1]=>
int(6)
[2]=>
int(2)
[5]=>
int(0)
[6]=>
int(250)
}
With the lack of 3 and 4 keys making the JSON formatter think we've got an
object.
Bug: T139094
Change-Id: Ia21fd4bd352afc9170357576a3e0eb17b4528326