wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-18 03:41:45 +00:00
Code Issues Packages Projects Releases Wiki Activity
15288 commits 161 branches 1 tag 190 MiB
Commit graph

2128 commits

Author SHA1 Message Date
jenkins-bot 25d2eb2848 Merge "Use ve.resolveUrl in MediaContext/Dialog" 2018-05-07 15:28:52 +00:00
Ed Sanders 8bddec44e3 Create an MWSurface and move langChange handling there 
Change-Id: I8a75b5f431f454b66441fc301b90e5f28636612e
 2018-05-07 11:53:23 +01:00
Ed Sanders 478b0bcbb9 Create getters for localised APIs (getContentApi/getLocalApi) 
Pass through the current document when available, otherwise
assume the current surface's document.

Also add a getter for getPageName, so that can vary based
on the target document.

Bug: T193856
Change-Id: Ifdc951fdc6a43b924d102e3fcd7e59e52023757b
 2018-05-05 14:32:55 +01:00
Ed Sanders b54f427078 Remove unused overrides in internal link annotation inspector 
Removes an unused call to mw.util.getUrl.

Change-Id: I3988311b7160af628ea4ceeafcfdc3cc0a7a3774
 2018-05-05 14:32:55 +01:00
Ed Sanders 3b4923fa74 Use ve.resolveUrl in MediaContext/Dialog 
Change-Id: I53e28d6cec13ac77718ba3cae425c4c43c96e174
 2018-05-05 14:04:15 +01:00
Ed Sanders ebcf1e1151 Check imageModel exists in #checkChanged 
Bug: T193879
Change-Id: Ic6eda7a056e5207042b575609b9da1869e3a759e
 2018-05-04 14:52:03 +01:00
Ed Sanders 1bd430c9d1 Convert most uses of isForClipboard to doesModeNeedRendering 
Depends-On: I0f1b90056e9d1a4fa0e188700604709297593924
Change-Id: I6fa1cde51ffc859b57ab557e3ddf8a76d92bf94f
 2018-04-30 16:10:27 +00:00
Ed Sanders 8fdc1f7085 Follow-up Iea7ad832: Fix context in MWPopupTool 
Bug: T193043
Change-Id: I2b035a50543093988a291ea8c8958a3a7cc9e7ba
 2018-04-29 21:45:10 +01:00
Bartosz Dziewoński e1635fdc52 Update custom styles for format menu after OOUI changes 
Bug: T193098
Change-Id: I00d28f16b03a31ecda1dc57050945e98e8eb37e8
 2018-04-26 01:48:28 +02:00
jenkins-bot ec8be1bfa1 Merge "Add a plain text paste transfer handler for source mode" 2018-04-23 21:00:41 +00:00
David Lynch 6f8e58fa8a Add a plain text paste transfer handler for source mode 
This allows plain text pasting into source mode without interfering with the
possible-conversion that should happen when it's pasted into visual mode.

Bug: T190590
Bug: T192320
Depends-On: I47a5bf321fb64d4a631ec6fd728bee269d4cdae0
Change-Id: I71db368c683a6a846569d7627f4cc73e907a61d2
 2018-04-22 12:52:56 -05:00
jenkins-bot 9ecd73f771 Merge "NWE: Fix selection when applying async links" 2018-04-19 16:01:22 +00:00
Ed Sanders 53e758a427 NWE: Fix selection when applying async links 
Change-Id: I31dc6f2d9fcd563bdbd8245bda6336d317aa512a
 2018-04-17 16:33:23 +00:00
hunter be5289689f Add label to Options dialog > Categories input fields 
Add label to indicate the function of the input field underneath the
categories label in the options dialog. The <label> element is
preferred for screen readers and users with visual disabilities.

Bug: T146966
Change-Id: Ib300ca7a1fd55d320c1a1a8c8c7fd01ab8b0b9c5
 2018-04-17 06:28:32 +00:00
Ed Sanders 2496fcefb0 Fix layout of welcome dialog on smaller screens 
Bug: T191095
Change-Id: Ic329fe22a6758fe58ec56dc3b5a293b83d9b38fb
 2018-04-12 23:15:15 +01:00
Ed Sanders 3682ab070d mw.Target: Remove .protectedClasses, only used in ArticleTarget 
Also fix documentation

Change-Id: I3fa93dd95c3ef47f649d3f92a38e14750a411333
 2018-04-12 15:38:23 +00:00
jenkins-bot b7abb924c2 Merge "Abstract API calls to 'parsefragment'" 2018-04-09 16:13:27 +00:00
Ed Sanders 924f9ec730 Use 'imageBroken' icon for missing images' contextItem 
Change-Id: I3ba8f34a8ff03c949c18df102e7334449abb6e27
 2018-04-06 15:32:55 +01:00
Ed Sanders 16211cdc09 Abstract API calls to 'parsefragment' 
Change-Id: Id0be3207219a6d93cebff2b6b5061cd24898d5cb
 2018-04-06 13:49:16 +01:00
David Lynch c4c5582121 MWTransclusionDialog: remove extra padding from framesets 
Bug: T191234
Change-Id: I6cfec45607f2dd428347879c134dbe286397f8b6
 2018-04-05 11:30:05 -05:00
jenkins-bot 7b1d248ec1 Merge "ve.ui.MWMediaDialog: Use dropdown for image type selector" 2018-04-05 11:02:22 +00:00
jenkins-bot f3ba1a780f Merge "ve.ui.MWParameterPage: Pass $overlay to PopupButtonWidget" 2018-04-04 21:36:39 +00:00
jenkins-bot f5b0d655cf Merge "FeedbackTool: Add the ability to vary feedback page for source mode" 2018-04-04 21:24:09 +00:00
Bartosz Dziewoński 0cf02e0155 ve.ui.MWParameterPage: Pass $overlay to PopupButtonWidget 
Also, pass $overlay to all PageLayout subclasses used in ve.ui.MWMetaDialog
and ve.ui.MWTemplateDialog/ve.ui.MWTransclusionDialog, for consistency.

Bug: T191395
Change-Id: Ib7ed2e2c04ff7930be1161bd2b981180ee59557a
 2018-04-04 22:45:13 +02:00
James D. Forrester 31730cc5b3 FeedbackTool: Add the ability to vary feedback page for source mode 
Wikis with a local link over-ride configured will need to do so here
for the new message `visualeditor-sourcefeedback-link`; wikis with a
remote link configured will need to update their configuration ahead
of this being deployed, setting $wgVisualEditorSourceFeedbackTitle.

Bug: T157953
Change-Id: Iea7ad8328b03f69e01d7c67ca1ddbb7ae7906288
 2018-04-04 18:11:10 +00:00
Ed Sanders b5be51db7e Use cog icon for options 
Bug: T191099
Change-Id: I68638dcfa2531ce01843ae3517d9245deb716769
 2018-04-04 13:22:00 +01:00
jenkins-bot f04563faba Merge "Show redirect link in preview" 2018-04-03 19:01:02 +00:00
Ed Sanders 36e0f8988d Show redirect link in preview 
Bug: T191128
Change-Id: I08fc03dd869e6b074a24698f9037380b26e3dd2c
 2018-04-02 17:34:51 +01:00
jenkins-bot 45afe665c1 Merge "Visual diffs in source mode section edits" 2018-04-02 16:05:34 +00:00
jenkins-bot 476a590c3c Merge "Parse title in show preview using hack" 2018-03-27 20:29:35 +00:00
jenkins-bot 5b36d88eae Merge "Make edit notices popup wider (320 -> 380)" 2018-03-27 17:24:58 +00:00
Ed Sanders d3e5385944 Visual diffs in source mode section edits 
Bug: T190845
Change-Id: I938352eec8b49f27784c12ddea72bbe69fdd6cb2
 2018-03-27 17:53:54 +01:00
Esanders 3cd35b95e9 Make edit notices popup wider (320 -> 380) 
Bug: T184379
Change-Id: Ic68f5e117bb0057bb5fa8b83834707abfbadb3b3
 2018-03-27 14:16:25 +00:00
Bartosz Dziewoński b8bcba8cbe ve.ui.MWMediaDialog: Use dropdown for image type selector 
The dialog is not wide enough to fit four buttons side-by-side.

Bug: T74187
Change-Id: I6a4e5692b5f1b2ca9bb78d4e6c6103036f371a52
 2018-03-27 14:40:39 +02:00
jenkins-bot fe625aa5ea Merge "ve.ui.MWPopupTool: Allow labels of buttons in help menu to wrap" 2018-03-27 11:55:16 +00:00
jenkins-bot 6deaeffa95 Merge "Revert "Make edit notices popup wider (320 -> 450)"" 2018-03-27 11:30:12 +00:00
Bartosz Dziewoński 4fd4a5259b ve.ui.MWPopupTool: Allow labels of buttons in help menu to wrap 
Bug: T190796
Change-Id: I7889119a60133100825d7db4a02e6d0a7c797eba
 2018-03-27 12:31:24 +02:00
Bartosz Dziewoński a0dacccd83 Revert "Make edit notices popup wider (320 -> 450)" 
This reverts commit d5a61eb95d.

Bug: T184379
Change-Id: I0198c6d1faf1474ea0faab7e05ec95cfb43c9206
 2018-03-27 10:13:45 +00:00
Volker E e837512cc6 Replace deprecated 'comment' with 'speechBubble' icon 
Bug: T183600
Change-Id: Iebebba61a099193051cffc11f41e366bdb1c19e1
 2018-03-26 21:14:35 -07:00
James D. Forrester fe525e3bcc *Dialog: Don't set to small size, which is the default 
Change-Id: I3b7a19acd0ee5112d104257bdc1e9ff0e9b4ff24
 2018-03-26 15:02:11 -07:00
jenkins-bot dc3e192179 Merge "Make edit notices popup wider (320 -> 450)" 2018-03-26 21:31:07 +00:00
jenkins-bot 44720da389 Merge "*Dialog: Drop verbose option, ignored since v0.20.0" 2018-03-26 16:18:49 +00:00
James D. Forrester 9e01553f0b *Dialog: Drop verbose option, ignored since v0.20.0 
Change-Id: If0bc7946b67aaae97886e8dbd956e9338b0e0b40
 2018-03-26 08:55:03 -07:00
Ed Sanders 95fc150a4f Remove unused static overrides from dialog 
Change-Id: I31f0310baa5c438b17f16749368102d8cede22db
 2018-03-26 15:49:04 +01:00
jenkins-bot 966e46ac80 Merge "Fix the image sizes in ve.ui.MWInternalLinkContextItem" 2018-03-23 05:36:51 +00:00
Ed Sanders f7b0118de0 Fix layout of media info fields 
Bug: T190468
Change-Id: Ic81781318a9003064e7d8f283901d70a5bae6ebc
 2018-03-22 22:15:52 +00:00
jenkins-bot 511dfc41ca Merge "Make save commands only executable when article is saveable" 2018-03-22 17:03:37 +00:00
Ed Sanders 8a974f25e6 Fix the image sizes in ve.ui.MWInternalLinkContextItem 
Remove the image size styles from the class
.ve-ui-mwInternalLinkContextItem-hasImage too

Bug: T97631
Follow up: I84edeec38ecfb90f5d53
Change-Id: I39937bf4ba12f7047545b187c54a1c5fae157e4a
 2018-03-22 17:03:19 +00:00
Ed Sanders 3a56d42901 Make save commands only executable when article is saveable 
Change-Id: Ia22fbae45201254867bf6e8920aff944ba9276b9
 2018-03-22 10:44:30 -05:00
jenkins-bot bfd4a5870f Merge "Use single-line editor for image captions" 2018-03-22 01:32:09 +00:00
jenkins-bot 663b9f9a35 Merge "Remove special font-size treatment following-up UI unified in 14px base" 2018-03-21 21:07:16 +00:00
jenkins-bot e03f3e2c73 Merge "Update icons for new 20px grid" 2018-03-21 20:59:23 +00:00
jenkins-bot cf9ddabe23 Merge "Disable visual diffs on source mode section edits" 2018-03-20 23:02:33 +00:00
Ed Sanders 8bfb270168 Use single-line editor for image captions 
Depends-On: I2be081c766fab41b152d03b43e7e936e3f636166
Change-Id: Ifcdc34826ad81e96c22fd68ceb637107cde24d4a
 2018-03-20 22:51:27 +00:00
Volker E d44bb0bc1b Remove special font-size treatment following-up UI unified in 14px base 
Removing `0.8em` VE special base `font-size` for UI as we're unifying
OOUI interfaces to `14px` equals to `0.875em` at user agent default size.

Bug: T97631
Depends-on: I693d168d2ccf2babbcfe8952af3e1c262aa97773
Change-Id: I84edeec38ecfb90f5d53199f3b26fc3f83ab0611
 2018-03-20 20:03:19 +00:00
Bartosz Dziewoński d80099dad1 Update icons for new 20px grid 
Set viewBox to "2 2 20 20" to trim 2px off each side of our
existing 24px icons, therefore aligning them to the new 20px
grid. All of them had been drawn with large margins, so none
of the graphic is lost.

Bug: T177432
Bug: T190151
Change-Id: I23a6daa5dc2d4a9afc50f275da5df370d2319277
 2018-03-20 20:03:11 +00:00
jenkins-bot 9d004c4d35 Merge "Use OOUI 'markup' icon instead of local 'alienextension'" 2018-03-20 19:50:55 +00:00
jenkins-bot cea546b502 Merge "MediaContext: Link filename to file page" 2018-03-20 18:41:09 +00:00
jenkins-bot bb34d650c0 Merge "Improve media context item to show Image/Video/Audio instead of 'Media'" 2018-03-20 18:38:53 +00:00
Ed Sanders 10792e179f MediaContext: Link filename to file page 
Change-Id: Ice3fdd40cd1f7b8ba2841ac326babc7f24a2635e
 2018-03-20 17:45:50 +00:00
Ed Sanders c245dd9ca0 Improve media context item to show Image/Video/Audio instead of 'Media' 
Change-Id: Ie3b7ec62483e725d3ce073095a2a958c1db930d5
 2018-03-20 17:45:48 +00:00
Ed Sanders 78ba8bbe3c Use OOUI 'markup' icon instead of local 'alienextension' 
Change-Id: Id15596ab0013cb2078480bdb4dde25ef8e7ae50b
 2018-03-20 17:27:54 +00:00
Bartosz Dziewoński c99b4a0ad5 ve.ui.Icons: Add missing global "invert" variant 
Bug: T190166
Change-Id: I28cc22d49881a25973b31e5e112130fb21cf4a37
 2018-03-20 16:36:18 +01:00
jenkins-bot 39a8c9e14b Merge "Restrict width of diff feedback button mobile" 2018-03-20 02:09:11 +00:00
jenkins-bot e23dd5fb6d Merge "Make gallery dialog work with native gallery implementation" 2018-03-19 23:39:00 +00:00
jenkins-bot 5b82bb180d Merge "Fix title preview when not overridden" 2018-03-19 23:24:21 +00:00
Thalia 12cc56400b Make gallery dialog work with native gallery implementation 
Updates the model and re-renders the gallery.

Bug: T150621
Bug: T149602
Bug: T149596
Change-Id: I1e93c3af02eeeff1fcdaa5549cccc61ea755ee04
 2018-03-19 23:55:17 +01:00
Ed Sanders 5e1c024d33 Parse title in show preview using hack 
Really Parsoid should do this for us.

Bug: T189540
Change-Id: Ie3b5d458e7e6611565e5852f351d715a48be521a
 2018-03-19 21:58:33 +00:00
Ed Sanders 81f3c2df38 Fix title preview when not overridden 
Change-Id: I555b057d8f20704c0676646afd03c78ad3353f23
 2018-03-19 21:56:54 +00:00
jenkins-bot 48028e84b9 Merge "Allow ve.ui.MWCategoryInputWidget to use different API" 2018-03-19 21:29:58 +00:00
petarpetkovic fe8b510232 Allow ve.ui.MWCategoryInputWidget to use different API 
* Provide config option to specify which API
ve.ui.MWCategoryInputWidget will use.
* To be used in Iec79e687eff8c63434054282650c97cc882f348d

Change-Id: Ib8869d4facf8b3210b309200d944fad4508d7eee
 2018-03-19 16:50:27 +01:00
Ed Sanders d0eafd6b8d Restrict width of diff feedback button mobile 
Change-Id: Ia4ceb73efb76d7714102619fce9cd87cf34216f9
 2018-03-14 14:32:37 +00:00
Ed Sanders c6653b6a2d Show page title in preview 
Bug: T189540
Change-Id: Idc203f7fcafcf944108938168b492e90091e3255
 2018-03-13 10:15:16 +00:00
jenkins-bot 540cb864ca Merge "ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image" 2018-03-12 12:28:10 +00:00
Ed Sanders 4fc2b32b17 Disable visual diffs on source mode section edits 
Bug: T183938
Change-Id: I0d03c47e9b4c30760b7d3bd7bf90d91e79eb8569
 2018-03-10 22:54:54 +00:00
Bartosz Dziewoński 3c676013f8 ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image 
Currently this only handles the caption, but there will be more.

Change-Id: Ia8a25de89375d0ba873f4891b053c7aceab15534
 2018-03-10 17:16:16 +00:00
David Lynch 4e10d5b975 Update rel attribute checks to be aware of multiple rel values 
Various checks didn't think a rel attribute could contain multiple values.
Mostly they don't, but to play it safe let's adjust the checks.

Change-Id: I29823b7c8c65ef6b2ff41ce9a801840000972e9c
Depends-On: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
 2018-03-08 14:34:56 -06:00
Ed Sanders 43ea4c2b51 Fix infinite recursion in positionDiffElement 
updateSize eventually calls setDimensions, which calls
positionDiffElement, so protect against infinite recursion.

Change-Id: I07992f337394712000e6e12c637c6e1442869722
 2018-03-03 18:47:08 +00:00
Ed Sanders d5a61eb95d Make edit notices popup wider (320 -> 450) 
Bug: T184379
Change-Id: Id2df8f8d162db3389206666fa07ea4cc0be8cdec
 2018-03-02 13:29:54 +00:00
Bartosz Dziewo??ski dbfe6c0b5a ve.ui.MWSaveDialog: Allow limiting comment length by characters rather than bytes 
Bug: T185948
Change-Id: I882d69beb1cd442868c8d73988f5b3a2bbb084bc
 2018-02-27 22:35:08 +01:00
Bartosz Dziewoński 3d422bac2a ve.ui.MWGalleryDialog: Handle galleries with 0 items 
We still don't allow inserting such galleries, but we can handle them
in existing content.

Bug: T75230
Change-Id: I5d7350f00871ac295b0ebc00a633b44570347d85
 2018-02-21 22:11:41 +01:00
David Lynch bd64b58071 MWTemplateTitleInputWidget: recover gracefully if TemplateData not present 
Bug: T187917
Change-Id: Ica0c853e1a7bc908651260df115d59d1939a7939
 2018-02-21 11:53:56 -06:00
Ed Sanders ee5b80aeee Avoid jQuery.parseHTML 
Bug: T187713
Change-Id: Ic156d6fb670fa2f79cf3c1d5fe0c6272b53b6440
 2018-02-19 15:41:20 +00:00
Ed Sanders 33858c6818 MWSaveDialog: Another check to see if visual diff is still visible 
Bug: T187282
Change-Id: Ia29a335bf6b1bad0eeb55b54094475c7fcc18dfe
 2018-02-16 15:21:12 +00:00
Ed Sanders e0b7fbe6f8 NWE preview: Avoid skin style clash 
Bug: T187075
Change-Id: I6ac6eebca3bd89ce19fb64f6e95809c4d595bc8b
 2018-02-13 16:22:56 +00:00
James D. Forrester b6c18b2d49 Don't try to insertMetas at 0,0, just at 0 now (lest we crash) 
Bug: T187112
Change-Id: I56e39276637ea018c1ec742d833d115ee881a5d5
 2018-02-12 19:32:23 +00:00
jenkins-bot 3d0d5667bc Merge "ve.ui.MWWikitextSurface: Implement textSelection 'replaceSelection', 'encapsulateSelection'" 2018-02-08 23:58:24 +00:00
jenkins-bot b2400138a5 Merge "ve.ui.MWWikitextSurface: Make 'textSelection' API chainable methods really chainable" 2018-02-08 19:44:36 +00:00
Bartosz Dziewoński 5ce321bc60 ve.ui.MWWikitextSurface: Implement textSelection 'replaceSelection', 'encapsulateSelection' 
Bug: T185917
Depends-On: I39bbbce20336a1286a07bf8032acdfb8a7e0cdb6
Depends-On: I05086ddce2ddd857ff88eba75cfdb6bf877bd924
Change-Id: I1e7ed33275d0a97f4b0b3c9756bbef2f3f3ad73c
 2018-02-08 19:50:17 +01:00
Bartosz Dziewoński 5f36aac24c ve.ui.MWWikitextSurface: Make 'textSelection' API chainable methods really chainable 
Change-Id: I1292021a4a8dee70cfa203a040f176996e4a13ff
 2018-02-08 19:48:33 +01:00
Ed Sanders b14480f49b Assume wpTextbox1 has an API registered already 
Bug: T186743
Change-Id: I19b085dfbf6229854c3d70807ffe83685ca811fe
 2018-02-07 20:12:51 +00:00
jenkins-bot e613c8edc4 Merge "Load modules for preview" 2018-01-30 17:40:45 +00:00
jenkins-bot 8e1ec692d8 Merge "textSelection: Implement getCaretPosition" 2018-01-30 16:48:00 +00:00
jenkins-bot 5e2e0013ae Merge "Implement simple methods from $.textSelection API" 2018-01-30 16:47:19 +00:00
Ed Sanders 9e16e1cbd4 textSelection: Implement getCaretPosition 
Bug: T185992
Depends-On: Id60f4b8aa177564f5252508ce6cff2424eb03fc8
Change-Id: I1a1a953dfbb299a15ba9d4d3e624e6779e72d11c
 2018-01-30 10:54:02 +00:00
Ed Sanders aeb4f2f2b7 Implement simple methods from $.textSelection API 
This should make it easier for some gadgets to work
with NWE.

Bug: T185992
Change-Id: Ic60440f345b8226fb5acaeb966e25eb003ad7866
 2018-01-30 10:53:49 +00:00
Volker E e64ede5b49 Remove unnecessary and low-contrast opacity 
Change-Id: I4853a77679687d23059c118914df42a1d3c2785c
 2018-01-29 23:51:08 -08:00
Ed Sanders 9770c80615 Load modules for preview 
Bug: T147702
Change-Id: I94f6bdf122d4e2c9fba3103f36c438980ce8228d
 2018-01-29 22:35:00 +00:00
jenkins-bot d7d026425c Merge "Make visual diffs the default in visual mode" 2018-01-27 00:21:24 +00:00
David Lynch d97b734352 MWWikitextStringTransferHandler: Perform Parsoid cleanup on result 
Parsoid markup delivered as a result of a paste was being handled differently.

Bug: T183173
Change-Id: Ic563d2c5cd1f663f35860892b369fb7ba34b9c55
 2018-01-22 14:43:19 -08:00
David Chan c7b76329ad Use ve.dm.MetaList without explicitly requiring metadata index 
For future compatibility with Ib5174b0dcba1c24f44d889e08140bee31a064011 .

Change-Id: I15f252ce5d36bc0c38c5f5035e5176bf5e6d96e5
 2018-01-21 18:33:28 -08:00
David Lynch a52dc16244 Update TitleInput's getTitle to getMWTitle 
cb92c72c63274b332dc81edf473b1b3979ab4bdf in MW core changed this.

Bug: T185231
Change-Id: I9084a11bd40e46bddbcd1922ff549703bc90f60f
 2018-01-18 11:39:23 -06:00
jenkins-bot d5bf4d41de Merge "Remember preferred diff viewer" 2018-01-18 15:37:35 +00:00
jenkins-bot 31e7006610 Merge "getSelectedItem() -> findSelectedItem()" 2018-01-17 17:29:36 +00:00
Ed Sanders a1e2cb237c Resize link context item after getting description 
Descriptions can run to more than two lines.

Bug: T183650
Change-Id: I3d0a5787cab19abc4851340b08fe4a109e7aec31
 2018-01-17 16:06:28 +00:00
Ed Sanders 0169701257 getSelectedItem() -> findSelectedItem() 
Change-Id: Idf90335d06800b690063c7b2a781e822f0ee7ba9
 2018-01-17 13:39:13 +00:00
Ed Sanders e70fe7c1a1 Make visual diffs the default in visual mode 
Bug: T178248
Change-Id: I9fe22862d4415df034a0054f934c9ebd1d731a5d
 2018-01-17 13:31:07 +00:00
Ed Sanders 7661081ab9 Remember preferred diff viewer 
Separate the preference by surface mode, so you can
use a different preference for NWE.

Bug: T178691
Change-Id: Ib8494a4562ce766a7c8ef7ec1447d06f5d0f17c5
 2018-01-17 13:31:07 +00:00
jenkins-bot 2ea64bdd27 Merge "Change save dialog accesskey to be entirely off the trigger" 2018-01-10 21:30:51 +00:00
jenkins-bot 9768750cd3 Merge "Use findItemFromData instead getItemFromData" 2018-01-10 19:54:30 +00:00
David Lynch 64944c119a Use mw.storage instead of localStorage 
mw.storage catches errors, so we won't crash horribly when the user has
localStorage disabled / full.

Bug: T181822
Change-Id: I212994eb535b9a8fb5f6c09deaa10b16c3d7f10e
 2018-01-10 11:44:24 -06:00
David Lynch a89c79dc79 Change save dialog accesskey to be entirely off the trigger 
Accesskeys in this situation are unreliable cross-browser. Firefox won't
trigger the accesskey inside the dialog. We can manually simulate it, via the
existing trigger.

Bug: T121183
Change-Id: Ib919d8b9fcd9324a517037bcc6ef93a26d1488b9
 2018-01-08 11:52:06 -06:00
jenkins-bot 683ac88fcc Merge "doc: Bump copyright year" 2018-01-03 19:20:07 +00:00
James D. Forrester 0a7a845a42 doc: Bump copyright year 
Change-Id: I0b299c840ede1a1b8552cecfc70c5760ab036181
 2018-01-03 17:45:07 +00:00
jenkins-bot fad1466d84 Merge "Fix editfont size in source mode" 2018-01-03 01:12:25 +00:00
Ed Sanders 459ce75cb2 Fix editfont size in source mode 
Bug: T182320
Change-Id: I777a1a80cb9887bc473aecb5d7b25fd6454a3d60
 2018-01-02 19:20:18 +00:00
Bartosz Dziewoński 578c55b7c1 ve.ui.MWSettingsPage: Fix doc comment 
Change-Id: Iff4e8854124340a30081009221cde5b2831c81f3
 2017-12-30 03:26:13 +00:00
Prateek Saxena ecd663c4a0 Use findItemFromData instead getItemFromData 
Depends-on: Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
Bug: T76630
Change-Id: I379da96a42c440c7d2d5dc2f3de2773c03546c04
 2017-12-28 11:53:29 +05:30
Ed Sanders 8a356b19d7 Enable spellchecking on media caption inputs 
Bug: T182393
Change-Id: I23d3f1b37225f9e5a9a9651b6e7b590d38dc99b3
 2017-12-12 16:42:55 +00:00
David Lynch 7777f69e7b Use rel="noopener" on links targeted at new windows 
Bug: T180932
Change-Id: I93bda6aaebf97727a187774cccbeba4f27fcddd5
 2017-11-30 13:15:38 -06:00
David Lynch efbfcd8b35 ui.MWSaveDialog: consistent handling of preview category links 
Category links weren't being checked for redlink status, and weren't opening
in a new window.

Bug: T179913
Change-Id: Ic665583128bf51710178c5674cd35c273f5f207e
 2017-11-29 11:24:32 -06:00
Ed Sanders 77773df985 Create MW tables with captions by default 
Bug: T181173
Change-Id: Ib17331e0e8478ba67c1ecbbee4a284d9993cb552
Depends-On: Ieb668d282f7afa9332cead94c95f19f652102af1
 2017-11-27 16:37:24 +00:00
Ed Sanders 57bf86b69e Add mw-parser-output to preview elements 
Bug: T180214
Change-Id: I74700061c89ab4004229e3b03353067e92031774
 2017-11-10 15:34:51 +00:00
Volker E fdf30c1793 Unify SVG markup 
Align SVG markup across Foundation products by:
- unifying XML declaration,
- removing unnecessary `standalone="no"` attribute as it's default,
- removing all SVG editor metadata
- removing all `g` group elements except where necessary for transforms,
- putting attributes on `path`,
- removing unnecessary ids and
- unifying whitespace.

Saving up to 23% file size before gzipping.

Bug: T178867
Change-Id: If0339073a12f24df1a0f8dcc110c35e0ee2d38a7
 2017-11-06 10:43:56 -08:00
Ed Sanders 3fff0a88d7 Fire wikipage.content hook on edit notices 
Bug: T179315
Change-Id: Ib9a19acbb2459c5b94fc72610f86a48feb80a380
 2017-10-30 22:21:50 +00:00
David Lynch ab1e5d58d4 MWInternalLinkContextItem: increase specificity to override OOUI changes 
OOUI 8e31b2f273 increased changed various icon CSS rules, and increased their
specificity. Increase ours to match. This restores the correct size/ratio of
the images in the link context item.

Bug: T178933
Change-Id: I4f1a6dde363cf99f7665dc83f4b0fa6b1dd3c29e
 2017-10-24 16:09:38 -05:00
Ed Sanders b752a0620b Increase selector specificity to fix layout regression 
Removes negative margin from first item in help popup.

Change-Id: I87ecca9f886dd4061a2afa781ca997ef751907ef
 2017-10-19 15:21:12 +01:00
Bartosz Dziewoński 99cdc08f53 ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons 
OOjs UI's styles now include 'top: 0' for icons, which messes us up here.

Bug: T178415
Change-Id: Ia3234848f69fd67d0b3e35c817de1d9847d46143
 2017-10-17 17:55:53 +00:00
Ed Sanders 013d26f0b0 MWParameterPage: Use MultilineTextInputWidget instead of config 
Change-Id: Icccd6460452774ae0ff21ce9df36dfe428d935d2
 2017-10-12 18:13:06 +01:00
Ed Sanders 581847acb3 Show visual diffs in wikitext mode 
Bug: T170371
Change-Id: I8fd9ed4f804444ec486c4df72125cdeb04da0d5f
 2017-10-11 20:31:39 +01:00
jenkins-bot 28d4ed974f Merge "Remove reference to editfont-default" 2017-10-03 18:48:21 +00:00
Ed Sanders cd097bed3d Allow MediaWiki extensions to use self closing tags 
Parsoid now supports this by setting body to null.

Change-Id: I24d856f0cffeacb00cb2b757e34315bc02b595d0
 2017-10-02 10:52:48 -07:00
Ed Sanders ddc056a40a MWExtensionWindow: Always send a string to setValueAndWhitespace 
Bug: T177180
Change-Id: I3a32e1b22e82bc0c182d26a952e7592aafd4b5e4
 2017-10-02 16:26:16 +01:00
Ed Sanders 852e1ababe MWAlienExtensionNode: Listen to attribute changes 
Also:
* Disconnect change event on this.input, which doesn't
  get destroyed on teardown
* Add padding between attributes and this.input
* Assume the alien extensions can have a rendering when
  their body is empty.

Bug: T177181
Bug: T177183
Change-Id: I2e59f8195b255f33f91901213c92ea14793635b4
 2017-10-02 16:22:41 +01:00
jenkins-bot ff7c57489a Merge "Set padded=false for link inspector" 2017-09-29 16:42:29 +00:00
Ed Sanders 582a3e62fb Remove upstreamed link inspector page icons 
Change-Id: I997b299d9a61ec9307025a7f4d106f185283eb40
Depends-On: I297648d14b4a2540a40f3a0b7d22a7905ef7c035
 2017-09-29 16:27:50 +00:00
Ed Sanders ef46e45b43 Set padded=false for link inspector 
Logically depends on I615b485a272.

Bug: T177080
Change-Id: Ica54238d891fa41eefb0b9216eb4f2190818a502
 2017-09-29 16:14:29 +01:00
Volker E 4067b05832 Unify monospace font family stack 
Bug: T176636
Change-Id: I9ad1a92cef7875371e232c8e4babc842ba711e8c
 2017-09-28 00:24:53 +02:00
James D. Forrester 2c70792c4f Replace constructive with progressive UI flag 
Change-Id: Iae36e978978ed6642f44606a934c540cf5f8537f
 2017-09-26 15:14:32 -04:00
Ed Sanders 38d716f895 Follow-up Iebd1def1: Revert MWSignatureTool case 
The tool checks the page name before the target is initialized.

Change-Id: I02ec528a11cc01b026fb95617388d47323ad96ee
 2017-09-26 19:59:56 +01:00
Ed Sanders 1b8f8d8908 Replace wg(Relevant)PageName with target#pageName 
The default value of target#pageName is wgRelevantPageName
but other targets my override this, or change it dynamically
(e.g. ContentTranslation).

Also remove duplicate setter of pageName in mw.ArticleTarget,
already set in mw.Target.

Change-Id: Iebd1def1d4142978a673afec584a0b663644d176
 2017-09-26 13:22:00 +01:00
jenkins-bot f17b099984 Merge "Use findFirstSelectableitem instead of getFirstSelectableItem" 2017-09-21 18:13:09 +00:00
jenkins-bot e1ae0a91ec Merge "Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label" 2017-09-20 16:20:40 +00:00
C. Scott Ananian 853ec0bc9c Inspectors for editing LanguageConverter markup 
Basic inspectors for editing.  Changing from block to inline, or
adding "hidden" or "describe" flags not supported.

The UI layout for two-way and one-way rules could certainly be improved.

Bug: T49411
Change-Id: I5ce29e4bf47abf509afde0a57f64b5d1189f5185
 2017-09-15 09:24:33 -07:00
C. Scott Ananian 26df4dca33 Doc update: use the full class name so JSDuck hyperlinks it correctly 
Change-Id: I2c6f6a6c5b497767d7f7731c86cc145ed60b1deb
 2017-09-14 11:07:07 -04:00
jenkins-bot 1809344c8a Merge "URL decode file names in gallery, as in PHP parser" 2017-09-13 18:00:56 +00:00
Ed Sanders a6ac6d0cec Fix typos in gallery attribute names 
The MW attributes are 'style' and 'class'. The plural
forms are used internally only to avoid JS keywords.

Change-Id: I1b7d14872aab4b6b3882d00165924fd1639e1744
 2017-09-13 14:06:44 +01:00
Ed Sanders 280696ad3f URL decode file names in gallery, as in PHP parser 
Bug: T175816
Change-Id: I3ec9c1f6db57798cdc1b5a787dd0bd9b4d3beef1
 2017-09-13 14:03:20 +01:00
jenkins-bot 508fdf1543 Merge "Don't require a selection to run any of the save actions" 2017-09-11 15:10:23 +00:00
jenkins-bot 822db7eacf Merge "Add feedback link for visual diff inside save dialog" 2017-09-11 12:01:39 +00:00
Ed Sanders 13ef05b489 Don't require a selection to run any of the save actions 
Change-Id: I3a8f7e1e9e3714f226ac240a429a62d011112285
 2017-09-10 14:53:14 +01:00
David Lynch 569f917edc MWExtensionWindow: clean up originalMwData on teardown 
Not doing this makes adding a new extension node with the exact same content
as a previously-viewed one have the Done button disabled.

Bug: T172586
Change-Id: I39105144e17135044ef644b5464b0fbfdfc019d5
 2017-09-07 10:40:36 -05:00
Bartosz Dziewoński 92cea19890 Use .length instead of .size() for jQuery objects 
.size() is deprecated.

Change-Id: Ib28b7fede117de474efea705adf5dc2cdf8cb101
 2017-09-06 14:52:40 +02:00
Prateek Saxena 1d6b87243e Use findFirstSelectableitem instead of getFirstSelectableItem 
Depends-on: Ic12be404eba490e5ce748f0d754a807e12f6ba76
Bug: T76630
Change-Id: I7daccf8620ec43a56183fd455048a1f2c5f71f26
 2017-09-06 15:42:42 +10:00
Thalia a3902ebff8 Add feedback link for visual diff inside save dialog 
Bug: T170665
Change-Id: I0b09b1089c834a013ad5fee4ecdf75b483b56323
 2017-09-05 13:35:37 +01:00
Prateek Saxena 2b923c0346 MWTemplateDialog: BookletLayout: Use findClosestPage instead of getClosestPage 
Bug: T76630
Depends-on: I068dad8c79c4bda6ea37ab6a1eb6ba72ab6f7dc0
Change-Id: Ib4e380aa6cd0cacbadd42bdf447ddee6443f22ef
 2017-09-05 12:13:41 +10:00
jenkins-bot af756c4c20 Merge "EducationPopup: Add cursor:pointer" 2017-08-30 17:59:26 +00:00
Ed Sanders 24747966b6 EducationPopup: Add cursor:pointer 
We still expect the user to click on the tool, and
the actions still works (albeit delayed), so we
should use cursor:pointer.

Change-Id: I6d2b0140f5fd918809f05acc6e405ef430c518fd
 2017-08-30 17:48:27 +00:00
jenkins-bot a24be49c01 Merge "ve.ui.MWEducationPopupTool: Position blue dots with CSS only" 2017-08-30 17:42:38 +00:00
jenkins-bot 1a40fd2b71 Merge "ve.ui.MWLanguageVariantNodeContextItem: Fix condition for empty table" 2017-08-30 15:48:07 +00:00
jenkins-bot 61ae9df214 Merge "MWParameterPage: Vertically align actions with label" 2017-08-30 15:42:53 +00:00
Egbe Eugene 2fc6423070 Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label 
Since "nbsp" is hard to translate, it is removed from the current
text of visualeditor-mwlanguagevariantcontextitem-rule-code-label,
which was "Language&nbsp;code" - now changed to "Language code".
Instead the table headings (where this message is used) are defined
as non-breaking in CSS.

Bug: T173181
Change-Id: I9794fa010ad908fe772fa6858c25acc6beb973d5
 2017-08-29 21:58:33 +02:00
Bartosz Dziewoński bff16fb352 ve.ui.MWLanguageVariantNodeContextItem: Fix condition for empty table 
For magical HTML reasons, a `<tbody>` node is automatically inserted
inside the `<table>` node. Therefore the table always had exactly one
direct child, this check always failed and table was never shown.
Instead, count the rows.

Change-Id: Ia8a5387c3f605689ab1053c923952ec955b83253
 2017-08-29 21:57:48 +02:00
David Lynch 5d4ff082e6 MWLinkAnnotationInspector: check input validity when switching modes 
Focusing a TextInputWidget normally unsets validity. However, because we're
kind of pretending this is the same input, just in a different mode, it
doesn't make sense to the user that the focus behavior occurs. So, make it
recheck validity after we switch.

Bug: T172159
Change-Id: I1d9d6670d72483c7510fd5ed3c539b43af8432bf
 2017-08-29 11:28:29 -05:00
Bartosz Dziewoński 0a378318bf ve.ui.MWEducationPopupTool: Position blue dots with CSS only 
We can place them in bottom center of the toolbar buttons with
just CSS, no need to manually calculate the position (which
doesn't give the correct results if the toolbar is not visible).

Also add z-index for correct rendering inside TargetWidget,
not overlapped by the toolbar border (e.g. in the media dialog).

Bug: T174120
Change-Id: I556ddfcf252669107cf21810fbed7c9a3751e906
 2017-08-29 18:21:44 +02:00
Ed Sanders c8e856bfb2 MWParameterPage: Vertically align actions with label 
Also make label consistent height, with or without an
indicator using line-height, and move closer to input.

Change-Id: I1b6e6e2f3caa4c949583cafa9448aae6ebc1e0a1
 2017-08-29 14:45:21 +01:00
Ed Sanders 550408f863 Increase width of param actions container 
Bug: T174202
Change-Id: I61a175593b087219b22c5be91d00054b1c15e1dc
 2017-08-29 14:28:26 +01:00
Ed Sanders 63607c4cff Remove reference to editfont-default 
Bug: T170223
Depends-On: I1ace59c980740fc785ccbd500e19cc8b71d46a5b
Change-Id: I2ac04df04b6652b47490dff5202683c041178a2c
 2017-08-25 18:44:53 +01:00
jenkins-bot b73deb1690 Merge "Create wrapper paragraph when converting block image to inline" 2017-08-24 22:16:16 +00:00
jenkins-bot f315c650f6 Merge "Don't focus media dialog until ready process" 2017-08-24 17:18:54 +00:00
Brad Jorsch 2abb9b1b2d Remove execute mode from non-executable 
Change-Id: I46549acd49ca883e9047b8117cb968a9ddbb06cc
 2017-08-24 10:57:25 -04:00
Ed Sanders eb2ee52de0 Create wrapper paragraph when converting block image to inline 
This prevents the image jumping into another paragraph,
e.g. in a different table cell.

Move the logic for removing the old image out of MWMediaDialog
and into MWImageModel#insertImageNode.

Bug: T121449
Change-Id: Ibd7c92f3f90c382ceffd3e0defb12ba36a3786d2
 2017-08-24 15:56:22 +01:00
Ed Sanders b11b144ad6 Don't focus media dialog until ready process 
Bug: T174027
Change-Id: I070b5538e12c8a165a714ac6c3fd172f0ed179d4
 2017-08-24 15:38:11 +01:00
Ed Sanders 51207e7aa5 Allow for mw.body being null in <selfclosing/> extensions 
Bug: T173016
Change-Id: I8daa65e5dc0368b366710f044b621287e83e26f7
 2017-08-23 16:13:16 +00:00
Volker E 19eb726677 Align border and border-radius values 
Aligning `border` code syntax codebase-wide and
`border-radius` values to WikimediaUI theme.

Change-Id: I1a16dccf17bd112ba5071ebfe02d57237feb39e0
 2017-08-16 14:05:55 -07:00
Volker E aaffa6aa46 Replace remaining greys/reds with WikimediaUI color palette colors 
Replacing remaining greys and reds apart Monobook/Apex specific
stylesheets with WikimediaUI palette colors.

Bug: T173459
Change-Id: I9b5b1c379bf76e8da57eeff28c7dd000f148a8fc
 2017-08-16 13:43:02 -07:00
David Chan c87abccdf9 MWLinkAction: Don't annotate close tags 
Change-Id: I273838eba4cb259cf053ce88378da10b0e241155
 2017-08-13 11:33:43 -04:00
jenkins-bot 8975449eaf Merge "Context item for LanguageConverter markup" 2017-08-11 14:29:09 +00:00
C. Scott Ananian c89a3059f8 Context item for LanguageConverter markup 
Add a context item giving more information on language converter markup.

Bug: T49411
Change-Id: I3c91db84793a9a965dcb760253b24edee5d7bd23
 2017-08-10 11:02:41 -04:00
David Chan c03d69b761 Expose ve.ui.MWInternalLinkContextItem generateBody logic 
Change-Id: I94912ac2c471cc5d227fa8b9cb29c302ca29814d
 2017-08-09 17:58:49 +00:00
Ed Sanders a90f8f5ea1 Copy over missing steps from MWLinkAnnotationInspector to Wikitext version 
Bug: T171892
Bug: T171895
Change-Id: Id14eed79b9a2395b3b722828e62b05d3d8d44327
 2017-07-31 18:44:12 +01:00
Bartosz Dziewoński 49d5bae106 ve.ui.MWEducationPopupTool: Don't show if not inside a BarToolGroup 
The popup gets hideously deformed in other cases. Getting it to work
would probably be difficult. Let's just not show it.

Bug: T170919
Change-Id: If9005e9cdea52fefab981f4c7f05f71fce99f3e8
 2017-07-19 22:13:34 +02:00
Ed Sanders 835a775a49 build: Upgrade grunt-eslint from 19.0.0 to 20.0.0 
Mostly indent and regex fixes.

Change-Id: Iaf9d02363c78cb71deec5c4cab53a05b67f60600
 2017-07-18 12:55:33 +01:00
jenkins-bot 1333373c3e Merge "Drop local 'template' icon, use 'puzzle' from upstream" 2017-07-17 15:09:28 +00:00
Bartosz Dziewoński 0e00b2c109 Fix wikitext preview in IE and Edge 
In Internet Explorer and Edge, NodeList objects do not have the
'forEach' method. However, Array's 'forEach' can be applied to them,
as we do elsewhere in the code.

https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach

Bug: T170466
Change-Id: Icb19995e140607d45c47fb6ae8d60ac80b664d02
 2017-07-14 15:30:27 +02:00
Ed Sanders 0917d27e61 Fix wikitext table insertion 
Since Ic8b11d8052 #insertContent puts multiline strings on separate
lines, so to get this to behave correctly, pass in linear data instead.

Bug: T170160
Change-Id: Ie121fce1af46c6834945f4de30bcd9924ee96fd1
 2017-07-10 16:16:11 +01:00
James D. Forrester 528942c2e1 Drop local 'template' icon, use 'puzzle' from upstream 
Now that our template icon has been upstreamed thereto.

Bug: T111041
Change-Id: If101018de284dcc1be086d92427de0d88adb0e02
 2017-07-06 09:52:56 -07:00
Bartosz Dziewoński 4c3c8b3d1e ve.ui.MWWikitextSwitchConfirmDialog: Remove broken "evil hack" 
The promise #getTeardownProcess is trying to resolve/reject no longer
exists, causing exceptions. The code has been unnecessary for a while,
as we do all the work in #getActionProcess. (In the case that we do
switch, the teardown code isn't even called, since we navigate away.)

Cancelling the switch to wikitext works correctly after removing this
code.

Bug: T169588
Change-Id: I1b9b12edf12a0b91f06c13aa53024efb80868387
 2017-07-04 21:49:15 +02:00
jenkins-bot 16f5bc609e Merge "TextInputWidgets: update for deprecated multiline behavior" 2017-07-03 21:21:20 +00:00
David Lynch cfe1d6c0c9 TextInputWidgets: update for deprecated multiline behavior 
Remove config option `multiline` and change to MultilineTextInputWidget as
appropriate.

Bug: T169272
Change-Id: I45565f01de76a88d64d7b0691d1e7279354f375d
 2017-07-03 22:09:58 +01:00
Ed Sanders dd54c9c95d Return truthy object when image info not found 
A missing image should return some data to say the
image is missing, not just reject the promise.

Bug: T169337
Change-Id: Ib41a64a783c1baca88f428417c98e7fb913d14a1
 2017-07-03 18:01:33 +00:00
Ed Sanders 915e818356 Clear all gallery state on teardown 
Change-Id: I90662d02bd2d9768bdcf27e532ed8b8792f764c3
 2017-07-03 17:48:06 +00:00
jenkins-bot 05bc265198 Merge "Keep TOC in correct place in document" 2017-06-28 12:31:33 +00:00
jenkins-bot be808346c9 Merge "Fix TOC meta item detection" 2017-06-28 12:31:32 +00:00
Ed Sanders 15af26876a GalleryDialog: Re-order and make margins even 
Move image inside filename fieldset, and make
margins between fieldsets and button 1em.

Change-Id: I7f6789043f873f9da4e960c94e22a7ee096a352f
 2017-06-23 12:16:35 -07:00
Ed Sanders 9eb637e933 GalleryDialog: Downstream fix for DraggableElement padding 
Bug: T168745
Change-Id: I95e6f5cd2126878c4f973285fceece1d5a03c4eb
 2017-06-23 11:58:37 -07:00
Ed Sanders fd1adfb3b5 Keep TOC in correct place in document 
Change-Id: I6ad8cd8cbd7ef902204408673eb096b7405abd24
 2017-06-22 15:16:15 -07:00
Ed Sanders 1a0fd81f64 Fix TOC meta item detection 
Change-Id: Icce35100bbc0bfb5584a676eec0e1774308d0f68
 2017-06-22 15:16:14 -07:00
David Lynch 9ded195f7e MWTransclusionDialog: fix conditions for "show options" button disabling 
As I understand it, the button should be enabled whenever there's more than
one option in the sidebar, and disabled otherwise. The previously chosen
conditions weren't perfectly proxying this, and the button would be disabled
whenever editing an already-existing transclusion.

Bug: T167710
Change-Id: Id303b680c072642ae7b66066e28ecc9f1dc90fd7
 2017-06-22 17:58:52 +01:00
Ed Sanders 6f72ef82d9 Show simple category list in preview 
Bug: T153534
Change-Id: Ie86abdad76a38855d5ad1a394c0bfb3c8dd5a8c6
 2017-06-20 23:50:52 +00:00