Alex Monk
c99a5b627e
DesktopArticleTarget: Change tab text on server side when possible
...
Usually. Unless you load VE, because then you might be loading on
`action=edit` in remember-last mode and therefore the tab text needs to
be updated from "Edit source" to "Edit". Or "Create source" to "Create".
Or the equivalent with 'local description' in the case of pages from
foreign file repos, etc.
Bug: T120970
Change-Id: I8f07be6c8e415b40ad134ee82d0bda1d63cc4f96
2015-12-15 10:49:45 -08:00
Alex Monk
76a12f2f9b
Try to actually resolve visualeditor-editor preference setting when switching editors
...
Seems we need to make sure this returns before navigating to the target page.
This reverts commit 40807a0743
.
Bug: T121122
Change-Id: I4edf03bc0d57b03897d9f1802eabd8f0dd9962b9
2015-12-15 17:35:22 +00:00
jenkins-bot
b08c8bd682
Merge "Fix up "Simplify some SET logic""
2015-12-15 02:56:45 +00:00
Alex Monk
39af893c75
Fix up "Simplify some SET logic"
...
By 'simplifying', I broke stuff.
This reverts commit b7227f96fe
.
Change-Id: I46fdcf336f556680fa72df0893447b6850cc4b1d
2015-12-15 02:50:15 +00:00
jenkins-bot
d3d851f394
Merge "Simplify some SET logic"
2015-12-14 21:17:15 +00:00
Alex Monk
b7227f96fe
Simplify some SET logic
...
Change-Id: Ie89260607f0253dd7d749af7426702985a0340f4
2015-12-14 21:11:15 +00:00
Translation updater bot
0200bbf328
Localisation updates from https://translatewiki.net .
...
Change-Id: I43deefad46e60797eda66e10c37eed67a61c141b
2015-12-14 22:06:23 +01:00
jenkins-bot
33cbf199f1
Merge "Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set""
2015-12-14 20:53:28 +00:00
Jforrester
40807a0743
Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set"
...
This reverts commit 5b083a7272
.
Change-Id: Ieac905b80ea219075b4de498d645f22c3e86c5ca
2015-12-14 20:46:08 +00:00
Bartosz Dziewoński
ca81362afd
ve.ui.MWMediaDialog: Make the dialog higher (600px)
...
Avoids a scrollbar for option 4 of the A/B test from T120867.
Change-Id: I3eacb560117219febd6e08066599e2d4d42df219
2015-12-14 20:53:32 +01:00
jenkins-bot
d750417545
Merge "Take pageCanLoadVE into account when figuring out whether VE will load in-page or not"
2015-12-14 17:14:41 +00:00
jenkins-bot
04d8089db6
Merge "Fix setEditorPreference call"
2015-12-14 17:08:42 +00:00
Alex Monk
774034b553
Take pageCanLoadVE into account when figuring out whether VE will load in-page or not
...
Bug: T121342
Change-Id: I84ade6e2ab062597fbfd859a90a864c7607547da
2015-12-14 16:58:26 +00:00
Alex Monk
a3148a1559
Fix setEditorPreference call
...
Added brokenly in I82e39752
Bug: T121343
Change-Id: Ie7b228e94458b17d6ec7c23be264144dec9563be
2015-12-14 16:49:28 +00:00
jenkins-bot
51d493918b
Merge "DesktopArticleTarget: Don't abort in SET mode if veswitched is set"
2015-12-14 16:46:02 +00:00
jenkins-bot
648457ca4c
Merge "Switch numbered link context to "delete" instead of "clear""
2015-12-14 01:19:22 +00:00
Translation updater bot
a6bab3aeff
Localisation updates from https://translatewiki.net .
...
Change-Id: I9b6d4fa66a9a18160d5143de1ed1c6e783bd0ed3
2015-12-13 22:24:39 +01:00
James D. Forrester
5b083a7272
DesktopArticleTarget: Don't abort in SET mode if veswitched is set
...
Bug: T121122
Change-Id: I6dca85361be0c1c1c0d39b12b167af813706ae0b
2015-12-11 18:15:25 -08:00
James D. Forrester
2368171fb7
DesktopArticleTarget: Consolidate editor preference setting code
...
Change-Id: I82e3975233eee0473b513d0931a2d6770fc0f86d
2015-12-11 17:12:28 -08:00
Alex Monk
0774bdf924
Try to clean up the WT->VE prompt opened -> closing -> closed data callbacks
...
To use
.then( function ( opened ) { return opened; } )
.then( function ( closing ) { return closing; } )
.then( function ( data ) {
etc. instead of nesting them in .done functions
Change-Id: Ic8cee9639b90cb378ce0b7e58dc04eab0ff4cbc7
2015-12-11 23:43:13 +00:00
Alex Monk
155d0240a4
Remember switching into VE from WT when discarding changes
...
Bug: T120966
Change-Id: I9a7b87cb2561416b72f53afa5140e9d2a4330cfe
2015-12-11 23:35:59 +00:00
Alex Monk
9e5a01aa6b
Check that we really want VE before loading it for section edits
...
Bug: T121189
Change-Id: I34371bf78d34e9d362e9cf5c64bdd108478969b9
2015-12-11 23:19:07 +00:00
Translation updater bot
e71f1d67d6
Localisation updates from https://translatewiki.net .
...
Change-Id: Ife97e1435802802dfeb7754fcea6874433bc6b0d
2015-12-11 23:56:38 +01:00
jenkins-bot
e24e2ed7cf
Merge "[BREAKING CHANGE] Create ve.init.mw.Target base class"
2015-12-11 18:16:22 +00:00
jenkins-bot
2e6719c0d7
Merge "Use upstreamed actionGroups functionality"
2015-12-11 18:09:50 +00:00
Ed Sanders
aa2e0af348
Update VE core submodule to master (19e50b7)
...
New changes:
e536779 [DEPRECATING CHANGE] Rename link inspector tools
3899967 Localisation updates from https://translatewiki.net .
0a1c09e [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets
Local changes:
* Refactor tools for the breaking change
Change-Id: I676af9c50b09ef007926240eb2327d1a0fdd80f5
2015-12-11 10:03:02 -08:00
Ed Sanders
fbb05fb8ed
Use upstreamed actionGroups functionality
...
Depends on I272175dff3 in ve core.
Change-Id: I94cef0f3d8c1b903780890934c2c4963cbe05989
2015-12-11 16:43:48 +00:00
Ed Sanders
21d5856000
[BREAKING CHANGE] Create ve.init.mw.Target base class
...
Move over logic which isn't specific to the article
implementation of VE (e.g. nothing related to loading/saving).
Refactors setupSurface to use an abstract tracking method (which
does nothing by default), and moves surface CSS classes to #createSurface.
Breaking change:
* Rename onSurfaceReady to surfaceReady. We shouldn't need to listen
to our own events.
* Rename onReady to documentReady. onReady is not a listener.
Bug: T97166
Change-Id: I7242b1bb5501b7755a18a13d13e166c30cac9cdd
2015-12-11 16:41:47 +00:00
Ed Sanders
672c91f41b
DesktopArticleTarget: Fix signature of editNotices
...
Also ensure it is always an array.
Change-Id: I8498463d3131817b90fa91404289c839110bdeaa
2015-12-11 16:41:47 +00:00
Alex Monk
98a456b189
Single edit tab: Fall back to the wikitext editor when certain parameters show up
...
We can't handle these yet. There's also 'preview' but I think we probably
qualify as supporting that.
Bug: T121126
Change-Id: I4602992a77f460b9bfcbad0eac1bdd79d67df04d
2015-12-10 23:13:25 +00:00
jenkins-bot
69778a65e5
Merge "Let the feedback tool be configured for a remote wiki"
2015-12-10 22:04:23 +00:00
Translation updater bot
46b901e640
Merge "Localisation updates from https://translatewiki.net ."
2015-12-10 22:02:32 +00:00
Translation updater bot
536ff00e5a
Localisation updates from https://translatewiki.net .
...
Change-Id: Ide641aaf9ffec8558271116f9a3a29c1307ed588
2015-12-10 23:01:35 +01:00
jenkins-bot
3db4f22ecf
Merge "MWSaveDialog: De-flag the 'return to save' button on diffs"
2015-12-10 21:51:01 +00:00
James D. Forrester
705199753c
Let the feedback tool be configured for a remote wiki
...
Bug: T92661
Change-Id: Id48729c89db208714f67fec1eabafe577a834b51
2015-12-10 12:12:59 -08:00
Ed Sanders
29f33a57d5
Rename mw.Target to mw.ArticleTarget
...
This makes way for a base mw.Target class which is
not specific to articles (e.g. Flow boards).
Bug: T97166
Change-Id: If72650bdf87aa9f195b004da0a4d815f1a8063a3
2015-12-10 16:26:20 +00:00
Alex Monk
128901866a
Don't check editor preferences etc. if user wants veaction=edit
...
Bug: T120978
Change-Id: I39e28c80440260959b7f1c25b82a057c21de43be
2015-12-09 23:04:02 +00:00
jenkins-bot
212300af1f
Merge "Avoid useless jQuery.click shortcut"
2015-12-09 22:18:12 +00:00
Translation updater bot
d08da2d62f
Localisation updates from https://translatewiki.net .
...
Change-Id: Ibbc339a27888a391c6c40ced26c154cabb29acf7
2015-12-09 21:43:17 +01:00
David Lynch
e9fbb38818
Switch numbered link context to "delete" instead of "clear"
...
Bug: T120705
Change-Id: I305a0469df8ca3fd75bcd371cf9b9f8894c09f7e
2015-12-09 12:42:20 -06:00
Ed Sanders
e7ccc77000
Edit mode switching: Tell VE if the wikitext was modified
...
Currently we assume that any document state from WE is modified
but that is not necessarily the case.
Change-Id: I085825152528ae5a5e973e8b44f68cb07ee92416
2015-12-09 17:44:43 +00:00
Ed Sanders
e9250d87fd
Avoid useless jQuery.click shortcut
...
Why have one event API when you can have ten...
Change-Id: I645cbeb4e486aba9e734ba47d2e7c3958a694f19
2015-12-09 17:34:00 +00:00
jenkins-bot
a9894809f6
Merge "DesktopArticleTarget: Handle section edit link clicks in single edit tab mode"
2015-12-09 17:16:12 +00:00
Alex Monk
b877e16723
DesktopArticleTarget: Handle section edit link clicks in single edit tab mode
...
Bug: T58337
Change-Id: Ic4c19cdfc3cfcf33604d0c4e7780b45967cdf57d
2015-12-09 09:08:46 -08:00
Ed Sanders
ae26eefb05
Fix typos
...
Add some common ones to typos.json
Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
2015-12-09 16:47:13 +00:00
jenkins-bot
6c1e613fa4
Merge "Make clear button on numbered external links remove the node"
2015-12-09 16:26:29 +00:00
jenkins-bot
87ce2f0a20
Merge "EducationPopup: Increase z-index above toolbar dialog's"
2015-12-09 16:26:26 +00:00
David Lynch
7b66083319
Make clear button on numbered external links remove the node
...
Bug: T120705
Change-Id: I07d57ba95f46f0fa80f9038ccb42d8d89375fd23
2015-12-09 10:11:54 -06:00
Ed Sanders
1121dc5295
EducationPopup: Increase z-index above toolbar dialog's
...
Bug: T116577
Change-Id: Icb91dcebd450f954b8bae18ee57f75386de754ac
2015-12-09 15:56:08 +00:00
jenkins-bot
2efbdc670c
Merge "Single edit tab and section links"
2015-12-09 00:40:46 +00:00