Catrope
d8fa2dfbee
Merge "Bug 37811 - VisualEditor: editing toolbar float trigger also triggers contextView icon, although there is no context to act on -Remove unused updateContext method. -Added check for selection length in contextView set method."
2012-07-07 15:49:45 +00:00
Rob Moen
b71586f296
Bug 37811 - VisualEditor: editing toolbar float trigger also triggers contextView icon, although there is no context to act on
...
-Remove unused updateContext method.
-Added check for selection length in contextView set method.
Change-Id: I1d5791c69deea80c54cff3e021ba4c90cdac2cc4
2012-07-07 08:47:51 -07:00
Catrope
ca868f6cb6
Merge "Bug 38008 - VisualEditor: Tooltips for formatting menu are broken Fixed inconsistency with message name being used for format dropdown"
2012-07-07 15:46:27 +00:00
Catrope
970873595b
Merge "Made extendClass accept a variadic list of base classes to extend with"
2012-07-07 04:31:48 +00:00
Catrope
b4b9634e76
Merge "Added feedback button to toolbar"
2012-07-07 04:30:44 +00:00
Catrope
82fbb943df
Merge "Removed unused variables"
2012-07-07 04:24:52 +00:00
Catrope
bf886937bf
Merge "Fix link inspector css in new version of chrome. Chrome engine modifies CSS names to lowercase when inside iframe..."
2012-07-07 02:05:06 +00:00
Catrope
bc0c8ae525
Merge "Rename ve.ce.BranchNode.doSlugs -> ve.ce.BranchNode.addSlugs"
2012-07-07 02:04:17 +00:00
Trevor Parscal
12b8818a02
(bug 37848) Fixing delete key at end of document, removing whitespace.
...
Change-Id: I64cc9e7a3251b7326b104cd3b8ecb0d07240cd77
2012-07-06 19:02:01 -07:00
Rob Moen
74ab4688cc
Bug 38008 - VisualEditor: Tooltips for formatting menu are broken
...
Fixed inconsistency with message name being used for format dropdown
Change-Id: Id1e3dd1fe61177d7592b449e227ef2527f4d30a1
2012-07-06 16:28:16 -07:00
Rob Moen
b345915d0f
Fix link inspector css in new version of chrome.
...
Chrome engine modifies CSS names to lowercase when inside iframe...
Change-Id: I9cd8ccba011d82549ad71acd2b18c6241ec47ca4
2012-07-06 14:50:19 -07:00
Inez Korczynski
d4bfa89b32
Rename ve.ce.BranchNode.doSlugs -> ve.ce.BranchNode.addSlugs
...
Change-Id: I162067be5a544817e36986eeb0acd0497d37f443
2012-07-05 16:55:45 -07:00
Trevor Parscal
6828e2c8b6
Removed unused variables
...
Change-Id: I7fa9e60c6feba5eb5b705d64c8f3aa192aae89ee
2012-06-28 04:24:08 -07:00
Trevor Parscal
49cb8a2d5a
Added feedback button to toolbar
...
Change-Id: I1f857e46430eae0d5d4ace181475881bc5495309
2012-06-28 02:53:54 -07:00
Trevor Parscal
1067f84764
Merge "Removing some logging"
2012-06-27 16:42:34 +00:00
Trevor Parscal
efe26d9be2
Merge "(bug 36201) Control-K triggers link inspector"
2012-06-27 16:41:51 +00:00
Christian Williams
b9f6baba63
(bug 36201) Control-K triggers link inspector
...
Change-Id: I0ffd237ce51d1899d2151fb76243e818c5f5cfb8
2012-06-27 09:41:06 -07:00
Trevor Parscal
02e24d6a39
Merge "Bugzilla:37804 - Double bound events were causing double backspace bugs"
2012-06-27 16:20:43 +00:00
Christian Williams
a26708dd6e
Removing some logging
...
Change-Id: I2876e56d2e3680d21877103618e59afec1c81ef9
2012-06-22 15:49:34 -07:00
Christian Williams
89e0f3d6ad
Bugzilla:37804 - Double bound events were causing double backspace bugs
...
Change-Id: I589185d077e1efe6fb2c0457a290a8ac9ce8bceb
2012-06-22 15:39:43 -07:00
Christian Williams
122a31a021
Bugzilla:33093 - Shift-Enter splits at paragraphs instead of list items
...
Change-Id: Ie32e878cf9c71f7179143c631a01c0e2e671ed18
2012-06-22 15:05:35 -07:00
Trevor Parscal
02b0c7a6f4
Made extendClass accept a variadic list of base classes to extend with
...
Change-Id: I6d2307ce39da47ad2673dd439789a2f74632c59f
2012-06-22 10:50:41 -07:00
Trevor Parscal
1ea3999e04
Fixed drop-down menu to match items more carefully
...
Change-Id: Ibd46861be243d2872f4edaa9a182d3931d4f9fab
2012-06-21 17:50:46 -07:00
Trevor Parscal
7af5af7683
Merge "Adjust oldRange in the rebuildNodes call as well"
2012-06-22 00:43:29 +00:00
Trevor Parscal
5af7c4d833
Merge "When trying to turn list items into headings, unlist them"
2012-06-22 00:42:51 +00:00
Catrope
fb38655ff0
When trying to turn list items into headings, unlist them
...
This requires splitting the list and unwrapping the items
Change-Id: Ie77fe00d2396e4f7d2f1b28bfc0b0301255454a4
2012-06-21 17:41:58 -07:00
Catrope
62b78c9109
Adjust oldRange in the rebuildNodes call as well
...
This fixes a bug Trevor reported where selecting from a list item across
a heading and into a paragraph, pressing backspace, then clicking undo
caused an exception.
Change-Id: Id2851271529e10548f6979a030a198054aa1c48f
2012-06-21 17:26:17 -07:00
Catrope
a0d87989cf
You know what, just don't render hrefs, these links aren't clickable anyway
...
Change-Id: If5f0c9a2fa41f09569195fe7807aba9a8207a3c9
2012-06-21 16:12:17 -07:00
Trevor Parscal
b560924467
Merge "Use title for rendering internal links, and guard against undefined"
2012-06-21 23:04:11 +00:00
Catrope
6ddfc4bcab
Use title for rendering internal links, and guard against undefined
...
Change-Id: I18a4e5e06303fcd9540fde8c3b21fe8f8887417e
2012-06-21 15:52:25 -07:00
Trevor Parscal
f021b02ce1
Merge "Reconcile the order and completeness of textStyles in 2 different places"
2012-06-21 22:33:41 +00:00
Catrope
9576f8fc48
Escape the href attribute on links
...
Change-Id: I3edaa5c9346f5c8c222c482bcb190acad2bac24d
2012-06-21 15:28:07 -07:00
Christian Williams
4f43ecefdf
No need to apply selection in this transaction
...
Change-Id: Ia1ea5800dfbe5d89ef2fe22462712d8a558e5e3b
2012-06-21 15:20:21 -07:00
Inez Korczynski
41f5f7378b
In Firefox hitting enter fires both events - keydown and keypress. We want to ignore key press for enter.
...
Change-Id: I49d19267cc6115342aadf11ea720e82bbf65ddb2
2012-06-21 14:52:43 -07:00
Catrope
f58b5b6fc8
Reconcile the order and completeness of textStyles in 2 different places
...
ve.ce.TextNode listed textStyle annotations that didn't actually exist,
and failed to recognize some that did exist (such as span; bug 37808).
Added all annotations to both places. <span> tags are now tolerated by
the editor in that it doesn't crash anymore, but they're displayed (and
saved!) without any attributes, so <span style="color:yellow;">y</span>
doesn't show a yellow 'y' in the editor and is saved back as
<span>y</span> .
Change-Id: Iaae11ad5044150fa904010983ff83579cb37733d
2012-06-21 14:46:43 -07:00
Trevor Parscal
ed33ca373f
Merge "Undo and redo keyboard shortcuts"
2012-06-21 20:58:53 +00:00
Christian Williams
050134d55e
Undo and redo keyboard shortcuts
...
Change-Id: Ia1e9db52f6fb2da79be28cdedaaf0dffc6097dc9
2012-06-21 13:58:21 -07:00
Inez Korczynski
07760653b2
Don't use custom handling for left and right arrow while metaKey is pressed as well.
...
Change-Id: I7e2f73ab085b877169f4a29bec04a294d6e13a2a
2012-06-21 13:56:32 -07:00
Trevor Parscal
d245ac030e
Merge "Fix display of edit summary message in save dialog"
2012-06-21 20:44:28 +00:00
Catrope
ae48f152f9
Fix display of edit summary message in save dialog
...
Fixed by adding the specialMessages module which is only loaded once the
editor loads. Then after it's loaded we use the summary message from
there to update the (possibly broken) summary message in the save
dialog.
Change-Id: I67f5c59501cdf7c66c925cef8d4dd42b0f2cfde3
2012-06-21 13:39:27 -07:00
Inez Korczynski
6381709703
In case of IE use non-breaking spaces inside slugs instead of invisible separators - as in different browsers.
...
Change-Id: Ib6ae077206de1ad772e47e212a9f276f6b0081e0
2012-06-21 13:34:13 -07:00
Rob Moen
3f8863b05a
If siteNotice is visible, add class and slide it up. On ve exit,
...
SlideDown fast if hidden by ve
Change-Id: I2a4104590de15da1302181a68d38bf271bcca249
2012-06-21 13:01:42 -07:00
Trevor Parscal
d4e51abac6
Merge "Tear down the beforeUnload handler when redirecting after page creation"
2012-06-21 19:48:51 +00:00
Trevor Parscal
51809e728b
Merge "Fix external link inspector"
2012-06-21 19:48:06 +00:00
Catrope
3a704b7491
Merge "Create init methods which hide and restore siteNotice if present."
2012-06-21 19:46:17 +00:00
Rob Moen
f28a2399f4
Create init methods which hide and restore siteNotice if present.
...
Change-Id: I2fbc74ae46474cdb2559ecaa083cc7353b050937
2012-06-21 12:44:33 -07:00
Catrope
fba013bedf
Tear down the beforeUnload handler when redirecting after page creation
...
Change-Id: If182eb62068c3c585a98535cc6761d98ad7dd56d
2012-06-21 12:41:39 -07:00
Catrope
5784d2b55c
Fix external link inspector
...
Wasn't loading the link target due to a typo
Change-Id: I77533f949363e79dab9b478e6ba10d05b9486acc
2012-06-21 12:40:28 -07:00
Trevor Parscal
437649e062
Merge "Fix problem in hasSlugAtOffset when a given offset is out of range of the document - so no node is returned from getNodeAtOffset"
2012-06-21 18:19:51 +00:00
Inez Korczynski
82d3040d76
Fix problem in hasSlugAtOffset when a given offset is out of range of the document - so no node is returned from getNodeAtOffset
...
Change-Id: I91951528c21ddd57f56d7f4854d0e626d96e04a1
2012-06-21 11:09:41 -07:00