Commit graph

20150 commits

Author SHA1 Message Date
Ed Sanders cc6bf882dc MWPreviewElement: Strip already-present TemplateStyles when building elements
Add unnecessary <style> tags to the page triggers slow re-renders.

Bug: T330781
Depends-on: Ia47234e90d8f2c150b5250be5497cf7c7b4c1ed2
Change-Id: I27c6167663bcb201dfff5d69e5faa6006fb9cb73
2023-03-14 18:46:30 +00:00
Bartosz Dziewoński 983293156c Update VE core submodule to master (bcb501475)
New changes:
e276b1380 Localisation updates from https://translatewiki.net.
b04fd505d PreviewElement: Add a #beforeAppend method so nodes can be modified
537aebf8c build: Upgrade stylelint-config-wikimedia from 0.13.1 to 0.14.0
7c88e4e36 CompletionAction/Widget: Factor out more methods for extensibility
bcb501475 ve.ui.TargetWidget: Fix type hint

Bug: T330781
Change-Id: I10736f4499d22af82e74fbc6c38e69d10703fcb0
2023-03-13 19:15:15 +01:00
Ed Sanders 4fde9c21f3 Gallery: Make ve.ce.Gallery(Image)CaptionNode active (editable)
Bug: T190224
Change-Id: I378465458d0391eb1265274b89e23dd4a308613f
2023-03-13 16:14:12 +00:00
Ed Sanders 950fc45cf0 MWGalleryImageNode: Handle own children
This means that DOM attributes are deep-restored and so
selser runs properly.

Change-Id: I2fdfc04aee5e8b3524214e25afd8443b5f6b240d
2023-03-13 16:14:06 +00:00
Ed Sanders d4db90f970 Gallery tests: Remove data-mw.body attribute
This is not output by Parsoid except in legacy mode.

Change-Id: Ide894a3c5dfbbd1b7a4c0f29bbea65245192f1ef
2023-03-13 16:13:47 +00:00
Arlo Breault 8c73feb0b3 Update gallery alt with caption when set as same
Follow up to Idf297d8a98995971c5835b0cea56c3317a3626e2

Bug: T330842
Change-Id: Ia5e180f03a8199d8347558803336617472492a23
2023-03-13 11:28:32 -04:00
jenkins-bot b9691dcd09 Merge "Set editor preference even when disableForAnons is set" 2023-03-13 14:19:33 +00:00
jenkins-bot 03083bb122 Merge "Fix incompatible skin reporting logic" 2023-03-13 13:43:24 +00:00
jenkins-bot 1156c83bd2 Merge "Fix line height in templates used dialog" 2023-03-13 12:50:00 +00:00
Ed Sanders a0b09412af Fix line height in templates used dialog
Bug: T287733
Change-Id: I5a9a9d8d397e255509966001abe069b988478a64
2023-03-13 08:49:02 +00:00
Translation updater bot 0a2f1bd5ec Localisation updates from https://translatewiki.net.
Change-Id: I3114bd1b3dc317ff8aff306b4a5c2381056ec972
2023-03-13 08:40:13 +01:00
James D. Forrester ffc2b27bf9 stylelint: Auto-fix selector-pseudo-element-colon-notation
Depends-On: I0cc0c16c5adae09090a30453431fe492f3475a69
Change-Id: Ie975f0534f32e46face9ab2ba0e0d3af11533de6
2023-03-12 22:03:06 +00:00
libraryupgrader 30c544e7e6 build: Updating npm dependencies
* grunt: 1.5.3 → 1.6.1
* stylelint-config-wikimedia: 0.13.1 → 0.14.0
  The following rules are failing and were disabled:
  * selector-pseudo-element-colon-notation

* cookiejar: 2.1.3 → 2.1.4
  * https://github.com/advisories/GHSA-h452-7996-h45h
* decode-uri-component: 0.2.0 → 0.2.2
  * https://github.com/advisories/GHSA-w573-4hg7-7wgq
* jpeg-js: 0.4.3 → 0.4.4
  * https://github.com/advisories/GHSA-xvf7-4v9q-58w6
* ua-parser-js: 1.0.2 → 1.0.34
  * https://github.com/advisories/GHSA-fhg7-m89q-25r3

Change-Id: I0b7c1d2324720a0e07f24cd79651c1166b22e406
2023-03-12 13:44:51 +00:00
DLynch 15482cba82 Merge "Update VE core submodule to master (7e95f6c58)" 2023-03-10 16:08:22 +00:00
Translation updater bot cbedd8fd8f Localisation updates from https://translatewiki.net.
Change-Id: Ic1a3318ad298f2f9aaddcb7d4ddd0433419feeab
2023-03-10 08:49:52 +01:00
Ed Sanders 0c5948b4ab Update VE core submodule to master (7e95f6c58)
New changes:
d125fdac5 Localisation updates from https://translatewiki.net.
0215f6c34 Localisation updates from https://translatewiki.net.
ff1398988 Fix logic for abandoning a completion widget
40550ada0 Follow-up I5c0ac857d: Change which clippable element we disable clipping on
c70347e1e VisualDiff: Don't descend in non-tree nodes in tree diff
035cfe1a3 Localisation updates from https://translatewiki.net.
412b30649 Collapse no-change diff context in lists

Bug: T211897
Bug: T319179
Bug: T330401
Change-Id: Ic54ad0e39d88e0e97bbbac2102e3575c8c4c1402
2023-03-09 22:35:00 +00:00
jenkins-bot 099b8f9968 Merge "Remove visualeditor-enable-experimental and ext.visualEditor.experimental" 2023-03-09 19:33:59 +00:00
jenkins-bot 15bbdae6a3 Merge "Enable VE by default for 3rd party installs" 2023-03-09 19:33:39 +00:00
jenkins-bot 022e66f963 Merge "Remove unused user option 'visualeditor-enable-language'" 2023-03-09 19:32:01 +00:00
Thiemo Kreuz e391b5b925 Move gray highlight of template items before blue active rect
Discussed in todays story time. The blue "active" color is mostly a
"reminder with which parameter I interacted last". It's more a
secondary, passive information. In contrast, the gray
highlighting/hover effect that appears when navigating the sidebar
with keyboard or mouse is an active, primary information ("this is
where you are right now"). It's really confusing when the keyboard
navigation indicator disappears behind the blue box.

This patch changes this for both top-level elements as well as
template parameters. The blue text color "shines through" the gray
highlight so we can still see both information.

Bug: T289043
Bug: T311204
Change-Id: Ief6a023d8fde4f6ca0c4b2ea2e831b66e1ea8c83
2023-03-09 10:52:00 +00:00
Translation updater bot fc1c0b2b9b Localisation updates from https://translatewiki.net.
Change-Id: Iccc9666770de0833e0d368bda4bb810807de0751
2023-03-09 09:06:37 +01:00
C. Scott Ananian 10cb01cdd1 Update DirectParsoidClient to match BCP-47 changes in core
We're trying to avoid passing raw strings around, since they can be
ambiguous specifiers of language.  This patch makes VE compatible
with I982e0df706a633b05dcc02b5220b737c19adc401, with a backward
compatibility workaround which can be removed after
I982e0df706a633b05dcc02b5220b737c19adc401 merges.

The new code also uses slightly more methods of the Language object,
which need to be mocked in a unit test.

Change-Id: I830867d58f8962d6a57be16ce3735e8384f9ac1c
2023-03-08 21:19:21 +00:00
jenkins-bot eab91853fa Merge "Template context: Link to source templates in "Generated from:" list" 2023-03-08 17:34:43 +00:00
Ed Sanders 1044753245 Set editor preference even when disableForAnons is set
disableForAnons is used to present a single wikitext tab on
dual-edit-tab wikis, and/or default-wikitext red links.

Users who open the editor and then switch to VE should still
have that preference stored in a cookie when that happens.

Bug: T331462
Change-Id: If2a866cff7e54d2832f6aa22eb268eb125f2d1c2
2023-03-08 15:12:07 +00:00
Ed Sanders 55ded73e9d Remove visualeditor-enable-experimental and ext.visualEditor.experimental
These haven't been used for a while, and we usually enable experimental
features via BetaFeatures these days.

Change-Id: Iec3a7da3cc962d8ac9416b508780fcdc3ca58d3e
2023-03-08 15:05:10 +00:00
Ed Sanders 31879219bb Enable VE by default for 3rd party installs
This shouldn't affect WMF wikis as they always set
the config explicity:
https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings.php#L2698-L2705

Change-Id: Iec2e0f97311befdfd5308aca3d339daaaa725760
2023-03-08 14:55:40 +00:00
Ed Sanders d813ddd85f Remove unused user option 'visualeditor-enable-language'
The features this used to control are now enabled unconditionally.

Change-Id: I77afdf36a96bac703f1c41d43fc7ddd2574fb78c
2023-03-08 14:55:40 +00:00
Translation updater bot f306cc3aec Localisation updates from https://translatewiki.net.
Change-Id: I4e2710178e1825887bc0d9771027e33822f63a46
2023-03-08 08:43:14 +01:00
Gergő Tisza 6d2ba502b8 Fix incompatible skin reporting logic
When checking for the presence of edit buttons, we should include
the VE edit button and the MinervaNeue page action link, but not
the "view source" button (which means the opposite: the user can't
edit).

Bug: T312632
Change-Id: I2eb6e833a0489c17cf8360aca61bd8b615e30461
2023-03-08 02:20:31 +00:00
Translation updater bot b372e13e55 Localisation updates from https://translatewiki.net.
Change-Id: Ic6192621ce07f076fc9e72039c27f16e35fc9c16
2023-03-07 08:55:18 +01:00
jenkins-bot b0f6367ae9 Merge "Per 1.40, VE should use parsoid directly in MW core." 2023-03-06 16:43:43 +00:00
Translation updater bot b1cd0e9229 Localisation updates from https://translatewiki.net.
Change-Id: I094471e9cc2bce15ad333856098c19c54e702d4d
2023-03-06 08:34:31 +01:00
Translation updater bot 370ee0483c Localisation updates from https://translatewiki.net.
Change-Id: Id24edf143c8e080bc83827e229f1635547751d5b
2023-03-03 08:49:48 +01:00
daniel 1d9af50f71 Per 1.40, VE should use parsoid directly in MW core.
VRS should no longer be needed to communicate with RESTbase.
The VisualEditorDefaultParsoidClient setting is retained for backwards
compatibility.

Change-Id: I1e7cdaa61d3d5b075b5551844d8b0293092c99ed
2023-03-02 18:39:17 +01:00
Translation updater bot 8583c0a53c Localisation updates from https://translatewiki.net.
Change-Id: I5da2fe9a0052a72c8a1c1ea783410b829047cfa2
2023-03-02 08:43:52 +01:00
Translation updater bot 490664b272 Localisation updates from https://translatewiki.net.
Change-Id: I7036ee501b60b0af3042bfcf971baef528429ba3
2023-03-01 08:25:11 +01:00
Translation updater bot fdcda109ba Localisation updates from https://translatewiki.net.
Change-Id: Ib2a397575fe94786f245d0882747192cfbe1abf8
2023-02-28 08:29:50 +01:00
Translation updater bot 70e472ed17 Localisation updates from https://translatewiki.net.
Change-Id: I749598bc781c068deb54a3846c3faa29fcb56140
2023-02-27 08:28:33 +01:00
James D. Forrester b12b5e21d9 build: Upgrade mediawiki/mediawiki-codesniffer from 40.0.1 to 41.0.0
Change-Id: I82a51fabffbdecd947077f143fff3a7ec7e3dbd6
2023-02-25 18:54:59 -05:00
Translation updater bot d3a35b5088 Localisation updates from https://translatewiki.net.
Change-Id: I1935fe6bd6b3056abb3c608f90bd735b03fa3b48
2023-02-24 09:00:58 +01:00
Ed Sanders 30b0f10c27 Template context: Link to source templates in "Generated from:" list
Bug: T328021
Change-Id: I0960f4033f99813ac761daf69abf437b00e7d3f0
2023-02-24 00:12:15 +00:00
Bartosz Dziewoński 19942e0e7b Update VE core submodule to master (51ac44db2)
New changes:
2a954cee0 BlockImageNode: Re-use captionData
3fce57ddb Localisation updates from https://translatewiki.net.
ab66f88eb CompletionWidget: Avoid double scrollbars
54195acfe CompletionWidget: Avoid exception when trying to update torn down widget
98d3af0a7 CompletionAction: Make suggestion data more extendable

Bug: T330401
Change-Id: I3480c988d3ee3b89423576a8ac8414070041a0cd
2023-02-23 19:51:36 +01:00
Translation updater bot 6437074655 Localisation updates from https://translatewiki.net.
Change-Id: I072693b5d9523d90fdc95f622952fe1ee34b6c79
2023-02-22 09:01:45 +01:00
Arlo Breault c068c166e2 Preserve link content for broken media
Parsoid will start populating the link content with the alt text if it's
available before falling back to the filename.  Preserving what's there
is needed to avoid dirty diffs during the transition and for cached
content.  In the future, we can remove errorText and replicate Parsoid's
new behaviour..

Bug: T273014
Needed-By: Iddf3e204d6e489cc8a33034da0d9e540efe65553
Change-Id: I7ab3d141b1df92d4447f7e3d6164082844d5bd10
2023-02-22 00:40:20 +01:00
jenkins-bot 8710f1ce75 Merge "Update MWGallery tests with newer Parsoid output" 2023-02-21 22:44:41 +00:00
jenkins-bot 864cd7045d Merge "Don't allow table attributes to be edited when hasExpandedAttrs" 2023-02-21 22:18:55 +00:00
Translation updater bot 22d0f85c77 Localisation updates from https://translatewiki.net.
Change-Id: I690265c39e97ecfa855cb3e1496f9756cd04fb89
2023-02-21 08:22:06 +01:00
Ed Sanders 1d4f828cbd Don't allow table attributes to be edited when hasExpandedAttrs
...but do allow table contents to be edited.

Bug: T307305
Change-Id: I4d714b35d2787d7259aab8250d6a772533dfde2e
2023-02-20 23:35:27 +00:00
Bartosz Dziewoński 286aa90ed9 Update VE core submodule to master (08c5c702b)
New changes:
24b2c7f0d ve.dm.Transaction: Factor out isAnnotationOnlyOperation
4c47b65c5 ve.dm.Surface#getModifiedRanges: Convert arguments to options object
5c15a0801 ve.dm.Surface#getModifiedRanges: Add excludeAnnotations/excludeAttributes
618d865d4 Localisation updates from https://translatewiki.net.
0f0f0f108 Localisation updates from https://translatewiki.net.
daae27877 Revert "Try to prevent selections inside ref/template nodes on Firefox"

Bug: T329983
Bug: T330104
Change-Id: Ie649e26838b1248fa4a4002dd2c121761a02c959
2023-02-20 21:19:59 +01:00
Translation updater bot 247d4cf042 Localisation updates from https://translatewiki.net.
Change-Id: I0b7e8432c4b48caf0c8659490b50f15a9e98fb88
2023-02-20 09:47:37 +01:00