Commit graph

10386 commits

Author SHA1 Message Date
jenkins-bot c02874842b Merge "Fix pattern for matching wikitext headings" 2015-08-25 16:23:15 +00:00
jenkins-bot e7a9af30d8 Merge "Use mw.Title to localise file: prefix on new images" 2015-08-25 16:23:12 +00:00
Ed Sanders 6e44d8a7c0 Use mw.Title to localise file: prefix on new images
Bug: T110104
Change-Id: I25e28367bf4b00a0447c941b7359ebff5fe59147
2015-08-25 17:17:49 +01:00
jenkins-bot fcddd07a03 Merge "Use new internal link builder" 2015-08-25 16:01:14 +00:00
James D. Forrester 44d6ca61ad Update VE core submodule to master (bf76dd7)
New changes:
4344098 Increase width of desktop context, inspectors to 400px
0970f8a Refactor surface config compilation
58c0491 Put spaces between multiple links when pasting
9d13857 Localisation updates from https://translatewiki.net.
bf76dd7 LanguageInspector: Make the widget use one line for language

Change-Id: I79688eaf55547af8749230f589427df7ded5bcb0
2015-08-25 08:55:35 -07:00
Ed Sanders 48a07e0bdc Use new internal link builder
Bug: T64816
Change-Id: I9ec857eef948028e65eb5e8bf21707f5f5bfd9c0
2015-08-25 16:39:32 +01:00
Timo Tijhof d97f85019c Fix flash of bad ve-edit tab on non-wikitext page in enabled namespacea
E.g. when viewing User:Example/common.js there was previously
both Edit and Edit source (or Create and Create source) and the
client-side JavaScript then removed the ve-edit tab after checking
the content model for 've.isAvailable'.

Change-Id: Ic2daeefa439648ef0602f8606773655cf9ab188a
2015-08-25 15:45:06 +02:00
Timo Tijhof 4e3d3acf65 mw.DesktopArticleTarget.init: Don't make non-VE edit tab collapsible
Collapsible relates to the Vector menu behaviour where an item
is moved into the dropdown menu if the window is narrow.

This should only apply to the secondary tab when there are two tabs.

If there is only one tab (non-VE, e.g. in a non-VE namespace) then
this tab should not be collapsible.

Server-side code handled this correctly, but client-side was
adding the class unconditionally.

Change-Id: Iecd195e92f43fe9f11b3938a1a24caed7b331e5f
2015-08-25 05:50:24 +02:00
Timo Tijhof 7825293849 Fix flash of wrong Edit tab in non-VE namespaces
Follows-up 6bc797f which added an early return in namespaces
where VE is not enabled. However, just like the init-init JS code
does already, we should still update the Edit tab message to say
"Edit source" regardless of whether VE is enabled.

After 6bc797f this started to cause a flash where the tab first
says "Edit" and then becomes "Edit source" client-side.

And since the Title::isKnown logic is not available client-side,
this actually exposed a bug with regards to MediaWiki-namespage
messages. Currently the client-side considers these "Create source"
when they are in fact "Edit" (or "Edit source").

Change-Id: If88d648b657d8a571beb7991805f8af8bd547975
2015-08-25 05:50:16 +02:00
jenkins-bot ce6d4eb8c5 Merge "ve.ce.MWTransclusionNode: Pass number of templates to context" 2015-08-24 21:47:08 +00:00
jenkins-bot 547d5afebd Merge "MWInternalLinkAnnotation: Override new getDisplayTitle method" 2015-08-24 21:41:22 +00:00
Alex Monk b5dd86685b ve.ce.MWTransclusionNode: Pass number of templates to context
Fixing <visualeditor-dialog-transclusion-contextitem-description>.

Bug: T109564
Change-Id: Icdf762b3761227c3fcedefc947ffc512520cff76
2015-08-24 14:41:07 -07:00
Ed Sanders a67965a888 MWInternalLinkAnnotation: Override new getDisplayTitle method
This allows the URL paste handler to use the normalized title
as the text content. Add a test to cover this behaviour.

Depends on Ica48fea69cc in core.

Bug: T109980
Change-Id: I2784adaf2949a73256049921227dde0917ef9aef
2015-08-24 14:29:49 -07:00
Ed Sanders 456439923a Fix pattern for matching wikitext headings
Fix the back-reference to \1 (1st set of brakcets).

Add an test to make sure the example sequences actually trigger the
wikitextString handler, and tweak test to ensure that the start-of-line
restriction in the heading regexp doesn't affect link matches.

Change-Id: I76187a12292a4923d1ee2505cfb955431ac252bb
2015-08-24 16:54:45 -04:00
Translation updater bot 86bdf9ce12 Localisation updates from https://translatewiki.net.
Change-Id: I433ac5a06341d686fe2aa8531286f0469595b1f2
2015-08-24 21:35:57 +02:00
Ed Sanders a33b082c13 MWWikitextStringTransferHandler: Show indeterminate progress bar while converting
Also store the abortable API request so it can be cancelled
by the dialog.

To test this, put sleep(4); in ApiVisualEditor.php.

Depends on Ied21e574baa in core.

Change-Id: I83ffa9e0b7164ca4a34eae86cde452d8f38dc853
2015-08-23 14:18:40 -07:00
James D. Forrester 5bc3bd487d Update VE core submodule to master (442ec14)
New changes:
736fe7f Localisation updates from https://translatewiki.net.
ed9a86f Don't autolink or autoconvert on "Paste Special"
35ffb6f Don't select pasted content
8a4fbe2 Localisation updates from https://translatewiki.net.
f62011c Move progress bar functionality up to DataTransferHandler
9abba55 Give links a getDisplayTitle method for use by transfer handler
7f1f965 Localisation updates from https://translatewiki.net.
0b3e045 ve.ce.Surface: Only perform blur-on-destroy hack if surface is focused
dbd6d88 UrlStringTransferHandler: Don't insert a space after URL paste

Change-Id: Ieb8cc541a189a0a5ff2e21077584a9c63c6c7d6f
2015-08-23 14:05:06 -07:00
C. Scott Ananian ee06f94879 Update VE core submodule to 89f6c2d7
New changes:
89f6c2d Strip trailing quotes when autolinking URLs

Local changes:
* Strip trailing quotes and non-URL characters when auto-linking

  Update ve-mw to match I58a9c7f97ef10d9f495e65da17f208b9fc431aa4 in core,
  since otherwise the ve.ui.LinkAction.test.js case with a quoted link
  will begin to fail.

  Make the set of stripped characters better match the combination of
  EXT_LINK_URL_CLASS in the PHP parser and the explicitly-stripped
  trailing punctuation in Parser.php::makeFreeExternalLink().

  Add some international quotation marks while we're at it to make
  everyone equally happy.

Change-Id: Iaffac4b073aeafa4f1137265c2d95e425c24d553
2015-08-23 14:03:01 -07:00
C. Scott Ananian ceb0e1f867 Autolink typed ISBN/RFC/PMIDs
Depends on Ibdad2fa98fca08eeaa96bf33a08dd7723c1edb8c in Parsoid.

Depends on I3dcd289ed7b565b9162ee671038eeb45449e1215 in ve-core.

Bug: T109498
Change-Id: I5650410d7fca30c90baddd4f0c3f6d80e6b39042
2015-08-23 13:59:22 -07:00
James D. Forrester 3adfa82ace Update VE core submodule to b5eaa6f
New changes:
b5eaa6f Factor out ve.ui.LinkAction#autolink

Change-Id: I0328132f233bdc0eb9515ce78489c65051aacb67
2015-08-23 13:55:06 -07:00
jenkins-bot f3c9784a76 Merge "Add spacer above basic reference option" 2015-08-23 20:46:52 +00:00
Translation updater bot ebc59b0c93 Localisation updates from https://translatewiki.net.
Change-Id: If545da604fffe1096618877fbdb8a53c4dfff973
2015-08-23 21:40:18 +02:00
Ed Sanders e59ee87887 Add spacer above basic reference option
Also add classes to basic/reuse so they can be differently styled.

Bug: T108725
Change-Id: I4d128afe86c7fae2d8cbd8a57749970942e39e76
2015-08-23 20:06:35 +01:00
Translation updater bot 544421a31d Localisation updates from https://translatewiki.net.
Change-Id: Ibb171514ab93770dfd18751c5a9da54d6cc7f644
2015-08-22 23:14:21 +02:00
jenkins-bot 614000851d Merge "Update VE core submodule to master (7ec7bb5)" 2015-08-21 19:35:58 +00:00
jenkins-bot a2060f57c1 Merge "MWLinkNodeInspector: Remove 'Open' button" 2015-08-21 19:30:40 +00:00
Translation updater bot d9af00392f Localisation updates from https://translatewiki.net.
Change-Id: I0c362dd030a23102524c0300d6bc6a6771f6b6fa
2015-08-21 21:00:37 +02:00
James D. Forrester d868a0f981 Update VE core submodule to master (7ec7bb5)
New changes:
0590b07 build: Enable jscs's checkParamNames jsdoc rule and make pass
8b845d7 doc: Fix jsdoc for ve.ui.WindowAction#getWindowManager
3819ff6 Localisation updates from https://translatewiki.net.
94651ca Follow-up 3819ff6: Fix build for added language 'su'
5feb0c7 build: Enable jscs's requireParamTypes jsdoc rule and make pass
0605837 build: Enable the remaining jscs jsdoc rules we can
e70f972 build: Enable jscs's checkTypes jsdoc rule and make pass
44eb8fe Localisation updates from https://translatewiki.net.
dc7c8ed Make focusing surfaces work in Firefox

Change-Id: I11248b4c190839cb87948b13b844d6171341d5c8
2015-08-21 10:46:01 -07:00
jenkins-bot ab950434c0 Merge "Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate" 2015-08-21 16:59:15 +00:00
jenkins-bot f2b5d4cc79 Merge "Builder for ve.dm.MWInternalLinkAnnotation" 2015-08-21 16:58:08 +00:00
Alex Monk 01f7207947 Don't retry request in tryWithPreparedCacheKey unless the error was badcachekey
Bug: T109787
Change-Id: I66cd40fadcdfd59bbea05240d0c9917342c6f5a2
2015-08-21 02:01:56 +01:00
Translation updater bot 6ae6373842 Localisation updates from https://translatewiki.net.
Change-Id: I897c31fac2447b0e7ae798e5a4b24888d0a5d0a0
2015-08-20 21:28:24 +02:00
jenkins-bot c20915032e Merge "QA: Upgrading to mw-selenium 1.x" 2015-08-20 17:27:12 +00:00
Dan Duvall 668a149103 QA: Upgrading to mw-selenium 1.x
Upgraded mw-selenium to 1.x, following the docs at
https://doc.wikimedia.org/rubygems/mediawiki-selenium/file.UPGRADE.html

Created an `environments.yml` file, converted page object definitions to
use relative paths, and refactored references to the global `ENV` using
methods of `MediawikiSelenium::Environment`.

Upgraded commons_upload as well to resolve a dependency conflict on
mediawiki_api.

Paired with: Rummana Yasmeen <ryasmeen@wikimedia.org>

Bug: T99661
Change-Id: I2a05cd816ea43afb48157e5dbe1ae42c6c124f6b
2015-08-20 09:52:16 -07:00
jenkins-bot 9ed7cd63ca Merge "build: Enable jscs jsDoc rules 'require*Types' and make pass" 2015-08-19 23:03:39 +00:00
jenkins-bot 0b0e17591c Merge "build: Enable jscs jsDoc rule 'checkTypes' and make pass" 2015-08-19 23:02:13 +00:00
jenkins-bot 94fdcf5699 Merge "build: Enable jscs jsDoc rules 'checkRedundant*' and make pass" 2015-08-19 23:02:11 +00:00
jenkins-bot 667e18cad2 Merge "build: Enable jscs jsDoc rule 'checkParamNames' and make pass" 2015-08-19 23:02:00 +00:00
James D. Forrester 55f78fcbf6 MWLinkNodeInspector: Remove 'Open' button
You can now do this from the context menu. No need to have extra buttons, and
this makes it consistent with the MWInternal/MWExternal link inspector.

Bug: T109646
Change-Id: Ifd4b3645c66ba2f32ccee7e2848967cf5e7ec82e
2015-08-19 15:58:13 -07:00
C. Scott Ananian 21b86a2b69 Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate
Change-Id: I904e797732c98a07654772a4f2432ba3ae5d7050
2015-08-19 16:57:06 -04:00
C. Scott Ananian 2852f6368f Builder for ve.dm.MWInternalLinkAnnotation
Add ve.dm.MWInternalLinkAnnotation.static.newFromTitle to build an
appropriate internal link annotation from a mw.Title.  Tweaked some
method signatures to avoid repeated reparsing of the title text.

Also refactor ve.dm.MWInternalLinkAnnotation.static.getTargetDataFromHref
to explicitly return a boolean indicating whether the result was determined
to be an internal link.

Bug: T64816
Change-Id: I74385d7b3ede1794398dabb749185f4080509b99
2015-08-19 16:57:06 -04:00
jenkins-bot 44ad757463 Merge "build: Enable jscs jsDoc rule 'requireNewlineAfterDescription' and make pass" 2015-08-19 20:52:38 +00:00
jenkins-bot 0d5803d6a5 Merge "build: Enable jscs jsDoc rule 'checkAnnotations' and make pass" 2015-08-19 20:50:00 +00:00
jenkins-bot 90b2717bb9 Merge "build: Enable jscs rule 'requireVarDeclFirst' and make pass" 2015-08-19 20:45:13 +00:00
jenkins-bot 8b50887e78 Merge "build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass" 2015-08-19 20:31:38 +00:00
jenkins-bot c2ea2d8129 Merge "build: Enable jscs rule 'requireDotNotation' and make pass" 2015-08-19 20:31:36 +00:00
Translation updater bot 6f5de25be5 Localisation updates from https://translatewiki.net.
Change-Id: I08cf651d4e52d32b5c9a700630fa98308f7e6455
2015-08-19 22:16:27 +02:00
James D. Forrester bf520fee03 build: Enable jscs jsDoc rules 'require*Types' and make pass
Change-Id: I60c769f1cb028e4f4da7aeb04ed2383b689ddbc8
2015-08-19 11:38:35 -07:00
James D. Forrester 282ddfa1b6 build: Enable jscs jsDoc rule 'checkTypes' and make pass
Change-Id: Idbf6e698ba7015ee5e4f1cf78234ad3f187f1c06
2015-08-19 11:37:13 -07:00
James D. Forrester 9e7041f925 build: Enable jscs jsDoc rules 'checkRedundant*' and make pass
Change-Id: I36262ee1fe6116749586014fd30df3e00733fa6c
2015-08-19 11:35:43 -07:00