Commit graph

20602 commits

Author SHA1 Message Date
Bartosz Dziewoński 9e79a0e218 Add more test cases for mw.libs.ve.getTargetDataFromHref
Bug: T324352
Change-Id: Ie6688736cadaa9f250f176b63b44fe85009dbbbf
2023-01-07 20:00:48 +00:00
Bartosz Dziewoński 25019d7f55 Fix encoding to roundtrip links without 'rawTitle'/'origTitle'
Our encoding for the hrefs like "./Foo" that we send to Parsoid
differed slightly from how Parsoid outputs them, so to avoid dirty
diffs, we had to store the original ones we received from Parsoid
and send them back if they were unchanged.

Change the encoding to match Parsoid's exactly (by referring to the
Parsoid source code), and then remove 'rawTitle'/'origTitle'.

On a historical note, 'rawTitle'/'origTitle' were originally added to
fix other issues with links, which I hope are long behind us:
* bb45d984ca (T145978)
* fda2e6c1b5 (T44140)

Follow-up to 362df66b47, which removed
some other old stuff from the handling of Parsoid links.

Bug: T325766
Change-Id: I0ad0a655380eb2fb29b5ac01e2e399ac550ce34a
2023-01-07 20:00:42 +00:00
Translation updater bot 4e2f129fa0 Localisation updates from https://translatewiki.net.
Change-Id: I6839e3851038dfd60f3928653142116b7cc89164
2023-01-06 08:57:18 +01:00
Translation updater bot 3910cd799a Localisation updates from https://translatewiki.net.
Change-Id: Icdf57197f3a2c25e670802033f500dd2402a5e6c
2023-01-05 09:11:35 +01:00
Bartosz Dziewoński 659b7989f0 Update VE core submodule to master (cb9c5fadc)
New changes:
9d0cd4d43 Rebuild demos with newly added language 'se'
274212549 Ignore 'origTitle' in tests
25dc9632c tests: Remove unused test data

Bug: T325766
Change-Id: Id05e7c72f1a24e108e9ea3062bd71992fe94a504
2023-01-04 19:57:51 +01:00
jenkins-bot e603b1b02a Merge "Replace mediawiki.Uri with native URL (easy cases)" 2023-01-04 08:12:11 +00:00
jenkins-bot 8d7c36cfb5 Merge "Allow using native URL (or polyfill)" 2023-01-04 08:12:08 +00:00
jenkins-bot 161a6a0623 Merge "Fix post-edit notification after switching from old wikitext editor" 2023-01-04 08:12:05 +00:00
Bartosz Dziewoński fd80fae57f Replace mediawiki.Uri with native URL (easy cases)
Replacing one-off uses in various auxiliary features: only used
in function scope (or narrower), nothing else depends on them.
Some of them didn't even need to do any URL parsing or formatting.

Bug: T325249
Change-Id: Ia9a18656f67cb0a204c87605459abb9f5bbdc347
2023-01-03 22:18:01 +01:00
Bartosz Dziewoński 8f1e9b6089 Allow using native URL (or polyfill)
Adding the polyfill as dependency to everything using mediawiki.Uri,
so that we can change the code in separate commits without thinking
about this.

Bug: T325249
Change-Id: I8a7d2e6c7f98ed6187a85a88f2b4a0a4a5ecfc56
2023-01-03 22:18:00 +01:00
Bartosz Dziewoński 60b9a71f9b Fix post-edit notification after switching from old wikitext editor
Follow-up to 37b81b5ba4.

Change-Id: I2e61b265822d75cd409d57a4aec7abfbbd4d3fc4
2023-01-03 22:17:56 +01:00
Translation updater bot a9ecb846eb Localisation updates from https://translatewiki.net.
Change-Id: I7d3dfe25812400bc2a3e0c004db2881321fcc13b
2023-01-03 08:21:50 +01:00
Bartosz Dziewoński aff1874418 Update VE core submodule to master (049fb828f)
New changes:
add00c1f5 Localisation updates from https://translatewiki.net.
930d7a40a ve.dm.SurfaceSynchronizer: Abstract out communication slightly
75b007dcf Remove obsolete browser support checks for HTML5 History API
dd7473296 Localisation updates from https://translatewiki.net.
29948421c Localisation updates from https://translatewiki.net.
049fb828f Localisation updates from https://translatewiki.net.

Change-Id: Ib78fb3c38c540957e4008efb6370b098017400e9
2023-01-02 19:11:21 +01:00
Translation updater bot b6fcdcb27b Localisation updates from https://translatewiki.net.
Change-Id: I543577c988f3f9fa9139b457e0b31fb6365c119c
2023-01-02 08:44:49 +01:00
Bartosz Dziewoński 1165a06f47 ve.ui.MWTemplatePage: Use <p> instead of <hr> in the description
I've never liked how this looked, it feels so 1995. Let's just use
multiple paragraphs instead of a <hr> to separate the text, similar to
what we do in ve.ui.MWParameterPage. The second paragraph is already
emphasized with italics.

Change-Id: I324cd1d81e61cf8a23095b4f8aed68040eb1bd8d
2022-12-29 16:14:47 +00:00
Bartosz Dziewoński fe77d35c36 ve.ui.MWTemplatePlaceholderPage: Remove cleanup for old mw.storage entries
Follow-up to 13f5637290.

Change-Id: Iba92f42831839bbf66ecbb8963cbd44e407392db
2022-12-29 16:14:41 +00:00
Bartosz Dziewoński 62d3fc128e Remove unused message 'visualeditor-dialog-transclusion-placeholder'
Unused since e1ea921f76.

Change-Id: I88a51de0ae5583ba52bb3477625879d273150b39
2022-12-29 16:14:35 +00:00
jenkins-bot 4c31d8478b Merge "Localisation updates from https://translatewiki.net." 2022-12-29 15:02:55 +00:00
Bartosz Dziewoński 4fb3db27e6 ve.ui.MWTemplatePlaceholderPage: Move label to real label for accessibility
By using OOUI 'label' instead of 'help', the label is associated with
the input using <label for=...> in HTML.

The result looks almost the same, except for font size. I like the
change, and I don't think it was intentional to make the font smaller
here.

Bug: T277028
Change-Id: If178ca8feb9970c9287ab6dfe51fdf0a81df1c45
2022-12-29 12:40:11 +00:00
Translation updater bot 57eee69a5f Localisation updates from https://translatewiki.net.
Change-Id: I80ff7fa8d6fb50275901f21a404734996cc97d36
2022-12-29 10:02:55 +01:00
jenkins-bot d411175cd8 Merge "TemplateDialog: separate “Add template” messages" 2022-12-28 23:46:27 +00:00
jenkins-bot 729eb1a79c Merge "Remove redundant/conflicting ARIA label in template dialog" 2022-12-28 23:45:27 +00:00
Umherirrender 31fdf64247 tests: Replace deprecated Language::factory
Bug: T325986
Change-Id: I87e3c799fcb8959d2b31084479b1d15219a10261
2022-12-28 19:38:38 +01:00
Translation updater bot 4e5da759da Localisation updates from https://translatewiki.net.
Change-Id: Ibfbf422f0f49ee8dd6489799715073d23ae0eff7
2022-12-26 09:11:32 +01:00
Translation updater bot 45f37745b6 Localisation updates from https://translatewiki.net.
Change-Id: I7429cfa5e4a633ee32b94a834cca62db57e02c35
2022-12-23 09:08:45 +01:00
jenkins-bot 567f1d7183 Merge "Log bucket/token for the DiscussionTools mobile a/b test" 2022-12-22 15:12:22 +00:00
Pols12 afca7bf0af TemplateDialog: separate “Add template” messages
Use distinct messages for section heading, button label and input
aria-label, to allow a potentially better localization.

Bug: T304121
Change-Id: I3e3b06a035e2f11f5f32face789b934e22916e49
2022-12-22 15:08:31 +01:00
thiemowmde a8fc627f3c Remove redundant/conflicting ARIA label in template dialog
The ARIA label was added via Ieeb29de. It was reusing an existing
message.

Later we added a placeholder to the same input field via I07c6e60.
Since then screenreaders possibly read two texts: "Find template" and
"Add template".

Bug: T296465
Change-Id: Icb8d5419b4a4e34a224744873c557cb873e17c40
2022-12-22 15:07:24 +01:00
Bartosz Dziewoński 420b2a9382 Update VE core submodule to master (1a3a68a6b)
New changes:
5b8a37e40 Localisation updates from https://translatewiki.net.
414e8866f Localisation updates from https://translatewiki.net.
52e83e7df Localisation updates from https://translatewiki.net.
1a3a68a6b Localisation updates from https://translatewiki.net.

Change-Id: I1429f837dcaff3878c15e54ace40054593134bcc
2022-12-22 11:37:08 +01:00
Translation updater bot 6314227c52 Localisation updates from https://translatewiki.net.
Change-Id: I079be807d8d1b6022776d2718ccd08cb9ddda230
2022-12-22 11:05:06 +01:00
Esther Akinloose 99f9899193 selenium: Toolbar should open format paragraph menu
Bug: T296187
Change-Id: Icb1fabcf054a2fb1b290815d6cc9945bda0433a4
2022-12-21 14:10:31 +00:00
jenkins-bot 2c3a098e50 Merge "selenium: Toolbar should open style text options" 2022-12-21 13:57:30 +00:00
Translation updater bot a1142a186a Localisation updates from https://translatewiki.net.
Change-Id: I4d3735fe772a22aa8bcf745b4483bbac866204a7
2022-12-21 09:18:47 +01:00
Esther Akinloose d5825af59d selenium: Toolbar should open style text options
Bug: T296187
Change-Id: I909176da40faa64b23d0dfcafa4b9a6f62c0820e
2022-12-20 15:36:13 +00:00
jenkins-bot 3c6cf5fef5 Merge "selenium: Toolbar should open structure options menu" 2022-12-20 14:50:12 +00:00
Translation updater bot 4afc221b25 Localisation updates from https://translatewiki.net.
Change-Id: I1815f5a013a3131832a47c09f796032a82a75aae
2022-12-20 09:30:51 +01:00
Esther Akinloose 4df16fac5b selenium: Toolbar should open structure options menu
Bug: T296187
Change-Id: Ia8abb12c911174c2c6778b5aff4272a9b14fbbe0
2022-12-19 15:05:28 +00:00
Translation updater bot 71dcfaebde Localisation updates from https://translatewiki.net.
Change-Id: I6dd3e0a48f2ae0fe05769fc84bb6c609ae4a21c5
2022-12-19 09:05:05 +01:00
David Lynch e9b2965655 Log bucket/token for the DiscussionTools mobile a/b test
Bug: T321961
Change-Id: I1e809c4405a561b75e59d2c27edbfc8a3e838f09
2022-12-16 14:44:29 -06:00
Translation updater bot 2c14ce80e2 Localisation updates from https://translatewiki.net.
Change-Id: Iabd8d04d96b57987ad7d9a4ef7ff8872d06e29bc
2022-12-16 08:47:52 +01:00
Thiemo Kreuz 8a42b05622 ve.dm.MWTemplateSpecModel: Document some large params as private class
While at it, also fix a few broken uses of `@see` where `@link` was
intended or for full names, there is no syntax needed, as JSDuck
already links those.

Change-Id: Iaeb46b05c6f2e6f00198bc2ae773c895935b4cea
2022-12-15 23:35:11 +00:00
daniel 3a50a092d9 Catch HttpException early
Catch HttpException from REST helpers, even when they are triggered
already during initialization. This will happen e.g. when the request is
asking for a render key for which the stashed rendering has expired.

Bug: T325310
Change-Id: I9e622b5bb253f5e40fe2b50ff08471beddac9acf
2022-12-15 18:12:37 +00:00
jenkins-bot e06122f86e Merge "ParsoidClient: Improve return type documentation for Phan" 2022-12-15 17:01:06 +00:00
Translation updater bot 0db9568ac8 Localisation updates from https://translatewiki.net.
Change-Id: If02a7a849fad5ee91ec10a72bcd164d72b1afc09
2022-12-15 11:37:14 +01:00
Bartosz Dziewoński ac946cff36 ParsoidClient: Improve return type documentation for Phan
Change-Id: I1aecdc5ab7a21e1ef43ddcec4f4dbea610822493
2022-12-15 00:00:41 +01:00
Bartosz Dziewoński b6929d5be1 Change mw.libs.ve.getTargetDataFromHref to not return bogus data for external links
For external links, `.title` and `.rawTitle` properties previously
contained the external link corrupted with some normalization intended
for MediaWiki titles.

This was useless, and in fact no caller actually uses this value:
they all check `.isInternal` first before accessing `.title` or
`.rawTitle`.

Also, correct other parameter documentation.

Change-Id: Ieeab56548f0a3b2f81a90f0d3ae0f81d744aa67b
2022-12-14 22:57:04 +01:00
Jon Robson 9c25161966 QUnit test module should explicitly target desktop
Setting to desktop as it has dependency
ext.visualEditor.desktopArticleTarget.init
which is a desktop only module

Bug: T127268
Change-Id: I5083cb6ccf9ab918a90c41afc6644fc839b8950e
2022-12-14 17:46:22 +00:00
Translation updater bot 3a63406fc5 Localisation updates from https://translatewiki.net.
Change-Id: Id2375bedae04a4a19be01e6a248f53e2650a1b91
2022-12-14 08:16:44 +01:00
jenkins-bot c31b3bde04 Merge "Set targets explicitly on desktop only module" 2022-12-14 05:35:58 +00:00
jenkins-bot 0c5f131976 Merge "Use new stable API for subtitle modification" 2022-12-14 04:12:38 +00:00